Browse Source

SONAR-10611 Fix quality gate and quality profile badge tooltips

tags/7.5
Grégoire Aubert 6 years ago
parent
commit
b61ddb3f84

+ 2
- 10
server/sonar-web/src/main/js/apps/quality-gates/components/BuiltInQualityGateBadge.tsx View File

@@ -19,8 +19,7 @@
*/
import * as React from 'react';
import * as classNames from 'classnames';
import Tooltip from '../../../components/controls/Tooltip';
import DocInclude from '../../../components/docs/DocInclude';
import DocTooltip from '../../../components/docs/DocTooltip';
import { translate } from '../../../helpers/l10n';

interface Props {
@@ -34,12 +33,5 @@ export default function BuiltInQualityGateBadge({ className }: Props) {
</div>
);

const overlay = (
<DocInclude
className="abs-width-300 cut-margins"
path="/tooltips/quality-gates/built-in-quality-gate"
/>
);

return <Tooltip overlay={overlay}>{badge}</Tooltip>;
return <DocTooltip doc="quality-gates/built-in-quality-gate">{badge}</DocTooltip>;
}

+ 5
- 10
server/sonar-web/src/main/js/apps/quality-profiles/components/BuiltInQualityProfileBadge.tsx View File

@@ -19,8 +19,7 @@
*/
import * as React from 'react';
import * as classNames from 'classnames';
import Tooltip from '../../../components/controls/Tooltip';
import DocInclude from '../../../components/docs/DocInclude';
import DocTooltip from '../../../components/docs/DocTooltip';
import { translate } from '../../../helpers/l10n';

interface Props {
@@ -35,12 +34,8 @@ export default function BuiltInQualityProfileBadge({ className, tooltip = true }
</div>
);

const overlay = (
<DocInclude
className="abs-width-300 cut-margins"
path="/tooltips/quality-profiles/built-in-quality-profile"
/>
);

return <Tooltip overlay={tooltip ? overlay : undefined}>{badge}</Tooltip>;
if (tooltip) {
return <DocTooltip doc="quality-profiles/built-in-quality-profile">{badge}</DocTooltip>;
}
return badge;
}

+ 3
- 9
server/sonar-web/src/main/js/apps/quality-profiles/home/ProfilesListRow.tsx View File

@@ -28,7 +28,7 @@ import { getRulesUrl } from '../../../helpers/urls';
import { isStagnant } from '../utils';
import { Profile } from '../types';
import Tooltip from '../../../components/controls/Tooltip';
import DocInclude from '../../../components/docs/DocInclude';
import DocTooltip from '../../../components/docs/DocTooltip';

interface Props {
onRequestFail: (reason: any) => void;
@@ -61,15 +61,9 @@ export default class ProfilesListRow extends React.PureComponent<Props> {

if (profile.isDefault) {
return (
<Tooltip
overlay={
<DocInclude
className="abs-width-300 cut-margins"
path="/tooltips/quality-profiles/default-quality-profile"
/>
}>
<DocTooltip doc="quality-profiles/default-quality-profile">
<span className="badge">{translate('default')}</span>
</Tooltip>
</DocTooltip>
);
}


Loading…
Cancel
Save