@@ -26,12 +26,17 @@ interface Props { | |||
} | |||
export default function ChangesList({ changes }: Props) { | |||
const renderSeverity = (key: string) => { | |||
const severity = changes[key]; | |||
return severity ? <SeverityChange severity={severity} /> : null; | |||
}; | |||
return ( | |||
<ul> | |||
{Object.keys(changes).map(key => ( | |||
<li key={key}> | |||
{key === 'severity' ? ( | |||
<SeverityChange severity={changes[key]} /> | |||
renderSeverity(key) | |||
) : ( | |||
<ParameterChange name={key} value={changes[key]} /> | |||
)} |
@@ -22,7 +22,7 @@ import SeverityHelper from '../../../components/shared/SeverityHelper'; | |||
import { translate } from '../../../helpers/l10n'; | |||
interface Props { | |||
severity: string | null; | |||
severity: string; | |||
} | |||
export default function SeverityChange({ severity }: Props) { |
@@ -23,8 +23,7 @@ import { translate } from '../../helpers/l10n'; | |||
interface Props { | |||
className?: string; | |||
// TODO avoid passing nil values | |||
severity: string | undefined | null; | |||
severity: string; | |||
} | |||
export default function SeverityHelper({ className, severity }: Props) { |