Browse Source

avoid passing null values to SeverityHelper

tags/7.6
Stas Vilchik 5 years ago
parent
commit
ba01aadcb0

+ 6
- 1
server/sonar-web/src/main/js/apps/quality-profiles/changelog/ChangesList.tsx View File

@@ -26,12 +26,17 @@ interface Props {
}

export default function ChangesList({ changes }: Props) {
const renderSeverity = (key: string) => {
const severity = changes[key];
return severity ? <SeverityChange severity={severity} /> : null;
};

return (
<ul>
{Object.keys(changes).map(key => (
<li key={key}>
{key === 'severity' ? (
<SeverityChange severity={changes[key]} />
renderSeverity(key)
) : (
<ParameterChange name={key} value={changes[key]} />
)}

+ 1
- 1
server/sonar-web/src/main/js/apps/quality-profiles/changelog/SeverityChange.tsx View File

@@ -22,7 +22,7 @@ import SeverityHelper from '../../../components/shared/SeverityHelper';
import { translate } from '../../../helpers/l10n';

interface Props {
severity: string | null;
severity: string;
}

export default function SeverityChange({ severity }: Props) {

+ 1
- 2
server/sonar-web/src/main/js/components/shared/SeverityHelper.tsx View File

@@ -23,8 +23,7 @@ import { translate } from '../../helpers/l10n';

interface Props {
className?: string;
// TODO avoid passing nil values
severity: string | undefined | null;
severity: string;
}

export default function SeverityHelper({ className, severity }: Props) {

Loading…
Cancel
Save