@@ -105,11 +105,9 @@ public class DefaultMavenPluginExecutor implements MavenPluginExecutor { | |||
} | |||
if (executeMethod.getParameterTypes().length == 1) { | |||
concreteExecuteMaven3(pom, goal); | |||
} | |||
else if (executeMethod.getParameterTypes().length == 3) { | |||
} else if (executeMethod.getParameterTypes().length == 3) { | |||
concreteExecuteMaven2(executeMethod, pom, goal); | |||
} | |||
else { | |||
} else { | |||
throw new SonarException("Unexpected parameter count on Maven LifecycleExecutor#execute method. Please check your Maven version."); | |||
} | |||
} |
@@ -78,8 +78,7 @@ public class BatchPluginRepository implements PluginRepository { | |||
PluginMetadata metadata = extractor.install(pluginFiles.get(0), remote.isCore(), extensionFiles, targetDir); | |||
if (StringUtils.isBlank(metadata.getBasePlugin()) || filter.accepts(metadata.getBasePlugin())) { | |||
metadataByKey.put(metadata.getKey(), metadata); | |||
} | |||
else { | |||
} else { | |||
LOG.debug("Excluded plugin: " + metadata.getKey()); | |||
} | |||
} |
@@ -58,8 +58,7 @@ public final class LoggingConfiguration { | |||
setShowSql(false); | |||
if (environment != null && "maven".equalsIgnoreCase(environment.getKey())) { | |||
setFormat(FORMAT_MAVEN); | |||
} | |||
else { | |||
} else { | |||
setFormat(FORMAT_DEFAULT); | |||
} | |||
} |
@@ -92,9 +92,7 @@ public abstract class AbstractTimeProfiling { | |||
if (i++ >= maxSize || item.totalTime() == 0) { | |||
return result; | |||
} | |||
else { | |||
result.add(item); | |||
} | |||
result.add(item); | |||
} | |||
return result; | |||
} |
@@ -41,8 +41,7 @@ public class HtmlCodeBuilder implements Appendable { | |||
colorizedCode.append(">"); | |||
} else if (c == '&') { | |||
colorizedCode.append("&"); | |||
} | |||
else { | |||
} else { | |||
colorizedCode.append(c); | |||
} | |||
return this; |
@@ -115,8 +115,7 @@ public class MeasureFilterCondition { | |||
sql.append(" ").append(operator.getSql()).append(" "); | |||
if (textValue == null) { | |||
sql.append(value); | |||
} | |||
else { | |||
} else { | |||
sql.append(textValue); | |||
} | |||
sql.append(" AND "); |
@@ -90,9 +90,8 @@ public class PurgeProfiler { | |||
for (Entry<String, Long> item : sortedFullList) { | |||
if (i++ >= maxSize || item.getValue() == 0) { | |||
return result; | |||
} else { | |||
result.add(item); | |||
} | |||
result.add(item); | |||
} | |||
return result; | |||
} |
@@ -73,8 +73,7 @@ public class MinimumFeedbackEdgeSetSolver { | |||
Set<FeedbackEdge> pendingFeedbackEdges = new HashSet<FeedbackEdge>(); | |||
if (cyclesNumber < maxNumberCyclesForSearchingMinimumFeedback) { | |||
searchFeedbackEdges(0, 0, pendingFeedbackEdges); | |||
} | |||
else { | |||
} else { | |||
lightResearchForFeedbackEdges(); | |||
} | |||
} | |||
@@ -112,15 +111,13 @@ public class MinimumFeedbackEdgeSetSolver { | |||
if (doesFeedbackEdgesContainAnEdgeOfTheCycle(pendingFeedbackEdges, feedbackCycle)) { | |||
searchFeedbackEdges(level + 1, pendingWeight, pendingFeedbackEdges); | |||
} | |||
else { | |||
} else { | |||
boolean hasAnEdgeWithOccurrenceOfOneBeenUsed = false; | |||
for (FeedbackEdge feedbackEdge : feedbackCycle) { | |||
if (feedbackEdge.getOccurences() == 1) { | |||
if (hasAnEdgeWithOccurrenceOfOneBeenUsed) { | |||
continue; | |||
} | |||
else { | |||
} else { | |||
hasAnEdgeWithOccurrenceOfOneBeenUsed = true; | |||
} | |||
} |
@@ -52,16 +52,14 @@ public class SumChildDistributionFormula implements Formula { | |||
if (measures == null || measures.isEmpty()) { | |||
return null; | |||
} | |||
else { | |||
RangeDistributionBuilder distribution = new RangeDistributionBuilder(context.getTargetMetric()); | |||
for (Measure measure : measures) { | |||
distribution.add(measure); | |||
} | |||
Measure measure = distribution.build(); | |||
if (!Scopes.isHigherThanOrEquals(context.getResource().getScope(), minimumScopeToPersist)) { | |||
measure.setPersistenceMode(PersistenceMode.MEMORY); | |||
} | |||
return measure; | |||
RangeDistributionBuilder distribution = new RangeDistributionBuilder(context.getTargetMetric()); | |||
for (Measure measure : measures) { | |||
distribution.add(measure); | |||
} | |||
Measure measure = distribution.build(); | |||
if (!Scopes.isHigherThanOrEquals(context.getResource().getScope(), minimumScopeToPersist)) { | |||
measure.setPersistenceMode(PersistenceMode.MEMORY); | |||
} | |||
return measure; | |||
} | |||
} |
@@ -265,9 +265,8 @@ public class HttpDownloader extends UriReader.SchemeProcessor implements BatchCo | |||
String errorResponseContent = IOUtils.toString(errorResponse); | |||
throw new HttpException(uri, responseCode, errorResponseContent); | |||
} | |||
else { | |||
throw new HttpException(uri, responseCode); | |||
} | |||
throw new HttpException(uri, responseCode); | |||
} finally { | |||
IOUtils.closeQuietly(errorResponse); | |||
} |
@@ -100,8 +100,7 @@ public abstract class BaseChartWeb extends BaseChart { | |||
} else { | |||
configureDefaultColors(renderer); | |||
} | |||
} | |||
catch (Exception e) { | |||
} catch (Exception e) { | |||
configureDefaultColors(renderer); | |||
} | |||
} | |||
@@ -117,8 +116,7 @@ public abstract class BaseChartWeb extends BaseChart { | |||
if (isParamValueValid(paramValue)) { | |||
try { | |||
result = Double.parseDouble(paramValue); | |||
} | |||
catch (NumberFormatException e) { | |||
} catch (NumberFormatException e) { | |||
// ignore | |||
} | |||
} | |||
@@ -144,8 +142,7 @@ public abstract class BaseChartWeb extends BaseChart { | |||
setWidth(iWidth); | |||
setHeight(iHeight); | |||
} | |||
} | |||
catch (NumberFormatException e) { | |||
} catch (NumberFormatException e) { | |||
// Do nothing, default dimensions are already setted | |||
} | |||
} |
@@ -85,8 +85,7 @@ public class PieChart extends BaseChartWeb implements DeprecatedChart { | |||
} else { | |||
configureDefaultColors(); | |||
} | |||
} | |||
catch (Exception e) { | |||
} catch (Exception e) { | |||
configureDefaultColors(); | |||
} | |||
} | |||
@@ -117,8 +116,7 @@ public class PieChart extends BaseChartWeb implements DeprecatedChart { | |||
double measure = 0; | |||
try { | |||
measure = Double.parseDouble(st.nextToken()); | |||
} | |||
catch (NumberFormatException e) { | |||
} catch (NumberFormatException e) { | |||
// ignore | |||
} | |||
dataset.setValue(Integer.toString(i), measure); |
@@ -117,8 +117,7 @@ public class UserSession { | |||
Permission perm = Permission.allGlobal().get(permissionKey); | |||
if (perm == null) { | |||
LOG.warn("Ignoring unknown permission {} for user {}", permissionKey, login); | |||
} | |||
else { | |||
} else { | |||
permissions.add(perm); | |||
} | |||
} |