Browse Source

SONAR-20984 Application's Projects list metrics are not retrieved for "New code"

tags/9.9.3.79811
guillaume-peoch-sonarsource 6 months ago
parent
commit
d05dc82a38

+ 20
- 5
server/sonar-web/src/main/js/apps/code/components/Search.tsx View File

@@ -28,7 +28,7 @@ import { getBranchLikeQuery } from '../../../helpers/branch-like';
import { KeyboardKeys } from '../../../helpers/keycodes';
import { translate } from '../../../helpers/l10n';
import { BranchLike } from '../../../types/branch-like';
import { ComponentQualifier } from '../../../types/component';
import { ComponentQualifier, isPortfolioLike } from '../../../types/component';
import { ComponentMeasure } from '../../../types/types';

interface Props {
@@ -144,7 +144,9 @@ export class Search extends React.PureComponent<Props, State> {
render() {
const { component, newCodeSelected } = this.props;
const { loading, query } = this.state;
const isPortfolio = ['VW', 'SVW', 'APP'].includes(component.qualifier);

const isPortfolio = isPortfolioLike(component.qualifier);
const searchPlaceholder = getSearchPlaceholderLabel(component.qualifier as ComponentQualifier);

return (
<div className="code-search" id="code-search">
@@ -171,9 +173,8 @@ export class Search extends React.PureComponent<Props, State> {
minLength={3}
onChange={this.handleQueryChange}
onKeyDown={this.handleKeyDown}
placeholder={translate(
isPortfolio ? 'code.search_placeholder.portfolio' : 'code.search_placeholder'
)}
placeholder={searchPlaceholder}
aria-label={searchPlaceholder}
value={this.state.query}
/>
<DeferredSpinner className="spacer-left" loading={loading} />
@@ -183,3 +184,17 @@ export class Search extends React.PureComponent<Props, State> {
}

export default withRouter(Search);

function getSearchPlaceholderLabel(qualifier: ComponentQualifier) {
switch (qualifier) {
case ComponentQualifier.Portfolio:
case ComponentQualifier.SubPortfolio:
return translate('code.search_placeholder.portfolio');

case ComponentQualifier.Application:
return translate('code.search_placeholder.application');

default:
return translate('code.search_placeholder');
}
}

+ 1
- 0
sonar-core/src/main/resources/org/sonar/l10n/core.properties View File

@@ -3435,6 +3435,7 @@ api_documentation.search=Search by name...
#------------------------------------------------------------------------------
code.open_component_page=Open Component's Page
code.search_placeholder=Search for files...
code.search_placeholder.application=Search for projects...
code.search_placeholder.portfolio=Search for projects and sub-portfolios...
code.parent_folder=Parent folder
code.last_analysis_date=Last analysis

Loading…
Cancel
Save