Browse Source

rename AnalysisMetadataHolder.baseProjectAnalysis to baseAnalysis

tags/6.1-RC1
Sébastien Lesaint 7 years ago
parent
commit
d0c6971201
12 changed files with 62 additions and 62 deletions
  1. 4
    4
      server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolder.java
  2. 4
    4
      server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolderImpl.java
  3. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/analysis/MutableAnalysisMetadataHolder.java
  4. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStep.java
  5. 3
    3
      server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/BuildComponentTreeStep.java
  6. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/LoadCrossProjectDuplicationsRepositoryStep.java
  7. 5
    5
      server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolderImplTest.java
  8. 7
    7
      server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolderRule.java
  9. 4
    4
      server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/analysis/MutableAnalysisMetadataHolderRule.java
  10. 15
    15
      server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStepTest.java
  11. 11
    11
      server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/scm/ScmInfoRepositoryImplTest.java
  12. 5
    5
      server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/step/LoadCrossProjectDuplicationsRepositoryStepTest.java

+ 4
- 4
server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolder.java View File

@@ -37,20 +37,20 @@ public interface AnalysisMetadataHolder {
long getAnalysisDate();

/**
* Convenience method equivalent to calling {@link #getBaseProjectSnapshot() == null}
* Convenience method equivalent to calling {@link #getBaseAnalysis() == null}
*
* @throws IllegalStateException if baseProjectSnapshot has not been set
*/
boolean isFirstAnalysis();

/**
* Return the last snapshot of the project.
* Return the last analysis of the project.
* If it's the first analysis, it will return null.
*
* @throws IllegalStateException if baseProjectSnapshot has not been set
* @throws IllegalStateException if baseAnalysis has not been set
*/
@CheckForNull
Analysis getBaseProjectSnapshot();
Analysis getBaseAnalysis();

/**
* @throws IllegalStateException if cross project duplication flag has not been set

+ 4
- 4
server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolderImpl.java View File

@@ -72,19 +72,19 @@ public class AnalysisMetadataHolderImpl implements MutableAnalysisMetadataHolder

@Override
public boolean isFirstAnalysis() {
return getBaseProjectSnapshot() == null;
return getBaseAnalysis() == null;
}

@Override
public MutableAnalysisMetadataHolder setBaseProjectSnapshot(@Nullable Analysis baseProjectAnalysis) {
public MutableAnalysisMetadataHolder setBaseAnalysis(@Nullable Analysis baseAnalysis) {
checkState(!this.baseProjectSnapshot.isInitialized(), "Base project snapshot has already been set");
this.baseProjectSnapshot.setProperty(baseProjectAnalysis);
this.baseProjectSnapshot.setProperty(baseAnalysis);
return this;
}

@Override
@CheckForNull
public Analysis getBaseProjectSnapshot() {
public Analysis getBaseAnalysis() {
checkState(baseProjectSnapshot.isInitialized(), "Base project snapshot has not been set");
return baseProjectSnapshot.getProperty();
}

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/analysis/MutableAnalysisMetadataHolder.java View File

@@ -36,9 +36,9 @@ public interface MutableAnalysisMetadataHolder extends AnalysisMetadataHolder {
MutableAnalysisMetadataHolder setAnalysisDate(long date);

/**
* @throws IllegalStateException if baseProjectAnalysis has already been set
* @throws IllegalStateException if baseAnalysis has already been set
*/
MutableAnalysisMetadataHolder setBaseProjectSnapshot(@Nullable Analysis baseProjectAnalysis);
MutableAnalysisMetadataHolder setBaseAnalysis(@Nullable Analysis baseAnalysis);

/**
* @throws IllegalStateException if cross project duplication flag has already been set

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStep.java View File

@@ -92,7 +92,7 @@ public class FileMoveDetectionStep implements ComputationStep {
@Override
public void execute() {
// do nothing if no files in db (first analysis)
Analysis baseProjectAnalysis = analysisMetadataHolder.getBaseProjectSnapshot();
Analysis baseProjectAnalysis = analysisMetadataHolder.getBaseAnalysis();
if (baseProjectAnalysis == null) {
LOG.debug("First analysis. Do nothing.");
return;

+ 3
- 3
server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/BuildComponentTreeStep.java View File

@@ -64,17 +64,17 @@ public class BuildComponentTreeStep implements ComputationStep {
UuidFactory uuidFactory = new UuidFactory(dbClient, moduleKey(reportProject, branch));
Component project = new ComponentRootBuilder(reportProject, uuidFactory, branch).build();
treeRootHolder.setRoot(project);
setBaseProjectSnapshot(project.getUuid());
setBaseAnalysis(project.getUuid());
}

private void setBaseProjectSnapshot(String projectUuid) {
private void setBaseAnalysis(String projectUuid) {
DbSession dbSession = dbClient.openSession(false);
try {
SnapshotDto snapshotDto = dbClient.snapshotDao().selectAnalysisByQuery(dbSession,
new SnapshotQuery()
.setComponentUuid(projectUuid)
.setIsLast(true));
analysisMetadataHolder.setBaseProjectSnapshot(toAnalysis(snapshotDto));
analysisMetadataHolder.setBaseAnalysis(toAnalysis(snapshotDto));
} finally {
dbClient.closeSession(dbSession);
}

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/task/projectanalysis/step/LoadCrossProjectDuplicationsRepositoryStep.java View File

@@ -118,7 +118,7 @@ public class LoadCrossProjectDuplicationsRepositoryStep implements ComputationSt
private List<DuplicationUnitDto> selectDuplicates(Component file, Collection<String> hashes) {
DbSession dbSession = dbClient.openSession(false);
try {
Analysis projectAnalysis = analysisMetadataHolder.getBaseProjectSnapshot();
Analysis projectAnalysis = analysisMetadataHolder.getBaseAnalysis();
String analysisUuid = projectAnalysis == null ? null : projectAnalysis.getUuid();
return dbClient.duplicationDao().selectCandidates(dbSession, analysisUuid, file.getFileAttributes().getLanguageKey(), hashes);
} finally {

+ 5
- 5
server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolderImplTest.java View File

@@ -70,7 +70,7 @@ public class AnalysisMetadataHolderImplTest {
public void isFirstAnalysis_return_true() throws Exception {
AnalysisMetadataHolderImpl underTest = new AnalysisMetadataHolderImpl();

underTest.setBaseProjectSnapshot(null);
underTest.setBaseAnalysis(null);
assertThat(underTest.isFirstAnalysis()).isTrue();
}

@@ -78,7 +78,7 @@ public class AnalysisMetadataHolderImplTest {
public void isFirstAnalysis_return_false() throws Exception {
AnalysisMetadataHolderImpl underTest = new AnalysisMetadataHolderImpl();

underTest.setBaseProjectSnapshot(baseProjectAnalysis);
underTest.setBaseAnalysis(baseProjectAnalysis);
assertThat(underTest.isFirstAnalysis()).isFalse();
}

@@ -95,17 +95,17 @@ public class AnalysisMetadataHolderImplTest {
expectedException.expect(IllegalStateException.class);
expectedException.expectMessage("Base project snapshot has not been set");

new AnalysisMetadataHolderImpl().getBaseProjectSnapshot();
new AnalysisMetadataHolderImpl().getBaseAnalysis();
}

@Test
public void setBaseProjectSnapshot_throws_ISE_when_called_twice() {
AnalysisMetadataHolderImpl underTest = new AnalysisMetadataHolderImpl();
underTest.setBaseProjectSnapshot(baseProjectAnalysis);
underTest.setBaseAnalysis(baseProjectAnalysis);

expectedException.expect(IllegalStateException.class);
expectedException.expectMessage("Base project snapshot has already been set");
underTest.setBaseProjectSnapshot(baseProjectAnalysis);
underTest.setBaseAnalysis(baseProjectAnalysis);
}

@Test

+ 7
- 7
server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/analysis/AnalysisMetadataHolderRule.java View File

@@ -36,7 +36,7 @@ public class AnalysisMetadataHolderRule extends ExternalResource implements Muta

private final InitializedProperty<Long> analysisDate = new InitializedProperty<>();

private final InitializedProperty<Analysis> baseProjectSnapshot = new InitializedProperty<>();
private final InitializedProperty<Analysis> baseAnalysis = new InitializedProperty<>();

private final InitializedProperty<Boolean> crossProjectDuplicationEnabled = new InitializedProperty<>();

@@ -80,20 +80,20 @@ public class AnalysisMetadataHolderRule extends ExternalResource implements Muta

@Override
public boolean isFirstAnalysis() {
return getBaseProjectSnapshot() == null;
return getBaseAnalysis() == null;
}

@Override
public AnalysisMetadataHolderRule setBaseProjectSnapshot(@Nullable Analysis baseProjectAnalysis) {
this.baseProjectSnapshot.setProperty(baseProjectAnalysis);
public AnalysisMetadataHolderRule setBaseAnalysis(@Nullable Analysis baseAnalysis) {
this.baseAnalysis.setProperty(baseAnalysis);
return this;
}

@Override
@CheckForNull
public Analysis getBaseProjectSnapshot() {
checkState(baseProjectSnapshot.isInitialized(), "Base project snapshot has not been set");
return baseProjectSnapshot.getProperty();
public Analysis getBaseAnalysis() {
checkState(baseAnalysis.isInitialized(), "Base analysis has not been set");
return baseAnalysis.getProperty();
}

@Override

+ 4
- 4
server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/analysis/MutableAnalysisMetadataHolderRule.java View File

@@ -60,15 +60,15 @@ public class MutableAnalysisMetadataHolderRule extends ExternalResource implemen
}

@Override
public MutableAnalysisMetadataHolderRule setBaseProjectSnapshot(@Nullable Analysis baseProjectAnalysis) {
delegate.setBaseProjectSnapshot(baseProjectAnalysis);
public MutableAnalysisMetadataHolderRule setBaseAnalysis(@Nullable Analysis baseAnalysis) {
delegate.setBaseAnalysis(baseAnalysis);
return this;
}

@Override
@CheckForNull
public Analysis getBaseProjectSnapshot() {
return delegate.getBaseProjectSnapshot();
public Analysis getBaseAnalysis() {
return delegate.getBaseAnalysis();
}

@Override

+ 15
- 15
server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStepTest.java View File

@@ -250,7 +250,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_baseProjectSnapshot_is_null() {
analysisMetadataHolder.setBaseProjectSnapshot(null);
analysisMetadataHolder.setBaseAnalysis(null);

underTest.execute();

@@ -259,7 +259,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_baseSnapshot_has_no_file_and_report_has_no_file() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);

underTest.execute();

@@ -268,7 +268,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_baseSnapshot_has_no_file() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
setFilesInReport(FILE_1, FILE_2);

underTest.execute();
@@ -278,7 +278,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_retrieves_only_file_and_unit_tests_from_last_snapshot() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
ArgumentCaptor<ComponentTreeQuery> captor = ArgumentCaptor.forClass(ComponentTreeQuery.class);
when(componentDao.selectDescendants(eq(dbSession), captor.capture()))
.thenReturn(Collections.emptyList());
@@ -295,7 +295,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_there_is_no_file_in_report() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents( /* no components */);
setFilesInReport();

@@ -306,7 +306,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_file_key_exists_in_both_DB_and_report() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents(FILE_1.getKey(), FILE_2.getKey());
setFilesInReport(FILE_2, FILE_1);

@@ -317,7 +317,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_move_if_content_of_file_is_same_in_DB_and_report() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
ComponentDto[] dtos = mockComponents(FILE_1.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT1);
setFilesInReport(FILE_2);
@@ -334,7 +334,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_content_of_file_is_not_similar_enough() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents(FILE_1.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT1);
setFilesInReport(FILE_2);
@@ -347,7 +347,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_content_of_file_is_empty_in_DB() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents(FILE_1.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT_EMPTY);
setFilesInReport(FILE_2);
@@ -360,7 +360,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_content_of_file_has_no_path_in_DB() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);

mockComponents(key -> newComponentDto(key).setPath(null), FILE_1.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT1);
@@ -374,7 +374,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_content_of_file_is_empty_in_report() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents(FILE_1.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT1);
setFilesInReport(FILE_2);
@@ -387,7 +387,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_two_added_files_have_same_content_as_the_one_in_db() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents(FILE_1.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT1);
setFilesInReport(FILE_2, FILE_3);
@@ -401,7 +401,7 @@ public class FileMoveDetectionStepTest {

@Test
public void execute_detects_no_move_if_two_deleted_files_have_same_content_as_the_one_added() {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
mockComponents(FILE_1.getKey(), FILE_2.getKey());
mockContentOfFileInDb(FILE_1.getKey(), CONTENT1);
mockContentOfFileInDb(FILE_2.getKey(), CONTENT1);
@@ -420,7 +420,7 @@ public class FileMoveDetectionStepTest {
// - file2 deleted
// - file4 untouched
// - file5 renamed to file6 with a small change
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
Component file4 = fileComponent(5);
Component file5 = fileComponent(6);
Component file6 = fileComponent(7);
@@ -452,7 +452,7 @@ public class FileMoveDetectionStepTest {
*/
@Test
public void real_life_use_case() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(ANALYSIS);
analysisMetadataHolder.setBaseAnalysis(ANALYSIS);
List<String> componentDtoKey = new ArrayList<>();
for (File f : FileUtils.listFiles(new File("src/test/resources/org/sonar/server/computation/task/projectanalysis/filemove/FileMoveDetectionStepTest/v1"), null, false)) {
componentDtoKey.add(f.getName());

+ 11
- 11
server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/scm/ScmInfoRepositoryImplTest.java View File

@@ -90,7 +90,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void read_from_report() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addChangesetInReport("john", DATE_1, "rev-1");

ScmInfo scmInfo = underTest.getScmInfo(FILE).get();
@@ -101,7 +101,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void getScmInfo_returns_absent_if_CopyFromPrevious_is_false_and_there_is_no_changeset_in_report() {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
// put data in DB, which should not be used
addFileSourceInDb("henry", DATE_1, "rev-1", computeSourceHash(1));
addFileSourceInReport(1);
@@ -111,7 +111,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void getScmInfo_returns_ScmInfo_from_DB_CopyFromPrevious_is_true_if_hashes_are_the_same() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addFileSourceInDb("henry", DATE_1, "rev-1", computeSourceHash(1));
addFileSourceInReport(1);
addCopyFromPreviousChangesetInReport();
@@ -124,7 +124,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void getScmInfo_returns_absent_when_CopyFromPrevious_is_true_but_hashes_are_not_the_same() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addFileSourceInDb("henry", DATE_1, "rev-1", computeSourceHash(1) + "_different");
addFileSourceInReport(1);
addCopyFromPreviousChangesetInReport();
@@ -136,7 +136,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void read_from_report_even_if_data_in_db_exists() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addFileSourceInDb("henry", DATE_1, "rev-1", computeSourceHash(1));
addChangesetInReport("john", DATE_2, "rev-2");

@@ -150,7 +150,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void read_from_db_even_if_data_in_report_exists_when_CopyFromPrevious_is_true() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addFileSourceInDb("henry", DATE_1, "rev-1", computeSourceHash(1));
addFileSourceInReport(1);
addChangesetInReport("john", DATE_2, "rev-2", true);
@@ -165,13 +165,13 @@ public class ScmInfoRepositoryImplTest {

@Test
public void return_nothing_when_no_data_in_report_nor_db() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
assertThat(underTest.getScmInfo(FILE)).isAbsent();
}

@Test
public void return_nothing_when_nothing_in_report_and_db_has_no_scm() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addFileSourceInDb(null, null, null, "don't care");
addFileSourceInReport(1);

@@ -180,7 +180,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void fail_with_NPE_when_component_is_null() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);

thrown.expect(NullPointerException.class);
thrown.expectMessage("Component cannot be bull");
@@ -219,7 +219,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void load_scm_info_from_cache_when_already_read() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);
addChangesetInReport("john", DATE_1, "rev-1");
ScmInfo scmInfo = underTest.getScmInfo(FILE).get();
assertThat(scmInfo.getAllChangesets()).hasSize(1);
@@ -233,7 +233,7 @@ public class ScmInfoRepositoryImplTest {

@Test
public void not_read_in_db_on_first_analysis_when_CopyFromPrevious_is_true() throws Exception {
analysisMetadataHolder.setBaseProjectSnapshot(null);
analysisMetadataHolder.setBaseAnalysis(null);
addFileSourceInDb("henry", DATE_1, "rev-1", "don't care");
addFileSourceInReport(1);
addCopyFromPreviousChangesetInReport();

+ 5
- 5
server/sonar-server/src/test/java/org/sonar/server/computation/task/projectanalysis/step/LoadCrossProjectDuplicationsRepositoryStepTest.java View File

@@ -124,7 +124,7 @@ public class LoadCrossProjectDuplicationsRepositoryStepTest {
@Test
public void call_compute_cpd_on_one_duplication() throws Exception {
when(crossProjectDuplicationStatusHolder.isEnabled()).thenReturn(true);
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);

ComponentDto otherProject = createProject("OTHER_PROJECT_KEY");
SnapshotDto otherProjectSnapshot = createProjectSnapshot(otherProject);
@@ -174,7 +174,7 @@ public class LoadCrossProjectDuplicationsRepositoryStepTest {
@Test
public void call_compute_cpd_on_many_duplication() throws Exception {
when(crossProjectDuplicationStatusHolder.isEnabled()).thenReturn(true);
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);

ComponentDto otherProject = createProject("OTHER_PROJECT_KEY");
SnapshotDto otherProjectSnapshot = createProjectSnapshot(otherProject);
@@ -262,7 +262,7 @@ public class LoadCrossProjectDuplicationsRepositoryStepTest {
@Test
public void nothing_to_do_when_cross_project_duplication_is_disabled() throws Exception {
when(crossProjectDuplicationStatusHolder.isEnabled()).thenReturn(false);
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);

ComponentDto otherProject = createProject("OTHER_PROJECT_KEY");
SnapshotDto otherProjectSnapshot = createProjectSnapshot(otherProject);
@@ -297,7 +297,7 @@ public class LoadCrossProjectDuplicationsRepositoryStepTest {
@Test
public void nothing_to_do_when_no_cpd_text_blocks_found() throws Exception {
when(crossProjectDuplicationStatusHolder.isEnabled()).thenReturn(true);
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);

batchReportReader.putDuplicationBlocks(FILE_REF, Collections.<ScannerReport.CpdTextBlock>emptyList());

@@ -309,7 +309,7 @@ public class LoadCrossProjectDuplicationsRepositoryStepTest {
@Test
public void nothing_to_do_when_cpd_text_blocks_exists_but_no_duplicated_found() throws Exception {
when(crossProjectDuplicationStatusHolder.isEnabled()).thenReturn(true);
analysisMetadataHolder.setBaseProjectSnapshot(baseProjectAnalysis);
analysisMetadataHolder.setBaseAnalysis(baseProjectAnalysis);

ScannerReport.CpdTextBlock originBlock = ScannerReport.CpdTextBlock.newBuilder()
.setHash("a8998353e96320ec")

Loading…
Cancel
Save