Преглед на файлове

fix promise rejection handler of condition creation

tags/7.6
Stas Vilchik преди 5 години
родител
ревизия
d3fe612523

+ 2
- 2
server/sonar-web/src/main/js/api/quality-gates.ts Целия файл

@@ -79,13 +79,13 @@ export function createCondition(
organization?: string;
} & T.Omit<T.Condition, 'id'>
): Promise<T.Condition> {
return postJSON('/api/qualitygates/create_condition', data);
return postJSON('/api/qualitygates/create_condition', data).catch(throwGlobalError);
}

export function updateCondition(
data: { organization?: string } & T.Condition
): Promise<T.Condition> {
return postJSON('/api/qualitygates/update_condition', data);
return postJSON('/api/qualitygates/update_condition', data).catch(throwGlobalError);
}

export function deleteCondition(data: { id: number; organization?: string }): Promise<void> {

+ 2
- 10
server/sonar-web/src/main/js/apps/quality-gates/components/ConditionModal.tsx Целия файл

@@ -25,7 +25,6 @@ import Period from './Period';
import { translate, getLocalizedMetricName } from '../../../helpers/l10n';
import { createCondition, updateCondition } from '../../../api/quality-gates';
import { isDiffMetric } from '../../../helpers/measures';
import { parseError } from '../../../helpers/request';
import ConfirmModal from '../../../components/controls/ConfirmModal';
import { Alert } from '../../../components/ui/Alert';

@@ -100,16 +99,9 @@ export default class ConditionModal extends React.PureComponent<Props, State> {
} else {
submitPromise = createCondition({ gateId: qualityGate.id, organization, ...newCondition });
}
return submitPromise.then(this.props.onAddCondition, (error: any) =>
parseError(error).then(message => {
if (this.mounted) {
this.setState({ errorMessage: message });
}
return Promise.reject(message);
})
);
return submitPromise.then(this.props.onAddCondition);
}
return Promise.reject('No metric selected');
return Promise.reject();
};

handleChooseType = (metric: T.Metric) => {

Loading…
Отказ
Запис