Browse Source

Rename Visitor to ComponentVisitor

tags/5.2-RC1
Julien Lancelot 8 years ago
parent
commit
df1e852ed6
45 changed files with 103 additions and 103 deletions
  1. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/component/ComponentVisitor.java
  2. 4
    4
      server/sonar-server/src/main/java/org/sonar/server/computation/component/DepthTraversalTypeAwareCrawler.java
  3. 3
    3
      server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareCrawler.java
  4. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareVisitor.java
  5. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareVisitorWrapper.java
  6. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/component/TreeRootHolderImpl.java
  7. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/component/TypeAwareVisitor.java
  8. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/component/TypeAwareVisitorWrapper.java
  9. 9
    9
      server/sonar-server/src/main/java/org/sonar/server/computation/component/VisitorsCrawler.java
  10. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/container/ComputeEngineContainer.java
  11. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/container/ComputeEngineContainerImpl.java
  12. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/formula/FormulaExecutorComponentCrawler.java
  13. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/measure/MeasureComputersVisitor.java
  14. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/sqale/SqaleMeasuresVisitor.java
  15. 10
    10
      server/sonar-server/src/main/java/org/sonar/server/computation/step/ComponentVisitors.java
  16. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/ComputeQProfileMeasureStep.java
  17. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/step/CustomMeasuresCopyStep.java
  18. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/step/ExecuteVisitorsStep.java
  19. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/FillMeasuresWithVariationsStep.java
  20. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/IntegrateIssuesStep.java
  21. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistDuplicationsStep.java
  22. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistEventsStep.java
  23. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistFileSourcesStep.java
  24. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistMeasuresStep.java
  25. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistNumberOfDaysSinceLastCommitStep.java
  26. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistProjectLinksStep.java
  27. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistTestsStep.java
  28. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateEventsStep.java
  29. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateLoadingStep.java
  30. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateMeasuresStep.java
  31. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityProfileEventsStep.java
  32. 1
    1
      server/sonar-server/src/main/java/org/sonar/server/computation/step/SizeMeasuresStep.java
  33. 2
    2
      server/sonar-server/src/main/java/org/sonar/server/computation/step/ValidateProjectStep.java
  34. 1
    1
      server/sonar-server/src/test/java/org/sonar/server/computation/batch/TreeRootHolderRule.java
  35. 3
    3
      server/sonar-server/src/test/java/org/sonar/server/computation/component/PathAwareCrawlerTest.java
  36. 1
    1
      server/sonar-server/src/test/java/org/sonar/server/computation/component/PostOrderDepthTraversalTypeAwareCrawlerTest.java
  37. 1
    1
      server/sonar-server/src/test/java/org/sonar/server/computation/component/PreOrderDepthTraversalTypeAwareCrawlerTest.java
  38. 7
    7
      server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerTest.java
  39. 5
    5
      server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPathAwareVisitorTest.java
  40. 3
    3
      server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPostOrderTypeAwareVisitorTest.java
  41. 3
    3
      server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPreOrderTypeAwareVisitorTest.java
  42. 3
    3
      server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureComputersVisitorTest.java
  43. 2
    2
      server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureRepositoryRule.java
  44. 2
    2
      server/sonar-server/src/test/java/org/sonar/server/computation/sqale/SqaleMeasuresVisitorTest.java
  45. 5
    5
      server/sonar-server/src/test/java/org/sonar/server/computation/step/ExecuteVisitorsStepTest.java

server/sonar-server/src/main/java/org/sonar/server/computation/component/Visitor.java → server/sonar-server/src/main/java/org/sonar/server/computation/component/ComponentVisitor.java View File

@@ -20,7 +20,7 @@

package org.sonar.server.computation.component;

public interface Visitor {
public interface ComponentVisitor {

Order getOrder();


+ 4
- 4
server/sonar-server/src/main/java/org/sonar/server/computation/component/DepthTraversalTypeAwareCrawler.java View File

@@ -29,9 +29,9 @@ import static java.util.Objects.requireNonNull;
*/
public abstract class DepthTraversalTypeAwareCrawler implements TypeAwareCrawler {
private final Component.Type maxDepth;
private final Visitor.Order order;
private final ComponentVisitor.Order order;

protected DepthTraversalTypeAwareCrawler(Component.Type maxDepth, Visitor.Order order) {
protected DepthTraversalTypeAwareCrawler(Component.Type maxDepth, ComponentVisitor.Order order) {
this.maxDepth = requireNonNull(maxDepth);
this.order = requireNonNull(order);
}
@@ -42,13 +42,13 @@ public abstract class DepthTraversalTypeAwareCrawler implements TypeAwareCrawler
return;
}

if (order == Visitor.Order.PRE_ORDER) {
if (order == ComponentVisitor.Order.PRE_ORDER) {
visitNode(component);
}

visitChildren(component);

if (order == Visitor.Order.POST_ORDER) {
if (order == ComponentVisitor.Order.POST_ORDER) {
visitNode(component);
}
}

+ 3
- 3
server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareCrawler.java View File

@@ -19,8 +19,8 @@
*/
package org.sonar.server.computation.component;

import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

/**
* A {@link ComponentCrawler} which provide access to a representation of the path from the root to the currently visited
@@ -32,7 +32,7 @@ public abstract class PathAwareCrawler<T> extends PathAwareVisitorAdapter<T> imp

private final DequeBasedPath<T> stack = new DequeBasedPath<>();

public PathAwareCrawler(Component.Type maxDepth, Visitor.Order order, StackElementFactory<T> factory) {
public PathAwareCrawler(Component.Type maxDepth, ComponentVisitor.Order order, StackElementFactory<T> factory) {
super(maxDepth, order, factory);
}


+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareVisitor.java View File

@@ -23,11 +23,11 @@ package org.sonar.server.computation.component;
import java.util.NoSuchElementException;

/**
* A {@link Visitor} which provide access to a representation of the path from the root to the currently visited
* A {@link ComponentVisitor} which provide access to a representation of the path from the root to the currently visited
* Component. It also provides a way to have an object associated to each Component and access it and all of its
* parent's.
*/
public interface PathAwareVisitor<T> extends Visitor {
public interface PathAwareVisitor<T> extends ComponentVisitor {

StackElementFactory<T> getFactory();


+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/component/PathAwareVisitorWrapper.java View File

@@ -66,7 +66,7 @@ public class PathAwareVisitorWrapper<T> implements VisitorWrapper {
}

@Override
public Visitor.Order getOrder() {
public ComponentVisitor.Order getOrder() {
return delegate.getOrder();
}


+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/component/TreeRootHolderImpl.java View File

@@ -23,7 +23,7 @@ import java.util.HashMap;
import java.util.Map;
import java.util.Objects;

import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

/**
* Holds the reference to the root of the {@link Component} tree for the current CE run.

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/component/TypeAwareVisitor.java View File

@@ -21,9 +21,9 @@
package org.sonar.server.computation.component;

/**
* A {@link Visitor} which can exposes methods which ensure the type of the visited Component.
* A {@link ComponentVisitor} which can exposes methods which ensure the type of the visited Component.
*/
public interface TypeAwareVisitor extends Visitor {
public interface TypeAwareVisitor extends ComponentVisitor {
/**
* Called when encountering a Component of type {@link Component.Type#PROJECT}
*/

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/component/TypeAwareVisitorWrapper.java View File

@@ -64,7 +64,7 @@ public class TypeAwareVisitorWrapper implements VisitorWrapper {
}

@Override
public Visitor.Order getOrder() {
public ComponentVisitor.Order getOrder() {
return delegate.getOrder();
}


+ 9
- 9
server/sonar-server/src/main/java/org/sonar/server/computation/component/VisitorsCrawler.java View File

@@ -36,7 +36,7 @@ public class VisitorsCrawler implements ComponentCrawler {
private final List<VisitorWrapper> preOrderVisitorWrappers;
private final List<VisitorWrapper> postOrderVisitorWrappers;

public VisitorsCrawler(Iterable<Visitor> visitors) {
public VisitorsCrawler(Iterable<ComponentVisitor> visitors) {
List<VisitorWrapper> visitorWrappers = from(visitors).transform(ToVisitorWrapper.INSTANCE).toList();
this.preOrderVisitorWrappers = from(visitorWrappers).filter(MathPreOrderVisitor.INSTANCE).toList();
this.postOrderVisitorWrappers = from(visitorWrappers).filter(MatchPostOrderVisitor.INSTANCE).toList();
@@ -95,15 +95,15 @@ public class VisitorsCrawler implements ComponentCrawler {
}
}

private enum ToVisitorWrapper implements Function<Visitor, VisitorWrapper> {
private enum ToVisitorWrapper implements Function<ComponentVisitor, VisitorWrapper> {
INSTANCE;

@Override
public VisitorWrapper apply(@Nonnull Visitor visitor) {
if (visitor instanceof TypeAwareVisitor) {
return new TypeAwareVisitorWrapper((TypeAwareVisitor) visitor);
} else if (visitor instanceof PathAwareVisitor) {
return new PathAwareVisitorWrapper((PathAwareVisitor) visitor);
public VisitorWrapper apply(@Nonnull ComponentVisitor componentVisitor) {
if (componentVisitor instanceof TypeAwareVisitor) {
return new TypeAwareVisitorWrapper((TypeAwareVisitor) componentVisitor);
} else if (componentVisitor instanceof PathAwareVisitor) {
return new PathAwareVisitorWrapper((PathAwareVisitor) componentVisitor);
} else {
throw new IllegalArgumentException("Only TypeAwareVisitor and PathAwareVisitor can be used");
}
@@ -128,7 +128,7 @@ public class VisitorsCrawler implements ComponentCrawler {

@Override
public boolean apply(@Nonnull VisitorWrapper visitorWrapper) {
return visitorWrapper.getOrder() == Visitor.Order.PRE_ORDER;
return visitorWrapper.getOrder() == ComponentVisitor.Order.PRE_ORDER;
}
}

@@ -137,7 +137,7 @@ public class VisitorsCrawler implements ComponentCrawler {

@Override
public boolean apply(@Nonnull VisitorWrapper visitorWrapper) {
return visitorWrapper.getOrder() == Visitor.Order.POST_ORDER;
return visitorWrapper.getOrder() == ComponentVisitor.Order.POST_ORDER;
}
}
}

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/container/ComputeEngineContainer.java View File

@@ -21,7 +21,7 @@ package org.sonar.server.computation.container;

import org.sonar.core.platform.ComponentContainer;
import org.sonar.server.computation.ReportQueue.Item;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.step.ComputationStep;

/**
@@ -46,7 +46,7 @@ public interface ComputeEngineContainer {
*/
<T extends ComputationStep> T getStep(Class<T> type);

<T extends Visitor> T getComponentVisitor(Class<T> type);
<T extends ComponentVisitor> T getComponentVisitor(Class<T> type);


}

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/container/ComputeEngineContainerImpl.java View File

@@ -43,10 +43,10 @@ import org.sonar.server.computation.ReportQueue;
import org.sonar.server.computation.activity.ActivityManager;
import org.sonar.server.computation.batch.BatchReportDirectoryHolderImpl;
import org.sonar.server.computation.batch.BatchReportReaderImpl;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DbIdsRepository;
import org.sonar.server.computation.component.ProjectSettingsRepository;
import org.sonar.server.computation.component.TreeRootHolderImpl;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.debt.DebtModelHolderImpl;
import org.sonar.server.computation.event.EventRepositoryImpl;
import org.sonar.server.computation.issue.BaseIssuesLoader;
@@ -274,7 +274,7 @@ public class ComputeEngineContainerImpl extends ComponentContainer implements Co
}

@Override
public <T extends Visitor> T getComponentVisitor(Class<T> type) {
public <T extends ComponentVisitor> T getComponentVisitor(Class<T> type) {
return getComponentByType(type);
}


+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/formula/FormulaExecutorComponentCrawler.java View File

@@ -26,8 +26,8 @@ import java.util.List;
import java.util.Map;
import javax.annotation.CheckForNull;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.PathAwareCrawler;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.measure.Measure;
import org.sonar.server.computation.measure.MeasureRepository;
import org.sonar.server.computation.metric.Metric;
@@ -59,7 +59,7 @@ public class FormulaExecutorComponentCrawler extends PathAwareCrawler<FormulaExe
private final List<Formula> formulas;

private FormulaExecutorComponentCrawler(Builder builder, List<Formula> formulas) {
super(Component.Type.FILE, Visitor.Order.POST_ORDER, COUNTERS_FACTORY);
super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER, COUNTERS_FACTORY);
this.periodsHolder = builder.periodsHolder;
this.measureRepository = builder.measureRepository;
this.metricRepository = builder.metricRepository;

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/measure/MeasureComputersVisitor.java View File

@@ -27,7 +27,7 @@ import org.sonar.server.computation.measure.api.MeasureComputerImplementationCon
import org.sonar.server.computation.metric.MetricRepository;

import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class MeasureComputersVisitor extends TypeAwareVisitorAdapter {


+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/sqale/SqaleMeasuresVisitor.java View File

@@ -23,8 +23,8 @@ package org.sonar.server.computation.sqale;
import com.google.common.base.Optional;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.PathAwareVisitorAdapter;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.measure.Measure;
import org.sonar.server.computation.measure.MeasureRepository;
import org.sonar.server.computation.metric.Metric;
@@ -44,7 +44,7 @@ public class SqaleMeasuresVisitor extends PathAwareVisitorAdapter<SqaleMeasuresV
private final Metric sqaleRatingMetric;

public SqaleMeasuresVisitor(MetricRepository metricRepository, MeasureRepository measureRepository, SqaleRatingSettings sqaleRatingSettings) {
super(Component.Type.FILE, Visitor.Order.POST_ORDER, new SimpleStackElementFactory<DevelopmentCost>() {
super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER, new SimpleStackElementFactory<DevelopmentCost>() {
@Override
public DevelopmentCost createForAny(Component component) {
return new DevelopmentCost();

+ 10
- 10
server/sonar-server/src/main/java/org/sonar/server/computation/step/ComponentVisitors.java View File

@@ -26,7 +26,7 @@ import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import java.util.List;
import javax.annotation.Nonnull;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.container.ComputeEngineContainer;
import org.sonar.server.computation.measure.MeasureComputersVisitor;
import org.sonar.server.computation.sqale.SqaleMeasuresVisitor;
@@ -36,7 +36,7 @@ import org.sonar.server.computation.sqale.SqaleMeasuresVisitor;
*/
public class ComponentVisitors {

private static final List<Class<? extends Visitor>> ORDERED_VISITOR_CLASSES = ImmutableList.of(
private static final List<Class<? extends ComponentVisitor>> ORDERED_VISITOR_CLASSES = ImmutableList.of(
SqaleMeasuresVisitor.class,

// Must be after all other visitors as it requires measures computed by previous visitors
@@ -44,9 +44,9 @@ public class ComponentVisitors {
);

/**
* List of all {@link Visitor}, ordered by execution sequence.
* List of all {@link ComponentVisitor}, ordered by execution sequence.
*/
public List<Class<? extends Visitor>> orderedClasses() {
public List<Class<? extends ComponentVisitor>> orderedClasses() {
return ORDERED_VISITOR_CLASSES;
}

@@ -56,13 +56,13 @@ public class ComponentVisitors {
this.computeEngineContainer = computeEngineContainer;
}

public Iterable<Visitor> instances() {
return Iterables.transform(orderedClasses(), new Function<Class<? extends Visitor>, Visitor>() {
public Iterable<ComponentVisitor> instances() {
return Iterables.transform(orderedClasses(), new Function<Class<? extends ComponentVisitor>, ComponentVisitor>() {
@Override
public Visitor apply(@Nonnull Class<? extends Visitor> input) {
Visitor visitor = computeEngineContainer.getComponentVisitor(input);
Preconditions.checkState(visitor != null, String.format("Visitor not found: %s", input));
return visitor;
public ComponentVisitor apply(@Nonnull Class<? extends ComponentVisitor> input) {
ComponentVisitor componentVisitor = computeEngineContainer.getComponentVisitor(input);
Preconditions.checkState(componentVisitor != null, String.format("Visitor not found: %s", input));
return componentVisitor;
}
});
}

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/ComputeQProfileMeasureStep.java View File

@@ -36,7 +36,7 @@ import org.sonar.server.computation.qualityprofile.QPMeasureData;
import org.sonar.server.computation.qualityprofile.QualityProfile;

import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

/**
* Aggregates quality profile on lower-level module nodes on their parent modules and project

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/step/CustomMeasuresCopyStep.java View File

@@ -27,9 +27,9 @@ import org.sonar.db.DbSession;
import org.sonar.db.MyBatis;
import org.sonar.db.measure.custom.CustomMeasureDto;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.measure.Measure;
import org.sonar.server.computation.measure.MeasureRepository;
import org.sonar.server.computation.metric.Metric;
@@ -52,7 +52,7 @@ public class CustomMeasuresCopyStep implements ComputationStep {

@Override
public void execute() {
new DepthTraversalTypeAwareCrawler(Component.Type.FILE, Visitor.Order.PRE_ORDER) {
new DepthTraversalTypeAwareCrawler(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER) {
@Override
public void visitAny(Component component) {
copy(component);

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/step/ExecuteVisitorsStep.java View File

@@ -20,13 +20,13 @@

package org.sonar.server.computation.step;

import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.component.VisitorsCrawler;

public class ExecuteVisitorsStep implements ComputationStep {
private final TreeRootHolder treeRootHolder;
private final Iterable<Visitor> visitors;
private final Iterable<ComponentVisitor> visitors;

public ExecuteVisitorsStep(TreeRootHolder treeRootHolder, ComponentVisitors visitors) {
this.treeRootHolder = treeRootHolder;

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/FillMeasuresWithVariationsStep.java View File

@@ -46,7 +46,7 @@ import org.sonar.server.computation.metric.MetricRepository;
import org.sonar.server.computation.period.Period;
import org.sonar.server.computation.period.PeriodsHolder;

import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

/**
* Set variations on all numeric measures found in the repository.

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/IntegrateIssuesStep.java View File

@@ -36,7 +36,7 @@ import org.sonar.server.computation.issue.IssueVisitors;
import org.sonar.server.computation.issue.TrackerExecution;
import org.sonar.server.util.cache.DiskCache;

import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

public class IntegrateIssuesStep implements ComputationStep {


+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistDuplicationsStep.java View File

@@ -36,7 +36,7 @@ import org.sonar.server.computation.component.DbIdsRepository;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;

import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

/**
* Persist duplications into

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistEventsStep.java View File

@@ -29,10 +29,10 @@ import org.sonar.db.MyBatis;
import org.sonar.db.event.EventDto;
import org.sonar.server.computation.batch.BatchReportReader;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DbIdsRepository;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.event.Event;
import org.sonar.server.computation.event.EventRepository;

@@ -139,7 +139,7 @@ public class PersistEventsStep implements ComputationStep {
private final long analysisDate;

public PersistEventComponentCrawler(DbSession session, long analysisDate) {
super(Component.Type.FILE, Visitor.Order.PRE_ORDER);
super(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER);
this.session = session;
this.analysisDate = analysisDate;
}

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistFileSourcesStep.java View File

@@ -49,7 +49,7 @@ import org.sonar.server.computation.source.LineReader;
import org.sonar.server.computation.source.ScmLineReader;
import org.sonar.server.computation.source.SymbolsLineReader;

import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class PersistFileSourcesStep implements ComputationStep {


+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistMeasuresStep.java View File

@@ -46,7 +46,7 @@ import static com.google.common.collect.FluentIterable.from;
import static org.sonar.api.measures.CoreMetrics.CLASS_COMPLEXITY_DISTRIBUTION_KEY;
import static org.sonar.api.measures.CoreMetrics.FILE_COMPLEXITY_DISTRIBUTION_KEY;
import static org.sonar.api.measures.CoreMetrics.FUNCTION_COMPLEXITY_DISTRIBUTION_KEY;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class PersistMeasuresStep implements ComputationStep {


+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistNumberOfDaysSinceLastCommitStep.java View File

@@ -39,7 +39,7 @@ import org.sonar.server.computation.metric.MetricRepository;
import org.sonar.server.source.index.SourceLineIndex;

import static com.google.common.base.Objects.firstNonNull;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class PersistNumberOfDaysSinceLastCommitStep implements ComputationStep {


+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistProjectLinksStep.java View File

@@ -41,7 +41,7 @@ import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;

import static com.google.common.collect.Sets.newHashSet;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

/**
* Persist project and module links

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/step/PersistTestsStep.java View File

@@ -49,9 +49,9 @@ import org.sonar.db.source.FileSourceDto;
import org.sonar.db.source.FileSourceDto.Type;
import org.sonar.server.computation.batch.BatchReportReader;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;

public class PersistTestsStep implements ComputationStep {

@@ -97,7 +97,7 @@ public class PersistTestsStep implements ComputationStep {
boolean hasUnprocessedCoverageDetails = false;

public TestDepthTraversalTypeAwareCrawler(DbSession session) {
super(Component.Type.FILE, Visitor.Order.PRE_ORDER);
super(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER);
this.session = session;
this.existingFileSourcesByUuid = new HashMap<>();
this.projectUuid = treeRootHolder.getRoot().getUuid();

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateEventsStep.java View File

@@ -26,9 +26,9 @@ import org.sonar.api.notifications.Notification;
import org.sonar.api.utils.log.Logger;
import org.sonar.api.utils.log.Loggers;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.event.Event;
import org.sonar.server.computation.event.EventRepository;
import org.sonar.server.computation.measure.Measure;
@@ -62,7 +62,7 @@ public class QualityGateEventsStep implements ComputationStep {

@Override
public void execute() {
new DepthTraversalTypeAwareCrawler(Component.Type.PROJECT, Visitor.Order.PRE_ORDER) {
new DepthTraversalTypeAwareCrawler(Component.Type.PROJECT, ComponentVisitor.Order.PRE_ORDER) {
@Override
public void visitProject(Component project) {
executeForProject(project);

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateLoadingStep.java View File

@@ -34,7 +34,7 @@ import org.sonar.server.computation.qualitygate.QualityGate;
import org.sonar.server.computation.qualitygate.QualityGateService;

import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

/**
* This step retrieves the QualityGate for the current {@link ReportQueue.Item} and stores it in

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityGateMeasuresStep.java View File

@@ -44,7 +44,7 @@ import org.sonar.server.computation.qualitygate.QualityGate;
import org.sonar.server.computation.qualitygate.QualityGateHolder;

import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

/**
* This step:

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/QualityProfileEventsStep.java View File

@@ -42,7 +42,7 @@ import org.sonar.server.computation.metric.MetricRepository;
import org.sonar.server.computation.qualityprofile.QPMeasureData;
import org.sonar.server.computation.qualityprofile.QualityProfile;

import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

/**
* Computation of quality profile events

+ 1
- 1
server/sonar-server/src/main/java/org/sonar/server/computation/step/SizeMeasuresStep.java View File

@@ -40,7 +40,7 @@ import static org.sonar.api.measures.CoreMetrics.LINES_KEY;
import static org.sonar.api.measures.CoreMetrics.NCLOC_KEY;
import static org.sonar.api.measures.CoreMetrics.STATEMENTS_KEY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
import static org.sonar.server.computation.measure.Measure.newMeasureBuilder;

/**

+ 2
- 2
server/sonar-server/src/main/java/org/sonar/server/computation/step/ValidateProjectStep.java View File

@@ -42,9 +42,9 @@ import org.sonar.db.component.ComponentDto;
import org.sonar.db.component.SnapshotDto;
import org.sonar.server.computation.batch.BatchReportReader;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;

import static org.sonar.api.utils.DateUtils.formatDateTime;

@@ -108,7 +108,7 @@ public class ValidateProjectStep implements ComputationStep {
private Component rawProject;

public ValidateProjectsCrawler(DbSession session, ComponentDao componentDao, boolean preventAutomaticProjectCreation, Map<String, ComponentDto> baseModulesByKey) {
super(Component.Type.MODULE, Visitor.Order.PRE_ORDER);
super(Component.Type.MODULE, ComponentVisitor.Order.PRE_ORDER);
this.session = session;
this.componentDao = componentDao;


+ 1
- 1
server/sonar-server/src/test/java/org/sonar/server/computation/batch/TreeRootHolderRule.java View File

@@ -30,7 +30,7 @@ import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.MutableTreeRootHolder;
import org.sonar.server.computation.component.TreeRootHolder;

import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

public class TreeRootHolderRule implements TestRule, MutableTreeRootHolder {
private Component root;

+ 3
- 3
server/sonar-server/src/test/java/org/sonar/server/computation/component/PathAwareCrawlerTest.java View File

@@ -38,8 +38,8 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class PathAwareCrawlerTest {

@@ -258,7 +258,7 @@ public class PathAwareCrawlerTest {
private static class TestPathAwareCrawler extends PathAwareCrawler<Integer> {
private final List<CallRecord> callsRecords = new ArrayList<>();

public TestPathAwareCrawler(Component.Type maxDepth, Visitor.Order order) {
public TestPathAwareCrawler(Component.Type maxDepth, ComponentVisitor.Order order) {
super(maxDepth, order, new SimpleStackElementFactory<Integer>() {
@Override
public Integer createForAny(Component component) {

+ 1
- 1
server/sonar-server/src/test/java/org/sonar/server/computation/component/PostOrderDepthTraversalTypeAwareCrawlerTest.java View File

@@ -29,7 +29,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

public class PostOrderDepthTraversalTypeAwareCrawlerTest {


+ 1
- 1
server/sonar-server/src/test/java/org/sonar/server/computation/component/PreOrderDepthTraversalTypeAwareCrawlerTest.java View File

@@ -29,7 +29,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class PreOrderDepthTraversalTypeAwareCrawlerTest {


+ 7
- 7
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerTest.java View File

@@ -34,8 +34,8 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class VisitorsCrawlerTest {

@@ -87,7 +87,7 @@ public class VisitorsCrawlerTest {
@Test
public void execute_pre_visitor_before_post_visitor() throws Exception {
InOrder inOrder = inOrder(spyPreOrderTypeAwareVisitor, spyPostOrderTypeAwareVisitor);
VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<Visitor>asList(spyPreOrderTypeAwareVisitor, spyPostOrderTypeAwareVisitor));
VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(spyPreOrderTypeAwareVisitor, spyPostOrderTypeAwareVisitor));
underTest.visit(COMPONENT_TREE);

inOrder.verify(spyPreOrderTypeAwareVisitor).visitProject(COMPONENT_TREE);
@@ -108,7 +108,7 @@ public class VisitorsCrawlerTest {
thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("Only TypeAwareVisitor and PathAwareVisitor can be used");

Visitor visitor = new Visitor() {
ComponentVisitor componentVisitor = new ComponentVisitor() {
@Override
public Order getOrder() {
return PRE_ORDER;
@@ -119,7 +119,7 @@ public class VisitorsCrawlerTest {
return FILE;
}
};
new VisitorsCrawler(Arrays.asList(visitor));
new VisitorsCrawler(Arrays.asList(componentVisitor));
}

private static Component component(final Component.Type type, final int ref, final Component... children) {
@@ -128,14 +128,14 @@ public class VisitorsCrawlerTest {

private static class TestTypeAwareVisitor extends TypeAwareVisitorAdapter {

public TestTypeAwareVisitor(Component.Type maxDepth, Visitor.Order order) {
public TestTypeAwareVisitor(Component.Type maxDepth, ComponentVisitor.Order order) {
super(maxDepth, order);
}
}

private static class TestPathAwareVisitor extends PathAwareVisitorAdapter<Integer> {

public TestPathAwareVisitor(Component.Type maxDepth, Visitor.Order order) {
public TestPathAwareVisitor(Component.Type maxDepth, ComponentVisitor.Order order) {
super(maxDepth, order, new SimpleStackElementFactory<Integer>() {
@Override
public Integer createForAny(Component component) {

+ 5
- 5
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPathAwareVisitorTest.java View File

@@ -40,8 +40,8 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class VisitorsCrawlerWithPathAwareVisitorTest {

@@ -265,14 +265,14 @@ public class VisitorsCrawlerWithPathAwareVisitorTest {
return new CallRecord(method, currentRef, currentRef, parentRef, ROOT_REF, path);
}

private static VisitorsCrawler newVisitorsCrawler(Visitor visitor) {
return new VisitorsCrawler(Arrays.asList(visitor));
private static VisitorsCrawler newVisitorsCrawler(ComponentVisitor componentVisitor) {
return new VisitorsCrawler(Arrays.asList(componentVisitor));
}

private static class TestPathAwareVisitor extends PathAwareVisitorAdapter<Integer> {
private final List<CallRecord> callsRecords = new ArrayList<>();

public TestPathAwareVisitor(Component.Type maxDepth, Visitor.Order order) {
public TestPathAwareVisitor(Component.Type maxDepth, ComponentVisitor.Order order) {
super(maxDepth, order, new SimpleStackElementFactory<Integer>() {
@Override
public Integer createForAny(Component component) {

+ 3
- 3
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPostOrderTypeAwareVisitorTest.java View File

@@ -31,7 +31,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.POST_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.POST_ORDER;

public class VisitorsCrawlerWithPostOrderTypeAwareVisitorTest {

@@ -296,8 +296,8 @@ public class VisitorsCrawlerWithPostOrderTypeAwareVisitorTest {
return DumbComponent.builder(type, ref).addChildren(children).build();
}

private static VisitorsCrawler newVisitorsCrawler(Visitor visitor) {
return new VisitorsCrawler(Arrays.asList(visitor));
private static VisitorsCrawler newVisitorsCrawler(ComponentVisitor componentVisitor) {
return new VisitorsCrawler(Arrays.asList(componentVisitor));
}

}

+ 3
- 3
server/sonar-server/src/test/java/org/sonar/server/computation/component/VisitorsCrawlerWithPreOrderTypeAwareVisitorTest.java View File

@@ -31,7 +31,7 @@ import static org.sonar.server.computation.component.Component.Type.DIRECTORY;
import static org.sonar.server.computation.component.Component.Type.FILE;
import static org.sonar.server.computation.component.Component.Type.MODULE;
import static org.sonar.server.computation.component.Component.Type.PROJECT;
import static org.sonar.server.computation.component.Visitor.Order.PRE_ORDER;
import static org.sonar.server.computation.component.ComponentVisitor.Order.PRE_ORDER;

public class VisitorsCrawlerWithPreOrderTypeAwareVisitorTest {

@@ -289,8 +289,8 @@ public class VisitorsCrawlerWithPreOrderTypeAwareVisitorTest {
return DumbComponent.builder(type, ref).addChildren(children).build();
}

private static VisitorsCrawler newVisitorsCrawler(Visitor visitor) {
return new VisitorsCrawler(Arrays.asList(visitor));
private static VisitorsCrawler newVisitorsCrawler(ComponentVisitor componentVisitor) {
return new VisitorsCrawler(Arrays.asList(componentVisitor));
}

}

+ 3
- 3
server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureComputersVisitorTest.java View File

@@ -26,7 +26,7 @@ import org.junit.Rule;
import org.junit.Test;
import org.sonar.api.ce.measure.MeasureComputer;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.VisitorsCrawler;
import org.sonar.server.computation.measure.api.MeasureComputerImpl;
import org.sonar.server.computation.metric.MetricRepositoryRule;
@@ -116,7 +116,7 @@ public class MeasureComputersVisitorTest {
.build()
));

VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<Visitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
visitorsCrawler.visit(ROOT);

assertThat(toEntries(measureRepository.getAddedRawMeasures(FILE_1_REF))).containsOnly(entryOf(NEW_METRIC_KEY, newMeasureBuilder().create(12)));
@@ -140,7 +140,7 @@ public class MeasureComputersVisitorTest {
measureRepository.addRawMeasure(ROOT_REF, COMMENT_LINES_KEY, newMeasureBuilder().create(7));

measureComputersHolder.setMeasureComputers(Collections.<MeasureComputer>emptyList());
VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<Visitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
VisitorsCrawler visitorsCrawler = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(new MeasureComputersVisitor(metricRepository, measureRepository, null, measureComputersHolder)));
visitorsCrawler.visit(ROOT);

assertThat(toEntries(measureRepository.getAddedRawMeasures(FILE_1_REF))).isEmpty();

+ 2
- 2
server/sonar-server/src/test/java/org/sonar/server/computation/measure/MeasureRepositoryRule.java View File

@@ -33,9 +33,9 @@ import javax.annotation.Nullable;
import org.junit.rules.ExternalResource;
import org.sonar.db.rule.RuleDto;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DepthTraversalTypeAwareCrawler;
import org.sonar.server.computation.component.TreeRootHolder;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.debt.Characteristic;
import org.sonar.server.computation.metric.Metric;
import org.sonar.server.computation.metric.MetricRepositoryRule;
@@ -386,7 +386,7 @@ public class MeasureRepositoryRule extends ExternalResource implements MeasureRe
private final Map<Integer, Component> componentsByRef = new HashMap<>();

public TreeComponentProvider(Component root) {
new DepthTraversalTypeAwareCrawler(Component.Type.FILE, Visitor.Order.PRE_ORDER) {
new DepthTraversalTypeAwareCrawler(Component.Type.FILE, ComponentVisitor.Order.PRE_ORDER) {
@Override
public void visitAny(Component component) {
checkState(!componentsByRef.containsKey(component.getRef()), "Tree contains more than one component with ref " + component.getRef());

+ 2
- 2
server/sonar-server/src/test/java/org/sonar/server/computation/sqale/SqaleMeasuresVisitorTest.java View File

@@ -26,9 +26,9 @@ import org.junit.Rule;
import org.junit.Test;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.server.computation.batch.TreeRootHolderRule;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.DumbComponent;
import org.sonar.server.computation.component.FileAttributes;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.component.VisitorsCrawler;
import org.sonar.server.computation.measure.Measure;
import org.sonar.server.computation.measure.MeasureRepoEntry;
@@ -82,7 +82,7 @@ public class SqaleMeasuresVisitorTest {

private SqaleRatingSettings sqaleRatingSettings = mock(SqaleRatingSettings.class);

private VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<Visitor>asList(new SqaleMeasuresVisitor(metricRepository, measureRepository, sqaleRatingSettings)));
private VisitorsCrawler underTest = new VisitorsCrawler(Arrays.<ComponentVisitor>asList(new SqaleMeasuresVisitor(metricRepository, measureRepository, sqaleRatingSettings)));

@Before
public void setUp() {

+ 5
- 5
server/sonar-server/src/test/java/org/sonar/server/computation/step/ExecuteVisitorsStepTest.java View File

@@ -26,9 +26,9 @@ import org.junit.Rule;
import org.junit.Test;
import org.sonar.server.computation.batch.TreeRootHolderRule;
import org.sonar.server.computation.component.Component;
import org.sonar.server.computation.component.ComponentVisitor;
import org.sonar.server.computation.component.PathAwareVisitorAdapter;
import org.sonar.server.computation.component.TypeAwareVisitorAdapter;
import org.sonar.server.computation.component.Visitor;
import org.sonar.server.computation.measure.MeasureRepositoryRule;
import org.sonar.server.computation.metric.Metric;
import org.sonar.server.computation.metric.MetricImpl;
@@ -87,7 +87,7 @@ public class ExecuteVisitorsStepTest {

@Test
public void execute_with_type_aware_visitor() throws Exception {
when(visitors.instances()).thenReturn(Arrays.<Visitor>asList(new TestTypeAwareVisitor()));
when(visitors.instances()).thenReturn(Arrays.<ComponentVisitor>asList(new TestTypeAwareVisitor()));
ExecuteVisitorsStep underStep = new ExecuteVisitorsStep(treeRootHolder, visitors);

measureRepository.addRawMeasure(FILE_1_REF, NCLOC_KEY, newMeasureBuilder().create(1));
@@ -107,7 +107,7 @@ public class ExecuteVisitorsStepTest {

@Test
public void execute_with_path_aware_visitor() throws Exception {
when(visitors.instances()).thenReturn(Arrays.<Visitor>asList(new TestPathAwareVisitor()));
when(visitors.instances()).thenReturn(Arrays.<ComponentVisitor>asList(new TestPathAwareVisitor()));
ExecuteVisitorsStep underStep = new ExecuteVisitorsStep(treeRootHolder, visitors);

measureRepository.addRawMeasure(FILE_1_REF, NCLOC_KEY, newMeasureBuilder().create(1));
@@ -125,7 +125,7 @@ public class ExecuteVisitorsStepTest {
private class TestTypeAwareVisitor extends TypeAwareVisitorAdapter {

public TestTypeAwareVisitor() {
super(Component.Type.FILE, Visitor.Order.POST_ORDER);
super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER);
}

@Override
@@ -138,7 +138,7 @@ public class ExecuteVisitorsStepTest {
private class TestPathAwareVisitor extends PathAwareVisitorAdapter<Counter> {

public TestPathAwareVisitor() {
super(Component.Type.FILE, Visitor.Order.POST_ORDER, new SimpleStackElementFactory<Counter>() {
super(Component.Type.FILE, ComponentVisitor.Order.POST_ORDER, new SimpleStackElementFactory<Counter>() {
@Override
public Counter createForAny(Component component) {
return new Counter();

Loading…
Cancel
Save