Mirrors/sonarqube
1
0
Fork 0
mirror of https://github.com/SonarSource/sonarqube.git synced 2024-08-08 14:11:17 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix incomplete assertions

Browse Source
This commit is contained in:
Sébastien Lesaint 2015-08-18 12:55:06 +02:00
parent 332c8e3a40
commit e15532991b
9 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
server/sonar-process-monitor/src/test/java/org/sonar/process/monitor/MonitorTest.java
View File

@ -119,7 +119,7 @@ public class MonitorTest {
failed = e.getMessage().equals("Can not start multiple times"); failed = e.getMessage().equals("Can not start multiple times");
} }
monitor.stop(); monitor.stop();
assertThat(failed); assertThat(failed).isTrue();
} }
@Test @Test

2
server/sonar-server/src/test/java/org/sonar/server/db/BaseDaoTest.java
View File

@ -84,7 +84,7 @@ public class BaseDaoTest {
dao.insert(session, myDto); dao.insert(session, myDto);
session.commit(); session.commit();
assertThat(myDto.getId()); assertThat(myDto.getId()).isGreaterThan(0);
long t1 = System.currentTimeMillis() + 1000; long t1 = System.currentTimeMillis() + 1000;

2
server/sonar-server/src/test/java/org/sonar/server/es/EsUtilsTest.java
View File

@ -65,7 +65,7 @@ public class EsUtilsTest {
@Test @Test
public void util_class() { public void util_class() {
assertThat(TestUtils.hasOnlyPrivateConstructors(EsUtils.class)); assertThat(TestUtils.hasOnlyPrivateConstructors(EsUtils.class)).isTrue();
} }
@Test @Test

2
server/sonar-server/src/test/java/org/sonar/server/rule/CommonRuleKeysTest.java
View File

@ -33,7 +33,7 @@ public class CommonRuleKeysTest {
@Test @Test
public void wonderful_test_to_verify_that_this_class_is_an_helper_class() throws Exception { public void wonderful_test_to_verify_that_this_class_is_an_helper_class() throws Exception {
assertThat(TestUtils.hasOnlyPrivateConstructors(CommonRuleKeys.class)); assertThat(TestUtils.hasOnlyPrivateConstructors(CommonRuleKeys.class)).isTrue();
} }
} }

2
server/sonar-server/src/test/java/org/sonar/server/rule/RegisterRulesMediumTest.java
View File

@ -321,7 +321,7 @@ public class RegisterRulesMediumTest {
// Verify rule has not been updated // Verify rule has not been updated
Rule customRuleReloaded = ruleIndex.getByKey(RuleTesting.XOO_X1); Rule customRuleReloaded = ruleIndex.getByKey(RuleTesting.XOO_X1);
assertThat(DateUtils.isSameInstant(customRuleReloaded.updatedAt(), updatedAt)); assertThat(DateUtils.isSameInstant(customRuleReloaded.updatedAt(), updatedAt)).isTrue();
} }
@Test @Test

2
server/sonar-server/src/test/java/org/sonar/server/search/FacetsMediumTest.java
View File

@ -145,7 +145,7 @@ public class FacetsMediumTest {
assertThat(facets.getFacetKeys(FIELD_TAGS)).isEmpty(); assertThat(facets.getFacetKeys(FIELD_TAGS)).isEmpty();
assertThat(facets.getFacetKeys(FIELD_CREATED_AT)).hasSize(1); assertThat(facets.getFacetKeys(FIELD_CREATED_AT)).hasSize(1);
FacetValue value = facets.getFacetValues(FIELD_CREATED_AT).iterator().next(); FacetValue value = facets.getFacetValues(FIELD_CREATED_AT).iterator().next();
assertThat(DateUtils.parseDateTime(value.getKey()).before(new Date())); assertThat(DateUtils.parseDateTime(value.getKey()).before(new Date())).isTrue();
assertThat(value.getValue()).isEqualTo(3L); assertThat(value.getValue()).isEqualTo(3L);
} }

2
sonar-core/src/test/java/org/sonar/core/util/ProtobufTest.java
View File

@ -41,7 +41,7 @@ public class ProtobufTest {
@Test @Test
public void only_utils() { public void only_utils() {
assertThat(TestUtils.hasOnlyPrivateConstructors(Protobuf.class)); assertThat(TestUtils.hasOnlyPrivateConstructors(Protobuf.class)).isTrue();
} }
@Test @Test

4
sonar-db/src/test/java/org/sonar/db/purge/period/KeepOneFilterTest.java
View File

@ -62,7 +62,7 @@ public class KeepOneFilterTest {
List<Long> snapshotIds = snapshotIds(toDelete); List<Long> snapshotIds = snapshotIds(toDelete);
assertThat(snapshotIds).contains(3L); assertThat(snapshotIds).contains(3L);
assertThat(snapshotIds.contains(4L)); assertThat(snapshotIds).contains(4L);
} }
@Test @Test
@ -80,7 +80,7 @@ public class KeepOneFilterTest {
List<Long> snapshotIds = snapshotIds(toDelete); List<Long> snapshotIds = snapshotIds(toDelete);
assertThat(snapshotIds).contains(1L); assertThat(snapshotIds).contains(1L);
assertThat(snapshotIds.contains(4L)); assertThat(snapshotIds).contains(4L);
} }
@Test @Test

2
sonar-db/src/test/java/org/sonar/db/rule/RuleDaoTest.java
View File

@ -85,7 +85,7 @@ public class RuleDaoTest {
dbTester.prepareDbUnit(getClass(), "shared.xml"); dbTester.prepareDbUnit(getClass(), "shared.xml");
assertThat(underTest.selectByKeys(dbTester.getSession(), Collections.<RuleKey>emptyList())).isEmpty(); assertThat(underTest.selectByKeys(dbTester.getSession(), Collections.<RuleKey>emptyList())).isEmpty();
assertThat(underTest.selectByKeys(dbTester.getSession(), asList(RuleKey.of("NOT", "FOUND"))).isEmpty()); assertThat(underTest.selectByKeys(dbTester.getSession(), asList(RuleKey.of("NOT", "FOUND")))).isEmpty();
List<RuleDto> rules = underTest.selectByKeys(dbTester.getSession(), asList(RuleKey.of("java", "S001"), RuleKey.of("java", "OTHER"))); List<RuleDto> rules = underTest.selectByKeys(dbTester.getSession(), asList(RuleKey.of("java", "S001"), RuleKey.of("java", "OTHER")));
assertThat(rules).hasSize(1); assertThat(rules).hasSize(1);