SONAR-12043 SchedulerImpl correctly handle Thread interrupt

server/sonar-main/src/main/java/org/sonar/application/Scheduler.java

@@ -21,7 +21,7 @@ package org.sonar.application;
 
 public interface Scheduler {
 
-  void schedule();
+  void schedule() throws InterruptedException;
 
   /**
    * Stops all processes and waits for them to be down.

server/sonar-main/src/main/java/org/sonar/application/SchedulerImpl.java

@@ -32,7 +32,6 @@ import org.sonar.application.command.AbstractCommand;
 import org.sonar.application.command.CommandFactory;
 import org.sonar.application.config.AppSettings;
 import org.sonar.application.config.ClusterSettings;
-import org.sonar.application.process.ManagedProcess;
 import org.sonar.application.process.ManagedProcessEventListener;
 import org.sonar.application.process.ManagedProcessHandler;
 import org.sonar.application.process.ManagedProcessLifecycle;
@@ -77,7 +76,7 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
   }
 
   @Override
-  public void schedule() {
+  public void schedule() throws InterruptedException {
     if (!nodeLifecycle.tryToMoveTo(NodeLifecycle.State.STARTING)) {
       return;
     }
@@ -98,20 +97,20 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
     tryToStartAll();
   }
 
-  private void tryToStartAll() {
+  private void tryToStartAll() throws InterruptedException {
     tryToStartEs();
     tryToStartWeb();
     tryToStartCe();
   }
 
-  private void tryToStartEs() {
+  private void tryToStartEs() throws InterruptedException {
     ManagedProcessHandler process = processesById.get(ProcessId.ELASTICSEARCH);
     if (process != null) {
       tryToStartProcess(process, commandFactory::createEsCommand);
     }
   }
 
-  private void tryToStartWeb() {
+  private void tryToStartWeb() throws InterruptedException {
     ManagedProcessHandler process = processesById.get(ProcessId.WEB_SERVER);
     if (process == null) {
       return;
@@ -136,7 +135,7 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
     }
   }
 
-  private void tryToStartCe() {
+  private void tryToStartCe() throws InterruptedException {
     ManagedProcessHandler process = processesById.get(ProcessId.COMPUTE_ENGINE);
     if (process != null && appState.isOperational(ProcessId.WEB_SERVER, true) && isEsClientStartable()) {
       tryToStartProcess(process, commandFactory::createCeCommand);
@@ -148,16 +147,17 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
     return appState.isOperational(ProcessId.ELASTICSEARCH, requireLocalEs);
   }
 
-  private void tryToStartProcess(ManagedProcessHandler process, Supplier<AbstractCommand> commandSupplier) {
-    tryToStart(process, () -> {
+  private void tryToStartProcess(ManagedProcessHandler processHandler, Supplier<AbstractCommand> commandSupplier) throws InterruptedException {
+    // starter or restarter thread was interrupted, we should not proceed with starting the process
+    if (Thread.currentThread().isInterrupted()) {
+      throw new InterruptedException();
+    }
+
+    try {
+      processHandler.start(() -> {
       AbstractCommand command = commandSupplier.get();
       return processLauncher.launch(command);
     });
-  }
-
-  private void tryToStart(ManagedProcessHandler process, Supplier<ManagedProcess> processMonitorSupplier) {
-    try {
-      process.start(processMonitorSupplier);
     } catch (RuntimeException e) {
       // failed to start command -> stop everything
       hardStop();
@@ -165,7 +165,7 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
     }
   }
 
-  private void hardStopAll() {
+  private void hardStopAll() throws InterruptedException {
     // order is important for non-cluster mode
     hardStopProcess(ProcessId.COMPUTE_ENGINE);
     hardStopProcess(ProcessId.WEB_SERVER);
@@ -175,8 +175,10 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
   /**
    * Request for quick stop then blocks until process is stopped.
    * Returns immediately if the process is disabled in configuration.
+   *
+   * @throws InterruptedException if {@link ManagedProcessHandler#hardStop()} throws a {@link InterruptedException}
    */
-  private void hardStopProcess(ProcessId processId) {
+  private void hardStopProcess(ProcessId processId) throws InterruptedException {
     ManagedProcessHandler process = processesById.get(processId);
     if (process != null) {
       process.hardStop();
@@ -191,12 +193,19 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
     if (nodeLifecycle.tryToMoveTo(NodeLifecycle.State.STOPPING)) {
       LOG.info("Stopping SonarQube");
     }
-    hardStopAll();
-    if (hardStopperThread != null && Thread.currentThread() != hardStopperThread) {
-      hardStopperThread.interrupt();
-    }
-    if (restarterThread != null && Thread.currentThread() != restarterThread) {
-      restarterThread.interrupt();
+    try {
+      hardStopAll();
+      if (hardStopperThread != null && Thread.currentThread() != hardStopperThread) {
+        hardStopperThread.interrupt();
+      }
+      if (restarterThread != null && Thread.currentThread() != restarterThread) {
+        restarterThread.interrupt();
+      }
+    } catch (InterruptedException e) {
+      // ignore and assume SQ stop is handled by another thread
+      LOG.debug("Stopping all processes was interrupted in the middle of a hard stop" +
+        " (current thread name is \"{}\")", Thread.currentThread().getName());
+      Thread.currentThread().interrupt();
     }
     awaitTermination.countDown();
   }
@@ -231,7 +240,14 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
   @Override
   public void onAppStateOperational(ProcessId processId) {
     if (nodeLifecycle.getState() == NodeLifecycle.State.STARTING) {
-      tryToStartAll();
+      try {
+        tryToStartAll();
+      } catch (InterruptedException e) {
+        // startup process was interrupted, let's assume it means shutdown was requested
+        LOG.debug("Startup process was interrupted on notification that process [{}] was operation", processId.getKey(), e);
+        hardStopAsync();
+        Thread.currentThread().interrupt();
+      }
     }
   }
 
@@ -293,6 +309,10 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
       try {
         appReloader.reload(settings);
         schedule();
+      } catch (InterruptedException e) {
+        // restart was interrupted, most likely by a stop thread, restart must be aborted
+        LOG.debug("{} thread was interrupted", getName(), e);
+        super.interrupt();
       } catch (Exception e) {
         LOG.error("Fail to restart", e);
         hardStop();
@@ -307,7 +327,12 @@ public class SchedulerImpl implements Scheduler, ManagedProcessEventListener, Pr
 
     @Override
     public void run() {
-      hardStopAll();
+      try {
+        hardStopAll();
+      } catch (InterruptedException e) {
+        LOG.debug("{} thread was interrupted", getName(), e);
+        interrupt();
+      }
     }
   }
 }

server/sonar-main/src/main/java/org/sonar/application/process/ManagedProcessHandler.java

@@ -98,7 +98,7 @@ public class ManagedProcessHandler {
    * Sends kill signal and awaits termination. No guarantee that process is gracefully terminated (=shutdown hooks
    * executed). It depends on OS.
    */
-  public void hardStop() {
+  public void hardStop() throws InterruptedException {
     if (lifecycle.tryToMoveTo(ManagedProcessLifecycle.State.HARD_STOPPING)) {
       hardStopImpl();
       if (process != null && process.isAlive()) {
@@ -123,7 +123,7 @@ public class ManagedProcessHandler {
     }
   }
 
-  private void hardStopImpl() {
+  private void hardStopImpl() throws InterruptedException {
     if (process == null) {
       return;
     }
@@ -132,8 +132,10 @@ public class ManagedProcessHandler {
       process.waitFor(hardStopTimeout.getDuration(), hardStopTimeout.getUnit());
     } catch (InterruptedException e) {
       // can't wait for the termination of process. Let's assume it's down.
-      LOG.warn("Interrupted while hard stopping process {}", processId, e);
+      String errorMessage = format("Interrupted while hard stopping process %s", processId);
+      LOG.warn(errorMessage, e);
       Thread.currentThread().interrupt();
+      throw new InterruptedException(errorMessage);
     } catch (Throwable e) {
       LOG.error("Failed while asking for hard stop of process {}", processId, e);
     }

server/sonar-main/src/test/java/org/sonar/application/process/ManagedProcessHandlerTest.java

@@ -191,7 +191,13 @@ public class ManagedProcessHandlerTest {
     try (TestManagedProcess testProcess = new TestManagedProcess()) {
       underTest.start(() -> testProcess);
 
-      Thread stopperThread = new Thread(underTest::hardStop);
+      Thread stopperThread = new Thread(() -> {
+        try {
+          underTest.hardStop();
+        } catch (InterruptedException e) {
+          throw new RuntimeException(e);
+        }
+      });
       stopperThread.start();
 
       // thread is blocked until process stopped

sonar-application/src/main/java/org/sonar/application/App.java

@@ -46,7 +46,7 @@ public class App {
     this.javaVersion = javaVersion;
   }
 
-  public void start(String[] cliArguments) throws IOException {
+  public void start(String[] cliArguments) throws IOException, InterruptedException {
     AppSettingsLoader settingsLoader = new AppSettingsLoaderImpl(cliArguments, new ServiceLoaderWrapper());
     AppSettings settings = settingsLoader.load();
     // order is important - logging must be configured before any other components (AppFileSystem, ...)
@@ -91,7 +91,7 @@ public class App {
     }
   }
 
-  public static void main(String... args) throws IOException {
+  public static void main(String... args) throws Exception {
     new App(JavaVersion.INSTANCE).start(args);
   }