@@ -36,8 +36,8 @@ import org.sonar.server.exceptions.NotFoundException; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static java.lang.String.format; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class ComponentFinder { | |||
private static final String MSG_COMPONENT_ID_OR_KEY_TEMPLATE = "Either '%s' or '%s' must be provided"; |
@@ -42,7 +42,7 @@ import static java.util.Collections.singleton; | |||
import static java.util.Collections.singletonList; | |||
import static org.sonar.core.component.ComponentKeys.isValidProjectKey; | |||
import static org.sonar.db.component.ComponentKeyUpdaterDao.checkIsProjectOrModule; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
@ServerSide | |||
public class ComponentService { |
@@ -42,7 +42,7 @@ import org.sonar.server.permission.PermissionTemplateService; | |||
import static java.util.Collections.singletonList; | |||
import static org.sonar.api.resources.Qualifiers.PROJECT; | |||
import static org.sonar.core.component.ComponentKeys.isValidProjectKey; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class ComponentUpdater { | |||
@@ -34,7 +34,7 @@ import org.sonar.server.user.UserSession; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static com.google.common.base.Strings.isNullOrEmpty; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
@ServerSide | |||
public class AssignAction extends Action { |
@@ -22,7 +22,7 @@ package org.sonar.server.permission; | |||
import java.util.List; | |||
import static org.apache.commons.lang.StringUtils.isNotBlank; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class ApplyPermissionTemplateQuery { | |||
@@ -30,7 +30,7 @@ import static org.sonar.core.permission.GlobalPermissions.SYSTEM_ADMIN; | |||
import static org.sonar.server.permission.PermissionChange.Operation.ADD; | |||
import static org.sonar.server.permission.PermissionChange.Operation.REMOVE; | |||
import static org.sonar.server.permission.RequestValidator.validateNotAnyoneAndAdminPermission; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class GroupPermissionChanger { | |||
@@ -26,7 +26,7 @@ import org.sonar.db.permission.OrganizationPermission; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.core.util.stream.MoreCollectors.toList; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public abstract class PermissionChange { | |||
@@ -29,11 +29,10 @@ import org.sonar.api.resources.ResourceType; | |||
import org.sonar.api.resources.ResourceTypes; | |||
import org.sonar.core.permission.GlobalPermissions; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.ws.WsUtils; | |||
import static com.google.common.base.Strings.isNullOrEmpty; | |||
import static java.lang.String.format; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_KEY_PATTERN; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_QUALIFIER; | |||
@@ -49,7 +48,7 @@ public class RequestValidator { | |||
} | |||
public String validateProjectPermission(String permission) { | |||
WsUtils.checkRequest(permissionService.getAllProjectPermissions().contains(permission), | |||
BadRequestException.checkRequest(permissionService.getAllProjectPermissions().contains(permission), | |||
String.format("The '%s' parameter for project permissions must be one of %s. '%s' was passed.", PARAM_PERMISSION, | |||
allProjectsPermissionsOnOneLine, permission)); | |||
return permission; |
@@ -29,7 +29,7 @@ import static org.sonar.api.web.UserRole.PUBLIC_PERMISSIONS; | |||
import static org.sonar.core.permission.GlobalPermissions.SYSTEM_ADMIN; | |||
import static org.sonar.server.permission.PermissionChange.Operation.ADD; | |||
import static org.sonar.server.permission.PermissionChange.Operation.REMOVE; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Adds and removes user permissions. Both global and project scopes are supported. |
@@ -45,7 +45,7 @@ import static org.apache.commons.io.FileUtils.forceMkdir; | |||
import static org.apache.commons.io.FileUtils.toFile; | |||
import static org.apache.commons.lang.StringUtils.substringAfterLast; | |||
import static org.sonar.core.util.FileUtils.deleteQuietly; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Downloads plugins from update center. Files are copied in the directory extensions/downloads and then |
@@ -56,7 +56,7 @@ import static org.sonar.server.measure.Rating.E; | |||
import static org.sonar.server.qualitygate.Condition.Operator.GREATER_THAN; | |||
import static org.sonar.server.qualitygate.Condition.Operator.LESS_THAN; | |||
import static org.sonar.server.qualitygate.ValidRatingMetrics.isCoreRatingMetric; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class QualityGateConditionsUpdater { | |||
@@ -56,7 +56,7 @@ import org.sonar.db.rule.RuleDefinitionDto; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
@ServerSide | |||
public class QProfileExporters { |
@@ -39,7 +39,7 @@ import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.qualityprofile.index.ActiveRuleIndexer; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class QProfileFactoryImpl implements QProfileFactory { | |||
@@ -33,7 +33,7 @@ import org.sonar.db.qualityprofile.QProfileDto; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.qualityprofile.index.ActiveRuleIndexer; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class QProfileTreeImpl implements QProfileTree { | |||
@@ -42,7 +42,7 @@ import static java.util.Objects.requireNonNull; | |||
import static org.sonar.core.util.stream.MoreCollectors.index; | |||
import static org.sonar.core.util.stream.MoreCollectors.toArrayList; | |||
import static org.sonar.core.util.stream.MoreCollectors.uniqueIndex; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Cache of the data required to activate/deactivate |
@@ -52,7 +52,7 @@ import org.sonar.server.user.UserSession; | |||
import org.sonar.server.util.TypeValidations; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Activation and deactivation of rules in Quality profiles |
@@ -49,7 +49,7 @@ import org.sonar.server.util.TypeValidations; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static com.google.common.collect.Lists.newArrayList; | |||
import static java.lang.String.format; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
@ServerSide | |||
public class RuleCreator { |
@@ -58,7 +58,7 @@ import static org.sonar.api.CoreProperties.DEFAULT_ISSUE_ASSIGNEE; | |||
import static org.sonar.core.util.Slug.slugify; | |||
import static org.sonar.core.util.stream.MoreCollectors.toList; | |||
import static org.sonar.process.ProcessProperties.Property.ONBOARDING_TUTORIAL_SHOW_TO_NEW_USERS; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
@ServerSide | |||
public class UserUpdater { |
@@ -24,7 +24,7 @@ import javax.annotation.Nullable; | |||
import org.apache.commons.lang.StringUtils; | |||
import org.sonar.api.PropertyType; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class BooleanTypeValidation implements TypeValidation { | |||
@@ -24,7 +24,7 @@ import javax.annotation.Nullable; | |||
import org.apache.commons.lang.StringUtils; | |||
import org.sonar.api.PropertyType; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class StringListTypeValidation implements TypeValidation { | |||
@@ -26,7 +26,7 @@ import javax.annotation.Nonnull; | |||
import javax.annotation.Nullable; | |||
import org.sonar.api.server.ServerSide; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
@ServerSide | |||
public class TypeValidations { |
@@ -41,7 +41,7 @@ import org.sonar.server.user.UserSession; | |||
import static com.google.common.collect.Maps.newHashMap; | |||
import static org.sonar.process.ProcessProperties.Property.SONARCLOUD_ENABLED; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
@ServerSide | |||
public class ProjectDataLoader { |
@@ -40,7 +40,7 @@ import static org.sonar.server.branch.ws.ProjectBranchesParameters.ACTION_DELETE | |||
import static org.sonar.server.branch.ws.ProjectBranchesParameters.PARAM_BRANCH; | |||
import static org.sonar.server.branch.ws.ProjectBranchesParameters.PARAM_PROJECT; | |||
import static org.sonar.server.project.Project.from; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class DeleteAction implements BranchWsAction { | |||
private final DbClient dbClient; |
@@ -67,8 +67,8 @@ import static org.sonar.server.ce.ws.CeWsParameters.PARAM_MIN_SUBMITTED_AT; | |||
import static org.sonar.server.ce.ws.CeWsParameters.PARAM_ONLY_CURRENTS; | |||
import static org.sonar.server.ce.ws.CeWsParameters.PARAM_STATUS; | |||
import static org.sonar.server.ce.ws.CeWsParameters.PARAM_TYPE; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class ActivityAction implements CeWsAction { |
@@ -44,7 +44,7 @@ import static org.sonar.server.ce.ws.CeWsParameters.PARAM_COMPONENT; | |||
import static org.sonar.server.ce.ws.CeWsParameters.PARAM_PULL_REQUEST; | |||
import static org.sonar.server.ws.KeyExamples.KEY_BRANCH_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PULL_REQUEST_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class AnalysisStatusAction implements CeWsAction { |
@@ -38,7 +38,7 @@ import static org.apache.commons.lang.StringUtils.abbreviate; | |||
import static org.apache.commons.lang.StringUtils.defaultIfBlank; | |||
import static org.sonar.core.component.ComponentKeys.MAX_COMPONENT_KEY_LENGTH; | |||
import static org.sonar.db.component.ComponentValidator.MAX_COMPONENT_NAME_LENGTH; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class SubmitAction implements CeWsAction { | |||
@@ -42,8 +42,8 @@ import org.sonar.db.ce.CeQueueDto; | |||
import org.sonar.db.ce.CeTaskMessageDto; | |||
import org.sonar.db.component.ComponentDto; | |||
import org.sonar.db.permission.OrganizationPermission; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import org.sonar.server.user.UserSession; | |||
import org.sonar.server.ws.WsUtils; | |||
import org.sonarqube.ws.Ce; | |||
import static org.sonar.server.user.AbstractUserSession.insufficientPrivilegesException; | |||
@@ -100,7 +100,7 @@ public class TaskAction implements CeWsAction { | |||
checkPermission(component); | |||
wsTaskResponse.setTask(wsTaskFormatter.formatQueue(dbSession, queueDto.get())); | |||
} else { | |||
CeActivityDto ceActivityDto = WsUtils.checkFoundWithOptional(dbClient.ceActivityDao().selectByUuid(dbSession, taskUuid), "No activity found for task '%s'", taskUuid); | |||
CeActivityDto ceActivityDto = NotFoundException.checkFoundWithOptional(dbClient.ceActivityDao().selectByUuid(dbSession, taskUuid), "No activity found for task '%s'", taskUuid); | |||
Optional<ComponentDto> component = loadComponent(dbSession, ceActivityDto.getComponentUuid()); | |||
checkPermission(component); | |||
Set<AdditionalField> additionalFields = AdditionalField.getFromRequest(wsRequest); |
@@ -43,8 +43,8 @@ import org.sonar.server.component.index.ComponentIndex; | |||
import org.sonar.server.component.index.ComponentQuery; | |||
import org.sonar.server.es.SearchIdResult; | |||
import org.sonar.server.es.SearchOptions; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import org.sonar.server.organization.DefaultOrganizationProvider; | |||
import org.sonar.server.ws.WsUtils; | |||
import org.sonarqube.ws.Components; | |||
import org.sonarqube.ws.Components.SearchWsResponse; | |||
@@ -164,7 +164,7 @@ public class SearchAction implements ComponentsWsAction { | |||
private OrganizationDto getOrganization(DbSession dbSession, SearchRequest request) { | |||
String organizationKey = Optional.ofNullable(request.getOrganization()) | |||
.orElseGet(defaultOrganizationProvider.get()::getKey); | |||
return WsUtils.checkFoundWithOptional( | |||
return NotFoundException.checkFoundWithOptional( | |||
dbClient.organizationDao().selectByKey(dbSession, organizationKey), | |||
"No organizationDto with key '%s'", organizationKey); | |||
} |
@@ -83,13 +83,12 @@ import static org.sonar.server.component.ws.ProjectMeasuresQueryValidator.NON_ME | |||
import static org.sonar.server.measure.index.ProjectMeasuresIndex.SUPPORTED_FACETS; | |||
import static org.sonar.server.measure.index.ProjectMeasuresQuery.SORT_BY_LAST_ANALYSIS_DATE; | |||
import static org.sonar.server.measure.index.ProjectMeasuresQuery.SORT_BY_NAME; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.ACTION_SEARCH_PROJECTS; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_FILTER; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_ORGANIZATION; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_QUALIFIERS; | |||
import static org.sonarqube.ws.client.project.ProjectsWsParameters.FILTER_LANGUAGES; | |||
import static org.sonarqube.ws.client.project.ProjectsWsParameters.FILTER_TAGS; | |||
@@ -46,7 +46,7 @@ import static com.google.common.base.Preconditions.checkArgument; | |||
import static com.google.common.base.Strings.emptyToNull; | |||
import static java.lang.String.format; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonarqube.ws.client.issue.IssuesWsParameters.ACTION_ASSIGN; | |||
import static org.sonarqube.ws.client.issue.IssuesWsParameters.PARAM_ASSIGNEE; | |||
import static org.sonarqube.ws.client.issue.IssuesWsParameters.PARAM_ISSUE; |
@@ -47,7 +47,7 @@ import static java.util.Optional.ofNullable; | |||
import static org.sonar.api.server.ws.WebService.Param.PAGE_SIZE; | |||
import static org.sonar.api.server.ws.WebService.Param.TEXT_QUERY; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class AuthorsAction implements IssuesWsAction { |
@@ -44,7 +44,7 @@ import static com.google.common.base.Preconditions.checkArgument; | |||
import static org.sonar.api.server.ws.WebService.Param.PAGE_SIZE; | |||
import static org.sonar.api.server.ws.WebService.Param.TEXT_QUERY; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
/** |
@@ -41,7 +41,7 @@ import static org.sonar.server.component.ComponentFinder.ParamNames.PROJECT_ID_A | |||
import static org.sonar.server.measure.custom.ws.CustomMeasureValidator.checkPermissions; | |||
import static org.sonar.server.measure.custom.ws.CustomMeasureValueDescription.measureValueDescription; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class CreateAction implements CustomMeasuresWsAction { | |||
public static final String ACTION = "create"; |
@@ -81,7 +81,7 @@ import static org.sonar.server.measure.ws.SnapshotDtoToWsPeriod.snapshotToWsPeri | |||
import static org.sonar.server.ws.KeyExamples.KEY_BRANCH_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PULL_REQUEST_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class ComponentAction implements MeasuresWsAction { |
@@ -113,7 +113,7 @@ import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PULL_REQUEST_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsParameterBuilder.createQualifiersParameter; | |||
import static org.sonar.server.ws.WsParameterBuilder.QualifierParameterContext.newQualifierParameterContext; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
/** |
@@ -53,7 +53,7 @@ import static org.sonar.server.measure.ws.MeasureDtoToWsMeasure.updateMeasureBui | |||
import static org.sonar.server.measure.ws.MeasuresWsParametersBuilder.createMetricKeysParameter; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_002; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonar.server.component.ws.MeasuresWsParameters.PARAM_METRIC_KEYS; | |||
import static org.sonar.server.component.ws.MeasuresWsParameters.PARAM_PROJECT_KEYS; |
@@ -38,7 +38,7 @@ import static org.sonar.db.metric.MetricValidator.MAX_DOMAIN_LENGTH; | |||
import static org.sonar.db.metric.MetricValidator.MAX_KEY_LENGTH; | |||
import static org.sonar.db.metric.MetricValidator.MAX_NAME_LENGTH; | |||
import static org.sonar.server.util.MetricKeyValidator.checkMetricKeyFormat; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class CreateAction implements MetricsWsAction { | |||
private static final String ACTION = "create"; |
@@ -37,7 +37,7 @@ import static org.sonar.db.metric.MetricValidator.MAX_DESCRIPTION_LENGTH; | |||
import static org.sonar.db.metric.MetricValidator.MAX_DOMAIN_LENGTH; | |||
import static org.sonar.db.metric.MetricValidator.MAX_KEY_LENGTH; | |||
import static org.sonar.db.metric.MetricValidator.MAX_NAME_LENGTH; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class UpdateAction implements MetricsWsAction { | |||
private static final String ACTION = "update"; |
@@ -45,8 +45,8 @@ import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_C | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_LOGIN; | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_PROJECT; | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_TYPE; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class AddAction implements NotificationsWsAction { | |||
private final NotificationCenter notificationCenter; |
@@ -54,7 +54,7 @@ import static java.util.Optional.ofNullable; | |||
import static org.sonar.core.util.stream.MoreCollectors.toOneElement; | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.ACTION_LIST; | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_LOGIN; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class ListAction implements NotificationsWsAction { |
@@ -45,8 +45,8 @@ import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_C | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_LOGIN; | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_PROJECT; | |||
import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_TYPE; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class RemoveAction implements NotificationsWsAction { | |||
private final NotificationCenter notificationCenter; |
@@ -41,8 +41,8 @@ import static org.sonar.db.user.GroupMembershipQuery.IN; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_LOGIN; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_ORGANIZATION; | |||
import static org.sonar.server.ws.KeyExamples.KEY_ORG_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class AddMemberAction implements OrganizationsWsAction { |
@@ -35,7 +35,7 @@ import static org.sonar.db.permission.OrganizationPermission.ADMINISTER; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_KEY; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_ORGANIZATION; | |||
import static org.sonar.server.ws.KeyExamples.KEY_ORG_EXAMPLE_002; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class DeleteAction implements OrganizationsWsAction { | |||
private static final String ACTION = "delete"; |
@@ -34,8 +34,8 @@ import static org.sonar.db.permission.OrganizationPermission.ADMINISTER; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_LOGIN; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_ORGANIZATION; | |||
import static org.sonar.server.ws.KeyExamples.KEY_ORG_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class RemoveMemberAction implements OrganizationsWsAction { | |||
private final DbClient dbClient; |
@@ -54,7 +54,7 @@ import static org.sonar.api.server.ws.WebService.SelectionMode.SELECTED; | |||
import static org.sonar.db.permission.OrganizationPermission.ADMINISTER; | |||
import static org.sonar.server.es.SearchOptions.MAX_LIMIT; | |||
import static org.sonar.server.organization.ws.OrganizationsWsSupport.PARAM_ORGANIZATION; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class SearchMembersAction implements OrganizationsWsAction { |
@@ -38,7 +38,7 @@ import org.sonar.server.usergroups.ws.GroupWsSupport; | |||
import org.sonarqube.ws.client.permission.PermissionsWsParameters; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_GROUP_ID; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_GROUP_NAME; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_ORGANIZATION; |
@@ -23,7 +23,7 @@ import com.google.common.base.Optional; | |||
import javax.annotation.CheckForNull; | |||
import javax.annotation.Nullable; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Reference to a project <b>as defined by web service callers</b>. It allows to reference a project |
@@ -38,7 +38,7 @@ import static org.sonar.server.permission.ws.WsParameters.createGroupIdParameter | |||
import static org.sonar.server.permission.ws.WsParameters.createGroupNameParameter; | |||
import static org.sonar.server.permission.ws.WsParameters.createTemplateParameters; | |||
import static org.sonar.server.permission.ws.template.WsTemplateRef.fromRequest; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION; | |||
public class AddGroupToTemplateAction implements PermissionsWsAction { |
@@ -44,7 +44,7 @@ import static java.util.Objects.requireNonNull; | |||
import static org.sonar.server.permission.PermissionPrivilegeChecker.checkGlobalAdmin; | |||
import static org.sonar.server.permission.RequestValidator.MSG_TEMPLATE_WITH_SAME_NAME; | |||
import static org.sonar.server.permission.ws.template.PermissionTemplateDtoToPermissionTemplateResponse.toPermissionTemplateResponse; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_DESCRIPTION; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_NAME; |
@@ -37,8 +37,8 @@ import org.sonar.server.user.UserSession; | |||
import static org.sonar.server.permission.PermissionPrivilegeChecker.checkGlobalAdmin; | |||
import static org.sonar.server.permission.ws.template.WsTemplateRef.newTemplateRef; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_ORGANIZATION; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_ID; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_NAME; |
@@ -56,7 +56,7 @@ import static java.util.Optional.ofNullable; | |||
import static org.sonar.api.utils.DateUtils.formatDateTime; | |||
import static org.sonar.server.permission.PermissionPrivilegeChecker.checkGlobalAdmin; | |||
import static org.sonar.server.permission.ws.template.SearchTemplatesData.builder; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_ORGANIZATION; | |||
@@ -42,7 +42,7 @@ import static org.sonar.server.permission.PermissionPrivilegeChecker.checkGlobal | |||
import static org.sonar.server.permission.ws.template.WsTemplateRef.newTemplateRef; | |||
import static org.sonar.server.ws.WsParameterBuilder.createDefaultTemplateQualifierParameter; | |||
import static org.sonar.server.ws.WsParameterBuilder.QualifierParameterContext.newQualifierParameterContext; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_ORGANIZATION; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_QUALIFIER; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_ID; |
@@ -29,12 +29,12 @@ import org.sonar.api.utils.System2; | |||
import org.sonar.db.DbClient; | |||
import org.sonar.db.DbSession; | |||
import org.sonar.db.permission.template.PermissionTemplateDto; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.permission.ws.PermissionWsSupport; | |||
import org.sonar.server.permission.ws.PermissionsWsAction; | |||
import org.sonar.server.permission.RequestValidator; | |||
import org.sonar.server.permission.ws.WsParameters; | |||
import org.sonar.server.user.UserSession; | |||
import org.sonar.server.ws.WsUtils; | |||
import org.sonarqube.ws.Permissions.PermissionTemplate; | |||
import org.sonarqube.ws.Permissions.UpdateTemplateWsResponse; | |||
@@ -45,7 +45,7 @@ import static org.apache.commons.lang.StringUtils.isBlank; | |||
import static org.sonar.server.permission.PermissionPrivilegeChecker.checkGlobalAdmin; | |||
import static org.sonar.server.permission.RequestValidator.MSG_TEMPLATE_WITH_SAME_NAME; | |||
import static org.sonar.server.permission.ws.template.PermissionTemplateDtoToPermissionTemplateResponse.toPermissionTemplateResponse; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_DESCRIPTION; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_ID; | |||
@@ -143,7 +143,7 @@ public class UpdateTemplateAction implements PermissionsWsAction { | |||
} | |||
private void validateTemplateNameForUpdate(DbSession dbSession, String organizationUuid, String name, long id) { | |||
WsUtils.checkRequest(!isBlank(name), "The template name must not be blank"); | |||
BadRequestException.checkRequest(!isBlank(name), "The template name must not be blank"); | |||
PermissionTemplateDto permissionTemplateWithSameName = dbClient.permissionTemplateDao().selectByName(dbSession, organizationUuid, name); | |||
checkRequest(permissionTemplateWithSameName == null || permissionTemplateWithSameName.getId() == id, |
@@ -23,7 +23,7 @@ import javax.annotation.CheckForNull; | |||
import javax.annotation.Nullable; | |||
import org.sonar.api.server.ws.Request; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_ORGANIZATION; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_ID; | |||
import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_NAME; |
@@ -37,7 +37,7 @@ import org.sonarqube.ws.Projects.BulkUpdateKeyWsResponse; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static org.sonar.db.component.ComponentKeyUpdaterDao.checkIsProjectOrModule; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.project.ProjectsWsParameters.ACTION_BULK_UPDATE_KEY; | |||
import static org.sonarqube.ws.client.project.ProjectsWsParameters.PARAM_DRY_RUN; |
@@ -29,7 +29,7 @@ import org.sonar.server.organization.BillingValidations; | |||
import org.sonar.server.organization.BillingValidationsProxy; | |||
import org.sonar.server.organization.DefaultOrganizationProvider; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
@ServerSide | |||
public class ProjectsWsSupport { |
@@ -32,7 +32,7 @@ import org.sonar.server.project.Visibility; | |||
import org.sonar.server.user.UserSession; | |||
import static org.sonar.server.user.AbstractUserSession.insufficientPrivilegesException; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class UpdateDefaultVisibilityAction implements ProjectsWsAction { | |||
static final String ACTION = "update_default_visibility"; |
@@ -45,7 +45,7 @@ import static java.lang.String.format; | |||
import static java.util.Collections.singletonList; | |||
import static org.sonar.api.web.UserRole.PUBLIC_PERMISSIONS; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.project.ProjectsWsParameters.PARAM_PROJECT; | |||
import static org.sonarqube.ws.client.project.ProjectsWsParameters.PARAM_VISIBILITY; | |||
@@ -26,8 +26,9 @@ import org.sonar.api.web.UserRole; | |||
import org.sonar.db.DbClient; | |||
import org.sonar.db.DbSession; | |||
import org.sonar.db.component.ProjectLinkDto; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import org.sonar.server.user.UserSession; | |||
import org.sonar.server.ws.WsUtils; | |||
import static org.sonar.db.component.ProjectLinkDto.PROVIDED_TYPES; | |||
import static org.sonar.server.projectlink.ws.ProjectLinksWsParameters.ACTION_DELETE; | |||
@@ -68,7 +69,7 @@ public class DeleteAction implements ProjectLinksWsAction { | |||
try (DbSession dbSession = dbClient.openSession(false)) { | |||
ProjectLinkDto link = dbClient.projectLinkDao().selectByUuid(dbSession, id); | |||
link = WsUtils.checkFound(link, "Link with id '%s' not found", id); | |||
link = NotFoundException.checkFound(link, "Link with id '%s' not found", id); | |||
checkProjectAdminPermission(link); | |||
checkNotProvided(link); | |||
@@ -80,7 +81,7 @@ public class DeleteAction implements ProjectLinksWsAction { | |||
private static void checkNotProvided(ProjectLinkDto link) { | |||
String type = link.getType(); | |||
boolean isProvided = type != null && PROVIDED_TYPES.contains(type); | |||
WsUtils.checkRequest(!isProvided, "Provided link cannot be deleted."); | |||
BadRequestException.checkRequest(!isProvided, "Provided link cannot be deleted."); | |||
} | |||
private void checkProjectAdminPermission(ProjectLinkDto link) { |
@@ -25,7 +25,7 @@ import org.sonar.api.server.ws.WebService; | |||
import org.sonar.db.component.ComponentDto; | |||
import static java.lang.String.format; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class ProjectLinksWs implements WebService { | |||
@@ -38,7 +38,7 @@ import static java.util.Collections.singletonList; | |||
import static org.sonar.api.resources.Qualifiers.PROJECT; | |||
import static org.sonar.server.es.ProjectIndexer.Cause.PROJECT_TAGS_UPDATE; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class SetAction implements ProjectTagsWsAction { | |||
/** |
@@ -51,8 +51,8 @@ import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_PRO | |||
import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_PROJECT_KEY; | |||
import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_PULL_REQUEST; | |||
import static org.sonar.server.user.AbstractUserSession.insufficientPrivilegesException; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class ProjectStatusAction implements QualityGatesWsAction { |
@@ -43,8 +43,8 @@ import static org.sonar.db.organization.OrganizationDto.Subscription.PAID; | |||
import static org.sonar.db.permission.OrganizationPermission.ADMINISTER_QUALITY_GATES; | |||
import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_ORGANIZATION; | |||
import static org.sonar.server.user.AbstractUserSession.insufficientPrivilegesException; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class QualityGatesWsSupport { | |||
@@ -46,7 +46,7 @@ import static org.sonar.core.util.stream.MoreCollectors.toSet; | |||
import static org.sonar.core.util.stream.MoreCollectors.uniqueIndex; | |||
import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_ID; | |||
import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_NAME; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class ShowAction implements QualityGatesWsAction { |
@@ -49,8 +49,8 @@ import org.sonarqube.ws.MediaTypes; | |||
import static java.nio.charset.StandardCharsets.UTF_8; | |||
import static org.sonar.core.util.Uuids.UUID_EXAMPLE_01; | |||
import static org.sonar.server.qualityprofile.ws.QProfileWsSupport.createOrganizationParam; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_ORGANIZATION; | |||
import static org.sonarqube.ws.client.qualityprofile.QualityProfileWsParameters.PARAM_KEY; | |||
import static org.sonarqube.ws.client.qualityprofile.QualityProfileWsParameters.PARAM_LANGUAGE; |
@@ -41,9 +41,9 @@ import static com.google.common.base.Preconditions.checkState; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.db.organization.OrganizationDto.Subscription.PAID; | |||
import static org.sonar.server.user.AbstractUserSession.insufficientPrivilegesException; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_ORGANIZATION; | |||
@ServerSide |
@@ -34,7 +34,7 @@ import static java.lang.String.format; | |||
import static java.util.Optional.ofNullable; | |||
import static org.sonar.core.util.Uuids.UUID_EXAMPLE_01; | |||
import static org.sonar.server.qualityprofile.ws.CreateAction.NAME_MAXIMUM_LENGTH; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonarqube.ws.client.qualityprofile.QualityProfileWsParameters.PARAM_KEY; | |||
import static org.sonarqube.ws.client.qualityprofile.QualityProfileWsParameters.PARAM_NAME; | |||
@@ -48,7 +48,7 @@ import static java.util.Optional.ofNullable; | |||
import static org.sonar.api.rule.RuleStatus.DEPRECATED; | |||
import static org.sonar.api.utils.DateUtils.formatDateTime; | |||
import static org.sonar.core.util.Uuids.UUID_EXAMPLE_01; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.qualityprofile.QualityProfileWsParameters.ACTION_SHOW; | |||
import static org.sonarqube.ws.client.qualityprofile.QualityProfileWsParameters.PARAM_COMPARE_TO_SONAR_WAY; |
@@ -29,7 +29,7 @@ import org.sonar.server.exceptions.NotFoundException; | |||
import org.sonar.server.user.UserSession; | |||
import static java.lang.String.format; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class UnsetRootAction implements RootsWsAction { | |||
private static final String PARAM_LOGIN = "login"; |
@@ -56,8 +56,8 @@ import static org.sonar.server.rule.ws.RulesWsParameters.PARAM_TAGS; | |||
import static org.sonar.server.rule.ws.RulesWsParameters.PARAM_TEMPLATE_KEY; | |||
import static org.sonar.server.rule.ws.RulesWsParameters.PARAM_TYPES; | |||
import static org.sonar.server.util.EnumUtils.toEnums; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
@ServerSide | |||
public class RuleQueryFactory { |
@@ -75,7 +75,7 @@ import static org.sonar.server.security.SecurityStandardHelper.SANS_TOP_25_CWE_M | |||
import static org.sonar.server.security.SecurityStandardHelper.SONARSOURCE_CWE_MAPPING; | |||
import static org.sonar.server.security.SecurityStandardHelper.SONARSOURCE_OTHER_CWES_CATEGORY; | |||
import static org.sonar.server.security.SecurityStandardHelper.UNKNOWN_STANDARD; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
@ServerSide | |||
public class RuleWsSupport { |
@@ -32,9 +32,9 @@ import org.sonar.api.utils.text.JsonWriter; | |||
import org.sonar.db.DbClient; | |||
import org.sonar.db.DbSession; | |||
import org.sonar.db.organization.OrganizationDto; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import org.sonar.server.organization.DefaultOrganizationProvider; | |||
import org.sonar.server.rule.index.RuleIndex; | |||
import org.sonar.server.ws.WsUtils; | |||
import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_ORGANIZATION; | |||
@@ -85,7 +85,7 @@ public class TagsAction implements RulesWsAction { | |||
try (DbSession dbSession = dbClient.openSession(false)) { | |||
String organizationOrDefaultKey = Optional.ofNullable(organizationKey) | |||
.orElseGet(defaultOrganizationProvider.get()::getKey); | |||
return WsUtils.checkFoundWithOptional( | |||
return NotFoundException.checkFoundWithOptional( | |||
dbClient.organizationDao().selectByKey(dbSession, organizationOrDefaultKey), | |||
"No organization with key '%s'", organizationOrDefaultKey); | |||
} |
@@ -28,7 +28,7 @@ import org.sonar.server.user.UserSession; | |||
import org.sonarqube.ws.Settings.EncryptWsResponse; | |||
import static org.sonar.server.setting.ws.SettingsWsParameters.PARAM_VALUE; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class EncryptAction implements SettingsWsAction { |
@@ -67,7 +67,7 @@ import static org.sonar.server.setting.ws.SettingsWsParameters.PARAM_PULL_REQUES | |||
import static org.sonar.server.setting.ws.SettingsWsParameters.PARAM_VALUE; | |||
import static org.sonar.server.setting.ws.SettingsWsParameters.PARAM_VALUES; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class SetAction implements SettingsWsAction { | |||
private static final Collector<CharSequence, ?, String> COMMA_JOINER = Collectors.joining(","); |
@@ -42,7 +42,7 @@ import org.sonar.server.exceptions.BadRequestException; | |||
import static java.lang.String.format; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class SettingValidations { | |||
private final PropertyDefinitions definitions; |
@@ -44,8 +44,8 @@ import static org.sonar.server.component.ComponentFinder.ParamNames.UUID_AND_KEY | |||
import static org.sonar.server.ws.KeyExamples.KEY_BRANCH_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_FILE_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PULL_REQUEST_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class LinesAction implements SourcesWsAction { | |||
@@ -38,7 +38,7 @@ import org.sonar.server.component.ComponentFinder; | |||
import org.sonar.server.source.SourceService; | |||
import org.sonar.server.user.UserSession; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class ScmAction implements SourcesWsAction { | |||
@@ -33,7 +33,7 @@ import org.sonar.server.component.ComponentFinder; | |||
import org.sonar.server.source.SourceService; | |||
import org.sonar.server.user.UserSession; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class ShowAction implements SourcesWsAction { | |||
@@ -53,6 +53,7 @@ import org.sonar.db.property.PropertyQuery; | |||
import org.sonar.db.qualitygate.QualityGateDto; | |||
import org.sonar.db.qualityprofile.QProfileDto; | |||
import org.sonar.server.component.ComponentFinder; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import org.sonar.server.organization.BillingValidations; | |||
import org.sonar.server.organization.BillingValidationsProxy; | |||
@@ -62,7 +63,6 @@ import org.sonar.server.qualityprofile.QPMeasureData; | |||
import org.sonar.server.qualityprofile.QualityProfile; | |||
import org.sonar.server.ui.PageRepository; | |||
import org.sonar.server.user.UserSession; | |||
import org.sonar.server.ws.WsUtils; | |||
import static java.lang.String.format; | |||
import static java.util.Collections.emptySortedSet; | |||
@@ -179,7 +179,7 @@ public class ComponentAction implements NavigationWsAction { | |||
} | |||
private static void checkComponentNotAModuleAndNotADirectory(ComponentDto component) { | |||
WsUtils.checkRequest(!MODULE_OR_DIR_QUALIFIERS.contains(component.qualifier()), "Operation not supported for module or directory components"); | |||
BadRequestException.checkRequest(!MODULE_OR_DIR_QUALIFIERS.contains(component.qualifier()), "Operation not supported for module or directory components"); | |||
} | |||
private ComponentDto getRootProjectOrBranch(ComponentDto component, DbSession session) { |
@@ -46,7 +46,7 @@ import org.sonar.server.user.UserSession; | |||
import static org.sonar.db.organization.OrganizationDto.Subscription.PAID; | |||
import static org.sonar.db.permission.OrganizationPermission.ADMINISTER; | |||
import static org.sonar.server.ws.KeyExamples.KEY_ORG_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
public class OrganizationAction implements NavigationWsAction { | |||
@@ -47,8 +47,8 @@ import static java.lang.String.format; | |||
import static java.util.Collections.singletonList; | |||
import static org.sonar.api.CoreProperties.DEFAULT_ISSUE_ASSIGNEE; | |||
import static org.sonar.process.ProcessProperties.Property.SONARCLOUD_ENABLED; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class DeactivateAction implements UsersWsAction { | |||
@@ -52,8 +52,8 @@ import static org.sonar.api.server.ws.WebService.Param.PAGE_SIZE; | |||
import static org.sonar.api.server.ws.WebService.Param.SELECTED; | |||
import static org.sonar.api.server.ws.WebService.Param.TEXT_QUERY; | |||
import static org.sonar.api.utils.Paging.forPageIndex; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.client.user.UsersWsParameters.PARAM_LOGIN; | |||
import static org.sonarqube.ws.client.user.UsersWsParameters.PARAM_ORGANIZATION; |
@@ -41,7 +41,7 @@ import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_LOGIN; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_ORGANIZATION_KEY; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.defineGroupWsParameters; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.defineLoginWsParameter; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
public class AddUserAction implements UserGroupsWsAction { | |||
@@ -29,7 +29,7 @@ import org.sonar.server.permission.GroupIdOrAnyone; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static com.google.common.base.Preconditions.checkState; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Reference to a user group <b>as declared by web service requests</b>. It is one, and only one, |
@@ -36,9 +36,9 @@ import org.sonarqube.ws.UserGroups; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static java.util.Optional.ofNullable; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
/** | |||
* Factorizes code about user groups between web services |
@@ -36,8 +36,8 @@ import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_GROUP_NAME; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_LOGIN; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.defineGroupWsParameters; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.defineLoginWsParameter; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
public class RemoveUserAction implements UserGroupsWsAction { | |||
@@ -42,8 +42,8 @@ import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_GROUP_DESCRIPT | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_GROUP_ID; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_GROUP_NAME; | |||
import static org.sonar.server.usergroups.ws.GroupWsSupport.toProtobuf; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class UpdateAction implements UserGroupsWsAction { |
@@ -37,7 +37,7 @@ import static org.sonar.api.utils.DateUtils.formatDateTime; | |||
import static org.sonar.server.usertoken.ws.UserTokenSupport.ACTION_GENERATE; | |||
import static org.sonar.server.usertoken.ws.UserTokenSupport.PARAM_LOGIN; | |||
import static org.sonar.server.usertoken.ws.UserTokenSupport.PARAM_NAME; | |||
import static org.sonar.server.ws.WsUtils.checkRequest; | |||
import static org.sonar.server.exceptions.BadRequestException.checkRequest; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class GenerateAction implements UserTokensWsAction { |
@@ -28,7 +28,7 @@ import org.sonar.server.user.UserSession; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.server.user.AbstractUserSession.insufficientPrivilegesException; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
public class UserTokenSupport { | |||
@@ -51,7 +51,7 @@ import static org.sonar.server.ws.KeyExamples.KEY_ORG_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.NAME_WEBHOOK_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.URL_WEBHOOK_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkStateWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
import static org.sonarqube.ws.Webhooks.CreateWsResponse.Webhook; |
@@ -35,7 +35,7 @@ import static org.sonar.server.webhook.ws.WebhooksWsParameters.DELETE_ACTION; | |||
import static org.sonar.server.webhook.ws.WebhooksWsParameters.KEY_PARAM; | |||
import static org.sonar.server.webhook.ws.WebhooksWsParameters.KEY_PARAM_MAXIMUM_LENGTH; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkStateWithOptional; | |||
public class DeleteAction implements WebhooksWsAction { |
@@ -47,7 +47,7 @@ import static org.sonar.server.webhook.ws.WebhooksWsParameters.ORGANIZATION_KEY_ | |||
import static org.sonar.server.webhook.ws.WebhooksWsParameters.PROJECT_KEY_PARAM; | |||
import static org.sonar.server.ws.KeyExamples.KEY_ORG_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkStateWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
@@ -44,7 +44,7 @@ import static org.sonar.server.webhook.ws.WebhooksWsParameters.URL_PARAM_MAXIMUM | |||
import static org.sonar.server.ws.KeyExamples.KEY_PROJECT_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.NAME_WEBHOOK_EXAMPLE_001; | |||
import static org.sonar.server.ws.KeyExamples.URL_WEBHOOK_EXAMPLE_001; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.checkStateWithOptional; | |||
public class UpdateAction implements WebhooksWsAction { |
@@ -35,7 +35,7 @@ import org.sonarqube.ws.Webhooks; | |||
import static java.util.Objects.requireNonNull; | |||
import static org.sonar.server.webhook.ws.WebhookWsSupport.copyDtoToProtobuf; | |||
import static org.sonar.server.ws.WsUtils.checkFoundWithOptional; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFoundWithOptional; | |||
import static org.sonar.server.ws.WsUtils.writeProtobuf; | |||
public class WebhookDeliveryAction implements WebhooksWsAction { |
@@ -23,6 +23,7 @@ import com.google.common.base.MoreObjects; | |||
import java.util.List; | |||
import static com.google.common.base.Preconditions.checkArgument; | |||
import static java.lang.String.format; | |||
import static java.net.HttpURLConnection.HTTP_BAD_REQUEST; | |||
import static java.util.Arrays.asList; | |||
@@ -38,6 +39,18 @@ public class BadRequestException extends ServerException { | |||
this.errors = errors; | |||
} | |||
public static void checkRequest(boolean expression, String message, Object... messageArguments) { | |||
if (!expression) { | |||
throw create(format(message, messageArguments)); | |||
} | |||
} | |||
public static void checkRequest(boolean expression, List<String> messages) { | |||
if (!expression) { | |||
throw create(messages); | |||
} | |||
} | |||
public static BadRequestException create(List<String> errorMessages) { | |||
checkArgument(!errorMessages.isEmpty(), "At least one error message is required"); | |||
checkArgument(errorMessages.stream().noneMatch(message -> message == null || message.isEmpty()), "Message cannot be empty"); |
@@ -19,6 +19,10 @@ | |||
*/ | |||
package org.sonar.server.exceptions; | |||
import com.google.common.base.Optional; | |||
import javax.annotation.Nullable; | |||
import static java.lang.String.format; | |||
import static java.net.HttpURLConnection.HTTP_NOT_FOUND; | |||
public class NotFoundException extends ServerException { | |||
@@ -26,4 +30,36 @@ public class NotFoundException extends ServerException { | |||
public NotFoundException(String message) { | |||
super(HTTP_NOT_FOUND, message); | |||
} | |||
/** | |||
* @throws NotFoundException if the value if null | |||
* @return the value | |||
*/ | |||
public static <T> T checkFound(@Nullable T value, String message, Object... messageArguments) { | |||
if (value == null) { | |||
throw new NotFoundException(format(message, messageArguments)); | |||
} | |||
return value; | |||
} | |||
/** | |||
* @throws NotFoundException if the value is not present | |||
* @return the value | |||
*/ | |||
public static <T> T checkFoundWithOptional(Optional<T> value, String message, Object... messageArguments) { | |||
if (!value.isPresent()) { | |||
throw new NotFoundException(format(message, messageArguments)); | |||
} | |||
return value.get(); | |||
} | |||
public static <T> T checkFoundWithOptional(java.util.Optional<T> value, String message, Object... messageArguments) { | |||
if (!value.isPresent()) { | |||
throw new NotFoundException(format(message, messageArguments)); | |||
} | |||
return value.get(); | |||
} | |||
} |
@@ -50,7 +50,7 @@ import static org.apache.commons.lang.StringUtils.substringAfterLast; | |||
import static org.apache.commons.lang.StringUtils.substringBeforeLast; | |||
import static org.sonar.server.ws.RequestVerifier.verifyRequest; | |||
import static org.sonar.server.ws.ServletRequest.SUPPORTED_MEDIA_TYPES_BY_URL_SUFFIX; | |||
import static org.sonar.server.ws.WsUtils.checkFound; | |||
import static org.sonar.server.exceptions.NotFoundException.checkFound; | |||
/** | |||
* @since 4.2 |
@@ -19,22 +19,14 @@ | |||
*/ | |||
package org.sonar.server.ws; | |||
import com.google.common.base.Optional; | |||
import com.google.common.collect.ImmutableSet; | |||
import com.google.protobuf.Message; | |||
import java.io.OutputStream; | |||
import java.io.OutputStreamWriter; | |||
import java.util.List; | |||
import java.util.Set; | |||
import javax.annotation.Nullable; | |||
import org.apache.commons.io.IOUtils; | |||
import org.sonar.api.resources.Qualifiers; | |||
import org.sonar.api.server.ws.Request; | |||
import org.sonar.api.server.ws.Response; | |||
import org.sonar.api.utils.text.JsonWriter; | |||
import org.sonar.core.util.ProtobufJsonFormat; | |||
import org.sonar.server.exceptions.BadRequestException; | |||
import org.sonar.server.exceptions.NotFoundException; | |||
import static java.lang.String.format; | |||
import static java.nio.charset.StandardCharsets.UTF_8; | |||
@@ -66,53 +58,6 @@ public class WsUtils { | |||
} | |||
} | |||
/** | |||
* @throws BadRequestException | |||
*/ | |||
public static void checkRequest(boolean expression, String message, Object... messageArguments) { | |||
if (!expression) { | |||
throw BadRequestException.create(format(message, messageArguments)); | |||
} | |||
} | |||
public static void checkRequest(boolean expression, List<String> messages) { | |||
if (!expression) { | |||
throw BadRequestException.create(messages); | |||
} | |||
} | |||
/** | |||
* @throws NotFoundException if the value if null | |||
* @return the value | |||
*/ | |||
public static <T> T checkFound(@Nullable T value, String message, Object... messageArguments) { | |||
if (value == null) { | |||
throw new NotFoundException(format(message, messageArguments)); | |||
} | |||
return value; | |||
} | |||
/** | |||
* @throws NotFoundException if the value is not present | |||
* @return the value | |||
*/ | |||
public static <T> T checkFoundWithOptional(Optional<T> value, String message, Object... messageArguments) { | |||
if (!value.isPresent()) { | |||
throw new NotFoundException(format(message, messageArguments)); | |||
} | |||
return value.get(); | |||
} | |||
public static <T> T checkFoundWithOptional(java.util.Optional<T> value, String message, Object... messageArguments) { | |||
if (!value.isPresent()) { | |||
throw new NotFoundException(format(message, messageArguments)); | |||
} | |||
return value.get(); | |||
} | |||
public static <T> T checkStateWithOptional(java.util.Optional<T> value, String message, Object... messageArguments) { | |||
if (!value.isPresent()) { | |||
throw new IllegalStateException(format(message, messageArguments)); |
@@ -19,7 +19,6 @@ | |||
*/ | |||
package org.sonar.server.ws; | |||
import java.io.IOException; | |||
import org.junit.Rule; | |||
import org.junit.Test; | |||
import org.junit.rules.ExpectedException; | |||
@@ -84,7 +83,7 @@ public class WsUtilsTest { | |||
@Test | |||
public void checkRequest_ok() { | |||
WsUtils.checkRequest(true, "Missing param: %s", "foo"); | |||
BadRequestException.checkRequest(true, "Missing param: %s", "foo"); | |||
// do not fail | |||
} | |||
@@ -93,7 +92,7 @@ public class WsUtilsTest { | |||
expectedException.expect(BadRequestException.class); | |||
expectedException.expectMessage("Missing param: foo"); | |||
WsUtils.checkRequest(false, "Missing param: %s", "foo"); | |||
BadRequestException.checkRequest(false, "Missing param: %s", "foo"); | |||
} | |||
} |