123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281 |
- /*
- * SonarQube
- * Copyright (C) 2009-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.scanner.issue;
-
- import java.io.IOException;
- import java.util.Collections;
- import java.util.HashSet;
- import java.util.List;
- import org.junit.Before;
- import org.junit.Rule;
- import org.junit.Test;
- import org.junit.rules.TemporaryFolder;
- import org.junit.runner.RunWith;
- import org.mockito.ArgumentCaptor;
- import org.mockito.junit.MockitoJUnitRunner;
- import org.sonar.api.batch.bootstrap.ProjectDefinition;
- import org.sonar.api.batch.fs.InputComponent;
- import org.sonar.api.batch.fs.internal.DefaultInputFile;
- import org.sonar.api.batch.fs.internal.DefaultInputProject;
- import org.sonar.api.batch.fs.internal.TestInputFileBuilder;
- import org.sonar.api.batch.rule.internal.ActiveRulesBuilder;
- import org.sonar.api.batch.rule.internal.NewActiveRule;
- import org.sonar.api.batch.sensor.issue.NewIssue;
- import org.sonar.api.batch.sensor.issue.internal.DefaultExternalIssue;
- import org.sonar.api.batch.sensor.issue.internal.DefaultIssue;
- import org.sonar.api.batch.sensor.issue.internal.DefaultIssueLocation;
- import org.sonar.api.batch.sensor.issue.internal.DefaultMessageFormatting;
- import org.sonar.api.rule.RuleKey;
- import org.sonar.api.rule.Severity;
- import org.sonar.api.rules.RuleType;
- import org.sonar.scanner.protocol.output.ScannerReport;
- import org.sonar.scanner.protocol.output.ScannerReport.FlowType;
- import org.sonar.scanner.report.ReportPublisher;
-
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.assertj.core.api.Assertions.tuple;
- import static org.mockito.ArgumentMatchers.any;
- import static org.mockito.ArgumentMatchers.eq;
- import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
- import static org.mockito.Mockito.mock;
- import static org.mockito.Mockito.verify;
- import static org.mockito.Mockito.verifyNoInteractions;
- import static org.mockito.Mockito.when;
- import static org.sonar.api.batch.sensor.issue.MessageFormatting.Type.CODE;
-
- @RunWith(MockitoJUnitRunner.class)
- public class IssuePublisherTest {
- static final RuleKey JAVA_RULE_KEY = RuleKey.of("java", "AvoidCycle");
- private static final RuleKey NOSONAR_RULE_KEY = RuleKey.of("java", "NoSonarCheck");
-
- private DefaultInputProject project;
-
- @Rule
- public TemporaryFolder temp = new TemporaryFolder();
- public IssueFilters filters = mock(IssueFilters.class);
-
- private final ActiveRulesBuilder activeRulesBuilder = new ActiveRulesBuilder();
- private IssuePublisher moduleIssues;
- private final DefaultInputFile file = new TestInputFileBuilder("foo", "src/Foo.php").initMetadata("Foo\nBar\nBiz\n").build();
- private final ReportPublisher reportPublisher = mock(ReportPublisher.class, RETURNS_DEEP_STUBS);
-
- @Before
- public void prepare() throws IOException {
- project = new DefaultInputProject(ProjectDefinition.create()
- .setKey("foo")
- .setBaseDir(temp.newFolder())
- .setWorkDir(temp.newFolder()));
-
- activeRulesBuilder.addRule(new NewActiveRule.Builder()
- .setRuleKey(JAVA_RULE_KEY)
- .setSeverity(Severity.INFO)
- .setQProfileKey("qp-1")
- .build());
- initModuleIssues();
- }
-
- @Test
- public void ignore_null_active_rule() {
- RuleKey INACTIVE_RULE_KEY = RuleKey.of("repo", "inactive");
- initModuleIssues();
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message("Foo"))
- .forRule(INACTIVE_RULE_KEY);
- boolean added = moduleIssues.initAndAddIssue(issue);
-
- assertThat(added).isFalse();
- verifyNoInteractions(reportPublisher);
- }
-
- @Test
- public void ignore_null_rule_of_active_rule() {
- initModuleIssues();
-
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message("Foo"))
- .forRule(JAVA_RULE_KEY);
- boolean added = moduleIssues.initAndAddIssue(issue);
-
- assertThat(added).isFalse();
- verifyNoInteractions(reportPublisher);
- }
-
- @Test
- public void add_issue_to_cache() {
- initModuleIssues();
-
- final String ruleDescriptionContextKey = "spring";
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message("Foo"))
- .forRule(JAVA_RULE_KEY)
- .overrideSeverity(org.sonar.api.batch.rule.Severity.CRITICAL)
- .setQuickFixAvailable(true)
- .setRuleDescriptionContextKey(ruleDescriptionContextKey)
- .setCodeVariants(List.of("variant1", "variant2"));
-
- when(filters.accept(any(InputComponent.class), any(ScannerReport.Issue.class))).thenReturn(true);
-
- boolean added = moduleIssues.initAndAddIssue(issue);
-
- assertThat(added).isTrue();
- ArgumentCaptor<ScannerReport.Issue> argument = ArgumentCaptor.forClass(ScannerReport.Issue.class);
- verify(reportPublisher.getWriter()).appendComponentIssue(eq(file.scannerId()), argument.capture());
- assertThat(argument.getValue().getSeverity()).isEqualTo(org.sonar.scanner.protocol.Constants.Severity.CRITICAL);
- assertThat(argument.getValue().getQuickFixAvailable()).isTrue();
- assertThat(argument.getValue().getRuleDescriptionContextKey()).isEqualTo(ruleDescriptionContextKey);
- assertThat(argument.getValue().getCodeVariantsList()).containsExactly("variant1", "variant2");
- }
-
- @Test
- public void add_issue_flows_to_cache() {
- initModuleIssues();
-
- DefaultMessageFormatting messageFormatting = new DefaultMessageFormatting().start(0).end(4).type(CODE);
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file))
- // Flow without type
- .addFlow(List.of(new DefaultIssueLocation().on(file).at(file.selectLine(1)).message("Foo1", List.of(messageFormatting)),
- new DefaultIssueLocation().on(file).at(file.selectLine(2)).message("Foo2")))
- // Flow with type and description
- .addFlow(List.of(new DefaultIssueLocation().on(file)), NewIssue.FlowType.DATA, "description")
- // Flow with execution type and no description
- .addFlow(List.of(new DefaultIssueLocation().on(file)), NewIssue.FlowType.EXECUTION, null)
- .forRule(JAVA_RULE_KEY);
-
- when(filters.accept(any(InputComponent.class), any(ScannerReport.Issue.class))).thenReturn(true);
- moduleIssues.initAndAddIssue(issue);
-
- ArgumentCaptor<ScannerReport.Issue> argument = ArgumentCaptor.forClass(ScannerReport.Issue.class);
- verify(reportPublisher.getWriter()).appendComponentIssue(eq(file.scannerId()), argument.capture());
- List<ScannerReport.Flow> writtenFlows = argument.getValue().getFlowList();
-
- assertThat(writtenFlows)
- .extracting(ScannerReport.Flow::getDescription, ScannerReport.Flow::getType)
- .containsExactly(tuple("", FlowType.UNDEFINED), tuple("description", FlowType.DATA), tuple("", FlowType.EXECUTION));
-
- assertThat(writtenFlows.get(0).getLocationCount()).isEqualTo(2);
- assertThat(writtenFlows.get(0).getLocationList()).containsExactly(
- ScannerReport.IssueLocation.newBuilder()
- .setComponentRef(file.scannerId())
- .setMsg("Foo1")
- .addMsgFormatting(ScannerReport.MessageFormatting.newBuilder().setStart(0).setEnd(4).setType(ScannerReport.MessageFormattingType.CODE).build())
- .setTextRange(ScannerReport.TextRange.newBuilder().setStartLine(1).setEndLine(1).setEndOffset(3).build())
- .build(),
- ScannerReport.IssueLocation.newBuilder()
- .setComponentRef(file.scannerId())
- .setMsg("Foo2")
- .setTextRange(ScannerReport.TextRange.newBuilder().setStartLine(2).setEndLine(2).setEndOffset(3).build())
- .build());
- }
-
- @Test
- public void add_external_issue_to_cache() {
- initModuleIssues();
-
- DefaultExternalIssue issue = new DefaultExternalIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message("Foo"))
- .type(RuleType.BUG)
- .forRule(JAVA_RULE_KEY)
- .severity(org.sonar.api.batch.rule.Severity.CRITICAL);
-
- moduleIssues.initAndAddExternalIssue(issue);
-
- ArgumentCaptor<ScannerReport.ExternalIssue> argument = ArgumentCaptor.forClass(ScannerReport.ExternalIssue.class);
- verify(reportPublisher.getWriter()).appendComponentExternalIssue(eq(file.scannerId()), argument.capture());
- assertThat(argument.getValue().getSeverity()).isEqualTo(org.sonar.scanner.protocol.Constants.Severity.CRITICAL);
- }
-
- @Test
- public void use_severity_from_active_rule_if_no_severity_on_issue() {
- initModuleIssues();
-
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message("Foo"))
- .forRule(JAVA_RULE_KEY);
- when(filters.accept(any(InputComponent.class), any(ScannerReport.Issue.class))).thenReturn(true);
- moduleIssues.initAndAddIssue(issue);
-
- ArgumentCaptor<ScannerReport.Issue> argument = ArgumentCaptor.forClass(ScannerReport.Issue.class);
- verify(reportPublisher.getWriter()).appendComponentIssue(eq(file.scannerId()), argument.capture());
- assertThat(argument.getValue().getSeverity()).isEqualTo(org.sonar.scanner.protocol.Constants.Severity.INFO);
- }
-
- @Test
- public void filter_issue() {
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message(""))
- .forRule(JAVA_RULE_KEY);
-
- when(filters.accept(any(InputComponent.class), any(ScannerReport.Issue.class))).thenReturn(false);
-
- boolean added = moduleIssues.initAndAddIssue(issue);
-
- assertThat(added).isFalse();
- verifyNoInteractions(reportPublisher);
- }
-
- @Test
- public void should_ignore_lines_commented_with_nosonar() {
- initModuleIssues();
-
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message(""))
- .forRule(JAVA_RULE_KEY);
-
- file.noSonarAt(new HashSet<>(Collections.singletonList(3)));
-
- boolean added = moduleIssues.initAndAddIssue(issue);
-
- assertThat(added).isFalse();
- verifyNoInteractions(reportPublisher);
- }
-
- @Test
- public void should_accept_issues_on_no_sonar_rules() {
- // The "No Sonar" rule logs violations on the lines that are flagged with "NOSONAR" !!
- activeRulesBuilder.addRule(new NewActiveRule.Builder()
- .setRuleKey(NOSONAR_RULE_KEY)
- .setSeverity(Severity.INFO)
- .setQProfileKey("qp-1")
- .build());
- initModuleIssues();
-
- file.noSonarAt(new HashSet<>(Collections.singletonList(3)));
-
- DefaultIssue issue = new DefaultIssue(project)
- .at(new DefaultIssueLocation().on(file).at(file.selectLine(3)).message(""))
- .forRule(NOSONAR_RULE_KEY);
-
- when(filters.accept(any(InputComponent.class), any(ScannerReport.Issue.class))).thenReturn(true);
-
- boolean added = moduleIssues.initAndAddIssue(issue);
-
- assertThat(added).isTrue();
- verify(reportPublisher.getWriter()).appendComponentIssue(eq(file.scannerId()), any());
- }
-
- /**
- * Every rules and active rules has to be added in builders before creating IssuePublisher
- */
- private void initModuleIssues() {
- moduleIssues = new IssuePublisher(activeRulesBuilder.build(), filters, reportPublisher);
- }
-
- }
|