123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145 |
- /*
- * SonarQube
- * Copyright (C) 2009-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.issue;
-
- import java.util.Date;
- import java.util.List;
- import org.junit.Before;
- import org.junit.Rule;
- import org.junit.Test;
- import org.sonar.core.issue.DefaultIssue;
- import org.sonar.core.issue.IssueChangeContext;
- import org.sonar.db.DbTester;
- import org.sonar.db.component.ComponentDto;
- import org.sonar.db.component.ProjectData;
- import org.sonar.db.issue.IssueDto;
- import org.sonar.db.rule.RuleDto;
- import org.sonar.server.issue.workflow.FunctionExecutor;
- import org.sonar.server.issue.workflow.IssueWorkflow;
- import org.sonar.server.issue.workflow.Transition;
- import org.sonar.server.tester.UserSessionRule;
-
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.assertj.core.api.Assertions.assertThatThrownBy;
- import static org.sonar.api.issue.Issue.STATUS_CONFIRMED;
- import static org.sonar.api.issue.Issue.STATUS_OPEN;
- import static org.sonar.api.rules.RuleType.CODE_SMELL;
- import static org.sonar.api.web.UserRole.ISSUE_ADMIN;
- import static org.sonar.core.issue.IssueChangeContext.issueChangeContextByUserBuilder;
- import static org.sonar.db.component.ComponentTesting.newFileDto;
-
- public class TransitionServiceIT {
-
- @Rule
- public DbTester db = DbTester.create();
- @Rule
- public UserSessionRule userSession = UserSessionRule.standalone();
-
- private IssueFieldsSetter updater = new IssueFieldsSetter();
- private IssueWorkflow workflow = new IssueWorkflow(new FunctionExecutor(updater), updater);
-
- private TransitionService underTest = new TransitionService(userSession, workflow);
-
- @Before
- public void setUp() {
- workflow.start();
- }
-
- @Test
- public void list_transitions() {
- ProjectData project = db.components().insertPrivateProject();
- ComponentDto file = db.components().insertComponent(newFileDto(project.getMainBranchComponent()));
- RuleDto rule = db.rules().insert();
- IssueDto issue = db.issues().insert(rule, project.getMainBranchComponent(), file, i -> i.setStatus(STATUS_OPEN).setResolution(null).setType(CODE_SMELL));
- userSession.logIn().addProjectPermission(ISSUE_ADMIN, project.getProjectDto())
- .registerBranches(project.getMainBranchDto());
-
- List<Transition> result = underTest.listTransitions(issue.toDefaultIssue());
-
- assertThat(result).extracting(Transition::key).containsOnly("confirm", "resolve", "falsepositive", "wontfix");
- }
-
- @Test
- public void list_transitions_returns_empty_list_on_external_issue() {
- ProjectData project = db.components().insertPrivateProject();
- ComponentDto file = db.components().insertComponent(newFileDto(project.getMainBranchComponent()));
- RuleDto externalRule = db.rules().insert(r -> r.setIsExternal(true));
- IssueDto externalIssue = db.issues().insert(externalRule, project.getMainBranchComponent(), file, i -> i.setStatus(STATUS_OPEN).setResolution(null).setType(CODE_SMELL));
- userSession.logIn().addProjectPermission(ISSUE_ADMIN, project.getProjectDto())
- .registerBranches(project.getMainBranchDto());
-
- List<Transition> result = underTest.listTransitions(externalIssue.toDefaultIssue());
-
- assertThat(result).isEmpty();
- }
-
- @Test
- public void list_transitions_returns_only_transitions_that_do_not_requires_issue_admin_permission() {
- ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
- ComponentDto file = db.components().insertComponent(newFileDto(project));
- RuleDto rule = db.rules().insert();
- IssueDto issue = db.issues().insert(rule, project, file, i -> i.setStatus(STATUS_OPEN).setResolution(null).setType(CODE_SMELL));
- userSession.logIn();
-
- List<Transition> result = underTest.listTransitions(issue.toDefaultIssue());
-
- assertThat(result).extracting(Transition::key).containsOnly("confirm");
- }
-
- @Test
- public void list_transitions_returns_nothing_when_not_logged() {
- ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
- ComponentDto file = db.components().insertComponent(newFileDto(project));
- RuleDto rule = db.rules().insert();
- IssueDto issue = db.issues().insert(rule, project, file, i -> i.setStatus(STATUS_OPEN).setResolution(null).setType(CODE_SMELL));
-
- List<Transition> result = underTest.listTransitions(issue.toDefaultIssue());
-
- assertThat(result).isEmpty();
- }
-
- @Test
- public void do_transition() {
- ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
- ComponentDto file = db.components().insertComponent(newFileDto(project));
- RuleDto rule = db.rules().insert();
- IssueDto issue = db.issues().insert(rule, project, file, i -> i.setStatus(STATUS_OPEN).setResolution(null).setType(CODE_SMELL));
-
- DefaultIssue defaultIssue = issue.toDefaultIssue();
- boolean result = underTest.doTransition(defaultIssue, issueChangeContextByUserBuilder(new Date(), "user_uuid").build(), "confirm");
-
- assertThat(result).isTrue();
- assertThat(defaultIssue.status()).isEqualTo(STATUS_CONFIRMED);
- }
-
- @Test
- public void do_transition_fail_on_external_issue() {
- ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
- ComponentDto file = db.components().insertComponent(newFileDto(project));
- RuleDto externalRule = db.rules().insert(r -> r.setIsExternal(true));
- IssueDto externalIssue = db.issues().insert(externalRule, project, file, i -> i.setStatus(STATUS_OPEN).setResolution(null).setType(CODE_SMELL));
- DefaultIssue defaultIssue = externalIssue.toDefaultIssue();
-
- IssueChangeContext issueChangeContext = issueChangeContextByUserBuilder(new Date(), "user_uuid").build();
- assertThatThrownBy(() -> underTest.doTransition(defaultIssue, issueChangeContext, "confirm"))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessage("Transition is not allowed on issues imported from external rule engines");
- }
- }
|