123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371 |
- /*
- * SonarQube
- * Copyright (C) 2009-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.notification.ws;
-
- import javax.annotation.Nullable;
- import org.junit.Rule;
- import org.junit.Test;
- import org.sonar.api.notifications.Notification;
- import org.sonar.db.DbClient;
- import org.sonar.db.DbTester;
- import org.sonar.db.component.ComponentDto;
- import org.sonar.db.component.ProjectData;
- import org.sonar.db.project.ProjectDto;
- import org.sonar.db.user.UserDto;
- import org.sonar.server.component.TestComponentFinder;
- import org.sonar.server.exceptions.BadRequestException;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.exceptions.NotFoundException;
- import org.sonar.server.exceptions.UnauthorizedException;
- import org.sonar.server.notification.NotificationChannel;
- import org.sonar.server.notification.NotificationDispatcherMetadata;
- import org.sonar.server.tester.UserSessionRule;
- import org.sonar.server.ws.TestRequest;
- import org.sonar.server.ws.TestResponse;
- import org.sonar.server.ws.WsActionTester;
-
- import static java.net.HttpURLConnection.HTTP_NO_CONTENT;
- import static java.util.Arrays.asList;
- import static java.util.Collections.singletonList;
- import static java.util.Optional.ofNullable;
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.assertj.core.api.Assertions.assertThatThrownBy;
- import static org.mockito.Mockito.mock;
- import static org.mockito.Mockito.when;
- import static org.sonar.api.web.UserRole.USER;
- import static org.sonar.db.component.ComponentTesting.newPortfolio;
- import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_CHANNEL;
- import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_LOGIN;
- import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_PROJECT;
- import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_TYPE;
-
- public class AddActionIT {
- private static final String NOTIF_MY_NEW_ISSUES = "Dispatcher1";
- private static final String NOTIF_NEW_ISSUES = "Dispatcher2";
- private static final String NOTIF_NEW_QUALITY_GATE_STATUS = "Dispatcher3";
-
- @Rule
- public UserSessionRule userSession = UserSessionRule.standalone();
- @Rule
- public DbTester db = DbTester.create();
-
- private final DbClient dbClient = db.getDbClient();
-
- private final NotificationChannel emailChannel = new FakeNotificationChannel("EmailChannel");
- private final NotificationChannel twitterChannel = new FakeNotificationChannel("TwitterChannel");
- // default channel, based on class simple name
- private final NotificationChannel defaultChannel = new FakeNotificationChannel("EmailNotificationChannel");
-
- private final Dispatchers dispatchers = mock(Dispatchers.class);
-
- private final WsActionTester ws = new WsActionTester(new AddAction(new NotificationCenter(
- new NotificationDispatcherMetadata[] {},
- new NotificationChannel[] {emailChannel, twitterChannel, defaultChannel}),
- new NotificationUpdater(dbClient), dispatchers, dbClient, TestComponentFinder.from(db), userSession));
-
- @Test
- public void add_to_email_channel_by_default() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- call(NOTIF_MY_NEW_ISSUES, null, null, null);
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), null);
- }
-
- @Test
- public void add_to_a_specific_channel() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(asList(NOTIF_MY_NEW_ISSUES, NOTIF_NEW_QUALITY_GATE_STATUS));
-
- call(NOTIF_NEW_QUALITY_GATE_STATUS, twitterChannel.getKey(), null, null);
-
- db.notifications().assertExists(twitterChannel.getKey(), NOTIF_NEW_QUALITY_GATE_STATUS, userSession.getUuid(), null);
- }
-
- @Test
- public void add_notification_on_private_with_USER_permission() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- ProjectDto project = db.components().insertPrivateProject().getProjectDto();
- userSession.addProjectPermission(USER, project);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- call(NOTIF_MY_NEW_ISSUES, null, project.getKey(), null);
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), project);
- }
-
- @Test
- public void add_notification_on_public_project() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- ProjectDto project = db.components().insertPublicProject().getProjectDto();
- userSession.registerProjects(project);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- call(NOTIF_MY_NEW_ISSUES, null, project.getKey(), null);
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), project);
- }
-
- @Test
- public void add_a_global_notification_when_a_project_one_exists() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(asList(NOTIF_MY_NEW_ISSUES));
- ProjectDto project = db.components().insertPrivateProject().getProjectDto();
- userSession.addProjectPermission(USER, project);
- call(NOTIF_MY_NEW_ISSUES, null, project.getKey(), null);
-
- call(NOTIF_MY_NEW_ISSUES, null, null, null);
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), project);
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), null);
- }
-
- @Test
- public void add_a_notification_on_private_project_when_a_global_one_exists() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- ProjectDto project = db.components().insertPrivateProject().getProjectDto();
- call(NOTIF_MY_NEW_ISSUES, null, null, null);
-
- userSession.addProjectPermission(USER, project);
- call(NOTIF_MY_NEW_ISSUES, null, project.getKey(), null);
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), project);
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), null);
- }
-
- @Test
- public void add_a_notification_on_public_project_when_a_global_one_exists() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- ProjectDto project = db.components().insertPublicProject().getProjectDto();
- userSession.registerProjects(project);
- call(NOTIF_MY_NEW_ISSUES, null, null, null);
-
- call(NOTIF_MY_NEW_ISSUES, null, project.getKey(), null);
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), project);
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, userSession.getUuid(), null);
- }
-
- @Test
- public void http_no_content() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- TestResponse result = call(NOTIF_MY_NEW_ISSUES, null, null, null);
-
- assertThat(result.getStatus()).isEqualTo(HTTP_NO_CONTENT);
- }
-
- @Test
- public void add_a_notification_to_a_user_as_system_administrator() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user).setSystemAdministrator();
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- call(NOTIF_MY_NEW_ISSUES, null, null, user.getLogin());
-
- db.notifications().assertExists(defaultChannel.getKey(), NOTIF_MY_NEW_ISSUES, user.getUuid(), null);
- }
-
- @Test
- public void fail_if_login_is_provided_and_unknown() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user).setSystemAdministrator();
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, null, "LOGIN 404"))
- .isInstanceOf(NotFoundException.class)
- .hasMessageContaining("User 'LOGIN 404' not found");
- }
-
- @Test
- public void fail_if_login_provided_and_not_system_administrator() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user).setNonSystemAdministrator();
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- String login = user.getLogin();
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, null, login))
- .isInstanceOf(ForbiddenException.class);
- }
-
- @Test
- public void fail_if_project_provided_and_not_project_user() {
- ProjectDto project = db.components().insertPrivateProject().getProjectDto();
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- String projectKey = project.getKey();
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, projectKey, null))
- .isInstanceOf(ForbiddenException.class);
- }
-
- @Test
- public void fail_when_notification_already_exists() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- call(NOTIF_MY_NEW_ISSUES, null, null, null);
-
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, null, null))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessageContaining("Notification already added");
- }
-
- @Test
- public void fail_when_unknown_channel() {
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, "Channel42", null, null))
- .isInstanceOf(IllegalArgumentException.class);
- }
-
- @Test
- public void fail_when_unknown_global_dispatcher() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- assertThatThrownBy(() -> call("Dispatcher42", null, null, null))
- .isInstanceOf(BadRequestException.class)
- .hasMessageContaining("Value of parameter 'type' (Dispatcher42) must be one of: [Dispatcher1]");
- }
-
- @Test
- public void fail_when_unknown_project_dispatcher_on_private_project() {
- ProjectData project = db.components().insertPrivateProject();
- userSession.addProjectPermission(USER, project.getProjectDto());
- when(dispatchers.getGlobalDispatchers()).thenReturn(asList(NOTIF_MY_NEW_ISSUES, NOTIF_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(asList(NOTIF_MY_NEW_ISSUES, NOTIF_NEW_ISSUES));
-
- assertThatThrownBy(() -> call("Dispatcher42", null, project.projectKey(), null))
- .isInstanceOf(BadRequestException.class)
- .hasMessageContaining("Value of parameter 'type' (Dispatcher42) must be one of: [Dispatcher1, Dispatcher2]");
- }
-
- @Test
- public void fail_when_unknown_project_dispatcher_on_public_project() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- ComponentDto project = db.components().insertPublicProject().getMainBranchComponent();
- when(dispatchers.getGlobalDispatchers()).thenReturn(asList(NOTIF_MY_NEW_ISSUES, NOTIF_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(asList(NOTIF_MY_NEW_ISSUES, NOTIF_NEW_ISSUES));
-
- String projectKey = project.getKey();
- assertThatThrownBy(() -> call("Dispatcher42", null, projectKey, null))
- .isInstanceOf(BadRequestException.class)
- .hasMessageContaining("Value of parameter 'type' (Dispatcher42) must be one of: [Dispatcher1, Dispatcher2]");
- }
-
- @Test
- public void fail_when_no_dispatcher() {
- TestRequest request = ws.newRequest();
- assertThatThrownBy(request::execute)
- .isInstanceOf(IllegalArgumentException.class);
- }
-
- @Test
- public void fail_when_project_is_unknown() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, "Project-42", null))
- .isInstanceOf(NotFoundException.class);
- }
-
- @Test
- public void fail_when_component_is_not_a_project() {
- UserDto user = db.users().insertUser();
- userSession.logIn(user);
- db.components().insertPortfolioAndSnapshot(newPortfolio().setKey("VIEW_1"));
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, "VIEW_1", null))
- .isInstanceOf(NotFoundException.class)
- .hasMessageContaining("Project 'VIEW_1' not found");
- }
-
- @Test
- public void fail_when_not_authenticated() {
- userSession.anonymous();
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
-
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, null, null))
- .isInstanceOf(UnauthorizedException.class);
- }
-
- @Test
- public void fail_when_user_does_not_have_USER_permission_on_private_project() {
- ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
- userSession.logIn().setNonSystemAdministrator();
- when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES));
- String key = project.getKey();
- String login = userSession.getLogin();
- assertThatThrownBy(() -> call(NOTIF_MY_NEW_ISSUES, null, key, login))
- .isInstanceOf(ForbiddenException.class);
- }
-
- private TestResponse call(String type, @Nullable String channel, @Nullable String project, @Nullable String login) {
- TestRequest request = ws.newRequest();
- request.setParam(PARAM_TYPE, type);
- ofNullable(channel).ifPresent(channel1 -> request.setParam(PARAM_CHANNEL, channel1));
- ofNullable(project).ifPresent(project1 -> request.setParam(PARAM_PROJECT, project1));
- ofNullable(login).ifPresent(login1 -> request.setParam(PARAM_LOGIN, login1));
- return request.execute();
- }
-
- private static class FakeNotificationChannel extends NotificationChannel {
- private final String key;
-
- private FakeNotificationChannel(String key) {
- this.key = key;
- }
-
- @Override
- public String getKey() {
- return this.key;
- }
-
- @Override
- public boolean deliver(Notification notification, String username) {
- // do nothing
- return true;
- }
- }
- }
|