You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

UsersActionIT.java 15KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2023 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.permission.ws;
  21. import java.util.Set;
  22. import org.junit.Test;
  23. import org.sonar.api.resources.Qualifiers;
  24. import org.sonar.api.resources.ResourceTypes;
  25. import org.sonar.api.server.ws.WebService.Param;
  26. import org.sonar.api.server.ws.WebService.SelectionMode;
  27. import org.sonar.api.web.UserRole;
  28. import org.sonar.db.component.BranchDto;
  29. import org.sonar.db.component.ComponentDto;
  30. import org.sonar.db.component.ProjectData;
  31. import org.sonar.db.component.ResourceTypesRule;
  32. import org.sonar.db.permission.GlobalPermission;
  33. import org.sonar.db.project.ProjectDto;
  34. import org.sonar.db.user.UserDto;
  35. import org.sonar.server.common.avatar.AvatarResolverImpl;
  36. import org.sonar.server.exceptions.BadRequestException;
  37. import org.sonar.server.exceptions.ForbiddenException;
  38. import org.sonar.server.exceptions.NotFoundException;
  39. import org.sonar.server.exceptions.UnauthorizedException;
  40. import org.sonar.server.management.ManagedInstanceService;
  41. import org.sonar.server.permission.PermissionService;
  42. import org.sonar.server.permission.PermissionServiceImpl;
  43. import org.sonar.server.permission.RequestValidator;
  44. import static java.util.function.Function.identity;
  45. import static java.util.stream.Collectors.toMap;
  46. import static org.apache.commons.lang.StringUtils.countMatches;
  47. import static org.assertj.core.api.Assertions.assertThat;
  48. import static org.assertj.core.api.Assertions.assertThatThrownBy;
  49. import static org.mockito.ArgumentMatchers.any;
  50. import static org.mockito.Mockito.mock;
  51. import static org.mockito.Mockito.when;
  52. import static org.sonar.api.server.ws.WebService.Param.PAGE;
  53. import static org.sonar.api.server.ws.WebService.Param.PAGE_SIZE;
  54. import static org.sonar.api.server.ws.WebService.Param.TEXT_QUERY;
  55. import static org.sonar.db.user.UserTesting.newUserDto;
  56. import static org.sonar.test.JsonAssert.assertJson;
  57. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION;
  58. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_ID;
  59. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_KEY;
  60. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_USER_LOGIN;
  61. public class UsersActionIT extends BasePermissionWsIT<UsersAction> {
  62. private final ResourceTypes resourceTypes = new ResourceTypesRule().setRootQualifiers(Qualifiers.PROJECT);
  63. private final PermissionService permissionService = new PermissionServiceImpl(resourceTypes);
  64. private final WsParameters wsParameters = new WsParameters(permissionService);
  65. private final RequestValidator requestValidator = new RequestValidator(permissionService);
  66. private final ManagedInstanceService managedInstanceService = mock(ManagedInstanceService.class);
  67. @Override
  68. protected UsersAction buildWsAction() {
  69. return new UsersAction(db.getDbClient(), userSession, newPermissionWsSupport(), new AvatarResolverImpl(), wsParameters, requestValidator, managedInstanceService);
  70. }
  71. @Test
  72. public void search_for_users_with_response_example() {
  73. UserDto user1 = db.users().insertUser(newUserDto().setLogin("admin").setName("Administrator").setEmail("admin@admin.com"));
  74. UserDto user2 = db.users().insertUser(newUserDto().setLogin("adam.west").setName("Adam West").setEmail("adamwest@adamwest.com"));
  75. UserDto user3 = db.users().insertUser(newUserDto().setLogin("george.orwell").setName("George Orwell").setEmail("george.orwell@1984.net"));
  76. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.ADMINISTER_QUALITY_PROFILES);
  77. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.ADMINISTER);
  78. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.ADMINISTER_QUALITY_GATES);
  79. db.users().insertGlobalPermissionOnUser(user3, GlobalPermission.SCAN);
  80. mockUsersAsManaged(user3.getUuid());
  81. loginAsAdmin();
  82. String result = newRequest().execute().getInput();
  83. assertJson(result).withStrictArrayOrder().isSimilarTo(getClass().getResource("users-example.json"));
  84. }
  85. @Test
  86. public void search_for_users_with_one_permission() {
  87. insertUsersHavingGlobalPermissions();
  88. loginAsAdmin();
  89. String result = newRequest().setParam("permission", "scan").execute().getInput();
  90. assertJson(result).withStrictArrayOrder().isSimilarTo(getClass().getResource("UsersActionIT/users.json"));
  91. }
  92. @Test
  93. public void search_for_users_with_permission_on_project() {
  94. // User has permission on project
  95. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  96. UserDto user = db.users().insertUser(newUserDto());
  97. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  98. // User has permission on another project
  99. ProjectDto anotherProject = db.components().insertPrivateProject().getProjectDto();
  100. UserDto userHavePermissionOnAnotherProject = db.users().insertUser(newUserDto());
  101. db.users().insertProjectPermissionOnUser(userHavePermissionOnAnotherProject, UserRole.ISSUE_ADMIN, anotherProject);
  102. // User has no permission
  103. UserDto withoutPermission = db.users().insertUser(newUserDto());
  104. userSession.logIn().addProjectPermission(GlobalPermission.ADMINISTER.getKey(), project);
  105. String result = newRequest()
  106. .setParam(PARAM_PERMISSION, UserRole.ISSUE_ADMIN)
  107. .setParam(PARAM_PROJECT_ID, project.getUuid())
  108. .execute()
  109. .getInput();
  110. assertThat(result).contains(user.getLogin())
  111. .doesNotContain(userHavePermissionOnAnotherProject.getLogin())
  112. .doesNotContain(withoutPermission.getLogin());
  113. }
  114. @Test
  115. public void search_also_for_users_without_permission_when_filtering_name() {
  116. // User with permission on project
  117. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  118. UserDto user = db.users().insertUser(newUserDto("with-permission-login", "with-permission-name", "with-permission-email"));
  119. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  120. // User without permission
  121. UserDto withoutPermission = db.users().insertUser(newUserDto("without-permission-login", "without-permission-name", "without-permission-email"));
  122. UserDto anotherUser = db.users().insertUser(newUserDto("another-user", "another-user", "another-user"));
  123. loginAsAdmin();
  124. String result = newRequest()
  125. .setParam(PARAM_PROJECT_ID, project.getUuid())
  126. .setParam(TEXT_QUERY, "with")
  127. .execute()
  128. .getInput();
  129. assertThat(result).contains(user.getLogin(), withoutPermission.getLogin()).doesNotContain(anotherUser.getLogin());
  130. }
  131. @Test
  132. public void search_also_for_users_without_permission_when_filtering_email() {
  133. // User with permission on project
  134. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  135. UserDto user = db.users().insertUser(newUserDto("with-permission-login", "with-permission-name", "with-permission-email"));
  136. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  137. // User without permission
  138. UserDto withoutPermission = db.users().insertUser(newUserDto("without-permission-login", "without-permission-name", "without-permission-email"));
  139. UserDto anotherUser = db.users().insertUser(newUserDto("another-user", "another-user", "another-user"));
  140. loginAsAdmin();
  141. String result = newRequest().setParam(PARAM_PROJECT_ID, project.getUuid()).setParam(TEXT_QUERY, "email").execute().getInput();
  142. assertThat(result).contains(user.getLogin(), withoutPermission.getLogin()).doesNotContain(anotherUser.getLogin());
  143. }
  144. @Test
  145. public void search_also_for_users_without_permission_when_filtering_login() {
  146. // User with permission on project
  147. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  148. UserDto user = db.users().insertUser(newUserDto("with-permission-login", "with-permission-name", "with-permission-email"));
  149. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  150. // User without permission
  151. UserDto withoutPermission = db.users().insertUser(newUserDto("without-permission-login", "without-permission-name", "without-permission-email"));
  152. UserDto anotherUser = db.users().insertUser(newUserDto("another-user", "another-user", "another-user"));
  153. loginAsAdmin();
  154. String result = newRequest().setParam(PARAM_PROJECT_ID, project.getUuid()).setParam(TEXT_QUERY, "login").execute().getInput();
  155. assertThat(result).contains(user.getLogin(), withoutPermission.getLogin()).doesNotContain(anotherUser.getLogin());
  156. }
  157. @Test
  158. public void search_for_users_with_query_as_a_parameter() {
  159. insertUsersHavingGlobalPermissions();
  160. loginAsAdmin();
  161. String result = newRequest()
  162. .setParam("permission", "scan")
  163. .setParam(TEXT_QUERY, "ame-1")
  164. .execute()
  165. .getInput();
  166. assertThat(result).contains("login-1")
  167. .doesNotContain("login-2")
  168. .doesNotContain("login-3");
  169. }
  170. @Test
  171. public void search_for_users_with_select_as_a_parameter() {
  172. insertUsersHavingGlobalPermissions();
  173. loginAsAdmin();
  174. String result = newRequest()
  175. .execute()
  176. .getInput();
  177. assertThat(result).contains("login-1", "login-2", "login-3");
  178. }
  179. @Test
  180. public void search_for_users_is_paginated() {
  181. for (int i = 9; i >= 0; i--) {
  182. UserDto user = db.users().insertUser(newUserDto().setName("user-" + i));
  183. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.ADMINISTER);
  184. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.ADMINISTER_QUALITY_GATES);
  185. }
  186. loginAsAdmin();
  187. assertJson(newRequest().setParam(PAGE, "1").setParam(PAGE_SIZE, "2").execute().getInput()).withStrictArrayOrder().isSimilarTo("{\n" +
  188. " \"paging\": {\n" +
  189. " \"pageIndex\": 1,\n" +
  190. " \"pageSize\": 2,\n" +
  191. " \"total\": 10\n" +
  192. " },\n" +
  193. " \"users\": [\n" +
  194. " {\n" +
  195. " \"name\": \"user-0\"\n" +
  196. " },\n" +
  197. " {\n" +
  198. " \"name\": \"user-1\"\n" +
  199. " }\n" +
  200. " ]\n" +
  201. "}");
  202. assertJson(newRequest().setParam(PAGE, "3").setParam(PAGE_SIZE, "4").execute().getInput()).withStrictArrayOrder().isSimilarTo("{\n" +
  203. " \"paging\": {\n" +
  204. " \"pageIndex\": 3,\n" +
  205. " \"pageSize\": 4,\n" +
  206. " \"total\": 10\n" +
  207. " },\n" +
  208. " \"users\": [\n" +
  209. " {\n" +
  210. " \"name\": \"user-8\"\n" +
  211. " },\n" +
  212. " {\n" +
  213. " \"name\": \"user-9\"\n" +
  214. " }\n" +
  215. " ]\n" +
  216. "}");
  217. }
  218. @Test
  219. public void return_more_than_20_permissions() {
  220. loginAsAdmin();
  221. for (int i = 0; i < 30; i++) {
  222. UserDto user = db.users().insertUser(newUserDto().setLogin("user-" + i));
  223. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.SCAN);
  224. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.PROVISION_PROJECTS);
  225. }
  226. String result = newRequest()
  227. .setParam(PAGE_SIZE, "100")
  228. .execute()
  229. .getInput();
  230. assertThat(countMatches(result, "scan")).isEqualTo(30);
  231. }
  232. @Test
  233. public void fail_if_project_permission_without_project() {
  234. loginAsAdmin();
  235. assertThatThrownBy(() -> {
  236. newRequest()
  237. .setParam(PARAM_PERMISSION, UserRole.ISSUE_ADMIN)
  238. .setParam(Param.SELECTED, SelectionMode.ALL.value())
  239. .execute();
  240. })
  241. .isInstanceOf(BadRequestException.class);
  242. }
  243. @Test
  244. public void fail_if_insufficient_privileges() {
  245. userSession.logIn("login");
  246. assertThatThrownBy(() -> {
  247. newRequest()
  248. .setParam("permission", GlobalPermission.ADMINISTER.getKey())
  249. .execute();
  250. })
  251. .isInstanceOf(ForbiddenException.class);
  252. }
  253. @Test
  254. public void fail_if_not_logged_in() {
  255. userSession.anonymous();
  256. assertThatThrownBy(() -> {
  257. newRequest()
  258. .setParam("permission", GlobalPermission.ADMINISTER.getKey())
  259. .execute();
  260. })
  261. .isInstanceOf(UnauthorizedException.class);
  262. }
  263. @Test
  264. public void fail_if_project_uuid_and_project_key_are_provided() {
  265. ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
  266. loginAsAdmin();
  267. assertThatThrownBy(() -> newRequest()
  268. .setParam(PARAM_PERMISSION, GlobalPermission.ADMINISTER.getKey())
  269. .setParam(PARAM_PROJECT_ID, project.uuid())
  270. .setParam(PARAM_PROJECT_KEY, project.getKey())
  271. .execute())
  272. .isInstanceOf(BadRequestException.class)
  273. .hasMessage("Project id or project key can be provided, not both.");
  274. }
  275. @Test
  276. public void fail_if_search_query_is_too_short() {
  277. loginAsAdmin();
  278. assertThatThrownBy(() -> newRequest().setParam(TEXT_QUERY, "ab").execute())
  279. .isInstanceOf(IllegalArgumentException.class)
  280. .hasMessage("'q' length (2) is shorter than the minimum authorized (3)");
  281. }
  282. @Test
  283. public void fail_when_using_branch_uuid() {
  284. UserDto user = db.users().insertUser(newUserDto());
  285. ProjectData project = db.components().insertPublicProject();
  286. BranchDto branch = db.components().insertProjectBranch(project.getProjectDto());
  287. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project.getProjectDto());
  288. userSession.logIn().addProjectPermission(UserRole.ADMIN, project.getProjectDto());
  289. assertThatThrownBy(() -> {
  290. newRequest()
  291. .setParam(PARAM_PROJECT_ID, branch.getUuid())
  292. .setParam(PARAM_USER_LOGIN, user.getLogin())
  293. .setParam(PARAM_PERMISSION, GlobalPermission.ADMINISTER.getKey())
  294. .execute();
  295. })
  296. .isInstanceOf(NotFoundException.class)
  297. .hasMessage("Entity not found");
  298. }
  299. private void insertUsersHavingGlobalPermissions() {
  300. UserDto user1 = db.users().insertUser(newUserDto("login-1", "name-1", "email-1"));
  301. UserDto user2 = db.users().insertUser(newUserDto("login-2", "name-2", "email-2"));
  302. UserDto user3 = db.users().insertUser(newUserDto("login-3", "name-3", "email-3"));
  303. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.SCAN);
  304. db.users().insertGlobalPermissionOnUser(user2, GlobalPermission.SCAN);
  305. db.users().insertGlobalPermissionOnUser(user3, GlobalPermission.ADMINISTER);
  306. mockUsersAsManaged(user1.getUuid());
  307. }
  308. private void mockUsersAsManaged(String... userUuids) {
  309. when(managedInstanceService.getUserUuidToManaged(any(), any())).thenAnswer(invocation ->
  310. {
  311. Set<?> allUsersUuids = invocation.getArgument(1, Set.class);
  312. return allUsersUuids.stream()
  313. .map(userUuid -> (String) userUuid)
  314. .collect(toMap(identity(), userUuid -> Set.of(userUuids).contains(userUuid)));
  315. }
  316. );
  317. }
  318. }