You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

BuiltInQProfileRepositoryImplTest.java 8.2KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2019 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.qualityprofile;
  21. import java.util.ArrayList;
  22. import java.util.Collections;
  23. import java.util.List;
  24. import org.junit.Rule;
  25. import org.junit.Test;
  26. import org.junit.rules.ExpectedException;
  27. import org.sonar.api.resources.Language;
  28. import org.sonar.api.resources.Languages;
  29. import org.sonar.api.server.profile.BuiltInQualityProfilesDefinition;
  30. import org.sonar.api.utils.System2;
  31. import org.sonar.db.DbClient;
  32. import org.sonar.db.DbTester;
  33. import org.sonar.server.language.LanguageTesting;
  34. import static java.util.Arrays.asList;
  35. import static org.assertj.core.api.Assertions.assertThat;
  36. import static org.assertj.core.groups.Tuple.tuple;
  37. import static org.mockito.Mockito.mock;
  38. public class BuiltInQProfileRepositoryImplTest {
  39. private static final Language FOO_LANGUAGE = LanguageTesting.newLanguage("foo", "foo", "foo");
  40. private static final String SONAR_WAY_QP_NAME = "Sonar way";
  41. @Rule
  42. public ExpectedException expectedException = ExpectedException.none();
  43. @Rule
  44. public DbTester dbTester = DbTester.create(System2.INSTANCE);
  45. private DbClient dbClient = dbTester.getDbClient();
  46. @Test
  47. public void get_throws_ISE_if_called_before_initialize() {
  48. BuiltInQProfileRepositoryImpl underTest = new BuiltInQProfileRepositoryImpl(mock(DbClient.class), new Languages());
  49. expectedException.expect(IllegalStateException.class);
  50. expectedException.expectMessage("initialize must be called first");
  51. underTest.get();
  52. }
  53. @Test
  54. public void initialize_throws_ISE_if_called_twice() {
  55. BuiltInQProfileRepositoryImpl underTest = new BuiltInQProfileRepositoryImpl(mock(DbClient.class), new Languages());
  56. underTest.initialize();
  57. expectedException.expect(IllegalStateException.class);
  58. expectedException.expectMessage("initialize must be called only once");
  59. underTest.initialize();
  60. }
  61. @Test
  62. public void initialize_throws_ISE_if_language_has_no_builtin_qp() {
  63. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(mock(DbClient.class), new Languages(FOO_LANGUAGE));
  64. expectedException.expect(IllegalStateException.class);
  65. expectedException.expectMessage("The following languages have no built-in quality profiles: foo");
  66. underTest.initialize();
  67. }
  68. @Test
  69. public void initialize_creates_no_BuiltInQProfile_when_all_definitions_apply_to_non_defined_languages() {
  70. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(mock(DbClient.class), new Languages(), new DummyProfileDefinition("foo", "P1", false));
  71. underTest.initialize();
  72. assertThat(underTest.get()).isEmpty();
  73. }
  74. @Test
  75. public void initialize_makes_single_profile_of_a_language_default_even_if_not_flagged_as_so() {
  76. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(dbClient, new Languages(FOO_LANGUAGE), new DummyProfileDefinition("foo", "foo1", false));
  77. underTest.initialize();
  78. assertThat(underTest.get())
  79. .extracting(BuiltInQProfile::getLanguage, BuiltInQProfile::isDefault)
  80. .containsExactly(tuple(FOO_LANGUAGE.getKey(), true));
  81. }
  82. @Test
  83. public void initialize_makes_single_profile_of_a_language_default_even_if_flagged_as_so() {
  84. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(dbClient, new Languages(FOO_LANGUAGE), new DummyProfileDefinition("foo", "foo1", true));
  85. underTest.initialize();
  86. assertThat(underTest.get())
  87. .extracting(BuiltInQProfile::getLanguage, BuiltInQProfile::isDefault)
  88. .containsExactly(tuple(FOO_LANGUAGE.getKey(), true));
  89. }
  90. @Test
  91. public void initialize_makes_first_profile_of_a_language_default_when_none_flagged_as_so() {
  92. List<DummyProfileDefinition> definitions = new ArrayList<>(
  93. asList(new DummyProfileDefinition("foo", "foo1", false), new DummyProfileDefinition("foo", "foo2", false)));
  94. Collections.shuffle(definitions);
  95. String firstName = definitions.get(0).getName();
  96. String secondName = definitions.get(1).getName();
  97. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(dbClient, new Languages(FOO_LANGUAGE), definitions.toArray(new BuiltInQualityProfilesDefinition[0]));
  98. underTest.initialize();
  99. assertThat(underTest.get())
  100. .extracting(BuiltInQProfile::getName, BuiltInQProfile::isDefault)
  101. .containsExactlyInAnyOrder(tuple(firstName, true), tuple(secondName, false));
  102. }
  103. @Test
  104. public void initialize_fails_with_ISE_when_two_profiles_with_different_name_are_default_for_the_same_language() {
  105. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(dbClient, new Languages(FOO_LANGUAGE),
  106. new DummyProfileDefinition("foo", "foo1", true), new DummyProfileDefinition("foo", "foo2", true));
  107. expectedException.expect(IllegalStateException.class);
  108. expectedException.expectMessage("Several Quality profiles are flagged as default for the language foo: [foo1, foo2]");
  109. underTest.initialize();
  110. }
  111. @Test
  112. public void initialize_creates_profile_Sonar_Way_as_default_if_none_other_is_defined_default_for_a_given_language() {
  113. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(
  114. dbClient, new Languages(FOO_LANGUAGE),
  115. new DummyProfileDefinition("foo", "doh", false), new DummyProfileDefinition("foo", "boo", false),
  116. new DummyProfileDefinition("foo", SONAR_WAY_QP_NAME, false), new DummyProfileDefinition("foo", "goo", false));
  117. underTest.initialize();
  118. assertThat(underTest.get())
  119. .filteredOn(b -> FOO_LANGUAGE.getKey().equals(b.getLanguage()))
  120. .filteredOn(BuiltInQProfile::isDefault)
  121. .extracting(BuiltInQProfile::getName)
  122. .containsExactly(SONAR_WAY_QP_NAME);
  123. }
  124. @Test
  125. public void initialize_does_not_create_Sonar_Way_as_default_if_other_profile_is_defined_as_default() {
  126. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(
  127. dbClient, new Languages(FOO_LANGUAGE),
  128. new DummyProfileDefinition("foo", SONAR_WAY_QP_NAME, false), new DummyProfileDefinition("foo", "goo", true));
  129. underTest.initialize();
  130. assertThat(underTest.get())
  131. .filteredOn(b -> FOO_LANGUAGE.getKey().equals(b.getLanguage()))
  132. .filteredOn(BuiltInQProfile::isDefault)
  133. .extracting(BuiltInQProfile::getName)
  134. .containsExactly("goo");
  135. }
  136. @Test
  137. public void initialize_matches_Sonar_Way_default_with_case_sensitivity() {
  138. String sonarWayInOtherCase = SONAR_WAY_QP_NAME.toUpperCase();
  139. BuiltInQProfileRepository underTest = new BuiltInQProfileRepositoryImpl(
  140. dbClient, new Languages(FOO_LANGUAGE),
  141. new DummyProfileDefinition("foo", "goo", false), new DummyProfileDefinition("foo", sonarWayInOtherCase, false));
  142. underTest.initialize();
  143. assertThat(underTest.get())
  144. .filteredOn(b -> FOO_LANGUAGE.getKey().equals(b.getLanguage()))
  145. .filteredOn(BuiltInQProfile::isDefault)
  146. .extracting(BuiltInQProfile::getName)
  147. .containsExactly("goo");
  148. }
  149. private static final class DummyProfileDefinition implements BuiltInQualityProfilesDefinition {
  150. private final String language;
  151. private final String name;
  152. private final boolean defaultProfile;
  153. private DummyProfileDefinition(String language, String name, boolean defaultProfile) {
  154. this.language = language;
  155. this.name = name;
  156. this.defaultProfile = defaultProfile;
  157. }
  158. @Override
  159. public void define(Context context) {
  160. context.createBuiltInQualityProfile(name, language)
  161. .setDefault(defaultProfile).done();
  162. }
  163. String getName() {
  164. return name;
  165. }
  166. }
  167. }