123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383 |
- /*
- * SonarQube
- * Copyright (C) 2009-2020 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.permission.ws;
-
- import org.junit.Before;
- import org.junit.Test;
- import org.sonar.api.resources.Qualifiers;
- import org.sonar.api.resources.ResourceTypes;
- import org.sonar.api.web.UserRole;
- import org.sonar.db.component.ComponentDto;
- import org.sonar.db.component.ResourceTypesRule;
- import org.sonar.db.user.UserDto;
- import org.sonar.server.exceptions.BadRequestException;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.exceptions.NotFoundException;
- import org.sonar.server.exceptions.ServerException;
- import org.sonar.server.permission.PermissionService;
- import org.sonar.server.permission.PermissionServiceImpl;
-
- import static java.lang.String.format;
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.sonar.api.web.UserRole.ADMIN;
- import static org.sonar.api.web.UserRole.CODEVIEWER;
- import static org.sonar.api.web.UserRole.ISSUE_ADMIN;
- import static org.sonar.api.web.UserRole.USER;
- import static org.sonar.core.permission.GlobalPermissions.PROVISIONING;
- import static org.sonar.core.permission.GlobalPermissions.QUALITY_GATE_ADMIN;
- import static org.sonar.core.permission.GlobalPermissions.SYSTEM_ADMIN;
- import static org.sonar.db.component.ComponentTesting.newDirectory;
- import static org.sonar.db.component.ComponentTesting.newFileDto;
- import static org.sonar.db.component.ComponentTesting.newModuleDto;
- import static org.sonar.db.component.ComponentTesting.newSubView;
- import static org.sonar.db.permission.OrganizationPermission.ADMINISTER;
- import static org.sonar.db.permission.OrganizationPermission.ADMINISTER_QUALITY_GATES;
- import static org.sonar.db.permission.OrganizationPermission.PROVISION_PROJECTS;
- import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION;
- import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_ID;
- import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_KEY;
- import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_USER_LOGIN;
-
- public class RemoveUserActionTest extends BasePermissionWsTest<RemoveUserAction> {
-
- private static final String A_PROJECT_UUID = "project-uuid";
- private static final String A_PROJECT_KEY = "project-key";
- private static final String A_LOGIN = "ray.bradbury";
-
- private UserDto user;
- private ResourceTypes resourceTypes = new ResourceTypesRule().setRootQualifiers(Qualifiers.PROJECT);
- private PermissionService permissionService = new PermissionServiceImpl(resourceTypes);
- private WsParameters wsParameters = new WsParameters(permissionService);
-
- @Before
- public void setUp() {
- user = db.users().insertUser(A_LOGIN);
- }
-
- @Override
- protected RemoveUserAction buildWsAction() {
- return new RemoveUserAction(db.getDbClient(), userSession, newPermissionUpdater(), newPermissionWsSupport(), wsParameters, permissionService);
- }
-
- @Test
- public void remove_permission_from_user() {
- db.users().insertPermissionOnUser(user, PROVISION_PROJECTS);
- db.users().insertPermissionOnUser(user, ADMINISTER_QUALITY_GATES);
- loginAsAdmin();
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, QUALITY_GATE_ADMIN)
- .execute();
-
- assertThat(db.users().selectPermissionsOfUser(user)).containsOnly(PROVISION_PROJECTS);
- }
-
- @Test
- public void fail_to_remove_admin_permission_if_last_admin() {
- db.users().insertPermissionOnUser(user, ADMINISTER);
- loginAsAdmin();
-
- expectedException.expect(BadRequestException.class);
- expectedException.expectMessage("Last user with permission 'admin'. Permission cannot be removed.");
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, ADMIN)
- .execute();
- }
-
- @Test
- public void remove_permission_from_project() {
- ComponentDto project = db.components().insertPrivateProject();
- db.users().insertProjectPermissionOnUser(user, CODEVIEWER, project);
- db.users().insertProjectPermissionOnUser(user, ISSUE_ADMIN, project);
- loginAsAdmin();
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, project.uuid())
- .setParam(PARAM_PERMISSION, CODEVIEWER)
- .execute();
-
- assertThat(db.users().selectProjectPermissionsOfUser(user, project)).containsOnly(ISSUE_ADMIN);
- }
-
- @Test
- public void remove_with_project_key() {
- ComponentDto project = db.components().insertPrivateProject();
- db.users().insertProjectPermissionOnUser(user, ISSUE_ADMIN, project);
- db.users().insertProjectPermissionOnUser(user, CODEVIEWER, project);
- loginAsAdmin();
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_KEY, project.getDbKey())
- .setParam(PARAM_PERMISSION, ISSUE_ADMIN)
- .execute();
-
- assertThat(db.users().selectProjectPermissionsOfUser(user, project)).containsOnly(CODEVIEWER);
- }
-
- @Test
- public void remove_with_view_uuid() {
- ComponentDto view = db.components().insertView();
- db.users().insertProjectPermissionOnUser(user, ISSUE_ADMIN, view);
- db.users().insertProjectPermissionOnUser(user, ADMIN, view);
- loginAsAdmin();
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_KEY, view.getDbKey())
- .setParam(PARAM_PERMISSION, ISSUE_ADMIN)
- .execute();
-
- assertThat(db.users().selectProjectPermissionsOfUser(user, view)).containsOnly(ADMIN);
- }
-
- @Test
- public void fail_when_project_does_not_exist() {
- loginAsAdmin();
-
- expectedException.expect(NotFoundException.class);
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, "unknown-project-uuid")
- .setParam(PARAM_PERMISSION, ISSUE_ADMIN)
- .execute();
- }
-
- @Test
- public void fail_when_project_permission_without_permission() {
- loginAsAdmin();
-
- expectedException.expect(BadRequestException.class);
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, ISSUE_ADMIN)
- .execute();
- }
-
- @Test
- public void fail_when_component_is_a_module() {
- ComponentDto project = db.components().insertPrivateProject();
- ComponentDto module = db.components().insertComponent(newModuleDto(project));
-
- failIfComponentIsNotAProjectOrView(module);
- }
-
- @Test
- public void fail_when_component_is_a_directory() {
- ComponentDto project = db.components().insertPrivateProject();
- ComponentDto file = db.components().insertComponent(newDirectory(project, "A/B"));
-
- failIfComponentIsNotAProjectOrView(file);
- }
-
- @Test
- public void fail_when_component_is_a_file() {
- ComponentDto project = db.components().insertPrivateProject();
- ComponentDto file = db.components().insertComponent(newFileDto(project, null, "file-uuid"));
-
- failIfComponentIsNotAProjectOrView(file);
- }
-
- @Test
- public void fail_when_component_is_a_subview() {
- ComponentDto portfolio = db.components().insertPrivatePortfolio();
- ComponentDto file = db.components().insertComponent(newSubView(portfolio));
-
- failIfComponentIsNotAProjectOrView(file);
- }
-
- private void failIfComponentIsNotAProjectOrView(ComponentDto file) {
- loginAsAdmin();
-
- expectedException.expect(BadRequestException.class);
- expectedException.expectMessage("Component '" + file.getDbKey() + "' (id: " + file.uuid() + ") must be a project or a view.");
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, file.uuid())
- .setParam(PARAM_PERMISSION, SYSTEM_ADMIN)
- .execute();
- }
-
- @Test
- public void fail_when_get_request() {
- loginAsAdmin();
-
- expectedException.expect(ServerException.class);
-
- newRequest()
- .setMethod("GET")
- .setParam(PARAM_USER_LOGIN, "george.orwell")
- .setParam(PARAM_PERMISSION, SYSTEM_ADMIN)
- .execute();
- }
-
- @Test
- public void fail_when_user_login_is_missing() {
- loginAsAdmin();
-
- expectedException.expect(IllegalArgumentException.class);
-
- newRequest()
- .setParam(PARAM_PERMISSION, SYSTEM_ADMIN)
- .execute();
- }
-
- @Test
- public void fail_when_permission_is_missing() {
- loginAsAdmin();
-
- expectedException.expect(IllegalArgumentException.class);
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .execute();
- }
-
- @Test
- public void fail_when_project_uuid_and_project_key_are_provided() {
- ComponentDto project = db.components().insertPrivateProject();
- loginAsAdmin();
-
- expectedException.expect(BadRequestException.class);
- expectedException.expectMessage("Project id or project key can be provided, not both.");
-
- newRequest()
- .setParam(PARAM_PERMISSION, SYSTEM_ADMIN)
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, project.uuid())
- .setParam(PARAM_PROJECT_KEY, project.getDbKey())
- .execute();
- }
-
- @Test
- public void removing_global_permission_fails_if_not_system_administrator() {
- userSession.logIn();
-
- expectedException.expect(ForbiddenException.class);
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, PROVISIONING)
- .execute();
- }
-
- @Test
- public void removing_project_permission_fails_if_not_administrator_of_project() {
- ComponentDto project = db.components().insertPrivateProject();
- userSession.logIn();
-
- expectedException.expect(ForbiddenException.class);
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, ISSUE_ADMIN)
- .setParam(PARAM_PROJECT_KEY, project.getDbKey())
- .execute();
- }
-
- /**
- * User is project administrator but not system administrator
- */
- @Test
- public void removing_project_permission_is_allowed_to_project_administrators() {
- ComponentDto project = db.components().insertPrivateProject();
- db.users().insertProjectPermissionOnUser(user, CODEVIEWER, project);
- db.users().insertProjectPermissionOnUser(user, ISSUE_ADMIN, project);
- userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, project.uuid())
- .setParam(PARAM_PERMISSION, ISSUE_ADMIN)
- .execute();
-
- assertThat(db.users().selectProjectPermissionsOfUser(user, project)).containsOnly(CODEVIEWER);
- }
-
- @Test
- public void fail_when_removing_USER_permission_on_a_public_project() {
- ComponentDto project = db.components().insertPublicProject();
- userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
-
- expectedException.expect(BadRequestException.class);
- expectedException.expectMessage("Permission user can't be removed from a public component");
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, project.uuid())
- .setParam(PARAM_PERMISSION, USER)
- .execute();
- }
-
- @Test
- public void fail_when_removing_CODEVIEWER_permission_on_a_public_project() {
- ComponentDto project = db.components().insertPublicProject();
- userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
-
- expectedException.expect(BadRequestException.class);
- expectedException.expectMessage("Permission codeviewer can't be removed from a public component");
-
- newRequest()
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PROJECT_ID, project.uuid())
- .setParam(PARAM_PERMISSION, CODEVIEWER)
- .execute();
- }
-
- @Test
- public void fail_when_using_branch_db_key() {
- ComponentDto project = db.components().insertPublicProject();
- userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
- ComponentDto branch = db.components().insertProjectBranch(project);
-
- expectedException.expect(NotFoundException.class);
- expectedException.expectMessage(format("Project key '%s' not found", branch.getDbKey()));
-
- newRequest()
- .setParam(PARAM_PROJECT_KEY, branch.getDbKey())
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, SYSTEM_ADMIN)
- .execute();
- }
-
- @Test
- public void fail_when_using_branch_uuid() {
- ComponentDto project = db.components().insertPublicProject();
- userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
- ComponentDto branch = db.components().insertProjectBranch(project);
-
- expectedException.expect(NotFoundException.class);
- expectedException.expectMessage(format("Project id '%s' not found", branch.uuid()));
-
- newRequest()
- .setParam(PARAM_PROJECT_ID, branch.uuid())
- .setParam(PARAM_USER_LOGIN, user.getLogin())
- .setParam(PARAM_PERMISSION, SYSTEM_ADMIN)
- .execute();
- }
-
- }
|