You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

PersistFileSourcesStepTest.java 19KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2021 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.ce.task.projectanalysis.source;
  21. import java.util.Arrays;
  22. import java.util.Collections;
  23. import java.util.List;
  24. import java.util.function.Consumer;
  25. import org.apache.commons.codec.digest.DigestUtils;
  26. import org.junit.Before;
  27. import org.junit.Rule;
  28. import org.junit.Test;
  29. import org.mockito.Mockito;
  30. import org.sonar.api.utils.System2;
  31. import org.sonar.ce.task.projectanalysis.component.Component;
  32. import org.sonar.ce.task.projectanalysis.component.FileAttributes;
  33. import org.sonar.ce.task.projectanalysis.component.ReportComponent;
  34. import org.sonar.ce.task.projectanalysis.component.TreeRootHolderRule;
  35. import org.sonar.ce.task.projectanalysis.scm.Changeset;
  36. import org.sonar.ce.task.projectanalysis.step.BaseStepTest;
  37. import org.sonar.ce.task.step.ComputationStep;
  38. import org.sonar.ce.task.step.TestComputationStepContext;
  39. import org.sonar.core.util.SequenceUuidFactory;
  40. import org.sonar.core.util.Uuids;
  41. import org.sonar.db.DbClient;
  42. import org.sonar.db.DbSession;
  43. import org.sonar.db.DbTester;
  44. import org.sonar.db.protobuf.DbFileSources;
  45. import org.sonar.db.source.FileSourceDto;
  46. import org.sonar.db.source.LineHashVersion;
  47. import static org.assertj.core.api.Assertions.assertThat;
  48. import static org.mockito.Mockito.mock;
  49. import static org.mockito.Mockito.verify;
  50. import static org.mockito.Mockito.when;
  51. public class PersistFileSourcesStepTest extends BaseStepTest {
  52. private static final int FILE1_REF = 3;
  53. private static final String PROJECT_UUID = "PROJECT";
  54. private static final String PROJECT_KEY = "PROJECT_KEY";
  55. private static final String FILE1_UUID = "FILE1";
  56. private static final long NOW = 123456789L;
  57. private static final long PAST = 15000L;
  58. private System2 system2 = mock(System2.class);
  59. @Rule
  60. public DbTester dbTester = DbTester.create(system2);
  61. @Rule
  62. public TreeRootHolderRule treeRootHolder = new TreeRootHolderRule();
  63. private SourceLinesHashRepository sourceLinesHashRepository = mock(SourceLinesHashRepository.class);
  64. private SourceLinesHashRepositoryImpl.LineHashesComputer lineHashesComputer = mock(SourceLinesHashRepositoryImpl.LineHashesComputer.class);
  65. private FileSourceDataComputer fileSourceDataComputer = mock(FileSourceDataComputer.class);
  66. private FileSourceDataWarnings fileSourceDataWarnings = mock(FileSourceDataWarnings.class);
  67. private DbClient dbClient = dbTester.getDbClient();
  68. private DbSession session = dbTester.getSession();
  69. private PersistFileSourcesStep underTest;
  70. @Before
  71. public void setup() {
  72. when(system2.now()).thenReturn(NOW);
  73. when(sourceLinesHashRepository.getLineHashesComputerToPersist(Mockito.any(Component.class))).thenReturn(lineHashesComputer);
  74. underTest = new PersistFileSourcesStep(dbClient, system2, treeRootHolder, sourceLinesHashRepository, fileSourceDataComputer, fileSourceDataWarnings, new SequenceUuidFactory());
  75. initBasicReport(1);
  76. }
  77. @Override
  78. protected ComputationStep step() {
  79. return underTest;
  80. }
  81. @Test
  82. public void persist_sources() {
  83. List<String> lineHashes = Arrays.asList("137f72c3708c6bd0de00a0e5a69c699b", "e6251bcf1a7dc3ba5e7933e325bbe605");
  84. String sourceHash = "ee5a58024a155466b43bc559d953e018";
  85. DbFileSources.Data fileSourceData = DbFileSources.Data.newBuilder()
  86. .addAllLines(Arrays.asList(
  87. DbFileSources.Line.newBuilder().setSource("line1").setLine(1).build(),
  88. DbFileSources.Line.newBuilder().setSource("line2").setLine(2).build()))
  89. .build();
  90. when(fileSourceDataComputer.compute(fileComponent().build(), fileSourceDataWarnings))
  91. .thenReturn(new FileSourceDataComputer.Data(fileSourceData, lineHashes, sourceHash, null));
  92. underTest.execute(new TestComputationStepContext());
  93. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  94. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  95. assertThat(fileSourceDto.getProjectUuid()).isEqualTo(PROJECT_UUID);
  96. assertThat(fileSourceDto.getFileUuid()).isEqualTo(FILE1_UUID);
  97. assertThat(fileSourceDto.getBinaryData()).isNotEmpty();
  98. assertThat(fileSourceDto.getDataHash()).isNotEmpty();
  99. assertThat(fileSourceDto.getLineHashesVersion()).isEqualTo(LineHashVersion.WITHOUT_SIGNIFICANT_CODE.getDbValue());
  100. assertThat(fileSourceDto.getLineHashes()).isNotEmpty();
  101. assertThat(fileSourceDto.getCreatedAt()).isEqualTo(NOW);
  102. assertThat(fileSourceDto.getUpdatedAt()).isEqualTo(NOW);
  103. DbFileSources.Data data = fileSourceDto.getSourceData();
  104. assertThat(data.getLinesCount()).isEqualTo(2);
  105. assertThat(data.getLines(0).getLine()).isOne();
  106. assertThat(data.getLines(0).getSource()).isEqualTo("line1");
  107. assertThat(data.getLines(1).getLine()).isEqualTo(2);
  108. assertThat(data.getLines(1).getSource()).isEqualTo("line2");
  109. verify(fileSourceDataWarnings).commitWarnings();
  110. }
  111. @Test
  112. public void persist_source_hashes() {
  113. List<String> lineHashes = Arrays.asList("137f72c3708c6bd0de00a0e5a69c699b", "e6251bcf1a7dc3ba5e7933e325bbe605");
  114. String sourceHash = "ee5a58024a155466b43bc559d953e018";
  115. setComputedData(DbFileSources.Data.newBuilder().build(), lineHashes, sourceHash, null);
  116. underTest.execute(new TestComputationStepContext());
  117. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  118. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  119. assertThat(fileSourceDto.getLineHashes()).containsExactly("137f72c3708c6bd0de00a0e5a69c699b", "e6251bcf1a7dc3ba5e7933e325bbe605");
  120. assertThat(fileSourceDto.getSrcHash()).isEqualTo("ee5a58024a155466b43bc559d953e018");
  121. verify(fileSourceDataWarnings).commitWarnings();
  122. }
  123. @Test
  124. public void persist_coverage() {
  125. DbFileSources.Data dbData = DbFileSources.Data.newBuilder().addLines(
  126. DbFileSources.Line.newBuilder()
  127. .setConditions(10)
  128. .setCoveredConditions(2)
  129. .setLineHits(1)
  130. .setLine(1)
  131. .build())
  132. .build();
  133. setComputedData(dbData);
  134. underTest.execute(new TestComputationStepContext());
  135. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  136. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  137. assertThat(fileSourceDto.getSourceData()).isEqualTo(dbData);
  138. verify(fileSourceDataWarnings).commitWarnings();
  139. }
  140. private ReportComponent.Builder fileComponent() {
  141. return ReportComponent.builder(Component.Type.FILE, FILE1_REF).setUuid(FILE1_UUID).setKey("PROJECT_KEY" + ":src/Foo.java");
  142. }
  143. @Test
  144. public void persist_scm() {
  145. DbFileSources.Data dbData = DbFileSources.Data.newBuilder().addLines(
  146. DbFileSources.Line.newBuilder()
  147. .setScmAuthor("john")
  148. .setScmDate(123456789L)
  149. .setScmRevision("rev-1")
  150. .build())
  151. .build();
  152. setComputedData(dbData);
  153. underTest.execute(new TestComputationStepContext());
  154. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  155. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  156. assertThat(fileSourceDto.getSourceData()).isEqualTo(dbData);
  157. assertThat(fileSourceDto.getRevision()).isNull();
  158. verify(fileSourceDataWarnings).commitWarnings();
  159. }
  160. @Test
  161. public void persist_scm_some_lines() {
  162. DbFileSources.Data dbData = DbFileSources.Data.newBuilder().addAllLines(Arrays.asList(
  163. DbFileSources.Line.newBuilder()
  164. .setScmAuthor("john")
  165. .setScmDate(123456789L)
  166. .setScmRevision("rev-1")
  167. .build(),
  168. DbFileSources.Line.newBuilder()
  169. .setScmDate(223456789L)
  170. .build(),
  171. DbFileSources.Line.newBuilder()
  172. .build()))
  173. .build();
  174. setComputedData(dbData);
  175. underTest.execute(new TestComputationStepContext());
  176. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  177. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  178. DbFileSources.Data data = fileSourceDto.getSourceData();
  179. assertThat(data.getLinesList()).hasSize(3);
  180. assertThat(data.getLines(0).getScmAuthor()).isEqualTo("john");
  181. assertThat(data.getLines(0).getScmDate()).isEqualTo(123456789L);
  182. assertThat(data.getLines(0).getScmRevision()).isEqualTo("rev-1");
  183. assertThat(data.getLines(1).getScmAuthor()).isEmpty();
  184. assertThat(data.getLines(1).getScmDate()).isEqualTo(223456789L);
  185. assertThat(data.getLines(1).getScmRevision()).isEmpty();
  186. assertThat(data.getLines(2).getScmAuthor()).isEmpty();
  187. assertThat(data.getLines(2).getScmDate()).isZero();
  188. assertThat(data.getLines(2).getScmRevision()).isEmpty();
  189. verify(fileSourceDataWarnings).commitWarnings();
  190. }
  191. @Test
  192. public void persist_highlighting() {
  193. DbFileSources.Data dbData = DbFileSources.Data.newBuilder().addLines(
  194. DbFileSources.Line.newBuilder()
  195. .setHighlighting("2,4,a")
  196. .build())
  197. .build();
  198. setComputedData(dbData);
  199. underTest.execute(new TestComputationStepContext());
  200. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  201. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  202. DbFileSources.Data data = fileSourceDto.getSourceData();
  203. assertThat(data).isEqualTo(dbData);
  204. assertThat(data.getLinesList()).hasSize(1);
  205. assertThat(data.getLines(0).getHighlighting()).isEqualTo("2,4,a");
  206. verify(fileSourceDataWarnings).commitWarnings();
  207. }
  208. @Test
  209. public void persist_symbols() {
  210. DbFileSources.Data dbData = DbFileSources.Data.newBuilder().addAllLines(Arrays.asList(
  211. DbFileSources.Line.newBuilder()
  212. .setSymbols("2,4,1")
  213. .build(),
  214. DbFileSources.Line.newBuilder().build(),
  215. DbFileSources.Line.newBuilder()
  216. .setSymbols("1,3,1")
  217. .build()))
  218. .build();
  219. setComputedData(dbData);
  220. underTest.execute(new TestComputationStepContext());
  221. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  222. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  223. assertThat(fileSourceDto.getSourceData()).isEqualTo(dbData);
  224. verify(fileSourceDataWarnings).commitWarnings();
  225. }
  226. @Test
  227. public void persist_duplication() {
  228. DbFileSources.Data dbData = DbFileSources.Data.newBuilder().addLines(
  229. DbFileSources.Line.newBuilder()
  230. .addDuplication(2)
  231. .build())
  232. .build();
  233. setComputedData(dbData);
  234. underTest.execute(new TestComputationStepContext());
  235. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  236. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  237. assertThat(fileSourceDto.getSourceData()).isEqualTo(dbData);
  238. verify(fileSourceDataWarnings).commitWarnings();
  239. }
  240. @Test
  241. public void save_revision() {
  242. Changeset latest = Changeset.newChangesetBuilder().setDate(0L).setRevision("rev-1").build();
  243. setComputedData(DbFileSources.Data.newBuilder().build(), Collections.singletonList("lineHashes"), "srcHash", latest);
  244. underTest.execute(new TestComputationStepContext());
  245. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  246. assertThat(fileSourceDto.getRevision()).isEqualTo("rev-1");
  247. verify(fileSourceDataWarnings).commitWarnings();
  248. }
  249. @Test
  250. public void not_save_revision() {
  251. setComputedData(DbFileSources.Data.newBuilder().build());
  252. underTest.execute(new TestComputationStepContext());
  253. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  254. assertThat(fileSourceDto.getRevision()).isNull();
  255. verify(fileSourceDataWarnings).commitWarnings();
  256. }
  257. @Test
  258. public void not_update_sources_when_nothing_has_changed() {
  259. dbClient.fileSourceDao().insert(dbTester.getSession(), createDto());
  260. dbTester.getSession().commit();
  261. Changeset changeset = Changeset.newChangesetBuilder().setDate(1L).setRevision("rev-1").build();
  262. setComputedData(DbFileSources.Data.newBuilder().build(), Collections.singletonList("lineHash"), "sourceHash", changeset);
  263. underTest.execute(new TestComputationStepContext());
  264. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  265. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  266. assertThat(fileSourceDto.getSrcHash()).isEqualTo("sourceHash");
  267. assertThat(fileSourceDto.getLineHashes()).isEqualTo(Collections.singletonList("lineHash"));
  268. assertThat(fileSourceDto.getCreatedAt()).isEqualTo(PAST);
  269. assertThat(fileSourceDto.getUpdatedAt()).isEqualTo(PAST);
  270. verify(fileSourceDataWarnings).commitWarnings();
  271. }
  272. @Test
  273. public void update_sources_when_source_updated() {
  274. // Existing sources
  275. long past = 150000L;
  276. dbClient.fileSourceDao().insert(dbTester.getSession(), new FileSourceDto()
  277. .setUuid(Uuids.createFast())
  278. .setProjectUuid(PROJECT_UUID)
  279. .setFileUuid(FILE1_UUID)
  280. .setSrcHash("5b4bd9815cdb17b8ceae19eb1810c34c")
  281. .setLineHashes(Collections.singletonList("6438c669e0d0de98e6929c2cc0fac474"))
  282. .setDataHash("6cad150e3d065976c230cddc5a09efaa")
  283. .setSourceData(DbFileSources.Data.newBuilder()
  284. .addLines(DbFileSources.Line.newBuilder()
  285. .setLine(1)
  286. .setSource("old line")
  287. .build())
  288. .build())
  289. .setCreatedAt(past)
  290. .setUpdatedAt(past)
  291. .setRevision("rev-0"));
  292. dbTester.getSession().commit();
  293. DbFileSources.Data newSourceData = DbFileSources.Data.newBuilder()
  294. .addLines(DbFileSources.Line.newBuilder()
  295. .setLine(1)
  296. .setSource("old line")
  297. .setScmDate(123456789L)
  298. .setScmRevision("rev-1")
  299. .setScmAuthor("john")
  300. .build())
  301. .build();
  302. Changeset changeset = Changeset.newChangesetBuilder().setDate(1L).setRevision("rev-1").build();
  303. setComputedData(newSourceData, Collections.singletonList("6438c669e0d0de98e6929c2cc0fac474"), "5b4bd9815cdb17b8ceae19eb1810c34c", changeset);
  304. underTest.execute(new TestComputationStepContext());
  305. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  306. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  307. assertThat(fileSourceDto.getCreatedAt()).isEqualTo(past);
  308. assertThat(fileSourceDto.getUpdatedAt()).isEqualTo(NOW);
  309. assertThat(fileSourceDto.getRevision()).isEqualTo("rev-1");
  310. verify(fileSourceDataWarnings).commitWarnings();
  311. }
  312. @Test
  313. public void update_sources_when_src_hash_is_missing() {
  314. dbClient.fileSourceDao().insert(dbTester.getSession(), createDto(dto -> dto.setSrcHash(null)));
  315. dbTester.getSession().commit();
  316. DbFileSources.Data sourceData = DbFileSources.Data.newBuilder().build();
  317. setComputedData(sourceData, Collections.singletonList("lineHash"), "newSourceHash", null);
  318. underTest.execute(new TestComputationStepContext());
  319. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  320. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  321. assertThat(fileSourceDto.getCreatedAt()).isEqualTo(PAST);
  322. assertThat(fileSourceDto.getUpdatedAt()).isEqualTo(NOW);
  323. assertThat(fileSourceDto.getSrcHash()).isEqualTo("newSourceHash");
  324. verify(fileSourceDataWarnings).commitWarnings();
  325. }
  326. @Test
  327. public void update_sources_when_revision_is_missing() {
  328. DbFileSources.Data sourceData = DbFileSources.Data.newBuilder()
  329. .addLines(DbFileSources.Line.newBuilder()
  330. .setLine(1)
  331. .setSource("line")
  332. .build())
  333. .build();
  334. dbClient.fileSourceDao().insert(dbTester.getSession(), createDto(dto -> dto.setRevision(null)));
  335. dbTester.getSession().commit();
  336. Changeset changeset = Changeset.newChangesetBuilder().setDate(1L).setRevision("revision").build();
  337. setComputedData(sourceData, Collections.singletonList("137f72c3708c6bd0de00a0e5a69c699b"), "29f25900140c94db38035128cb6de6a2", changeset);
  338. underTest.execute(new TestComputationStepContext());
  339. assertThat(dbTester.countRowsOfTable("file_sources")).isOne();
  340. FileSourceDto fileSourceDto = dbClient.fileSourceDao().selectByFileUuid(session, FILE1_UUID);
  341. assertThat(fileSourceDto.getCreatedAt()).isEqualTo(PAST);
  342. assertThat(fileSourceDto.getUpdatedAt()).isEqualTo(NOW);
  343. assertThat(fileSourceDto.getRevision()).isEqualTo("revision");
  344. verify(fileSourceDataWarnings).commitWarnings();
  345. }
  346. private FileSourceDto createDto() {
  347. return createDto(dto -> {
  348. });
  349. }
  350. private FileSourceDto createDto(Consumer<FileSourceDto> modifier) {
  351. DbFileSources.Data sourceData = DbFileSources.Data.newBuilder().build();
  352. byte[] data = FileSourceDto.encodeSourceData(sourceData);
  353. String dataHash = DigestUtils.md5Hex(data);
  354. FileSourceDto dto = new FileSourceDto()
  355. .setUuid(Uuids.createFast())
  356. .setProjectUuid(PROJECT_UUID)
  357. .setFileUuid(FILE1_UUID)
  358. .setSrcHash("sourceHash")
  359. .setLineHashes(Collections.singletonList("lineHash"))
  360. .setDataHash(dataHash)
  361. .setRevision("rev-1")
  362. .setSourceData(sourceData)
  363. .setCreatedAt(PAST)
  364. .setUpdatedAt(PAST);
  365. modifier.accept(dto);
  366. return dto;
  367. }
  368. private void setComputedData(DbFileSources.Data data, List<String> lineHashes, String sourceHash, Changeset latestChangeWithRevision) {
  369. FileSourceDataComputer.Data computedData = new FileSourceDataComputer.Data(data, lineHashes, sourceHash, latestChangeWithRevision);
  370. when(fileSourceDataComputer.compute(fileComponent().build(), fileSourceDataWarnings)).thenReturn(computedData);
  371. }
  372. private void setComputedData(DbFileSources.Data data) {
  373. FileSourceDataComputer.Data computedData = new FileSourceDataComputer.Data(data, Collections.emptyList(), "", null);
  374. when(fileSourceDataComputer.compute(fileComponent().build(), fileSourceDataWarnings)).thenReturn(computedData);
  375. }
  376. private void initBasicReport(int numberOfLines) {
  377. ReportComponent root = ReportComponent.builder(Component.Type.PROJECT, 1).setUuid(PROJECT_UUID).setKey(PROJECT_KEY).addChildren(
  378. fileComponent().setFileAttributes(new FileAttributes(false, null, numberOfLines)).build())
  379. .build();
  380. treeRootHolder.setRoots(root, root);
  381. }
  382. }