123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590 |
- /*
- * SonarQube
- * Copyright (C) 2009-2024 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.ce.task.projectanalysis.issue;
-
- import com.google.gson.Gson;
- import java.util.Arrays;
- import java.util.LinkedHashMap;
- import java.util.List;
- import java.util.Map;
- import java.util.Set;
- import javax.annotation.Nullable;
- import org.assertj.core.data.MapEntry;
- import org.junit.jupiter.api.Test;
- import org.junit.jupiter.api.extension.RegisterExtension;
- import org.sonar.api.issue.impact.Severity;
- import org.sonar.api.issue.impact.SoftwareQuality;
- import org.sonar.api.rules.RuleType;
- import org.sonar.ce.task.projectanalysis.batch.BatchReportReaderRule;
- import org.sonar.ce.task.projectanalysis.component.Component;
- import org.sonar.ce.task.projectanalysis.component.TreeRootHolderRule;
- import org.sonar.ce.task.projectanalysis.measure.Measure;
- import org.sonar.ce.task.projectanalysis.measure.MeasureRepoEntry;
- import org.sonar.ce.task.projectanalysis.measure.MeasureRepositoryRule;
- import org.sonar.ce.task.projectanalysis.metric.MetricRepositoryRule;
- import org.sonar.core.issue.DefaultIssue;
- import org.sonar.db.rule.RuleTesting;
- import org.sonar.server.measure.ImpactMeasureBuilder;
-
- import static java.util.Arrays.stream;
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.assertj.core.api.Assertions.entry;
- import static org.mockito.ArgumentMatchers.any;
- import static org.mockito.ArgumentMatchers.eq;
- import static org.mockito.Mockito.mock;
- import static org.mockito.Mockito.when;
- import static org.sonar.api.issue.Issue.RESOLUTION_FALSE_POSITIVE;
- import static org.sonar.api.issue.Issue.RESOLUTION_FIXED;
- import static org.sonar.api.issue.Issue.RESOLUTION_WONT_FIX;
- import static org.sonar.api.issue.Issue.STATUS_CLOSED;
- import static org.sonar.api.issue.Issue.STATUS_CONFIRMED;
- import static org.sonar.api.issue.Issue.STATUS_OPEN;
- import static org.sonar.api.issue.Issue.STATUS_RESOLVED;
- import static org.sonar.api.issue.impact.Severity.HIGH;
- import static org.sonar.api.issue.impact.Severity.LOW;
- import static org.sonar.api.issue.impact.Severity.MEDIUM;
- import static org.sonar.api.measures.CoreMetrics.ACCEPTED_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.ACCEPTED_ISSUES_KEY;
- import static org.sonar.api.measures.CoreMetrics.BLOCKER_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.BLOCKER_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.BUGS;
- import static org.sonar.api.measures.CoreMetrics.BUGS_KEY;
- import static org.sonar.api.measures.CoreMetrics.CODE_SMELLS;
- import static org.sonar.api.measures.CoreMetrics.CODE_SMELLS_KEY;
- import static org.sonar.api.measures.CoreMetrics.CONFIRMED_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.CONFIRMED_ISSUES_KEY;
- import static org.sonar.api.measures.CoreMetrics.CRITICAL_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.CRITICAL_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.FALSE_POSITIVE_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.FALSE_POSITIVE_ISSUES_KEY;
- import static org.sonar.api.measures.CoreMetrics.HIGH_IMPACT_ACCEPTED_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.HIGH_IMPACT_ACCEPTED_ISSUES_KEY;
- import static org.sonar.api.measures.CoreMetrics.INFO_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.MAINTAINABILITY_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.MAJOR_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.MAJOR_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.MINOR_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_ACCEPTED_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.NEW_ACCEPTED_ISSUES_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_BLOCKER_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_BLOCKER_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_BUGS;
- import static org.sonar.api.measures.CoreMetrics.NEW_BUGS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_CODE_SMELLS;
- import static org.sonar.api.measures.CoreMetrics.NEW_CODE_SMELLS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_CRITICAL_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_CRITICAL_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_INFO_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_MAINTAINABILITY_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.NEW_MAJOR_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_MAJOR_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_MINOR_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_RELIABILITY_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.NEW_SECURITY_HOTSPOTS;
- import static org.sonar.api.measures.CoreMetrics.NEW_SECURITY_HOTSPOTS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_SECURITY_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.NEW_VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.NEW_VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.NEW_VULNERABILITIES;
- import static org.sonar.api.measures.CoreMetrics.NEW_VULNERABILITIES_KEY;
- import static org.sonar.api.measures.CoreMetrics.OPEN_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.OPEN_ISSUES_KEY;
- import static org.sonar.api.measures.CoreMetrics.RELIABILITY_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.REOPENED_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.SECURITY_HOTSPOTS;
- import static org.sonar.api.measures.CoreMetrics.SECURITY_HOTSPOTS_KEY;
- import static org.sonar.api.measures.CoreMetrics.SECURITY_ISSUES;
- import static org.sonar.api.measures.CoreMetrics.VIOLATIONS;
- import static org.sonar.api.measures.CoreMetrics.VIOLATIONS_KEY;
- import static org.sonar.api.measures.CoreMetrics.VULNERABILITIES;
- import static org.sonar.api.measures.CoreMetrics.VULNERABILITIES_KEY;
- import static org.sonar.api.rule.Severity.BLOCKER;
- import static org.sonar.api.rule.Severity.CRITICAL;
- import static org.sonar.api.rule.Severity.MAJOR;
- import static org.sonar.api.rules.RuleType.BUG;
- import static org.sonar.api.rules.RuleType.CODE_SMELL;
- import static org.sonar.api.rules.RuleType.SECURITY_HOTSPOT;
- import static org.sonar.ce.task.projectanalysis.component.ReportComponent.builder;
- import static org.sonar.ce.task.projectanalysis.issue.IssueCounter.IMPACT_TO_METRIC_KEY;
- import static org.sonar.ce.task.projectanalysis.issue.IssueCounter.IMPACT_TO_NEW_METRIC_KEY;
- import static org.sonar.ce.task.projectanalysis.measure.Measure.newMeasureBuilder;
- import static org.sonar.ce.task.projectanalysis.measure.MeasureRepoEntry.entryOf;
-
- class IssueCounterTest {
-
- private static final Component FILE1 = builder(Component.Type.FILE, 1).build();
- private static final Component FILE2 = builder(Component.Type.FILE, 2).build();
- private static final Component FILE3 = builder(Component.Type.FILE, 3).build();
- private static final Component PROJECT = builder(Component.Type.PROJECT, 4).addChildren(FILE1, FILE2, FILE3).build();
-
- @RegisterExtension
- private final BatchReportReaderRule reportReader = new BatchReportReaderRule();
-
- @RegisterExtension
- private final TreeRootHolderRule treeRootHolder = new TreeRootHolderRule();
-
- @RegisterExtension
- private final MetricRepositoryRule metricRepository = new MetricRepositoryRule()
- .add(VIOLATIONS)
- .add(OPEN_ISSUES)
- .add(REOPENED_ISSUES)
- .add(CONFIRMED_ISSUES)
- .add(BLOCKER_VIOLATIONS)
- .add(CRITICAL_VIOLATIONS)
- .add(MAJOR_VIOLATIONS)
- .add(MINOR_VIOLATIONS)
- .add(INFO_VIOLATIONS)
- .add(NEW_VIOLATIONS)
- .add(NEW_BLOCKER_VIOLATIONS)
- .add(NEW_CRITICAL_VIOLATIONS)
- .add(NEW_MAJOR_VIOLATIONS)
- .add(NEW_MINOR_VIOLATIONS)
- .add(NEW_INFO_VIOLATIONS)
- .add(FALSE_POSITIVE_ISSUES)
- .add(ACCEPTED_ISSUES)
- .add(CODE_SMELLS)
- .add(BUGS)
- .add(VULNERABILITIES)
- .add(SECURITY_HOTSPOTS)
- .add(NEW_CODE_SMELLS)
- .add(NEW_BUGS)
- .add(NEW_VULNERABILITIES)
- .add(NEW_SECURITY_HOTSPOTS)
- .add(NEW_ACCEPTED_ISSUES)
- .add(HIGH_IMPACT_ACCEPTED_ISSUES)
- .add(RELIABILITY_ISSUES)
- .add(MAINTAINABILITY_ISSUES)
- .add(SECURITY_ISSUES)
- .add(NEW_RELIABILITY_ISSUES)
- .add(NEW_MAINTAINABILITY_ISSUES)
- .add(NEW_SECURITY_ISSUES);
-
- @RegisterExtension
- private final MeasureRepositoryRule measureRepository = MeasureRepositoryRule.create(treeRootHolder, metricRepository);
- private final NewIssueClassifier newIssueClassifier = mock(NewIssueClassifier.class);
- private final IssueCounter underTest = new IssueCounter(metricRepository, measureRepository, newIssueClassifier);
- private static int issueCounter;
-
- @Test
- void count_issues_by_status() {
- // bottom-up traversal -> from files to project
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, BLOCKER));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_FIXED, STATUS_CLOSED, MAJOR));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_FALSE_POSITIVE, STATUS_RESOLVED, MAJOR));
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(FILE2);
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, BLOCKER));
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, MAJOR));
- underTest.afterComponent(FILE2);
-
- underTest.beforeComponent(FILE3);
- // Security hotspot should be ignored
- underTest.onIssue(FILE3, createSecurityHotspot().setStatus(STATUS_OPEN));
- underTest.afterComponent(FILE3);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertMeasures(FILE1, entry(VIOLATIONS_KEY, 1), entry(OPEN_ISSUES_KEY, 1), entry(CONFIRMED_ISSUES_KEY, 0));
- assertMeasures(FILE2, entry(VIOLATIONS_KEY, 2), entry(OPEN_ISSUES_KEY, 0), entry(CONFIRMED_ISSUES_KEY, 2));
- assertMeasures(FILE3, entry(VIOLATIONS_KEY, 0));
- assertMeasures(PROJECT, entry(VIOLATIONS_KEY, 3), entry(OPEN_ISSUES_KEY, 1), entry(CONFIRMED_ISSUES_KEY, 2));
- }
-
- @Test
- void count_issues_by_resolution() {
- // bottom-up traversal -> from files to project
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, BLOCKER));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_FIXED, STATUS_CLOSED, MAJOR));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_FALSE_POSITIVE, STATUS_RESOLVED, MAJOR));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, MAJOR));
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(FILE2);
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, BLOCKER));
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, MAJOR));
- underTest.onIssue(FILE2, createIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, MAJOR));
- underTest.afterComponent(FILE2);
-
- underTest.beforeComponent(FILE3);
- // Security hotspot should be ignored
- underTest.onIssue(FILE3, createSecurityHotspot().setResolution(RESOLUTION_WONT_FIX));
- underTest.afterComponent(FILE3);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertMeasures(FILE1, entry(VIOLATIONS_KEY, 1), entry(FALSE_POSITIVE_ISSUES_KEY, 1), entry(ACCEPTED_ISSUES_KEY, 1));
- assertMeasures(FILE2, entry(VIOLATIONS_KEY, 2), entry(FALSE_POSITIVE_ISSUES_KEY, 0), entry(ACCEPTED_ISSUES_KEY, 1));
- assertMeasures(FILE3, entry(VIOLATIONS_KEY, 0));
- assertMeasures(PROJECT, entry(VIOLATIONS_KEY, 3), entry(FALSE_POSITIVE_ISSUES_KEY, 1), entry(ACCEPTED_ISSUES_KEY, 2));
- }
-
- @Test
- void count_unresolved_issues_by_severity() {
- // bottom-up traversal -> from files to project
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, BLOCKER));
- // this resolved issue is ignored
- underTest.onIssue(FILE1, createIssue(RESOLUTION_FIXED, STATUS_CLOSED, MAJOR));
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(FILE2);
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, BLOCKER));
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, MAJOR));
- underTest.afterComponent(FILE2);
-
- underTest.beforeComponent(PROJECT);
- // Security hotspot should be ignored
- underTest.onIssue(FILE3, createSecurityHotspot().setSeverity(MAJOR));
- underTest.afterComponent(PROJECT);
-
- assertMeasures(FILE1, entry(BLOCKER_VIOLATIONS_KEY, 1), entry(CRITICAL_VIOLATIONS_KEY, 0), entry(MAJOR_VIOLATIONS_KEY, 0));
- assertMeasures(FILE2, entry(BLOCKER_VIOLATIONS_KEY, 1), entry(CRITICAL_VIOLATIONS_KEY, 0), entry(MAJOR_VIOLATIONS_KEY, 1));
- assertMeasures(PROJECT, entry(BLOCKER_VIOLATIONS_KEY, 2), entry(CRITICAL_VIOLATIONS_KEY, 0), entry(MAJOR_VIOLATIONS_KEY, 1));
- }
-
- @Test
- void count_unresolved_issues_by_type() {
- // bottom-up traversal -> from files to project
- // file1 : one open code smell, one closed code smell (which will be excluded from metric)
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, BLOCKER).setType(CODE_SMELL));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_FIXED, STATUS_CLOSED, MAJOR).setType(CODE_SMELL));
- underTest.afterComponent(FILE1);
-
- // file2 : one bug
- underTest.beforeComponent(FILE2);
- underTest.onIssue(FILE2, createIssue(null, STATUS_CONFIRMED, BLOCKER).setType(BUG));
- underTest.afterComponent(FILE2);
-
- // file3 : one unresolved security hotspot
- underTest.beforeComponent(FILE3);
- underTest.onIssue(FILE3, createSecurityHotspot());
- underTest.onIssue(FILE3, createSecurityHotspot().setResolution(RESOLUTION_WONT_FIX).setStatus(STATUS_CLOSED));
- underTest.afterComponent(FILE3);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertMeasures(FILE1, entry(CODE_SMELLS_KEY, 1), entry(BUGS_KEY, 0), entry(VULNERABILITIES_KEY, 0), entry(SECURITY_HOTSPOTS_KEY, 0));
- assertMeasures(FILE2, entry(CODE_SMELLS_KEY, 0), entry(BUGS_KEY, 1), entry(VULNERABILITIES_KEY, 0), entry(SECURITY_HOTSPOTS_KEY, 0));
- assertMeasures(FILE3, entry(CODE_SMELLS_KEY, 0), entry(BUGS_KEY, 0), entry(VULNERABILITIES_KEY, 0), entry(SECURITY_HOTSPOTS_KEY, 1));
- assertMeasures(PROJECT, entry(CODE_SMELLS_KEY, 1), entry(BUGS_KEY, 1), entry(VULNERABILITIES_KEY, 0), entry(SECURITY_HOTSPOTS_KEY, 1));
- }
-
- @Test
- void count_new_issues() {
- when(newIssueClassifier.isEnabled()).thenReturn(true);
-
- underTest.beforeComponent(FILE1);
- // created before -> existing issues (so ignored)
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, BLOCKER).setType(CODE_SMELL));
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, BLOCKER).setType(BUG));
-
- // created after -> 4 new issues but 1 is closed
- underTest.onIssue(FILE1, createNewIssue(null, STATUS_OPEN, CRITICAL).setType(CODE_SMELL));
- underTest.onIssue(FILE1, createNewIssue(null, STATUS_OPEN, CRITICAL).setType(BUG));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_FIXED, STATUS_CLOSED, MAJOR).setType(BUG));
- underTest.onIssue(FILE1, createNewSecurityHotspot());
- underTest.onIssue(FILE1, createNewSecurityHotspot().setResolution(RESOLUTION_WONT_FIX).setStatus(STATUS_CLOSED));
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(FILE2);
- underTest.afterComponent(FILE2);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertIntValue(FILE1, entry(NEW_VIOLATIONS_KEY, 2), entry(NEW_CRITICAL_VIOLATIONS_KEY, 2), entry(NEW_BLOCKER_VIOLATIONS_KEY, 0), entry(NEW_MAJOR_VIOLATIONS_KEY, 0),
- entry(NEW_CODE_SMELLS_KEY, 1), entry(NEW_BUGS_KEY, 1), entry(NEW_VULNERABILITIES_KEY, 0), entry(NEW_SECURITY_HOTSPOTS_KEY, 1));
- assertIntValue(PROJECT, entry(NEW_VIOLATIONS_KEY, 2), entry(NEW_CRITICAL_VIOLATIONS_KEY, 2), entry(NEW_BLOCKER_VIOLATIONS_KEY, 0), entry(NEW_MAJOR_VIOLATIONS_KEY, 0),
- entry(NEW_CODE_SMELLS_KEY, 1), entry(NEW_BUGS_KEY, 1), entry(NEW_VULNERABILITIES_KEY, 0), entry(NEW_SECURITY_HOTSPOTS_KEY, 1));
- }
-
- @Test
- void count_new_accepted_issues() {
- when(newIssueClassifier.isEnabled()).thenReturn(true);
-
- underTest.beforeComponent(FILE1);
- // created before -> existing issues (so ignored)
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, CRITICAL));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, CRITICAL));
-
- // created after -> 2 accepted, 1 open, 1 hotspot
- underTest.onIssue(FILE1, createNewIssue(null, STATUS_OPEN, CRITICAL));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, CRITICAL));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, CRITICAL));
- underTest.onIssue(FILE1, createNewSecurityHotspot());
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertIntValue(FILE1, entry(NEW_VIOLATIONS_KEY, 1), entry(NEW_ACCEPTED_ISSUES_KEY, 2), entry(NEW_SECURITY_HOTSPOTS_KEY, 1));
- assertIntValue(PROJECT, entry(NEW_VIOLATIONS_KEY, 1), entry(NEW_ACCEPTED_ISSUES_KEY, 2), entry(NEW_SECURITY_HOTSPOTS_KEY, 1));
- }
-
- @Test
- void onIssue_shouldCountOverallSoftwareQualitiesMeasures() {
- when(newIssueClassifier.isEnabled()).thenReturn(true);
-
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, HIGH));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, MEDIUM));
-
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, SoftwareQuality.MAINTAINABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, MEDIUM));
-
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, HIGH));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, MEDIUM));
-
- underTest.onIssue(FILE1, createNewSecurityHotspot());
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- Set<Map.Entry<String, Measure>> entries = measureRepository.getRawMeasures(FILE1).entrySet();
-
- assertOverallSoftwareQualityMeasures(SoftwareQuality.MAINTAINABILITY, getImpactMeasure(4, 2, 2, 0), entries);
- assertOverallSoftwareQualityMeasures(SoftwareQuality.SECURITY, getImpactMeasure(2, 1, 1, 0), entries);
- assertOverallSoftwareQualityMeasures(SoftwareQuality.RELIABILITY, getImpactMeasure(0, 0, 0, 0), entries);
- }
-
- @Test
- void onIssue_shouldCountNewSoftwareQualitiesMeasures() {
- when(newIssueClassifier.isEnabled()).thenReturn(true);
-
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, SoftwareQuality.MAINTAINABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.MAINTAINABILITY, MEDIUM));
-
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.RELIABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.RELIABILITY, LOW));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, SoftwareQuality.RELIABILITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.RELIABILITY, MEDIUM));
-
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, MEDIUM));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, LOW));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, SoftwareQuality.SECURITY, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_OPEN, SoftwareQuality.SECURITY, MEDIUM));
-
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- Set<Map.Entry<String, Measure>> entries = measureRepository.getRawMeasures(FILE1).entrySet();
-
- assertNewSoftwareQualityMeasures(SoftwareQuality.MAINTAINABILITY, getImpactMeasure(2, 1, 1, 0), entries);
- assertNewSoftwareQualityMeasures(SoftwareQuality.RELIABILITY, getImpactMeasure(2, 0, 1, 1), entries);
- assertNewSoftwareQualityMeasures(SoftwareQuality.SECURITY, getImpactMeasure(4, 2, 1, 1), entries);
- }
-
- private static Map<String, Long> getImpactMeasure(long total, long high, long medium, long low) {
- Map<String, Long> map = new LinkedHashMap<>();
- map.put(LOW.name(), low);
- map.put(MEDIUM.name(), medium);
- map.put(HIGH.name(), high);
- map.put(ImpactMeasureBuilder.TOTAL_KEY, total);
- return map;
- }
-
- private void assertOverallSoftwareQualityMeasures(SoftwareQuality softwareQuality, Map<? extends String, Long> expectedMap,
- Set<Map.Entry<String, Measure>> actualRaw) {
- assertSoftwareQualityMeasures(softwareQuality, expectedMap, actualRaw, IMPACT_TO_METRIC_KEY);
- }
-
- private void assertNewSoftwareQualityMeasures(SoftwareQuality softwareQuality, Map<? extends String, Long> expectedMap,
- Set<Map.Entry<String, Measure>> actualRaw) {
- assertSoftwareQualityMeasures(softwareQuality, expectedMap, actualRaw, IMPACT_TO_NEW_METRIC_KEY);
- }
-
- private void assertSoftwareQualityMeasures(SoftwareQuality softwareQuality, Map<? extends String, Long> expectedMap,
- Set<Map.Entry<String, Measure>> actualRaw, Map<String, String> impactToMetricMap) {
-
- Map.Entry<String, Measure> softwareQualityMap = actualRaw.stream()
- .filter(e -> e.getKey().equals(impactToMetricMap.get(softwareQuality.name())))
- .findFirst()
- .get();
-
- assertThat(softwareQualityMap.getValue().getData()).isEqualTo(new Gson().toJson(expectedMap));
- }
-
- @Test
- void count_high_impact_accepted_issues() {
- when(newIssueClassifier.isEnabled()).thenReturn(true);
-
- underTest.beforeComponent(FILE1);
- // created before -> existing issues with 1 high impact accepted
- underTest.onIssue(FILE1, createIssue(null, STATUS_OPEN, HIGH));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, HIGH));
- underTest.onIssue(FILE1, createIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, MEDIUM));
-
- // created after -> 2 high impact accepted
- underTest.onIssue(FILE1, createNewIssue(null, STATUS_OPEN, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, HIGH));
- underTest.onIssue(FILE1, createNewIssue(RESOLUTION_WONT_FIX, STATUS_RESOLVED, MEDIUM));
- underTest.onIssue(FILE1, createNewSecurityHotspot());
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertIntValue(FILE1, entry(VIOLATIONS_KEY, 2), entry(NEW_VIOLATIONS_KEY, 1), entry(NEW_ACCEPTED_ISSUES_KEY, 3),
- entry(HIGH_IMPACT_ACCEPTED_ISSUES_KEY, 3));
- assertIntValue(PROJECT, entry(VIOLATIONS_KEY, 2), entry(NEW_VIOLATIONS_KEY, 1), entry(NEW_ACCEPTED_ISSUES_KEY, 3),
- entry(HIGH_IMPACT_ACCEPTED_ISSUES_KEY, 3));
- }
-
- @Test
- void exclude_hotspots_from_issue_counts() {
- // bottom-up traversal -> from files to project
- underTest.beforeComponent(FILE1);
- underTest.onIssue(FILE1, createSecurityHotspot());
- underTest.onIssue(FILE1, createSecurityHotspot());
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(FILE2);
- underTest.onIssue(FILE2, createSecurityHotspot());
- underTest.afterComponent(FILE2);
-
- underTest.beforeComponent(FILE3);
- underTest.afterComponent(FILE3);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertMeasures(FILE1, entry(VIOLATIONS_KEY, 0), entry(OPEN_ISSUES_KEY, 0), entry(CONFIRMED_ISSUES_KEY, 0));
- assertMeasures(FILE2, entry(VIOLATIONS_KEY, 0), entry(OPEN_ISSUES_KEY, 0), entry(CONFIRMED_ISSUES_KEY, 0));
- assertMeasures(FILE3, entry(VIOLATIONS_KEY, 0));
- assertMeasures(PROJECT, entry(VIOLATIONS_KEY, 0), entry(OPEN_ISSUES_KEY, 0), entry(CONFIRMED_ISSUES_KEY, 0));
- }
-
- @Test
- void exclude_new_hotspots_from_issue_counts() {
- when(newIssueClassifier.isEnabled()).thenReturn(true);
-
- underTest.beforeComponent(FILE1);
- // created before -> existing issues (so ignored)
- underTest.onIssue(FILE1, createSecurityHotspot());
- underTest.onIssue(FILE1, createSecurityHotspot());
-
- // created after, but closed
- underTest.onIssue(FILE1, createNewSecurityHotspot().setStatus(STATUS_RESOLVED).setResolution(RESOLUTION_WONT_FIX));
-
- for (String severity : Arrays.asList(CRITICAL, BLOCKER, MAJOR)) {
- DefaultIssue issue = createNewSecurityHotspot();
- issue.setSeverity(severity);
- underTest.onIssue(FILE1, issue);
- }
- underTest.afterComponent(FILE1);
-
- underTest.beforeComponent(FILE2);
- underTest.afterComponent(FILE2);
-
- underTest.beforeComponent(PROJECT);
- underTest.afterComponent(PROJECT);
-
- assertIntValue(FILE1, entry(NEW_VIOLATIONS_KEY, 0), entry(NEW_CRITICAL_VIOLATIONS_KEY, 0), entry(NEW_BLOCKER_VIOLATIONS_KEY, 0), entry(NEW_MAJOR_VIOLATIONS_KEY, 0),
- entry(NEW_VULNERABILITIES_KEY, 0));
- assertIntValue(PROJECT, entry(NEW_VIOLATIONS_KEY, 0), entry(NEW_CRITICAL_VIOLATIONS_KEY, 0), entry(NEW_BLOCKER_VIOLATIONS_KEY, 0), entry(NEW_MAJOR_VIOLATIONS_KEY, 0),
- entry(NEW_VULNERABILITIES_KEY, 0));
- }
-
- @SafeVarargs
- private void assertIntValue(Component componentRef, MapEntry<String, Integer>... entries) {
- assertThat(measureRepository.getRawMeasures(componentRef).entrySet()
- .stream()
- .filter(e -> e.getValue().getValueType() == Measure.ValueType.INT)
- .map(e -> entry(e.getKey(), e.getValue().getIntValue())))
- .contains(entries);
- }
-
- @SafeVarargs
- private void assertMeasures(Component componentRef, Map.Entry<String, Integer>... entries) {
- List<MeasureRepoEntry> expected = stream(entries)
- .map(e -> entryOf(e.getKey(), newMeasureBuilder().create(e.getValue())))
- .toList();
-
- assertThat(measureRepository.getRawMeasures(componentRef).entrySet().stream().map(e -> entryOf(e.getKey(), e.getValue())))
- .containsAll(expected);
- }
-
- private DefaultIssue createNewIssue(@Nullable String resolution, String status, String severity) {
- return createNewIssue(resolution, status, severity, CODE_SMELL);
- }
-
- private DefaultIssue createNewIssue(@Nullable String resolution, String status, Severity impactSeverity) {
- return createNewIssue(resolution, status, SoftwareQuality.MAINTAINABILITY, impactSeverity);
- }
-
- private DefaultIssue createNewIssue(@Nullable String resolution, String status, SoftwareQuality softwareQuality, Severity impactSeverity) {
- DefaultIssue issue = createNewIssue(resolution, status, MAJOR, CODE_SMELL);
- issue.addImpact(softwareQuality, impactSeverity);
- return issue;
- }
-
- private DefaultIssue createNewIssue(@Nullable String resolution, String status, String severity, RuleType ruleType) {
- DefaultIssue issue = createIssue(resolution, status, severity, ruleType);
- when(newIssueClassifier.isNew(any(), eq(issue))).thenReturn(true);
- return issue;
- }
-
- private static DefaultIssue createIssue(@Nullable String resolution, String status, String severity) {
- return createIssue(resolution, status, severity, CODE_SMELL);
- }
-
- private static DefaultIssue createIssue(@Nullable String resolution, String status, Severity impactSeverity) {
- return createIssue(resolution, status, SoftwareQuality.MAINTAINABILITY, impactSeverity);
- }
-
- private static DefaultIssue createIssue(@Nullable String resolution, String status, SoftwareQuality softwareQuality, Severity impactSeverity) {
- DefaultIssue issue = createIssue(resolution, status, MAJOR, CODE_SMELL);
- issue.addImpact(softwareQuality, impactSeverity);
- return issue;
- }
-
- private static DefaultIssue createIssue(@Nullable String resolution, String status, String severity, RuleType ruleType) {
- return new DefaultIssue()
- .setKey(String.valueOf(++issueCounter))
- .setResolution(resolution).setStatus(status)
- .setSeverity(severity).setRuleKey(RuleTesting.XOO_X1)
- .setType(ruleType);
- }
-
- private static DefaultIssue createSecurityHotspot() {
- return createIssue(null, STATUS_OPEN, "MAJOR", SECURITY_HOTSPOT);
- }
-
- private DefaultIssue createNewSecurityHotspot() {
- return createNewIssue(null, STATUS_OPEN, "MAJOR", SECURITY_HOTSPOT);
- }
- }
|