123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256 |
- /*
- * SonarQube
- * Copyright (C) 2009-2020 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.usergroups.ws;
-
- import org.junit.Rule;
- import org.junit.Test;
- import org.junit.rules.ExpectedException;
- import org.sonar.api.impl.utils.AlwaysIncreasingSystem2;
- import org.sonar.api.server.ws.Change;
- import org.sonar.api.server.ws.WebService.Action;
- import org.sonar.core.permission.GlobalPermissions;
- import org.sonar.db.DbTester;
- import org.sonar.db.user.GroupDto;
- import org.sonar.db.user.UserDto;
- import org.sonar.server.exceptions.BadRequestException;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.exceptions.NotFoundException;
- import org.sonar.server.tester.UserSessionRule;
- import org.sonar.server.usergroups.DefaultGroupFinder;
- import org.sonar.server.ws.TestRequest;
- import org.sonar.server.ws.TestResponse;
- import org.sonar.server.ws.WsActionTester;
-
- import static java.net.HttpURLConnection.HTTP_NO_CONTENT;
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.assertj.core.api.Assertions.tuple;
- import static org.sonar.db.permission.OrganizationPermission.ADMINISTER;
- import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_GROUP_NAME;
- import static org.sonar.server.usergroups.ws.GroupWsSupport.PARAM_LOGIN;
-
- public class RemoveUserActionTest {
-
- @Rule
- public DbTester db = DbTester.create(new AlwaysIncreasingSystem2());
- @Rule
- public UserSessionRule userSession = UserSessionRule.standalone();
- @Rule
- public ExpectedException expectedException = ExpectedException.none();
-
- private final WsActionTester ws = new WsActionTester(
- new RemoveUserAction(db.getDbClient(), userSession, new GroupWsSupport(db.getDbClient(), new DefaultGroupFinder(db.getDbClient()))));
-
- @Test
- public void verify_definition() {
- Action wsDef = ws.getDef();
-
- assertThat(wsDef.isInternal()).isFalse();
- assertThat(wsDef.since()).isEqualTo("5.2");
- assertThat(wsDef.isPost()).isTrue();
- assertThat(wsDef.changelog()).extracting(Change::getVersion, Change::getDescription).containsOnly(
- tuple("8.4", "Parameter 'id' is deprecated. Format changes from integer to string. Use 'name' instead."));
- }
-
- @Test
- public void does_nothing_if_user_is_not_in_group() {
- // keep an administrator
- insertAnAdministrator();
- insertDefaultGroup();
-
- GroupDto group = db.users().insertGroup("admins");
- UserDto user = db.users().insertUser("my-admin");
- loginAsAdmin();
-
- newRequest()
- .setParam("id", group.getUuid())
- .setParam("login", user.getLogin())
- .execute();
-
- assertThat(db.users().selectGroupUuidsOfUser(user)).isEmpty();
- }
-
- @Test
- public void remove_user_by_group_id() {
- // keep an administrator
- insertAnAdministrator();
- insertDefaultGroup();
- GroupDto users = db.users().insertGroup("users");
- UserDto user = db.users().insertUser("my-admin");
- db.users().insertMember(users, user);
- loginAsAdmin();
-
- newRequest()
- .setParam("id", users.getUuid())
- .setParam("login", user.getLogin())
- .execute();
-
- assertThat(db.users().selectGroupUuidsOfUser(user)).isEmpty();
- }
-
- @Test
- public void remove_user_by_group_name() {
- insertAnAdministrator();
- insertDefaultGroup();
- GroupDto group = db.users().insertGroup("a_group");
- UserDto user = db.users().insertUser("a_user");
- db.users().insertMember(group, user);
- loginAsAdmin();
-
- newRequest()
- .setParam(PARAM_GROUP_NAME, group.getName())
- .setParam(PARAM_LOGIN, user.getLogin())
- .execute();
-
- assertThat(db.users().selectGroupUuidsOfUser(user)).isEmpty();
- }
-
- @Test
- public void remove_user_only_from_one_group() {
- // keep an administrator
- insertAnAdministrator();
- insertDefaultGroup();
-
- GroupDto users = db.users().insertGroup("user");
- GroupDto admins = db.users().insertGroup("admins");
- UserDto user = db.users().insertUser("user");
- db.users().insertMember(users, user);
- db.users().insertMember(admins, user);
- loginAsAdmin();
-
- newRequest()
- .setParam("id", admins.getUuid())
- .setParam("login", user.getLogin())
- .execute();
-
- assertThat(db.users().selectGroupUuidsOfUser(user)).containsOnly(users.getUuid());
- }
-
- @Test
- public void response_status_is_no_content() {
- // keep an administrator
- insertAnAdministrator();
- insertDefaultGroup();
- GroupDto users = db.users().insertGroup("users");
- UserDto user = db.users().insertUser("my-admin");
- db.users().insertMember(users, user);
- loginAsAdmin();
-
- TestResponse response = newRequest()
- .setParam("id", users.getUuid())
- .setParam("login", user.getLogin())
- .execute();
-
- assertThat(response.getStatus()).isEqualTo(HTTP_NO_CONTENT);
- }
-
- @Test
- public void fail_if_unknown_group() {
- UserDto user = db.users().insertUser("my-admin");
-
- expectedException.expect(NotFoundException.class);
-
- loginAsAdmin();
- newRequest()
- .setParam("id", "42")
- .setParam("login", user.getLogin())
- .execute();
- }
-
- @Test
- public void fail_if_unknown_user() {
- insertDefaultGroup();
- GroupDto group = db.users().insertGroup("admins");
-
- expectedException.expect(NotFoundException.class);
-
- loginAsAdmin();
- newRequest()
- .setParam("id", group.getUuid())
- .setParam("login", "my-admin")
- .execute();
- }
-
- @Test
- public void throw_ForbiddenException_if_not_administrator() {
- GroupDto group = db.users().insertGroup("a-group");
- UserDto user = db.users().insertUser();
- db.users().insertMember(group, user);
- userSession.logIn("admin");
-
- expectedException.expect(ForbiddenException.class);
- expectedException.expectMessage("Insufficient privileges");
-
- newRequest()
- .setParam("id", group.getUuid())
- .setParam("login", user.getLogin())
- .execute();
- }
-
- @Test
- public void fail_to_remove_the_last_administrator() {
- db.users().insertDefaultGroup();
- GroupDto adminGroup = db.users().insertGroup("sonar-admins");
- db.users().insertPermissionOnGroup(adminGroup, GlobalPermissions.SYSTEM_ADMIN);
- UserDto adminUser = db.users().insertUser("the-single-admin");
- db.users().insertMember(adminGroup, adminUser);
- loginAsAdmin();
-
- expectedException.expect(BadRequestException.class);
- expectedException.expectMessage("The last administrator user cannot be removed");
-
- newRequest()
- .setParam("id", adminGroup.getUuid())
- .setParam("login", adminUser.getLogin())
- .execute();
- }
-
- @Test
- public void fail_to_remove_user_from_default_group() {
- UserDto user = db.users().insertUser();
- GroupDto defaultGroup = db.users().insertDefaultGroup();
- db.users().insertMember(defaultGroup, user);
- loginAsAdmin();
-
- expectedException.expect(IllegalArgumentException.class);
- expectedException.expectMessage("Default group 'sonar-users' cannot be used to perform this action");
-
- newRequest()
- .setParam("id", defaultGroup.getUuid())
- .setParam(PARAM_LOGIN, user.getLogin())
- .execute();
- }
-
- private TestRequest newRequest() {
- return ws.newRequest();
- }
-
- private void loginAsAdmin() {
- userSession.logIn("admin").addPermission(ADMINISTER);
- }
-
- private void insertAnAdministrator() {
- db.users().insertAdminByUserPermission();
- }
-
- private void insertDefaultGroup() {
- db.users().insertDefaultGroup();
- }
-
- }
|