You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

AppLoggingTest.java 11KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2019 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.application;
  21. import ch.qos.logback.classic.Level;
  22. import ch.qos.logback.classic.Logger;
  23. import ch.qos.logback.classic.LoggerContext;
  24. import ch.qos.logback.classic.encoder.PatternLayoutEncoder;
  25. import ch.qos.logback.classic.spi.ILoggingEvent;
  26. import ch.qos.logback.core.Appender;
  27. import ch.qos.logback.core.ConsoleAppender;
  28. import ch.qos.logback.core.FileAppender;
  29. import ch.qos.logback.core.encoder.Encoder;
  30. import ch.qos.logback.core.joran.spi.ConsoleTarget;
  31. import ch.qos.logback.core.rolling.RollingFileAppender;
  32. import java.io.File;
  33. import java.util.Iterator;
  34. import org.junit.AfterClass;
  35. import org.junit.Before;
  36. import org.junit.Rule;
  37. import org.junit.Test;
  38. import org.junit.rules.ExpectedException;
  39. import org.junit.rules.TemporaryFolder;
  40. import org.slf4j.LoggerFactory;
  41. import org.sonar.application.config.AppSettings;
  42. import org.sonar.application.config.TestAppSettings;
  43. import org.sonar.process.logging.LogbackHelper;
  44. import static org.assertj.core.api.Assertions.assertThat;
  45. import static org.slf4j.Logger.ROOT_LOGGER_NAME;
  46. import static org.sonar.application.process.StreamGobbler.LOGGER_GOBBLER;
  47. import static org.sonar.process.ProcessProperties.Property.CLUSTER_ENABLED;
  48. import static org.sonar.process.ProcessProperties.Property.PATH_LOGS;
  49. public class AppLoggingTest {
  50. @Rule
  51. public TemporaryFolder temp = new TemporaryFolder();
  52. @Rule
  53. public ExpectedException expectedException = ExpectedException.none();
  54. private File logDir;
  55. private AppSettings settings = new TestAppSettings();
  56. private AppLogging underTest = new AppLogging(settings);
  57. @Before
  58. public void setUp() throws Exception {
  59. logDir = temp.newFolder();
  60. settings.getProps().set(PATH_LOGS.getKey(), logDir.getAbsolutePath());
  61. }
  62. @AfterClass
  63. public static void resetLogback() throws Exception {
  64. new LogbackHelper().resetFromXml("/logback-test.xml");
  65. }
  66. @Test
  67. public void no_writing_to_sonar_log_file_when_running_from_sonar_script() {
  68. emulateRunFromSonarScript();
  69. LoggerContext ctx = underTest.configure();
  70. ctx.getLoggerList().forEach(AppLoggingTest::verifyNoFileAppender);
  71. }
  72. @Test
  73. public void root_logger_only_writes_to_console_with_formatting_when_running_from_sonar_script() {
  74. emulateRunFromSonarScript();
  75. LoggerContext ctx = underTest.configure();
  76. Logger rootLogger = ctx.getLogger(ROOT_LOGGER_NAME);
  77. ConsoleAppender<ILoggingEvent> consoleAppender = (ConsoleAppender<ILoggingEvent>) rootLogger.getAppender("APP_CONSOLE");
  78. verifyAppFormattedLogEncoder(consoleAppender.getEncoder());
  79. assertThat(rootLogger.iteratorForAppenders()).toIterable().hasSize(1);
  80. }
  81. @Test
  82. public void gobbler_logger_writes_to_console_without_formatting_when_running_from_sonar_script() {
  83. emulateRunFromSonarScript();
  84. LoggerContext ctx = underTest.configure();
  85. Logger gobblerLogger = ctx.getLogger(LOGGER_GOBBLER);
  86. verifyGobblerConsoleAppender(gobblerLogger);
  87. assertThat(gobblerLogger.iteratorForAppenders()).toIterable().hasSize(1);
  88. }
  89. @Test
  90. public void root_logger_writes_to_console_with_formatting_and_to_sonar_log_file_when_running_from_command_line() {
  91. emulateRunFromCommandLine(false);
  92. LoggerContext ctx = underTest.configure();
  93. Logger rootLogger = ctx.getLogger(ROOT_LOGGER_NAME);
  94. verifyAppConsoleAppender(rootLogger.getAppender("APP_CONSOLE"));
  95. verifySonarLogFileAppender(rootLogger.getAppender("file_sonar"));
  96. assertThat(rootLogger.iteratorForAppenders()).toIterable().hasSize(2);
  97. // verify no other logger writes to sonar.log
  98. ctx.getLoggerList()
  99. .stream()
  100. .filter(logger -> !ROOT_LOGGER_NAME.equals(logger.getName()))
  101. .forEach(AppLoggingTest::verifyNoFileAppender);
  102. }
  103. @Test
  104. public void gobbler_logger_writes_to_console_without_formatting_when_running_from_command_line() {
  105. emulateRunFromCommandLine(false);
  106. LoggerContext ctx = underTest.configure();
  107. Logger gobblerLogger = ctx.getLogger(LOGGER_GOBBLER);
  108. verifyGobblerConsoleAppender(gobblerLogger);
  109. assertThat(gobblerLogger.iteratorForAppenders()).toIterable().hasSize(1);
  110. }
  111. @Test
  112. public void root_logger_writes_to_console_with_formatting_and_to_sonar_log_file_when_running_from_ITs() {
  113. emulateRunFromCommandLine(true);
  114. LoggerContext ctx = underTest.configure();
  115. Logger rootLogger = ctx.getLogger(ROOT_LOGGER_NAME);
  116. verifyAppConsoleAppender(rootLogger.getAppender("APP_CONSOLE"));
  117. verifySonarLogFileAppender(rootLogger.getAppender("file_sonar"));
  118. assertThat(rootLogger.iteratorForAppenders()).toIterable().hasSize(2);
  119. ctx.getLoggerList()
  120. .stream()
  121. .filter(logger -> !ROOT_LOGGER_NAME.equals(logger.getName()))
  122. .forEach(AppLoggingTest::verifyNoFileAppender);
  123. }
  124. @Test
  125. public void gobbler_logger_writes_to_console_without_formatting_when_running_from_ITs() {
  126. emulateRunFromCommandLine(true);
  127. LoggerContext ctx = underTest.configure();
  128. Logger gobblerLogger = ctx.getLogger(LOGGER_GOBBLER);
  129. verifyGobblerConsoleAppender(gobblerLogger);
  130. assertThat(gobblerLogger.iteratorForAppenders()).toIterable().hasSize(1);
  131. }
  132. @Test
  133. public void configure_no_rotation_on_sonar_file() {
  134. settings.getProps().set("sonar.log.rollingPolicy", "none");
  135. LoggerContext ctx = underTest.configure();
  136. Logger rootLogger = ctx.getLogger(ROOT_LOGGER_NAME);
  137. Appender<ILoggingEvent> appender = rootLogger.getAppender("file_sonar");
  138. assertThat(appender)
  139. .isNotInstanceOf(RollingFileAppender.class)
  140. .isInstanceOf(FileAppender.class);
  141. }
  142. @Test
  143. public void default_level_for_root_logger_is_INFO() {
  144. LoggerContext ctx = underTest.configure();
  145. verifyRootLogLevel(ctx, Level.INFO);
  146. }
  147. @Test
  148. public void root_logger_level_changes_with_global_property() {
  149. settings.getProps().set("sonar.log.level", "TRACE");
  150. LoggerContext ctx = underTest.configure();
  151. verifyRootLogLevel(ctx, Level.TRACE);
  152. }
  153. @Test
  154. public void root_logger_level_changes_with_app_property() {
  155. settings.getProps().set("sonar.log.level.app", "TRACE");
  156. LoggerContext ctx = underTest.configure();
  157. verifyRootLogLevel(ctx, Level.TRACE);
  158. }
  159. @Test
  160. public void root_logger_level_is_configured_from_app_property_over_global_property() {
  161. settings.getProps().set("sonar.log.level", "TRACE");
  162. settings.getProps().set("sonar.log.level.app", "DEBUG");
  163. LoggerContext ctx = underTest.configure();
  164. verifyRootLogLevel(ctx, Level.DEBUG);
  165. }
  166. @Test
  167. public void root_logger_level_changes_with_app_property_and_is_case_insensitive() {
  168. settings.getProps().set("sonar.log.level.app", "debug");
  169. LoggerContext ctx = underTest.configure();
  170. verifyRootLogLevel(ctx, Level.DEBUG);
  171. }
  172. @Test
  173. public void default_to_INFO_if_app_property_has_invalid_value() {
  174. settings.getProps().set("sonar.log.level.app", "DodoDouh!");
  175. LoggerContext ctx = underTest.configure();
  176. verifyRootLogLevel(ctx, Level.INFO);
  177. }
  178. @Test
  179. public void fail_with_IAE_if_global_property_unsupported_level() {
  180. settings.getProps().set("sonar.log.level", "ERROR");
  181. expectedException.expect(IllegalArgumentException.class);
  182. expectedException.expectMessage("log level ERROR in property sonar.log.level is not a supported value (allowed levels are [TRACE, DEBUG, INFO])");
  183. underTest.configure();
  184. }
  185. @Test
  186. public void fail_with_IAE_if_app_property_unsupported_level() {
  187. settings.getProps().set("sonar.log.level.app", "ERROR");
  188. expectedException.expect(IllegalArgumentException.class);
  189. expectedException.expectMessage("log level ERROR in property sonar.log.level.app is not a supported value (allowed levels are [TRACE, DEBUG, INFO])");
  190. underTest.configure();
  191. }
  192. @Test
  193. public void no_info_log_from_hazelcast() {
  194. settings.getProps().set(CLUSTER_ENABLED.getKey(), "true");
  195. underTest.configure();
  196. assertThat(
  197. LoggerFactory.getLogger("com.hazelcast").isInfoEnabled()).isEqualTo(false);
  198. }
  199. private void emulateRunFromSonarScript() {
  200. settings.getProps().set("sonar.wrapped", "true");
  201. }
  202. private void emulateRunFromCommandLine(boolean withAllLogsPrintedToConsole) {
  203. if (withAllLogsPrintedToConsole) {
  204. settings.getProps().set("sonar.log.console", "true");
  205. }
  206. }
  207. private static void verifyNoFileAppender(Logger logger) {
  208. Iterator<Appender<ILoggingEvent>> iterator = logger.iteratorForAppenders();
  209. while (iterator.hasNext()) {
  210. assertThat(iterator.next()).isNotInstanceOf(FileAppender.class);
  211. }
  212. }
  213. private void verifySonarLogFileAppender(Appender<ILoggingEvent> appender) {
  214. assertThat(appender).isInstanceOf(FileAppender.class);
  215. FileAppender fileAppender = (FileAppender) appender;
  216. assertThat(fileAppender.getFile()).isEqualTo(new File(logDir, "sonar.log").getAbsolutePath());
  217. verifyAppFormattedLogEncoder(fileAppender.getEncoder());
  218. }
  219. private void verifyAppConsoleAppender(Appender<ILoggingEvent> appender) {
  220. assertThat(appender).isInstanceOf(ConsoleAppender.class);
  221. ConsoleAppender<ILoggingEvent> consoleAppender = (ConsoleAppender<ILoggingEvent>) appender;
  222. assertThat(consoleAppender.getTarget()).isEqualTo(ConsoleTarget.SystemOut.getName());
  223. verifyAppFormattedLogEncoder(consoleAppender.getEncoder());
  224. }
  225. private void verifyAppFormattedLogEncoder(Encoder<ILoggingEvent> encoder) {
  226. verifyFormattedLogEncoder(encoder, "%d{yyyy.MM.dd HH:mm:ss} %-5level app[][%logger{20}] %msg%n");
  227. }
  228. private void verifyGobblerConsoleAppender(Logger logger) {
  229. Appender<ILoggingEvent> appender = logger.getAppender("GOBBLER_CONSOLE");
  230. assertThat(appender).isInstanceOf(ConsoleAppender.class);
  231. ConsoleAppender<ILoggingEvent> consoleAppender = (ConsoleAppender<ILoggingEvent>) appender;
  232. assertThat(consoleAppender.getTarget()).isEqualTo(ConsoleTarget.SystemOut.getName());
  233. verifyFormattedLogEncoder(consoleAppender.getEncoder(), "%msg%n");
  234. }
  235. private void verifyFormattedLogEncoder(Encoder<ILoggingEvent> encoder, String logPattern) {
  236. assertThat(encoder).isInstanceOf(PatternLayoutEncoder.class);
  237. PatternLayoutEncoder patternEncoder = (PatternLayoutEncoder) encoder;
  238. assertThat(patternEncoder.getPattern()).isEqualTo(logPattern);
  239. }
  240. private void verifyRootLogLevel(LoggerContext ctx, Level expected) {
  241. Logger rootLogger = ctx.getLogger(ROOT_LOGGER_NAME);
  242. assertThat(rootLogger.getLevel()).isEqualTo(expected);
  243. }
  244. }