123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182 |
- /*
- * SonarQube
- * Copyright (C) 2009-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.qualitygate.ws;
-
- import com.tngtech.java.junit.dataprovider.DataProvider;
- import com.tngtech.java.junit.dataprovider.DataProviderRunner;
- import com.tngtech.java.junit.dataprovider.UseDataProvider;
- import java.util.Collection;
- import java.util.Optional;
- import javax.annotation.Nullable;
- import org.junit.Before;
- import org.junit.Rule;
- import org.junit.Test;
- import org.junit.runner.RunWith;
- import org.sonar.api.measures.Metric;
- import org.sonar.api.server.ws.WebService;
- import org.sonar.api.utils.System2;
- import org.sonar.core.util.UuidFactoryFast;
- import org.sonar.db.DbClient;
- import org.sonar.db.DbSession;
- import org.sonar.db.DbTester;
- import org.sonar.db.metric.MetricDto;
- import org.sonar.db.qualitygate.QualityGateConditionDto;
- import org.sonar.db.qualitygate.QualityGateDto;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.qualitygate.QualityGateConditionsUpdater;
- import org.sonar.server.qualitygate.QualityGateUpdater;
- import org.sonar.server.tester.UserSessionRule;
- import org.sonar.server.ws.TestRequest;
- import org.sonar.server.ws.WsActionTester;
- import org.sonarqube.ws.Qualitygates.CreateResponse;
-
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.assertj.core.api.Assertions.assertThatThrownBy;
- import static org.sonar.db.permission.GlobalPermission.ADMINISTER_QUALITY_GATES;
- import static org.sonar.server.qualitygate.QualityGateCaycChecker.CAYC_METRICS;
- import static org.sonar.server.qualitygate.ws.CreateAction.DEFAULT_METRIC_VALUES;
- import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_NAME;
-
- @RunWith(DataProviderRunner.class)
- public class CreateActionTest {
-
- @Rule
- public UserSessionRule userSession = UserSessionRule.standalone();
-
- @Rule
- public DbTester db = DbTester.create(System2.INSTANCE);
-
- private final DbClient dbClient = db.getDbClient();
- private final DbSession dbSession = db.getSession();
- private final CreateAction underTest = new CreateAction(dbClient, userSession, new QualityGateUpdater(dbClient, UuidFactoryFast.getInstance()),
- new QualityGateConditionsUpdater(dbClient));
- private final WsActionTester ws = new WsActionTester(underTest);
-
- @Before
- public void setup() {
- CAYC_METRICS.forEach(this::insertMetric);
- }
-
- @Test
- public void create_quality_gate_with_cayc_conditions() {
- logInAsQualityGateAdmin();
-
- String qgName = "Default";
- CreateResponse response = executeRequest(qgName);
-
- assertThat(response.getName()).isEqualTo(qgName);
- dbSession.commit();
-
- QualityGateDto qualityGateDto = dbClient.qualityGateDao().selectByName(dbSession, qgName);
- assertThat(qualityGateDto).isNotNull();
-
- var conditions = getConditions(dbSession, qualityGateDto);
-
- CAYC_METRICS.stream()
- .map(m -> dbClient.metricDao().selectByKey(dbSession, m.getKey()))
- .forEach(metricDto -> assertThat(conditions)
- .anyMatch(c -> metricDto.getUuid().equals(c.getMetricUuid()) && c.getErrorThreshold().equals(String.valueOf(getDefaultCaycValue(metricDto)))));
- }
-
- @Test
- public void test_ws_definition() {
- WebService.Action action = ws.getDef();
- assertThat(action).isNotNull();
- assertThat(action.isInternal()).isFalse();
- assertThat(action.isPost()).isTrue();
- assertThat(action.responseExampleAsString()).isNotEmpty();
- assertThat(action.params()).hasSize(1);
- }
-
- @Test
- public void throw_ForbiddenException_if_not_gate_administrator() {
- userSession.logIn();
-
- assertThatThrownBy(() -> executeRequest("Default"))
- .isInstanceOf(ForbiddenException.class)
- .hasMessageContaining("Insufficient privileges");
- }
-
- @Test
- public void throw_BadRequestException_if_name_is_already_used() {
- userSession.logIn().addPermission(ADMINISTER_QUALITY_GATES);
-
- executeRequest("Default");
-
- assertThatThrownBy(() -> executeRequest("Default"))
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessageContaining("Name has already been taken");
- }
-
- @Test
- @UseDataProvider("nullOrEmpty")
- public void fail_when_name_parameter_is_empty(@Nullable String nameParameter) {
- userSession.addPermission(ADMINISTER_QUALITY_GATES);
-
- TestRequest request = ws.newRequest();
- Optional.ofNullable(nameParameter).ifPresent(t -> request.setParam(PARAM_NAME, ""));
-
- assertThatThrownBy(() -> request.execute())
- .isInstanceOf(IllegalArgumentException.class)
- .hasMessageContaining("The 'name' parameter is missing");
- }
-
- @DataProvider
- public static Object[][] nullOrEmpty() {
- return new Object[][] {
- {null},
- {""},
- {" "}
- };
- }
-
- private Collection<QualityGateConditionDto> getConditions(DbSession dbSession, QualityGateDto qualityGate) {
- return dbClient.gateConditionDao().selectForQualityGate(dbSession, qualityGate.getUuid());
- }
-
- private CreateResponse executeRequest(String qualitGateName) {
- return ws.newRequest()
- .setParam("name", qualitGateName)
- .executeProtobuf(CreateResponse.class);
- }
-
- private void logInAsQualityGateAdmin() {
- userSession.logIn().addPermission(ADMINISTER_QUALITY_GATES);
- }
-
- private void insertMetric(Metric metric) {
- db.measures().insertMetric(m -> m
- .setKey(metric.getKey())
- .setValueType(metric.getType().name())
- .setHidden(metric.isHidden())
- .setDirection(metric.getDirection()));
- }
-
- private Integer getDefaultCaycValue(MetricDto metricDto) {
- return DEFAULT_METRIC_VALUES.containsKey(metricDto.getKey())
- ? DEFAULT_METRIC_VALUES.get(metricDto.getKey())
- : CAYC_METRICS.stream()
- .filter(metric -> metricDto.getKey().equals(metric.getKey()))
- .findAny()
- .orElseThrow()
- .getBestValue().intValue();
- }
-
- }
|