You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

DestroyActionTest.java 8.7KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2023 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.qualitygate.ws;
  21. import org.junit.Rule;
  22. import org.junit.Test;
  23. import org.sonar.api.server.ws.WebService;
  24. import org.sonar.api.utils.System2;
  25. import org.sonar.db.DbClient;
  26. import org.sonar.db.DbSession;
  27. import org.sonar.db.DbTester;
  28. import org.sonar.db.Pagination;
  29. import org.sonar.db.project.ProjectDto;
  30. import org.sonar.db.qualitygate.QualityGateDto;
  31. import org.sonar.db.user.GroupDto;
  32. import org.sonar.db.user.UserDto;
  33. import org.sonar.server.component.TestComponentFinder;
  34. import org.sonar.server.exceptions.ForbiddenException;
  35. import org.sonar.server.exceptions.NotFoundException;
  36. import org.sonar.server.qualitygate.QualityGateFinder;
  37. import org.sonar.server.tester.UserSessionRule;
  38. import org.sonar.server.ws.WsActionTester;
  39. import static java.lang.String.format;
  40. import static java.lang.String.valueOf;
  41. import static org.assertj.core.api.Assertions.assertThat;
  42. import static org.assertj.core.api.Assertions.assertThatThrownBy;
  43. import static org.assertj.core.api.Assertions.tuple;
  44. import static org.sonar.db.permission.GlobalPermission.ADMINISTER_QUALITY_GATES;
  45. import static org.sonar.db.permission.GlobalPermission.ADMINISTER_QUALITY_PROFILES;
  46. import static org.sonar.db.qualitygate.SearchQualityGatePermissionQuery.builder;
  47. import static org.sonar.db.user.SearchPermissionQuery.IN;
  48. import static org.sonar.server.qualitygate.ws.QualityGatesWsParameters.PARAM_NAME;
  49. public class DestroyActionTest {
  50. @Rule
  51. public UserSessionRule userSession = UserSessionRule.standalone();
  52. @Rule
  53. public DbTester db = DbTester.create(System2.INSTANCE);
  54. private final DbClient dbClient = db.getDbClient();
  55. private final QualityGateFinder qualityGateFinder = new QualityGateFinder(dbClient);
  56. private final QualityGatesWsSupport wsSupport = new QualityGatesWsSupport(db.getDbClient(), userSession, TestComponentFinder.from(db));
  57. private final DbSession dbSession = db.getSession();
  58. private final DestroyAction underTest = new DestroyAction(dbClient, wsSupport, qualityGateFinder);
  59. private final WsActionTester ws = new WsActionTester(underTest);
  60. @Test
  61. public void delete_quality_gate() {
  62. db.qualityGates().createDefaultQualityGate();
  63. QualityGateDto qualityGate = db.qualityGates().insertQualityGate();
  64. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  65. ws.newRequest()
  66. .setParam(PARAM_NAME, qualityGate.getName())
  67. .execute();
  68. assertThat(db.getDbClient().qualityGateDao().selectByUuid(dbSession, qualityGate.getUuid())).isNull();
  69. }
  70. @Test
  71. public void delete_quality_gate_if_non_default_when_a_default_exist() {
  72. db.qualityGates().createDefaultQualityGate();
  73. QualityGateDto qualityGate = db.qualityGates().insertQualityGate();
  74. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  75. ws.newRequest()
  76. .setParam(PARAM_NAME, qualityGate.getName())
  77. .execute();
  78. assertThat(db.getDbClient().qualityGateDao().selectByUuid(dbSession, qualityGate.getUuid())).isNull();
  79. }
  80. @Test
  81. public void delete_quality_gate_and_any_association_to_any_project() {
  82. db.qualityGates().createDefaultQualityGate();
  83. QualityGateDto qualityGate = db.qualityGates().insertQualityGate();
  84. ProjectDto prj1 = db.components().insertPublicProjectDto();
  85. ProjectDto prj2 = db.components().insertPublicProjectDto();
  86. db.qualityGates().associateProjectToQualityGate(prj1, qualityGate);
  87. db.qualityGates().associateProjectToQualityGate(prj2, qualityGate);
  88. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  89. ws.newRequest()
  90. .setParam(PARAM_NAME, qualityGate.getName())
  91. .execute();
  92. assertThat(db.getDbClient().projectQgateAssociationDao().selectQGateUuidByProjectUuid(dbSession, prj1.getUuid()))
  93. .isEmpty();
  94. assertThat(db.getDbClient().projectQgateAssociationDao().selectQGateUuidByProjectUuid(dbSession, prj2.getUuid()))
  95. .isEmpty();
  96. assertThat(db.getDbClient().projectQgateAssociationDao().selectQGateUuidByProjectUuid(dbSession, prj1.getUuid()))
  97. .isEmpty();
  98. assertThat(db.getDbClient().projectQgateAssociationDao().selectQGateUuidByProjectUuid(dbSession, prj2.getUuid()))
  99. .isEmpty();
  100. }
  101. @Test
  102. public void delete_quality_gate_and_any_associated_group_permissions() {
  103. db.qualityGates().createDefaultQualityGate();
  104. QualityGateDto qualityGate = db.qualityGates().insertQualityGate();
  105. GroupDto group1 = db.users().insertGroup();
  106. GroupDto group2 = db.users().insertGroup();
  107. db.qualityGates().addGroupPermission(qualityGate, group1);
  108. db.qualityGates().addGroupPermission(qualityGate, group2);
  109. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  110. ws.newRequest()
  111. .setParam(PARAM_NAME, qualityGate.getName())
  112. .execute();
  113. assertThat(db.getDbClient().qualityGateGroupPermissionsDao().selectByQuery(dbSession, builder()
  114. .setQualityGate(qualityGate)
  115. .setMembership(IN).build(),
  116. Pagination.all()))
  117. .isEmpty();
  118. }
  119. @Test
  120. public void delete_quality_gate_and_any_associated_user_permissions() {
  121. db.qualityGates().createDefaultQualityGate();
  122. QualityGateDto qualityGate = db.qualityGates().insertQualityGate();
  123. UserDto user1 = db.users().insertUser();
  124. UserDto user2 = db.users().insertUser();
  125. db.qualityGates().addUserPermission(qualityGate, user1);
  126. db.qualityGates().addUserPermission(qualityGate, user2);
  127. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  128. ws.newRequest()
  129. .setParam(PARAM_NAME, qualityGate.getName())
  130. .execute();
  131. assertThat(db.getDbClient().qualityGateUserPermissionDao().selectByQuery(dbSession, builder()
  132. .setQualityGate(qualityGate)
  133. .setMembership(IN).build(),
  134. Pagination.all()))
  135. .isEmpty();
  136. }
  137. @Test
  138. public void does_not_delete_built_in_quality_gate() {
  139. db.qualityGates().createDefaultQualityGate();
  140. QualityGateDto builtInQualityGate = db.qualityGates().insertBuiltInQualityGate();
  141. db.commit();
  142. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  143. assertThatThrownBy(() -> ws.newRequest()
  144. .setParam(PARAM_NAME, valueOf(builtInQualityGate.getName()))
  145. .execute())
  146. .isInstanceOf(IllegalArgumentException.class)
  147. .hasMessageContaining(format("Operation forbidden for built-in Quality Gate '%s'", builtInQualityGate.getName()));
  148. }
  149. @Test
  150. public void fail_when_missing_name() {
  151. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  152. assertThatThrownBy(() -> ws.newRequest()
  153. .execute())
  154. .isInstanceOf(IllegalArgumentException.class);
  155. }
  156. @Test
  157. public void fail_to_delete_default_quality_gate() {
  158. QualityGateDto defaultQualityGate = db.qualityGates().createDefaultQualityGate();
  159. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  160. assertThatThrownBy(() -> ws.newRequest()
  161. .setParam(PARAM_NAME, valueOf(defaultQualityGate.getName()))
  162. .execute())
  163. .isInstanceOf(IllegalArgumentException.class)
  164. .hasMessageContaining("The default quality gate cannot be removed");
  165. }
  166. @Test
  167. public void fail_on_unknown_quality_gate() {
  168. userSession.addPermission(ADMINISTER_QUALITY_GATES);
  169. assertThatThrownBy(() -> ws.newRequest()
  170. .setParam(PARAM_NAME, "unknown")
  171. .execute())
  172. .isInstanceOf(NotFoundException.class);
  173. }
  174. @Test
  175. public void fail_when_not_quality_gates_administer() {
  176. QualityGateDto qualityGate = db.qualityGates().insertQualityGate();
  177. db.qualityGates().createDefaultQualityGate();
  178. userSession.logIn("john").addPermission(ADMINISTER_QUALITY_PROFILES);
  179. assertThatThrownBy(() -> ws.newRequest()
  180. .setParam(PARAM_NAME, qualityGate.getName())
  181. .execute())
  182. .isInstanceOf(ForbiddenException.class);
  183. }
  184. @Test
  185. public void definition() {
  186. WebService.Action action = ws.getDef();
  187. assertThat(action.since()).isEqualTo("4.3");
  188. assertThat(action.isPost()).isTrue();
  189. assertThat(action.params())
  190. .extracting(WebService.Param::key, WebService.Param::isRequired)
  191. .containsExactlyInAnyOrder(
  192. tuple("name", true));
  193. }
  194. }