You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

QualityGateEvaluatorImplTest.java 5.7KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2021 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.qualitygate;
  21. import com.google.common.collect.ImmutableSet;
  22. import java.util.HashMap;
  23. import java.util.Map;
  24. import java.util.Optional;
  25. import java.util.Set;
  26. import java.util.stream.Collectors;
  27. import org.junit.Test;
  28. import org.sonar.api.CoreProperties;
  29. import org.sonar.api.config.Configuration;
  30. import org.sonar.api.config.internal.ConfigurationBridge;
  31. import org.sonar.api.config.internal.MapSettings;
  32. import org.sonar.api.measures.Metric;
  33. import static java.util.Collections.singleton;
  34. import static org.assertj.core.api.Assertions.assertThat;
  35. import static org.mockito.Mockito.mock;
  36. import static org.mockito.Mockito.when;
  37. import static org.sonar.api.measures.CoreMetrics.NEW_DUPLICATED_LINES_KEY;
  38. import static org.sonar.api.measures.CoreMetrics.NEW_LINES_KEY;
  39. import static org.sonar.api.measures.CoreMetrics.NEW_MAINTAINABILITY_RATING_KEY;
  40. import static org.sonar.server.qualitygate.FakeMeasure.newMeasureOnLeak;
  41. public class QualityGateEvaluatorImplTest {
  42. private final MapSettings settings = new MapSettings();
  43. private final Configuration configuration = new ConfigurationBridge(settings);
  44. private final QualityGateEvaluator underTest = new QualityGateEvaluatorImpl();
  45. @Test
  46. public void getMetricKeys_includes_by_default_new_lines() {
  47. QualityGate gate = mock(QualityGate.class);
  48. assertThat(underTest.getMetricKeys(gate)).containsExactly(NEW_LINES_KEY);
  49. }
  50. @Test
  51. public void getMetricKeys_includes_metrics_from_qgate() {
  52. Set<String> metricKeys = ImmutableSet.of("foo", "bar", "baz");
  53. Set<Condition> conditions = metricKeys.stream().map(key -> {
  54. Condition condition = mock(Condition.class);
  55. when(condition.getMetricKey()).thenReturn(key);
  56. return condition;
  57. }).collect(Collectors.toSet());
  58. QualityGate gate = mock(QualityGate.class);
  59. when(gate.getConditions()).thenReturn(conditions);
  60. assertThat(underTest.getMetricKeys(gate)).containsAll(metricKeys);
  61. }
  62. @Test
  63. public void evaluated_conditions_are_sorted() {
  64. Set<String> metricKeys = ImmutableSet.of("foo", "bar", NEW_MAINTAINABILITY_RATING_KEY);
  65. Set<Condition> conditions = metricKeys.stream().map(key -> {
  66. Condition condition = mock(Condition.class);
  67. when(condition.getMetricKey()).thenReturn(key);
  68. return condition;
  69. }).collect(Collectors.toSet());
  70. QualityGate gate = mock(QualityGate.class);
  71. when(gate.getConditions()).thenReturn(conditions);
  72. QualityGateEvaluator.Measures measures = mock(QualityGateEvaluator.Measures.class);
  73. assertThat(underTest.evaluate(gate, measures, configuration).getEvaluatedConditions()).extracting(x -> x.getCondition().getMetricKey())
  74. .containsExactly(NEW_MAINTAINABILITY_RATING_KEY, "bar", "foo");
  75. }
  76. @Test
  77. public void evaluate_is_OK_for_empty_qgate() {
  78. QualityGate gate = mock(QualityGate.class);
  79. QualityGateEvaluator.Measures measures = mock(QualityGateEvaluator.Measures.class);
  80. EvaluatedQualityGate evaluatedQualityGate = underTest.evaluate(gate, measures, configuration);
  81. assertThat(evaluatedQualityGate.getStatus()).isEqualTo(Metric.Level.OK);
  82. }
  83. @Test
  84. public void evaluate_is_ERROR() {
  85. Condition condition = new Condition(NEW_MAINTAINABILITY_RATING_KEY, Condition.Operator.GREATER_THAN, "0");
  86. QualityGate gate = mock(QualityGate.class);
  87. when(gate.getConditions()).thenReturn(singleton(condition));
  88. QualityGateEvaluator.Measures measures = key -> Optional.of(newMeasureOnLeak(1));
  89. assertThat(underTest.evaluate(gate, measures, configuration).getStatus()).isEqualTo(Metric.Level.ERROR);
  90. }
  91. @Test
  92. public void evaluate_for_small_changes() {
  93. Condition condition = new Condition(NEW_DUPLICATED_LINES_KEY, Condition.Operator.GREATER_THAN, "0");
  94. Map<String, QualityGateEvaluator.Measure> notSmallChange = new HashMap<>();
  95. notSmallChange.put(NEW_DUPLICATED_LINES_KEY, newMeasureOnLeak(1));
  96. notSmallChange.put(NEW_LINES_KEY, newMeasureOnLeak(1000));
  97. Map<String, QualityGateEvaluator.Measure> smallChange = new HashMap<>();
  98. smallChange.put(NEW_DUPLICATED_LINES_KEY, newMeasureOnLeak(1));
  99. smallChange.put(NEW_LINES_KEY, newMeasureOnLeak(10));
  100. QualityGate gate = mock(QualityGate.class);
  101. when(gate.getConditions()).thenReturn(singleton(condition));
  102. QualityGateEvaluator.Measures notSmallChangeMeasures = key -> Optional.ofNullable(notSmallChange.get(key));
  103. QualityGateEvaluator.Measures smallChangeMeasures = key -> Optional.ofNullable(smallChange.get(key));
  104. settings.setProperty(CoreProperties.QUALITY_GATE_IGNORE_SMALL_CHANGES, true);
  105. assertThat(underTest.evaluate(gate, notSmallChangeMeasures, configuration).getStatus()).isEqualTo(Metric.Level.ERROR);
  106. assertThat(underTest.evaluate(gate, smallChangeMeasures, configuration).getStatus()).isEqualTo(Metric.Level.OK);
  107. settings.setProperty(CoreProperties.QUALITY_GATE_IGNORE_SMALL_CHANGES, false);
  108. assertThat(underTest.evaluate(gate, smallChangeMeasures, configuration).getStatus()).isEqualTo(Metric.Level.ERROR);
  109. }
  110. }