You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

LiveQualityGateComputerImplTest.java 10.0KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2021 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.measure.live;
  21. import com.google.common.collect.ImmutableSet;
  22. import java.util.Collections;
  23. import java.util.Set;
  24. import java.util.stream.Collectors;
  25. import org.junit.Rule;
  26. import org.junit.Test;
  27. import org.junit.rules.ExpectedException;
  28. import org.sonar.api.config.Configuration;
  29. import org.sonar.api.config.internal.ConfigurationBridge;
  30. import org.sonar.api.config.internal.MapSettings;
  31. import org.sonar.api.measures.CoreMetrics;
  32. import org.sonar.api.measures.Metric;
  33. import org.sonar.db.DbTester;
  34. import org.sonar.db.component.BranchDto;
  35. import org.sonar.db.component.BranchType;
  36. import org.sonar.db.component.ComponentDto;
  37. import org.sonar.db.component.ComponentTesting;
  38. import org.sonar.db.measure.LiveMeasureDto;
  39. import org.sonar.db.metric.MetricDto;
  40. import org.sonar.db.project.ProjectDto;
  41. import org.sonar.db.qualitygate.QualityGateConditionDto;
  42. import org.sonar.db.qualitygate.QualityGateDto;
  43. import org.sonar.server.qualitygate.Condition;
  44. import org.sonar.server.qualitygate.EvaluatedCondition;
  45. import org.sonar.server.qualitygate.EvaluatedQualityGate;
  46. import org.sonar.server.qualitygate.QualityGate;
  47. import org.sonar.server.qualitygate.QualityGateEvaluator;
  48. import org.sonar.server.qualitygate.QualityGateFinder;
  49. import static com.google.common.base.Preconditions.checkState;
  50. import static java.util.Arrays.asList;
  51. import static java.util.Collections.emptyList;
  52. import static java.util.Collections.singleton;
  53. import static org.assertj.core.api.Assertions.assertThat;
  54. import static org.assertj.core.groups.Tuple.tuple;
  55. import static org.sonar.db.metric.MetricTesting.newMetricDto;
  56. public class LiveQualityGateComputerImplTest {
  57. @Rule
  58. public ExpectedException expectedException = ExpectedException.none();
  59. @Rule
  60. public DbTester db = DbTester.create();
  61. private final MapSettings settings = new MapSettings();
  62. private final Configuration configuration = new ConfigurationBridge(settings);
  63. private final TestQualityGateEvaluator qualityGateEvaluator = new TestQualityGateEvaluator();
  64. private final LiveQualityGateComputerImpl underTest = new LiveQualityGateComputerImpl(db.getDbClient(), new QualityGateFinder(db.getDbClient()), qualityGateEvaluator);
  65. @Test
  66. public void loadQualityGate_returns_hardcoded_gate_for_pull_requests() {
  67. ProjectDto project = db.components().insertPublicProjectDto();
  68. BranchDto branch = db.components().insertProjectBranch(project, b -> b.setBranchType(BranchType.PULL_REQUEST));
  69. MetricDto metric1 = db.measures().insertMetric(m -> m.setKey("new_metric"));
  70. MetricDto metric2 = db.measures().insertMetric(m -> m.setKey("metric"));
  71. QualityGateDto gate = db.qualityGates().insertQualityGate();
  72. db.qualityGates().setDefaultQualityGate(gate);
  73. db.qualityGates().addCondition(gate, metric1);
  74. db.qualityGates().addCondition(gate, metric2);
  75. QualityGate result = underTest.loadQualityGate(db.getSession(), project, branch);
  76. assertThat(result.getConditions()).extracting(Condition::getMetricKey).containsExactly("new_metric");
  77. }
  78. @Test
  79. public void loadQualityGate_on_branch_returns_default_gate() {
  80. ProjectDto project = db.components().insertPublicProjectDto();
  81. BranchDto branch = db.components().insertProjectBranch(project).setBranchType(BranchType.BRANCH);
  82. MetricDto metric = db.measures().insertMetric();
  83. QualityGateDto gate = db.qualityGates().insertQualityGate();
  84. db.qualityGates().setDefaultQualityGate(gate);
  85. QualityGateConditionDto condition = db.qualityGates().addCondition(gate, metric);
  86. QualityGate result = underTest.loadQualityGate(db.getSession(), project, branch);
  87. assertThat(result.getId()).isEqualTo("" + gate.getUuid());
  88. assertThat(result.getConditions())
  89. .extracting(Condition::getMetricKey, Condition::getOperator, Condition::getErrorThreshold)
  90. .containsExactlyInAnyOrder(
  91. tuple(metric.getKey(), Condition.Operator.fromDbValue(condition.getOperator()), condition.getErrorThreshold()));
  92. }
  93. @Test
  94. public void getMetricsRelatedTo() {
  95. Condition condition = new Condition("metric1", Condition.Operator.GREATER_THAN, "10");
  96. QualityGate gate = new QualityGate("1", "foo", ImmutableSet.of(condition));
  97. Set<String> result = underTest.getMetricsRelatedTo(gate);
  98. assertThat(result).containsExactlyInAnyOrder(
  99. // the metrics needed to compute the status of gate
  100. condition.getMetricKey(),
  101. // generated metrics
  102. CoreMetrics.ALERT_STATUS_KEY, CoreMetrics.QUALITY_GATE_DETAILS_KEY);
  103. }
  104. @Test
  105. public void refreshGateStatus_generates_gate_related_measures() {
  106. ComponentDto project = ComponentTesting.newPublicProjectDto();
  107. MetricDto conditionMetric = newMetricDto();
  108. MetricDto statusMetric = newMetricDto().setKey(CoreMetrics.ALERT_STATUS_KEY);
  109. MetricDto detailsMetric = newMetricDto().setKey(CoreMetrics.QUALITY_GATE_DETAILS_KEY);
  110. Condition condition = new Condition(conditionMetric.getKey(), Condition.Operator.GREATER_THAN, "10");
  111. QualityGate gate = new QualityGate("1", "foo", ImmutableSet.of(condition));
  112. MeasureMatrix matrix = new MeasureMatrix(singleton(project), asList(conditionMetric, statusMetric, detailsMetric), emptyList());
  113. EvaluatedQualityGate result = underTest.refreshGateStatus(project, gate, matrix, configuration);
  114. QualityGateEvaluator.Measures measures = qualityGateEvaluator.getCalledMeasures();
  115. assertThat(measures.get(conditionMetric.getKey())).isEmpty();
  116. assertThat(result.getStatus()).isEqualTo(Metric.Level.OK);
  117. assertThat(result.getEvaluatedConditions())
  118. .extracting(EvaluatedCondition::getStatus)
  119. .containsExactly(EvaluatedCondition.EvaluationStatus.OK);
  120. assertThat(matrix.getMeasure(project, CoreMetrics.ALERT_STATUS_KEY).get().getDataAsString()).isEqualTo(Metric.Level.OK.name());
  121. assertThat(matrix.getMeasure(project, CoreMetrics.QUALITY_GATE_DETAILS_KEY).get().getDataAsString())
  122. .isNotEmpty()
  123. // json format
  124. .startsWith("{").endsWith("}");
  125. }
  126. @Test
  127. public void refreshGateStatus_provides_measures_to_evaluator() {
  128. ComponentDto project = ComponentTesting.newPublicProjectDto();
  129. MetricDto numericMetric = newMetricDto().setValueType(Metric.ValueType.FLOAT.name());
  130. MetricDto numericNewMetric = newMetricDto().setValueType(Metric.ValueType.FLOAT.name()).setKey("new_metric");
  131. MetricDto stringMetric = newMetricDto().setValueType(Metric.ValueType.STRING.name());
  132. MetricDto statusMetric = newMetricDto().setKey(CoreMetrics.ALERT_STATUS_KEY);
  133. MetricDto detailsMetric = newMetricDto().setKey(CoreMetrics.QUALITY_GATE_DETAILS_KEY);
  134. QualityGate gate = new QualityGate("1", "foo", Collections.emptySet());
  135. LiveMeasureDto numericMeasure = new LiveMeasureDto().setMetricUuid(numericMetric.getUuid()).setValue(1.23).setVariation(4.56).setComponentUuid(project.uuid());
  136. LiveMeasureDto numericNewMeasure = new LiveMeasureDto().setMetricUuid(numericNewMetric.getUuid()).setValue(7.8).setVariation(8.9).setComponentUuid(project.uuid());
  137. LiveMeasureDto stringMeasure = new LiveMeasureDto().setMetricUuid(stringMetric.getUuid()).setData("bar").setComponentUuid(project.uuid());
  138. MeasureMatrix matrix = new MeasureMatrix(singleton(project), asList(statusMetric, detailsMetric, numericMetric, numericNewMetric, stringMetric),
  139. asList(numericMeasure, numericNewMeasure, stringMeasure));
  140. underTest.refreshGateStatus(project, gate, matrix, configuration);
  141. QualityGateEvaluator.Measures measures = qualityGateEvaluator.getCalledMeasures();
  142. QualityGateEvaluator.Measure loadedStringMeasure = measures.get(stringMetric.getKey()).get();
  143. assertThat(loadedStringMeasure.getStringValue()).hasValue("bar");
  144. assertThat(loadedStringMeasure.getValue()).isEmpty();
  145. assertThat(loadedStringMeasure.getType()).isEqualTo(Metric.ValueType.STRING);
  146. QualityGateEvaluator.Measure loadedNumericMeasure = measures.get(numericMetric.getKey()).get();
  147. assertThat(loadedNumericMeasure.getStringValue()).isEmpty();
  148. assertThat(loadedNumericMeasure.getValue()).hasValue(1.23);
  149. assertThat(loadedNumericMeasure.getType()).isEqualTo(Metric.ValueType.FLOAT);
  150. QualityGateEvaluator.Measure loadedNumericNewMeasure = measures.get(numericNewMetric.getKey()).get();
  151. assertThat(loadedNumericNewMeasure.getStringValue()).isEmpty();
  152. assertThat(loadedNumericNewMeasure.getNewMetricValue()).hasValue(8.9);
  153. assertThat(loadedNumericNewMeasure.getType()).isEqualTo(Metric.ValueType.FLOAT);
  154. }
  155. private static class TestQualityGateEvaluator implements QualityGateEvaluator {
  156. private Measures measures;
  157. @Override
  158. public EvaluatedQualityGate evaluate(QualityGate gate, Measures measures, Configuration configuration) {
  159. checkState(this.measures == null);
  160. this.measures = measures;
  161. EvaluatedQualityGate.Builder builder = EvaluatedQualityGate.newBuilder().setQualityGate(gate).setStatus(Metric.Level.OK);
  162. for (Condition condition : gate.getConditions()) {
  163. builder.addEvaluatedCondition(condition, EvaluatedCondition.EvaluationStatus.OK, "bar");
  164. }
  165. return builder.build();
  166. }
  167. private Measures getCalledMeasures() {
  168. return measures;
  169. }
  170. @Override
  171. public Set<String> getMetricKeys(QualityGate gate) {
  172. return gate.getConditions().stream().map(Condition::getMetricKey).collect(Collectors.toSet());
  173. }
  174. }
  175. }