You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

IntegrateCrossProjectDuplicationsTest.java 13KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2019 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.ce.task.projectanalysis.duplication;
  21. import java.util.ArrayList;
  22. import java.util.Arrays;
  23. import java.util.Collection;
  24. import java.util.Collections;
  25. import org.junit.Rule;
  26. import org.junit.Test;
  27. import org.sonar.api.impl.config.MapSettings;
  28. import org.sonar.api.impl.utils.TestSystem2;
  29. import org.sonar.api.utils.log.LogTester;
  30. import org.sonar.api.utils.log.LoggerLevel;
  31. import org.sonar.ce.task.log.CeTaskMessages;
  32. import org.sonar.ce.task.projectanalysis.component.Component;
  33. import org.sonar.ce.task.projectanalysis.component.FileAttributes;
  34. import org.sonar.duplications.block.Block;
  35. import org.sonar.duplications.block.ByteArray;
  36. import static com.google.common.base.Strings.padStart;
  37. import static java.util.Arrays.asList;
  38. import static java.util.Collections.singletonList;
  39. import static org.apache.commons.lang.RandomStringUtils.randomAlphanumeric;
  40. import static org.assertj.core.api.Assertions.assertThat;
  41. import static org.mockito.Mockito.mock;
  42. import static org.mockito.Mockito.verify;
  43. import static org.sonar.ce.task.projectanalysis.component.Component.Type.FILE;
  44. import static org.sonar.ce.task.projectanalysis.component.ReportComponent.builder;
  45. public class IntegrateCrossProjectDuplicationsTest {
  46. private static final String XOO_LANGUAGE = "xoo";
  47. private static final String ORIGIN_FILE_KEY = "ORIGIN_FILE_KEY";
  48. private static final Component ORIGIN_FILE = builder(FILE, 1)
  49. .setKey(ORIGIN_FILE_KEY)
  50. .setFileAttributes(new FileAttributes(false, XOO_LANGUAGE, 1))
  51. .build();
  52. private static final String OTHER_FILE_KEY = "OTHER_FILE_KEY";
  53. @Rule
  54. public LogTester logTester = new LogTester();
  55. @Rule
  56. public DuplicationRepositoryRule duplicationRepository = DuplicationRepositoryRule.create();
  57. private TestSystem2 system = new TestSystem2();
  58. private MapSettings settings = new MapSettings();
  59. private CeTaskMessages ceTaskMessages = mock(CeTaskMessages.class);
  60. private IntegrateCrossProjectDuplications underTest = new IntegrateCrossProjectDuplications(settings.asConfig(), duplicationRepository, ceTaskMessages, system);
  61. @Test
  62. public void add_duplications_from_two_blocks() {
  63. settings.setProperty("sonar.cpd.xoo.minimumTokens", 10);
  64. Collection<Block> originBlocks = asList(
  65. new Block.Builder()
  66. .setResourceId(ORIGIN_FILE_KEY)
  67. .setBlockHash(new ByteArray("a8998353e96320ec"))
  68. .setIndexInFile(0)
  69. .setLines(30, 43)
  70. .setUnit(0, 5)
  71. .build(),
  72. new Block.Builder()
  73. .setResourceId(ORIGIN_FILE_KEY)
  74. .setBlockHash(new ByteArray("2b5747f0e4c59124"))
  75. .setIndexInFile(1)
  76. .setLines(32, 45)
  77. .setUnit(5, 20)
  78. .build());
  79. Collection<Block> duplicatedBlocks = asList(
  80. new Block.Builder()
  81. .setResourceId(OTHER_FILE_KEY)
  82. .setBlockHash(new ByteArray("a8998353e96320ec"))
  83. .setIndexInFile(0)
  84. .setLines(40, 53)
  85. .build(),
  86. new Block.Builder()
  87. .setResourceId(OTHER_FILE_KEY)
  88. .setBlockHash(new ByteArray("2b5747f0e4c59124"))
  89. .setIndexInFile(1)
  90. .setLines(42, 55)
  91. .build());
  92. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  93. assertThat(duplicationRepository.getDuplications(ORIGIN_FILE))
  94. .containsExactly(
  95. crossProjectDuplication(new TextBlock(30, 45), OTHER_FILE_KEY, new TextBlock(40, 55)));
  96. }
  97. @Test
  98. public void add_duplications_from_a_single_block() {
  99. settings.setProperty("sonar.cpd.xoo.minimumTokens", 10);
  100. Collection<Block> originBlocks = singletonList(
  101. // This block contains 11 tokens -> a duplication will be created
  102. new Block.Builder()
  103. .setResourceId(ORIGIN_FILE_KEY)
  104. .setBlockHash(new ByteArray("a8998353e96320ec"))
  105. .setIndexInFile(0)
  106. .setLines(30, 45)
  107. .setUnit(0, 10)
  108. .build());
  109. Collection<Block> duplicatedBlocks = singletonList(
  110. new Block.Builder()
  111. .setResourceId(OTHER_FILE_KEY)
  112. .setBlockHash(new ByteArray("a8998353e96320ec"))
  113. .setIndexInFile(0)
  114. .setLines(40, 55)
  115. .build());
  116. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  117. assertThat(duplicationRepository.getDuplications(ORIGIN_FILE))
  118. .containsExactly(
  119. crossProjectDuplication(new TextBlock(30, 45), OTHER_FILE_KEY, new TextBlock(40, 55)));
  120. }
  121. @Test
  122. public void add_no_duplication_from_current_file() {
  123. settings.setProperty("sonar.cpd.xoo.minimumTokens", 10);
  124. Collection<Block> originBlocks = asList(
  125. new Block.Builder()
  126. .setResourceId(ORIGIN_FILE_KEY)
  127. .setBlockHash(new ByteArray("a8998353e96320ec"))
  128. .setIndexInFile(0)
  129. .setLines(30, 45)
  130. .setUnit(0, 10)
  131. .build(),
  132. // Duplication is on the same file
  133. new Block.Builder()
  134. .setResourceId(ORIGIN_FILE_KEY)
  135. .setBlockHash(new ByteArray("a8998353e96320ec"))
  136. .setIndexInFile(0)
  137. .setLines(46, 60)
  138. .setUnit(0, 10)
  139. .build());
  140. Collection<Block> duplicatedBlocks = singletonList(
  141. new Block.Builder()
  142. .setResourceId(OTHER_FILE_KEY)
  143. .setBlockHash(new ByteArray("a8998353e96320ed"))
  144. .setIndexInFile(0)
  145. .setLines(40, 55)
  146. .build());
  147. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  148. assertNoDuplicationAdded(ORIGIN_FILE);
  149. }
  150. @Test
  151. public void add_no_duplication_when_not_enough_tokens() {
  152. settings.setProperty("sonar.cpd.xoo.minimumTokens", 10);
  153. Collection<Block> originBlocks = singletonList(
  154. // This block contains 5 tokens -> not enough to consider it as a duplication
  155. new Block.Builder()
  156. .setResourceId(ORIGIN_FILE_KEY)
  157. .setBlockHash(new ByteArray("a8998353e96320ec"))
  158. .setIndexInFile(0)
  159. .setLines(30, 45)
  160. .setUnit(0, 4)
  161. .build());
  162. Collection<Block> duplicatedBlocks = singletonList(
  163. new Block.Builder()
  164. .setResourceId(OTHER_FILE_KEY)
  165. .setBlockHash(new ByteArray("a8998353e96320ec"))
  166. .setIndexInFile(0)
  167. .setLines(40, 55)
  168. .build());
  169. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  170. assertNoDuplicationAdded(ORIGIN_FILE);
  171. }
  172. @Test
  173. public void add_no_duplication_when_no_duplicated_blocks() {
  174. settings.setProperty("sonar.cpd.xoo.minimumTokens", 10);
  175. Collection<Block> originBlocks = singletonList(
  176. new Block.Builder()
  177. .setResourceId(ORIGIN_FILE_KEY)
  178. .setBlockHash(new ByteArray("a8998353e96320ec"))
  179. .setIndexInFile(0)
  180. .setLines(30, 45)
  181. .setUnit(0, 10)
  182. .build());
  183. underTest.computeCpd(ORIGIN_FILE, originBlocks, Collections.emptyList());
  184. assertNoDuplicationAdded(ORIGIN_FILE);
  185. }
  186. @Test
  187. public void add_duplication_for_java_even_when_no_token() {
  188. Component javaFile = builder(FILE, 1)
  189. .setKey(ORIGIN_FILE_KEY)
  190. .setFileAttributes(new FileAttributes(false, "java", 10))
  191. .build();
  192. Collection<Block> originBlocks = singletonList(
  193. // This block contains 0 token
  194. new Block.Builder()
  195. .setResourceId(ORIGIN_FILE_KEY)
  196. .setBlockHash(new ByteArray("a8998353e96320ec"))
  197. .setIndexInFile(0)
  198. .setLines(30, 45)
  199. .setUnit(0, 0)
  200. .build());
  201. Collection<Block> duplicatedBlocks = singletonList(
  202. new Block.Builder()
  203. .setResourceId(OTHER_FILE_KEY)
  204. .setBlockHash(new ByteArray("a8998353e96320ec"))
  205. .setIndexInFile(0)
  206. .setLines(40, 55)
  207. .build());
  208. underTest.computeCpd(javaFile, originBlocks, duplicatedBlocks);
  209. assertThat(duplicationRepository.getDuplications(ORIGIN_FILE))
  210. .containsExactly(
  211. crossProjectDuplication(new TextBlock(30, 45), OTHER_FILE_KEY, new TextBlock(40, 55)));
  212. }
  213. @Test
  214. public void default_minimum_tokens_is_one_hundred() {
  215. settings.setProperty("sonar.cpd.xoo.minimumTokens", (Integer) null);
  216. Collection<Block> originBlocks = singletonList(
  217. new Block.Builder()
  218. .setResourceId(ORIGIN_FILE_KEY)
  219. .setBlockHash(new ByteArray("a8998353e96320ec"))
  220. .setIndexInFile(0)
  221. .setLines(30, 45)
  222. .setUnit(0, 100)
  223. .build());
  224. Collection<Block> duplicatedBlocks = singletonList(
  225. new Block.Builder()
  226. .setResourceId(OTHER_FILE_KEY)
  227. .setBlockHash(new ByteArray("a8998353e96320ec"))
  228. .setIndexInFile(0)
  229. .setLines(40, 55)
  230. .build());
  231. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  232. assertThat(duplicationRepository.getDuplications(ORIGIN_FILE))
  233. .containsExactly(
  234. crossProjectDuplication(new TextBlock(30, 45), OTHER_FILE_KEY, new TextBlock(40, 55)));
  235. }
  236. @Test
  237. public void do_not_compute_more_than_one_hundred_duplications_when_too_many_duplicated_references() {
  238. Collection<Block> originBlocks = new ArrayList<>();
  239. Collection<Block> duplicatedBlocks = new ArrayList<>();
  240. Block.Builder blockBuilder = new Block.Builder()
  241. .setResourceId(ORIGIN_FILE_KEY)
  242. .setBlockHash(new ByteArray("a8998353e96320ec"))
  243. .setIndexInFile(0)
  244. .setLines(30, 45)
  245. .setUnit(0, 100);
  246. originBlocks.add(blockBuilder.build());
  247. // Generate more than 100 duplications of the same block
  248. for (int i = 0; i < 110; i++) {
  249. duplicatedBlocks.add(
  250. blockBuilder
  251. .setResourceId(randomAlphanumeric(16))
  252. .build());
  253. }
  254. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  255. assertThat(logTester.logs(LoggerLevel.WARN)).containsOnly(
  256. "Too many duplication references on file " + ORIGIN_FILE_KEY + " for block at line 30. Keeping only the first 100 references.");
  257. Iterable<Duplication> duplications = duplicationRepository.getDuplications(ORIGIN_FILE);
  258. assertThat(duplications).hasSize(1);
  259. assertThat(duplications.iterator().next().getDuplicates()).hasSize(100);
  260. }
  261. @Test
  262. public void do_not_compute_more_than_one_hundred_duplications_when_too_many_duplications() {
  263. Collection<Block> originBlocks = new ArrayList<>();
  264. Collection<Block> duplicatedBlocks = new ArrayList<>();
  265. Block.Builder blockBuilder = new Block.Builder()
  266. .setIndexInFile(0)
  267. .setLines(30, 45)
  268. .setUnit(0, 100);
  269. // Generate more than 100 duplication on different files
  270. for (int i = 0; i < 110; i++) {
  271. String hash = padStart("hash" + i, 16, 'a');
  272. originBlocks.add(
  273. blockBuilder
  274. .setResourceId(ORIGIN_FILE_KEY)
  275. .setBlockHash(new ByteArray(hash))
  276. .build());
  277. duplicatedBlocks.add(
  278. blockBuilder
  279. .setResourceId("resource" + i)
  280. .setBlockHash(new ByteArray(hash))
  281. .build());
  282. }
  283. underTest.computeCpd(ORIGIN_FILE, originBlocks, duplicatedBlocks);
  284. assertThat(duplicationRepository.getDuplications(ORIGIN_FILE)).hasSize(100);
  285. assertThat(logTester.logs(LoggerLevel.WARN)).containsOnly("Too many duplication groups on file " + ORIGIN_FILE_KEY + ". Keeping only the first 100 groups.");
  286. }
  287. @Test
  288. public void log_warning_if_this_deprecated_feature_is_enabled() {
  289. settings.setProperty("sonar.cpd.cross_project", "true");
  290. system.setNow(1000L);
  291. new IntegrateCrossProjectDuplications(settings.asConfig(), duplicationRepository, ceTaskMessages, system);
  292. assertThat(logTester.logs()).containsExactly("This analysis uses the deprecated cross-project duplication feature.");
  293. verify(ceTaskMessages).add(new CeTaskMessages.Message("This project uses the deprecated cross-project duplication feature.", 1000L));
  294. }
  295. private static Duplication crossProjectDuplication(TextBlock original, String otherFileKey, TextBlock duplicate) {
  296. return new Duplication(original, Arrays.asList(new CrossProjectDuplicate(otherFileKey, duplicate)));
  297. }
  298. private void assertNoDuplicationAdded(Component file) {
  299. assertThat(duplicationRepository.getDuplications(file)).isEmpty();
  300. }
  301. }