You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

ProjectTrackerBaseLazyInputTest.java 9.1KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2019 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.ce.task.projectanalysis.issue;
  21. import com.google.common.collect.ImmutableMap;
  22. import java.util.Collections;
  23. import java.util.Date;
  24. import org.junit.Before;
  25. import org.junit.Rule;
  26. import org.junit.Test;
  27. import org.sonar.api.impl.config.MapSettings;
  28. import org.sonar.api.utils.System2;
  29. import org.sonar.ce.task.projectanalysis.analysis.AnalysisMetadataHolderRule;
  30. import org.sonar.ce.task.projectanalysis.component.Component;
  31. import org.sonar.ce.task.projectanalysis.component.ReportComponent;
  32. import org.sonar.ce.task.projectanalysis.component.ReportModulesPath;
  33. import org.sonar.ce.task.projectanalysis.qualityprofile.ActiveRulesHolderRule;
  34. import org.sonar.core.issue.DefaultIssue;
  35. import org.sonar.db.DbClient;
  36. import org.sonar.db.DbTester;
  37. import org.sonar.db.component.ComponentDto;
  38. import org.sonar.db.issue.IssueDto;
  39. import org.sonar.db.rule.RuleDefinitionDto;
  40. import org.sonar.server.issue.IssueFieldsSetter;
  41. import static org.assertj.core.api.Assertions.assertThat;
  42. import static org.assertj.core.api.Assertions.tuple;
  43. import static org.mockito.Mockito.mock;
  44. import static org.mockito.Mockito.when;
  45. import static org.sonar.api.utils.DateUtils.parseDate;
  46. import static org.sonar.db.component.ComponentTesting.newDirectory;
  47. import static org.sonar.db.component.ComponentTesting.newFileDto;
  48. import static org.sonar.db.component.ComponentTesting.newModuleDto;
  49. public class ProjectTrackerBaseLazyInputTest {
  50. private static final Date ANALYSIS_DATE = parseDate("2016-06-01");
  51. @Rule
  52. public AnalysisMetadataHolderRule analysisMetadataHolder = new AnalysisMetadataHolderRule().setAnalysisDate(ANALYSIS_DATE);
  53. @Rule
  54. public DbTester dbTester = DbTester.create(System2.INSTANCE);
  55. @Rule
  56. public ActiveRulesHolderRule activeRulesHolderRule = new ActiveRulesHolderRule();
  57. @Rule
  58. public RuleRepositoryRule ruleRepositoryRule = new RuleRepositoryRule();
  59. private DbClient dbClient = dbTester.getDbClient();
  60. private ProjectTrackerBaseLazyInput underTest;
  61. private RuleDefinitionDto rule;
  62. private ComponentDto rootProjectDto;
  63. private ComponentIssuesLoader issuesLoader = new ComponentIssuesLoader(dbTester.getDbClient(), ruleRepositoryRule, activeRulesHolderRule, new MapSettings().asConfig(),
  64. System2.INSTANCE);
  65. private ReportModulesPath reportModulesPath;
  66. @Before
  67. public void prepare() {
  68. rule = dbTester.rules().insert();
  69. ruleRepositoryRule.add(rule.getKey());
  70. rootProjectDto = dbTester.components().insertMainBranch();
  71. ReportComponent rootProject = ReportComponent.builder(Component.Type.FILE, 1)
  72. .setKey(rootProjectDto.getDbKey())
  73. .setUuid(rootProjectDto.uuid()).build();
  74. reportModulesPath = mock(ReportModulesPath.class);
  75. underTest = new ProjectTrackerBaseLazyInput(analysisMetadataHolder, mock(ComponentsWithUnprocessedIssues.class), dbClient, new IssueFieldsSetter(), issuesLoader,
  76. reportModulesPath, rootProject);
  77. }
  78. @Test
  79. public void return_only_open_project_issues_if_no_modules_and_folders() {
  80. ComponentDto file = dbTester.components().insertComponent(newFileDto(rootProjectDto));
  81. IssueDto openIssueOnProject = dbTester.issues().insert(rule, rootProjectDto, rootProjectDto, i -> i.setStatus("OPEN").setResolution(null));
  82. IssueDto closedIssueOnProject = dbTester.issues().insert(rule, rootProjectDto, rootProjectDto, i -> i.setStatus("CLOSED").setResolution("FIXED"));
  83. IssueDto openIssue1OnFile = dbTester.issues().insert(rule, rootProjectDto, file, i -> i.setStatus("OPEN").setResolution(null));
  84. assertThat(underTest.loadIssues()).extracting(DefaultIssue::key).containsOnly(openIssueOnProject.getKey());
  85. }
  86. @Test
  87. public void migrate_and_return_folder_issues_on_root_project() {
  88. when(reportModulesPath.get()).thenReturn(Collections.emptyMap());
  89. ComponentDto folder = dbTester.components().insertComponent(newDirectory(rootProjectDto, "src"));
  90. ComponentDto file = dbTester.components().insertComponent(newFileDto(rootProjectDto));
  91. IssueDto openIssueOnProject = dbTester.issues().insert(rule, rootProjectDto, rootProjectDto, i -> i.setStatus("OPEN").setResolution(null));
  92. IssueDto openIssueOnDir = dbTester.issues().insert(rule, rootProjectDto, folder, i -> i.setStatus("OPEN").setMessage("Issue on dir").setResolution(null));
  93. IssueDto openIssue1OnFile = dbTester.issues().insert(rule, rootProjectDto, file, i -> i.setStatus("OPEN").setResolution(null));
  94. assertThat(underTest.loadIssues()).extracting(DefaultIssue::key, DefaultIssue::getMessage)
  95. .containsExactlyInAnyOrder(
  96. tuple(openIssueOnProject.getKey(), openIssueOnProject.getMessage()),
  97. tuple(openIssueOnDir.getKey(), "[src] Issue on dir"));
  98. }
  99. @Test
  100. public void migrate_and_return_module_and_folder_issues_on_module() {
  101. ComponentDto module = dbTester.components().insertComponent(newModuleDto(rootProjectDto).setPath("moduleAInDb"));
  102. when(reportModulesPath.get()).thenReturn(ImmutableMap.of(module.getDbKey(), "moduleAInReport"));
  103. ComponentDto folder = dbTester.components().insertComponent(newDirectory(module, "src"));
  104. ComponentDto file = dbTester.components().insertComponent(newFileDto(module));
  105. IssueDto openIssueOnProject = dbTester.issues().insert(rule, rootProjectDto, rootProjectDto, i -> i.setStatus("OPEN").setResolution(null));
  106. IssueDto openIssueOnModule = dbTester.issues().insert(rule, rootProjectDto, module, i -> i.setStatus("OPEN").setMessage("Issue on module").setResolution(null));
  107. IssueDto openIssueOnDir = dbTester.issues().insert(rule, rootProjectDto, folder, i -> i.setStatus("OPEN").setMessage("Issue on dir").setResolution(null));
  108. IssueDto openIssue1OnFile = dbTester.issues().insert(rule, rootProjectDto, file, i -> i.setStatus("OPEN").setResolution(null));
  109. assertThat(underTest.loadIssues()).extracting(DefaultIssue::key, DefaultIssue::getMessage)
  110. .containsExactlyInAnyOrder(
  111. tuple(openIssueOnProject.getKey(), openIssueOnProject.getMessage()),
  112. tuple(openIssueOnModule.getKey(), "[moduleAInReport] Issue on module"),
  113. tuple(openIssueOnDir.getKey(), "[moduleAInReport/src] Issue on dir"));
  114. }
  115. @Test
  116. public void use_db_path_if_module_missing_in_report() {
  117. ComponentDto module = dbTester.components().insertComponent(newModuleDto(rootProjectDto).setPath("moduleAInDb"));
  118. when(reportModulesPath.get()).thenReturn(Collections.emptyMap());
  119. ComponentDto folder = dbTester.components().insertComponent(newDirectory(module, "src"));
  120. IssueDto openIssueOnProject = dbTester.issues().insert(rule, rootProjectDto, rootProjectDto, i -> i.setStatus("OPEN").setResolution(null));
  121. IssueDto openIssueOnModule = dbTester.issues().insert(rule, rootProjectDto, module, i -> i.setStatus("OPEN").setMessage("Issue on module").setResolution(null));
  122. IssueDto openIssueOnDir = dbTester.issues().insert(rule, rootProjectDto, folder, i -> i.setStatus("OPEN").setMessage("Issue on dir").setResolution(null));
  123. assertThat(underTest.loadIssues()).extracting(DefaultIssue::key, DefaultIssue::getMessage)
  124. .containsExactlyInAnyOrder(
  125. tuple(openIssueOnProject.getKey(), openIssueOnProject.getMessage()),
  126. tuple(openIssueOnModule.getKey(), "[moduleAInDb] Issue on module"),
  127. tuple(openIssueOnDir.getKey(), "[moduleAInDb/src] Issue on dir"));
  128. }
  129. @Test
  130. public void empty_path_if_module_missing_in_report_and_db_and_for_slash_folder () {
  131. ComponentDto module = dbTester.components().insertComponent(newModuleDto(rootProjectDto).setPath(null));
  132. when(reportModulesPath.get()).thenReturn(Collections.emptyMap());
  133. ComponentDto folder = dbTester.components().insertComponent(newDirectory(module, "/"));
  134. IssueDto openIssueOnProject = dbTester.issues().insert(rule, rootProjectDto, rootProjectDto, i -> i.setStatus("OPEN").setResolution(null));
  135. IssueDto openIssueOnModule = dbTester.issues().insert(rule, rootProjectDto, module, i -> i.setStatus("OPEN").setMessage("Issue on module").setResolution(null));
  136. IssueDto openIssueOnDir = dbTester.issues().insert(rule, rootProjectDto, folder, i -> i.setStatus("OPEN").setMessage("Issue on dir").setResolution(null));
  137. assertThat(underTest.loadIssues()).extracting(DefaultIssue::key, DefaultIssue::getMessage)
  138. .containsExactlyInAnyOrder(
  139. tuple(openIssueOnProject.getKey(), openIssueOnProject.getMessage()),
  140. tuple(openIssueOnModule.getKey(), "Issue on module"),
  141. tuple(openIssueOnDir.getKey(), "Issue on dir"));
  142. }
  143. }