You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

UsersActionIT.java 15KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2023 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.permission.ws;
  21. import java.util.Set;
  22. import org.junit.Test;
  23. import org.sonar.api.resources.Qualifiers;
  24. import org.sonar.api.resources.ResourceTypes;
  25. import org.sonar.api.server.ws.WebService.Param;
  26. import org.sonar.api.server.ws.WebService.SelectionMode;
  27. import org.sonar.api.web.UserRole;
  28. import org.sonar.db.component.ComponentDto;
  29. import org.sonar.db.component.ResourceTypesRule;
  30. import org.sonar.db.permission.GlobalPermission;
  31. import org.sonar.db.project.ProjectDto;
  32. import org.sonar.db.user.UserDto;
  33. import org.sonar.server.exceptions.BadRequestException;
  34. import org.sonar.server.exceptions.ForbiddenException;
  35. import org.sonar.server.exceptions.NotFoundException;
  36. import org.sonar.server.exceptions.UnauthorizedException;
  37. import org.sonar.server.common.avatar.AvatarResolverImpl;
  38. import org.sonar.server.management.ManagedInstanceService;
  39. import org.sonar.server.permission.PermissionService;
  40. import org.sonar.server.permission.PermissionServiceImpl;
  41. import org.sonar.server.permission.RequestValidator;
  42. import static java.util.function.Function.identity;
  43. import static java.util.stream.Collectors.toMap;
  44. import static org.apache.commons.lang.StringUtils.countMatches;
  45. import static org.assertj.core.api.Assertions.assertThat;
  46. import static org.assertj.core.api.Assertions.assertThatThrownBy;
  47. import static org.mockito.ArgumentMatchers.any;
  48. import static org.mockito.Mockito.mock;
  49. import static org.mockito.Mockito.when;
  50. import static org.sonar.api.server.ws.WebService.Param.PAGE;
  51. import static org.sonar.api.server.ws.WebService.Param.PAGE_SIZE;
  52. import static org.sonar.api.server.ws.WebService.Param.TEXT_QUERY;
  53. import static org.sonar.db.user.UserTesting.newUserDto;
  54. import static org.sonar.test.JsonAssert.assertJson;
  55. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION;
  56. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_ID;
  57. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_KEY;
  58. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_USER_LOGIN;
  59. public class UsersActionIT extends BasePermissionWsIT<UsersAction> {
  60. private final ResourceTypes resourceTypes = new ResourceTypesRule().setRootQualifiers(Qualifiers.PROJECT);
  61. private final PermissionService permissionService = new PermissionServiceImpl(resourceTypes);
  62. private final WsParameters wsParameters = new WsParameters(permissionService);
  63. private final RequestValidator requestValidator = new RequestValidator(permissionService);
  64. private final ManagedInstanceService managedInstanceService = mock(ManagedInstanceService.class);
  65. @Override
  66. protected UsersAction buildWsAction() {
  67. return new UsersAction(db.getDbClient(), userSession, newPermissionWsSupport(), new AvatarResolverImpl(), wsParameters, requestValidator, managedInstanceService);
  68. }
  69. @Test
  70. public void search_for_users_with_response_example() {
  71. UserDto user1 = db.users().insertUser(newUserDto().setLogin("admin").setName("Administrator").setEmail("admin@admin.com"));
  72. UserDto user2 = db.users().insertUser(newUserDto().setLogin("adam.west").setName("Adam West").setEmail("adamwest@adamwest.com"));
  73. UserDto user3 = db.users().insertUser(newUserDto().setLogin("george.orwell").setName("George Orwell").setEmail("george.orwell@1984.net"));
  74. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.ADMINISTER_QUALITY_PROFILES);
  75. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.ADMINISTER);
  76. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.ADMINISTER_QUALITY_GATES);
  77. db.users().insertGlobalPermissionOnUser(user3, GlobalPermission.SCAN);
  78. mockUsersAsManaged(user3.getUuid());
  79. loginAsAdmin();
  80. String result = newRequest().execute().getInput();
  81. assertJson(result).withStrictArrayOrder().isSimilarTo(getClass().getResource("users-example.json"));
  82. }
  83. @Test
  84. public void search_for_users_with_one_permission() {
  85. insertUsersHavingGlobalPermissions();
  86. loginAsAdmin();
  87. String result = newRequest().setParam("permission", "scan").execute().getInput();
  88. assertJson(result).withStrictArrayOrder().isSimilarTo(getClass().getResource("UsersActionIT/users.json"));
  89. }
  90. @Test
  91. public void search_for_users_with_permission_on_project() {
  92. // User has permission on project
  93. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  94. UserDto user = db.users().insertUser(newUserDto());
  95. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  96. // User has permission on another project
  97. ProjectDto anotherProject = db.components().insertPrivateProject().getProjectDto();
  98. UserDto userHavePermissionOnAnotherProject = db.users().insertUser(newUserDto());
  99. db.users().insertProjectPermissionOnUser(userHavePermissionOnAnotherProject, UserRole.ISSUE_ADMIN, anotherProject);
  100. // User has no permission
  101. UserDto withoutPermission = db.users().insertUser(newUserDto());
  102. userSession.logIn().addProjectPermission(GlobalPermission.ADMINISTER.getKey(), project);
  103. String result = newRequest()
  104. .setParam(PARAM_PERMISSION, UserRole.ISSUE_ADMIN)
  105. .setParam(PARAM_PROJECT_ID, project.getUuid())
  106. .execute()
  107. .getInput();
  108. assertThat(result).contains(user.getLogin())
  109. .doesNotContain(userHavePermissionOnAnotherProject.getLogin())
  110. .doesNotContain(withoutPermission.getLogin());
  111. }
  112. @Test
  113. public void search_also_for_users_without_permission_when_filtering_name() {
  114. // User with permission on project
  115. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  116. UserDto user = db.users().insertUser(newUserDto("with-permission-login", "with-permission-name", "with-permission-email"));
  117. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  118. // User without permission
  119. UserDto withoutPermission = db.users().insertUser(newUserDto("without-permission-login", "without-permission-name", "without-permission-email"));
  120. UserDto anotherUser = db.users().insertUser(newUserDto("another-user", "another-user", "another-user"));
  121. loginAsAdmin();
  122. String result = newRequest()
  123. .setParam(PARAM_PROJECT_ID, project.getUuid())
  124. .setParam(TEXT_QUERY, "with")
  125. .execute()
  126. .getInput();
  127. assertThat(result).contains(user.getLogin(), withoutPermission.getLogin()).doesNotContain(anotherUser.getLogin());
  128. }
  129. @Test
  130. public void search_also_for_users_without_permission_when_filtering_email() {
  131. // User with permission on project
  132. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  133. UserDto user = db.users().insertUser(newUserDto("with-permission-login", "with-permission-name", "with-permission-email"));
  134. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  135. // User without permission
  136. UserDto withoutPermission = db.users().insertUser(newUserDto("without-permission-login", "without-permission-name", "without-permission-email"));
  137. UserDto anotherUser = db.users().insertUser(newUserDto("another-user", "another-user", "another-user"));
  138. loginAsAdmin();
  139. String result = newRequest().setParam(PARAM_PROJECT_ID, project.getUuid()).setParam(TEXT_QUERY, "email").execute().getInput();
  140. assertThat(result).contains(user.getLogin(), withoutPermission.getLogin()).doesNotContain(anotherUser.getLogin());
  141. }
  142. @Test
  143. public void search_also_for_users_without_permission_when_filtering_login() {
  144. // User with permission on project
  145. ProjectDto project = db.components().insertPrivateProject().getProjectDto();
  146. UserDto user = db.users().insertUser(newUserDto("with-permission-login", "with-permission-name", "with-permission-email"));
  147. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  148. // User without permission
  149. UserDto withoutPermission = db.users().insertUser(newUserDto("without-permission-login", "without-permission-name", "without-permission-email"));
  150. UserDto anotherUser = db.users().insertUser(newUserDto("another-user", "another-user", "another-user"));
  151. loginAsAdmin();
  152. String result = newRequest().setParam(PARAM_PROJECT_ID, project.getUuid()).setParam(TEXT_QUERY, "login").execute().getInput();
  153. assertThat(result).contains(user.getLogin(), withoutPermission.getLogin()).doesNotContain(anotherUser.getLogin());
  154. }
  155. @Test
  156. public void search_for_users_with_query_as_a_parameter() {
  157. insertUsersHavingGlobalPermissions();
  158. loginAsAdmin();
  159. String result = newRequest()
  160. .setParam("permission", "scan")
  161. .setParam(TEXT_QUERY, "ame-1")
  162. .execute()
  163. .getInput();
  164. assertThat(result).contains("login-1")
  165. .doesNotContain("login-2")
  166. .doesNotContain("login-3");
  167. }
  168. @Test
  169. public void search_for_users_with_select_as_a_parameter() {
  170. insertUsersHavingGlobalPermissions();
  171. loginAsAdmin();
  172. String result = newRequest()
  173. .execute()
  174. .getInput();
  175. assertThat(result).contains("login-1", "login-2", "login-3");
  176. }
  177. @Test
  178. public void search_for_users_is_paginated() {
  179. for (int i = 9; i >= 0; i--) {
  180. UserDto user = db.users().insertUser(newUserDto().setName("user-" + i));
  181. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.ADMINISTER);
  182. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.ADMINISTER_QUALITY_GATES);
  183. }
  184. loginAsAdmin();
  185. assertJson(newRequest().setParam(PAGE, "1").setParam(PAGE_SIZE, "2").execute().getInput()).withStrictArrayOrder().isSimilarTo("{\n" +
  186. " \"paging\": {\n" +
  187. " \"pageIndex\": 1,\n" +
  188. " \"pageSize\": 2,\n" +
  189. " \"total\": 10\n" +
  190. " },\n" +
  191. " \"users\": [\n" +
  192. " {\n" +
  193. " \"name\": \"user-0\"\n" +
  194. " },\n" +
  195. " {\n" +
  196. " \"name\": \"user-1\"\n" +
  197. " }\n" +
  198. " ]\n" +
  199. "}");
  200. assertJson(newRequest().setParam(PAGE, "3").setParam(PAGE_SIZE, "4").execute().getInput()).withStrictArrayOrder().isSimilarTo("{\n" +
  201. " \"paging\": {\n" +
  202. " \"pageIndex\": 3,\n" +
  203. " \"pageSize\": 4,\n" +
  204. " \"total\": 10\n" +
  205. " },\n" +
  206. " \"users\": [\n" +
  207. " {\n" +
  208. " \"name\": \"user-8\"\n" +
  209. " },\n" +
  210. " {\n" +
  211. " \"name\": \"user-9\"\n" +
  212. " }\n" +
  213. " ]\n" +
  214. "}");
  215. }
  216. @Test
  217. public void return_more_than_20_permissions() {
  218. loginAsAdmin();
  219. for (int i = 0; i < 30; i++) {
  220. UserDto user = db.users().insertUser(newUserDto().setLogin("user-" + i));
  221. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.SCAN);
  222. db.users().insertGlobalPermissionOnUser(user, GlobalPermission.PROVISION_PROJECTS);
  223. }
  224. String result = newRequest()
  225. .setParam(PAGE_SIZE, "100")
  226. .execute()
  227. .getInput();
  228. assertThat(countMatches(result, "scan")).isEqualTo(30);
  229. }
  230. @Test
  231. public void fail_if_project_permission_without_project() {
  232. loginAsAdmin();
  233. assertThatThrownBy(() -> {
  234. newRequest()
  235. .setParam(PARAM_PERMISSION, UserRole.ISSUE_ADMIN)
  236. .setParam(Param.SELECTED, SelectionMode.ALL.value())
  237. .execute();
  238. })
  239. .isInstanceOf(BadRequestException.class);
  240. }
  241. @Test
  242. public void fail_if_insufficient_privileges() {
  243. userSession.logIn("login");
  244. assertThatThrownBy(() -> {
  245. newRequest()
  246. .setParam("permission", GlobalPermission.ADMINISTER.getKey())
  247. .execute();
  248. })
  249. .isInstanceOf(ForbiddenException.class);
  250. }
  251. @Test
  252. public void fail_if_not_logged_in() {
  253. userSession.anonymous();
  254. assertThatThrownBy(() -> {
  255. newRequest()
  256. .setParam("permission", GlobalPermission.ADMINISTER.getKey())
  257. .execute();
  258. })
  259. .isInstanceOf(UnauthorizedException.class);
  260. }
  261. @Test
  262. public void fail_if_project_uuid_and_project_key_are_provided() {
  263. ComponentDto project = db.components().insertPrivateProject().getMainBranchComponent();
  264. loginAsAdmin();
  265. assertThatThrownBy(() -> newRequest()
  266. .setParam(PARAM_PERMISSION, GlobalPermission.ADMINISTER.getKey())
  267. .setParam(PARAM_PROJECT_ID, project.uuid())
  268. .setParam(PARAM_PROJECT_KEY, project.getKey())
  269. .execute())
  270. .isInstanceOf(BadRequestException.class)
  271. .hasMessage("Project id or project key can be provided, not both.");
  272. }
  273. @Test
  274. public void fail_if_search_query_is_too_short() {
  275. loginAsAdmin();
  276. assertThatThrownBy(() -> newRequest().setParam(TEXT_QUERY, "ab").execute())
  277. .isInstanceOf(IllegalArgumentException.class)
  278. .hasMessage("'q' length (2) is shorter than the minimum authorized (3)");
  279. }
  280. @Test
  281. public void fail_when_using_branch_uuid() {
  282. UserDto user = db.users().insertUser(newUserDto());
  283. ComponentDto project = db.components().insertPublicProject().getMainBranchComponent();
  284. ComponentDto branch = db.components().insertProjectBranch(project);
  285. db.users().insertProjectPermissionOnUser(user, UserRole.ISSUE_ADMIN, project);
  286. userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
  287. assertThatThrownBy(() -> {
  288. newRequest()
  289. .setParam(PARAM_PROJECT_ID, branch.uuid())
  290. .setParam(PARAM_USER_LOGIN, user.getLogin())
  291. .setParam(PARAM_PERMISSION, GlobalPermission.ADMINISTER.getKey())
  292. .execute();
  293. })
  294. .isInstanceOf(NotFoundException.class)
  295. .hasMessage("Entity not found");
  296. }
  297. private void insertUsersHavingGlobalPermissions() {
  298. UserDto user1 = db.users().insertUser(newUserDto("login-1", "name-1", "email-1"));
  299. UserDto user2 = db.users().insertUser(newUserDto("login-2", "name-2", "email-2"));
  300. UserDto user3 = db.users().insertUser(newUserDto("login-3", "name-3", "email-3"));
  301. db.users().insertGlobalPermissionOnUser(user1, GlobalPermission.SCAN);
  302. db.users().insertGlobalPermissionOnUser(user2, GlobalPermission.SCAN);
  303. db.users().insertGlobalPermissionOnUser(user3, GlobalPermission.ADMINISTER);
  304. mockUsersAsManaged(user1.getUuid());
  305. }
  306. private void mockUsersAsManaged(String... userUuids) {
  307. when(managedInstanceService.getUserUuidToManaged(any(), any())).thenAnswer(invocation ->
  308. {
  309. Set<?> allUsersUuids = invocation.getArgument(1, Set.class);
  310. return allUsersUuids.stream()
  311. .map(userUuid -> (String) userUuid)
  312. .collect(toMap(identity(), userUuid -> Set.of(userUuids).contains(userUuid)));
  313. }
  314. );
  315. }
  316. }