您最多选择25个主题 主题必须以字母或数字开头,可以包含连字符 (-),并且长度不得超过35个字符

ShowActionIT.java 10KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2023 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.newcodeperiod.ws;
  21. import org.junit.Before;
  22. import org.junit.Rule;
  23. import org.junit.Test;
  24. import org.sonar.api.server.ws.WebService;
  25. import org.sonar.api.utils.System2;
  26. import org.sonar.api.web.UserRole;
  27. import org.sonar.core.documentation.DocumentationLinkGenerator;
  28. import org.sonar.core.util.UuidFactoryFast;
  29. import org.sonar.db.DbClient;
  30. import org.sonar.db.DbTester;
  31. import org.sonar.db.component.BranchDto;
  32. import org.sonar.db.newcodeperiod.NewCodePeriodDao;
  33. import org.sonar.db.newcodeperiod.NewCodePeriodDbTester;
  34. import org.sonar.db.newcodeperiod.NewCodePeriodDto;
  35. import org.sonar.db.newcodeperiod.NewCodePeriodType;
  36. import org.sonar.db.project.ProjectDto;
  37. import org.sonar.server.component.ComponentFinder;
  38. import org.sonar.server.component.TestComponentFinder;
  39. import org.sonar.server.exceptions.ForbiddenException;
  40. import org.sonar.server.tester.UserSessionRule;
  41. import org.sonar.server.ws.WsActionTester;
  42. import org.sonarqube.ws.NewCodePeriods;
  43. import org.sonarqube.ws.NewCodePeriods.ShowWSResponse;
  44. import static org.assertj.core.api.Assertions.assertThat;
  45. import static org.assertj.core.api.Assertions.assertThatThrownBy;
  46. import static org.mockito.ArgumentMatchers.any;
  47. import static org.mockito.Mockito.mock;
  48. import static org.mockito.Mockito.when;
  49. import static org.sonarqube.ws.NewCodePeriods.NewCodePeriodType.NUMBER_OF_DAYS;
  50. import static org.sonarqube.ws.NewCodePeriods.NewCodePeriodType.PREVIOUS_VERSION;
  51. public class ShowActionIT {
  52. @Rule
  53. public UserSessionRule userSession = UserSessionRule.standalone();
  54. @Rule
  55. public DbTester db = DbTester.create(System2.INSTANCE);
  56. private DbClient dbClient = db.getDbClient();
  57. private ComponentFinder componentFinder = TestComponentFinder.from(db);
  58. private NewCodePeriodDao dao = new NewCodePeriodDao(System2.INSTANCE, UuidFactoryFast.getInstance());
  59. private NewCodePeriodDbTester tester = new NewCodePeriodDbTester(db);
  60. private DocumentationLinkGenerator documentationLinkGenerator = mock(DocumentationLinkGenerator.class);
  61. private WsActionTester ws;
  62. @Before
  63. public void setup() {
  64. when(documentationLinkGenerator.getDocumentationLink(any())).thenReturn("https://docs.sonarsource.com/sonarqube/latest/project-administration/defining-new-code/");
  65. ws = new WsActionTester(new ShowAction(dbClient, userSession, componentFinder, dao, documentationLinkGenerator));
  66. }
  67. @Test
  68. public void test_definition() {
  69. WebService.Action definition = ws.getDef();
  70. assertThat(definition.description()).contains("https://docs.sonarsource.com/sonarqube/latest/project-administration/defining-new-code/");
  71. assertThat(definition.key()).isEqualTo("show");
  72. assertThat(definition.isInternal()).isFalse();
  73. assertThat(definition.since()).isEqualTo("8.0");
  74. assertThat(definition.isPost()).isFalse();
  75. assertThat(definition.params()).extracting(WebService.Param::key).containsOnly("project", "branch");
  76. assertThat(definition.param("project").isRequired()).isFalse();
  77. assertThat(definition.param("branch").isRequired()).isFalse();
  78. }
  79. @Test
  80. public void throw_IAE_if_branch_is_specified_without_project() {
  81. assertThatThrownBy(() -> ws.newRequest()
  82. .setParam("branch", "branch")
  83. .execute())
  84. .isInstanceOf(IllegalArgumentException.class)
  85. .hasMessageContaining("If branch key is specified, project key needs to be specified too");
  86. }
  87. @Test
  88. public void throw_FE_if_no_project_permission() {
  89. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  90. assertThatThrownBy(() -> ws.newRequest()
  91. .setParam("project", project.getKey())
  92. .execute())
  93. .isInstanceOf(ForbiddenException.class)
  94. .hasMessageContaining("Insufficient privileges");
  95. }
  96. @Test
  97. public void throw_FE_if_project_issue_admin() {
  98. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  99. logInAsProjectIssueAdmin(project);
  100. assertThatThrownBy(() -> ws.newRequest()
  101. .setParam("project", project.getKey())
  102. .execute())
  103. .isInstanceOf(ForbiddenException.class)
  104. .hasMessageContaining("Insufficient privileges");
  105. }
  106. @Test
  107. public void show_global_setting() {
  108. tester.insert(new NewCodePeriodDto().setType(NewCodePeriodType.PREVIOUS_VERSION));
  109. ShowWSResponse response = ws.newRequest()
  110. .executeProtobuf(ShowWSResponse.class);
  111. assertResponse(response, "", "", PREVIOUS_VERSION, "", false, null);
  112. }
  113. @Test
  114. public void show_project_setting() {
  115. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  116. logInAsProjectAdministrator(project);
  117. var currentTime = System.currentTimeMillis();
  118. tester.insert(new NewCodePeriodDto()
  119. .setProjectUuid(project.getUuid())
  120. .setType(NewCodePeriodType.NUMBER_OF_DAYS)
  121. .setPreviousNonCompliantValue("100")
  122. .setUpdatedAt(currentTime)
  123. .setValue("90"));
  124. ShowWSResponse response = ws.newRequest()
  125. .setParam("project", project.getKey())
  126. .executeProtobuf(ShowWSResponse.class);
  127. assertResponse(response, project.getKey(), "", NUMBER_OF_DAYS, "90", false, "100");
  128. assertUpdatedAt(response, currentTime);
  129. }
  130. @Test
  131. public void show_branch_setting() {
  132. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  133. logInAsProjectAdministrator(project);
  134. BranchDto branch = db.components().insertProjectBranch(project, b -> b.setKey("branch"));
  135. tester.insert(new NewCodePeriodDto()
  136. .setProjectUuid(project.getUuid())
  137. .setBranchUuid(branch.getUuid())
  138. .setType(NewCodePeriodType.NUMBER_OF_DAYS)
  139. .setValue("1"));
  140. ShowWSResponse response = ws.newRequest()
  141. .setParam("project", project.getKey())
  142. .setParam("branch", "branch")
  143. .executeProtobuf(ShowWSResponse.class);
  144. assertResponse(response, project.getKey(), "branch", NUMBER_OF_DAYS, "1", false, null);
  145. }
  146. @Test
  147. public void show_inherited_project_setting() {
  148. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  149. logInAsProjectAdministrator(project);
  150. tester.insert(new NewCodePeriodDto().setType(NewCodePeriodType.PREVIOUS_VERSION));
  151. ShowWSResponse response = ws.newRequest()
  152. .setParam("project", project.getKey())
  153. .executeProtobuf(ShowWSResponse.class);
  154. assertResponse(response, project.getKey(), "", PREVIOUS_VERSION, "", true, null);
  155. }
  156. @Test
  157. public void show_inherited_branch_setting_from_project() {
  158. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  159. logInAsProjectAdministrator(project);
  160. BranchDto branch = db.components().insertProjectBranch(project, b -> b.setKey("branch"));
  161. tester.insert(new NewCodePeriodDto()
  162. .setProjectUuid(project.getUuid())
  163. .setType(NewCodePeriodType.NUMBER_OF_DAYS)
  164. .setValue("1"));
  165. ShowWSResponse response = ws.newRequest()
  166. .setParam("project", project.getKey())
  167. .setParam("branch", "branch")
  168. .executeProtobuf(ShowWSResponse.class);
  169. assertResponse(response, project.getKey(), "branch", NUMBER_OF_DAYS, "1", true, null);
  170. }
  171. @Test
  172. public void show_inherited_branch_setting_from_global() {
  173. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  174. logInAsProjectAdministrator(project);
  175. BranchDto branchDto = db.components().insertProjectBranch(project, b -> b.setKey("branch"));
  176. tester.insert(new NewCodePeriodDto().setType(NewCodePeriodType.NUMBER_OF_DAYS).setValue("3"));
  177. ShowWSResponse response = ws.newRequest()
  178. .setParam("project", project.getKey())
  179. .setParam("branch", "branch")
  180. .executeProtobuf(ShowWSResponse.class);
  181. assertResponse(response, project.getKey(), "branch", NUMBER_OF_DAYS, "3", true, null);
  182. }
  183. @Test
  184. public void show_inherited_if_project_not_found() {
  185. tester.insert(new NewCodePeriodDto().setType(NewCodePeriodType.NUMBER_OF_DAYS).setValue("3"));
  186. ShowWSResponse response = ws.newRequest()
  187. .setParam("project", "unknown")
  188. .executeProtobuf(ShowWSResponse.class);
  189. assertResponse(response, "", "", NUMBER_OF_DAYS, "3", true, null);
  190. }
  191. @Test
  192. public void show_inherited_if_branch_not_found() {
  193. ProjectDto project = db.components().insertPublicProject().getProjectDto();
  194. logInAsProjectScan(project);
  195. tester.insert(project.getUuid(), NewCodePeriodType.NUMBER_OF_DAYS, "3");
  196. ShowWSResponse response = ws.newRequest()
  197. .setParam("project", project.getKey())
  198. .setParam("branch", "unknown")
  199. .executeProtobuf(ShowWSResponse.class);
  200. assertResponse(response, project.getKey(), "", NUMBER_OF_DAYS, "3", true, null);
  201. }
  202. private void assertResponse(ShowWSResponse response, String projectKey, String branchKey, NewCodePeriods.NewCodePeriodType type, String value, boolean inherited,
  203. String previousNonCompliantValue) {
  204. assertThat(response.getBranchKey()).isEqualTo(branchKey);
  205. assertThat(response.getProjectKey()).isEqualTo(projectKey);
  206. assertThat(response.getInherited()).isEqualTo(inherited);
  207. assertThat(response.getValue()).isEqualTo(value);
  208. assertThat(response.getType()).isEqualTo(type);
  209. assertThat(response.getPreviousNonCompliantValue()).isEqualTo(previousNonCompliantValue == null ? "" : previousNonCompliantValue);
  210. }
  211. private static void assertUpdatedAt(ShowWSResponse response, long currentTime) {
  212. assertThat(response.getUpdatedAt()).isEqualTo(currentTime);
  213. }
  214. private void logInAsProjectAdministrator(ProjectDto project) {
  215. userSession.logIn().addProjectPermission(UserRole.ADMIN, project);
  216. }
  217. private void logInAsProjectScan(ProjectDto project) {
  218. userSession.logIn().addProjectPermission(UserRole.SCAN, project);
  219. }
  220. private void logInAsProjectIssueAdmin(ProjectDto project) {
  221. userSession.logIn().addProjectPermission(UserRole.ISSUE_ADMIN, project);
  222. }
  223. }