123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313 |
- /*
- * SonarQube
- * Copyright (C) 2009-2019 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.issue.ws;
-
- import java.util.Optional;
- import javax.annotation.Nullable;
- import org.junit.Rule;
- import org.junit.Test;
- import org.junit.rules.ExpectedException;
- import org.sonar.api.rules.RuleType;
- import org.sonar.api.utils.internal.TestSystem2;
- import org.sonar.db.DbClient;
- import org.sonar.db.DbSession;
- import org.sonar.db.DbTester;
- import org.sonar.db.issue.IssueDto;
- import org.sonar.db.organization.OrganizationDto;
- import org.sonar.db.user.UserDto;
- import org.sonar.server.es.EsTester;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.exceptions.NotFoundException;
- import org.sonar.server.exceptions.UnauthorizedException;
- import org.sonar.server.issue.IssueFieldsSetter;
- import org.sonar.server.issue.IssueFinder;
- import org.sonar.server.issue.WebIssueStorage;
- import org.sonar.server.issue.IssueUpdater;
- import org.sonar.server.issue.TestIssueChangePostProcessor;
- import org.sonar.server.issue.index.IssueIndexer;
- import org.sonar.server.issue.index.IssueIteratorFactory;
- import org.sonar.server.notification.NotificationManager;
- import org.sonar.server.organization.DefaultOrganizationProvider;
- import org.sonar.server.organization.TestDefaultOrganizationProvider;
- import org.sonar.server.rule.DefaultRuleFinder;
- import org.sonar.server.tester.UserSessionRule;
- import org.sonar.server.ws.WsActionTester;
-
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.junit.rules.ExpectedException.none;
- import static org.mockito.Mockito.mock;
- import static org.sonar.api.web.UserRole.CODEVIEWER;
- import static org.sonar.api.web.UserRole.USER;
- import static org.sonar.server.tester.UserSessionRule.standalone;
-
- public class AssignActionTest {
-
- private static final String PREVIOUS_ASSIGNEE = "previous";
- private static final String CURRENT_USER_LOGIN = "john";
- private static final String CURRENT_USER_UUID = "1";
-
- private static final long PAST = 10_000_000_000L;
- private static final long NOW = 50_000_000_000L;
-
- private TestSystem2 system2 = new TestSystem2().setNow(NOW);
-
- @Rule
- public ExpectedException expectedException = none();
- @Rule
- public UserSessionRule userSession = standalone();
- @Rule
- public EsTester es = EsTester.create();
- @Rule
- public DbTester db = DbTester.create(system2);
- public DbClient dbClient = db.getDbClient();
- private DbSession session = db.getSession();
-
- private DefaultOrganizationProvider defaultOrganizationProvider = TestDefaultOrganizationProvider.from(db);
- private IssueIndexer issueIndexer = new IssueIndexer(es.client(), dbClient, new IssueIteratorFactory(dbClient));
- private OperationResponseWriter responseWriter = mock(OperationResponseWriter.class);
- private TestIssueChangePostProcessor issueChangePostProcessor = new TestIssueChangePostProcessor();
- private AssignAction underTest = new AssignAction(system2, userSession, dbClient, new IssueFinder(dbClient, userSession), new IssueFieldsSetter(),
- new IssueUpdater(dbClient,
- new WebIssueStorage(system2, dbClient, new DefaultRuleFinder(dbClient, defaultOrganizationProvider), issueIndexer),
- mock(NotificationManager.class), issueChangePostProcessor),
- responseWriter);
- private WsActionTester ws = new WsActionTester(underTest);
-
- @Test
- public void assign_to_someone() {
- IssueDto issue = newIssueWithBrowsePermission();
- UserDto arthur = insertUser("arthur");
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "arthur")
- .execute();
-
- checkIssueAssignee(issue.getKey(), arthur.getUuid());
- Optional<IssueDto> optionalIssueDto = dbClient.issueDao().selectByKey(session, issue.getKey());
- assertThat(optionalIssueDto).isPresent();
- assertThat(optionalIssueDto.get().getAssigneeUuid()).isEqualTo(arthur.getUuid());
- assertThat(issueChangePostProcessor.wasCalled()).isFalse();
- }
-
- @Test
- public void assign_to_me() {
- IssueDto issue = newIssueWithBrowsePermission();
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "_me")
- .execute();
-
- checkIssueAssignee(issue.getKey(), CURRENT_USER_UUID);
- Optional<IssueDto> optionalIssueDto = dbClient.issueDao().selectByKey(session, issue.getKey());
- assertThat(optionalIssueDto).isPresent();
- assertThat(optionalIssueDto.get().getAssigneeUuid()).isEqualTo(CURRENT_USER_UUID);
- assertThat(issueChangePostProcessor.wasCalled()).isFalse();
- }
-
- @Test
- public void assign_to_me_using_deprecated_me_param() {
- IssueDto issue = newIssueWithBrowsePermission();
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("me", "true")
- .execute();
-
- checkIssueAssignee(issue.getKey(), CURRENT_USER_UUID);
- Optional<IssueDto> optionalIssueDto = dbClient.issueDao().selectByKey(session, issue.getKey());
- assertThat(optionalIssueDto).isPresent();
- assertThat(optionalIssueDto.get().getAssigneeUuid()).isEqualTo(CURRENT_USER_UUID);
- }
-
- @Test
- public void unassign() {
- IssueDto issue = newIssueWithBrowsePermission();
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .execute();
-
- checkIssueAssignee(issue.getKey(), null);
- Optional<IssueDto> optionalIssueDto = dbClient.issueDao().selectByKey(session, issue.getKey());
- assertThat(optionalIssueDto).isPresent();
- assertThat(optionalIssueDto.get().getAssigneeUuid()).isNull();
- assertThat(issueChangePostProcessor.wasCalled()).isFalse();
- }
-
- @Test
- public void unassign_with_empty_assignee_param() {
- IssueDto issue = newIssueWithBrowsePermission();
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "")
- .execute();
-
- checkIssueAssignee(issue.getKey(), null);
- Optional<IssueDto> optionalIssueDto = dbClient.issueDao().selectByKey(session, issue.getKey());
- assertThat(optionalIssueDto).isPresent();
- assertThat(optionalIssueDto.get().getAssigneeUuid()).isNull();
- assertThat(issueChangePostProcessor.wasCalled()).isFalse();
- }
-
- @Test
- public void nothing_to_do_when_new_assignee_is_same_as_old_one() {
- UserDto user = insertUser("Bob");
- IssueDto issue = newIssue(user.getUuid());
- setUserWithBrowsePermission(issue);
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", user.getLogin())
- .execute();
-
- IssueDto issueReloaded = dbClient.issueDao().selectByKey(db.getSession(), issue.getKey()).get();
- assertThat(issueReloaded.getAssigneeUuid()).isEqualTo(user.getUuid());
- assertThat(issueReloaded.getUpdatedAt()).isEqualTo(PAST);
- assertThat(issueReloaded.getIssueUpdateTime()).isEqualTo(PAST);
- }
-
- @Test
- public void fail_when_assignee_does_not_exist() {
- IssueDto issue = newIssueWithBrowsePermission();
-
- expectedException.expect(NotFoundException.class);
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "unknown")
- .execute();
- }
-
- @Test
- public void fail_when_trying_to_assign_hotspot() {
- IssueDto issueDto = db.issues().insertIssue(i -> i.setType(RuleType.SECURITY_HOTSPOT));
- setUserWithBrowsePermission(issueDto);
- UserDto arthur = insertUser("arthur");
-
- expectedException.expect(IllegalArgumentException.class);
- expectedException.expectMessage("It is not allowed to assign a security hotspot");
-
- ws.newRequest()
- .setParam("issue", issueDto.getKey())
- .setParam("assignee", "arthur")
- .execute();
- }
-
- @Test
- public void fail_when_assignee_is_disabled() {
- IssueDto issue = newIssueWithBrowsePermission();
- db.users().insertUser(user -> user.setActive(false));
-
- expectedException.expect(NotFoundException.class);
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "unknown")
- .execute();
- }
-
- @Test
- public void fail_when_not_authenticated() {
- IssueDto issue = newIssue(PREVIOUS_ASSIGNEE);
- userSession.anonymous();
-
- expectedException.expect(UnauthorizedException.class);
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "_me")
- .execute();
- }
-
- @Test
- public void fail_when_missing_browse_permission() {
- IssueDto issue = newIssue(PREVIOUS_ASSIGNEE);
- setUserWithPermission(issue, CODEVIEWER);
-
- expectedException.expect(ForbiddenException.class);
-
- ws.newRequest()
- .setParam("issue", issue.getKey())
- .setParam("assignee", "_me")
- .execute();
- }
-
- @Test
- public void fail_when_assignee_is_not_member_of_organization_of_project_issue() {
- OrganizationDto org = db.organizations().insert(organizationDto -> organizationDto.setKey("Organization key"));
- IssueDto issueDto = db.issues().insertIssue(org, i -> i.setType(RuleType.CODE_SMELL));
- setUserWithBrowsePermission(issueDto);
- OrganizationDto otherOrganization = db.organizations().insert();
- UserDto assignee = db.users().insertUser("arthur");
- db.organizations().addMember(otherOrganization, assignee);
-
- expectedException.expect(IllegalArgumentException.class);
- expectedException.expectMessage("User 'arthur' is not member of organization 'Organization key'");
-
- ws.newRequest()
- .setParam("issue", issueDto.getKey())
- .setParam("assignee", "arthur")
- .execute();
- }
-
- private UserDto insertUser(String login) {
- UserDto user = db.users().insertUser(login);
- db.organizations().addMember(db.getDefaultOrganization(), user);
- return user;
- }
-
- private IssueDto newIssue(String assignee) {
- IssueDto issue = db.issues().insertIssue(
- issueDto -> issueDto
- .setAssigneeUuid(assignee)
- .setCreatedAt(PAST).setIssueCreationTime(PAST)
- .setUpdatedAt(PAST).setIssueUpdateTime(PAST)
- .setType(RuleType.CODE_SMELL));
- return issue;
- }
-
- private IssueDto newIssueWithBrowsePermission() {
- IssueDto issue = newIssue(PREVIOUS_ASSIGNEE);
- setUserWithBrowsePermission(issue);
- return issue;
- }
-
- private void setUserWithBrowsePermission(IssueDto issue) {
- setUserWithPermission(issue, USER);
- }
-
- private void setUserWithPermission(IssueDto issue, String permission) {
- insertUser(CURRENT_USER_LOGIN);
- userSession.logIn(CURRENT_USER_LOGIN)
- .addProjectPermission(permission,
- dbClient.componentDao().selectByUuid(db.getSession(), issue.getProjectUuid()).get(),
- dbClient.componentDao().selectByUuid(db.getSession(), issue.getComponentUuid()).get());
- }
-
- private void checkIssueAssignee(String issueKey, @Nullable String expectedAssignee) {
- IssueDto issueReloaded = dbClient.issueDao().selectByKey(db.getSession(), issueKey).get();
- assertThat(issueReloaded.getAssigneeUuid()).isEqualTo(expectedAssignee);
- assertThat(issueReloaded.getIssueUpdateTime()).isEqualTo(NOW);
- assertThat(issueReloaded.getUpdatedAt()).isEqualTo(NOW);
- }
- }
|