You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

RemoveUserFromTemplateActionTest.java 8.4KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228
  1. /*
  2. * SonarQube
  3. * Copyright (C) 2009-2019 SonarSource SA
  4. * mailto:info AT sonarsource DOT com
  5. *
  6. * This program is free software; you can redistribute it and/or
  7. * modify it under the terms of the GNU Lesser General Public
  8. * License as published by the Free Software Foundation; either
  9. * version 3 of the License, or (at your option) any later version.
  10. *
  11. * This program is distributed in the hope that it will be useful,
  12. * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
  14. * Lesser General Public License for more details.
  15. *
  16. * You should have received a copy of the GNU Lesser General Public License
  17. * along with this program; if not, write to the Free Software Foundation,
  18. * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  19. */
  20. package org.sonar.server.permission.ws.template;
  21. import java.util.List;
  22. import javax.annotation.Nullable;
  23. import org.junit.Before;
  24. import org.junit.Test;
  25. import org.sonar.api.resources.Qualifiers;
  26. import org.sonar.api.resources.ResourceTypes;
  27. import org.sonar.core.permission.GlobalPermissions;
  28. import org.sonar.db.component.ResourceTypesRule;
  29. import org.sonar.db.permission.PermissionQuery;
  30. import org.sonar.db.permission.template.PermissionTemplateDto;
  31. import org.sonar.db.user.UserDto;
  32. import org.sonar.server.exceptions.BadRequestException;
  33. import org.sonar.server.exceptions.ForbiddenException;
  34. import org.sonar.server.exceptions.NotFoundException;
  35. import org.sonar.server.exceptions.UnauthorizedException;
  36. import org.sonar.server.permission.PermissionService;
  37. import org.sonar.server.permission.PermissionServiceImpl;
  38. import org.sonar.server.permission.ws.BasePermissionWsTest;
  39. import org.sonar.server.permission.ws.RequestValidator;
  40. import org.sonar.server.permission.ws.WsParameters;
  41. import org.sonar.server.ws.TestRequest;
  42. import static org.assertj.core.api.Assertions.assertThat;
  43. import static org.sonar.api.web.UserRole.CODEVIEWER;
  44. import static org.sonar.api.web.UserRole.ISSUE_ADMIN;
  45. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION;
  46. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_NAME;
  47. import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_USER_LOGIN;
  48. public class RemoveUserFromTemplateActionTest extends BasePermissionWsTest<RemoveUserFromTemplateAction> {
  49. private static final String DEFAULT_PERMISSION = CODEVIEWER;
  50. private UserDto user;
  51. private PermissionTemplateDto template;
  52. private ResourceTypes resourceTypes = new ResourceTypesRule().setRootQualifiers(Qualifiers.PROJECT);
  53. private PermissionService permissionService = new PermissionServiceImpl(resourceTypes);
  54. private WsParameters wsParameters = new WsParameters(permissionService);
  55. private RequestValidator requestValidator = new RequestValidator(permissionService);
  56. @Override
  57. protected RemoveUserFromTemplateAction buildWsAction() {
  58. return new RemoveUserFromTemplateAction(db.getDbClient(), newPermissionWsSupport(), userSession, wsParameters, requestValidator);
  59. }
  60. @Before
  61. public void setUp() {
  62. user = db.users().insertUser("user-login");
  63. db.organizations().addMember(db.getDefaultOrganization(), user);
  64. template = db.permissionTemplates().insertTemplate(db.getDefaultOrganization());
  65. addUserToTemplate(user, template, DEFAULT_PERMISSION);
  66. }
  67. @Test
  68. public void remove_user_from_template() {
  69. loginAsAdmin(db.getDefaultOrganization());
  70. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  71. assertThat(getLoginsInTemplateAndPermission(template, DEFAULT_PERMISSION)).isEmpty();
  72. }
  73. @Test
  74. public void remove_user_from_template_by_name_case_insensitive() {
  75. loginAsAdmin(db.getDefaultOrganization());
  76. newRequest()
  77. .setParam(PARAM_USER_LOGIN, user.getLogin())
  78. .setParam(PARAM_PERMISSION, DEFAULT_PERMISSION)
  79. .setParam(PARAM_TEMPLATE_NAME, template.getName().toUpperCase())
  80. .execute();
  81. assertThat(getLoginsInTemplateAndPermission(template, DEFAULT_PERMISSION)).isEmpty();
  82. }
  83. @Test
  84. public void remove_user_from_template_twice_without_failing() {
  85. loginAsAdmin(db.getDefaultOrganization());
  86. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  87. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  88. assertThat(getLoginsInTemplateAndPermission(template, DEFAULT_PERMISSION)).isEmpty();
  89. }
  90. @Test
  91. public void keep_user_permission_not_removed() {
  92. addUserToTemplate(user, template, ISSUE_ADMIN);
  93. loginAsAdmin(db.getDefaultOrganization());
  94. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  95. assertThat(getLoginsInTemplateAndPermission(template, DEFAULT_PERMISSION)).isEmpty();
  96. assertThat(getLoginsInTemplateAndPermission(template, ISSUE_ADMIN)).containsExactly(user.getLogin());
  97. }
  98. @Test
  99. public void keep_other_users_when_one_user_removed() {
  100. UserDto newUser = db.users().insertUser("new-login");
  101. db.organizations().addMember(db.getDefaultOrganization(), newUser);
  102. addUserToTemplate(newUser, template, DEFAULT_PERMISSION);
  103. loginAsAdmin(db.getDefaultOrganization());
  104. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  105. assertThat(getLoginsInTemplateAndPermission(template, DEFAULT_PERMISSION)).containsExactly("new-login");
  106. }
  107. @Test
  108. public void fail_if_not_a_project_permission() {
  109. loginAsAdmin(db.getDefaultOrganization());
  110. expectedException.expect(IllegalArgumentException.class);
  111. newRequest(user.getLogin(), template.getUuid(), GlobalPermissions.PROVISIONING);
  112. }
  113. @Test
  114. public void fail_if_insufficient_privileges() {
  115. userSession.logIn();
  116. expectedException.expect(ForbiddenException.class);
  117. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  118. }
  119. @Test
  120. public void fail_if_not_logged_in() {
  121. userSession.anonymous();
  122. expectedException.expect(UnauthorizedException.class);
  123. newRequest(user.getLogin(), template.getUuid(), DEFAULT_PERMISSION);
  124. }
  125. @Test
  126. public void fail_if_user_missing() {
  127. loginAsAdmin(db.getDefaultOrganization());
  128. expectedException.expect(IllegalArgumentException.class);
  129. newRequest(null, template.getUuid(), DEFAULT_PERMISSION);
  130. }
  131. @Test
  132. public void fail_if_permission_missing() {
  133. loginAsAdmin(db.getDefaultOrganization());
  134. expectedException.expect(IllegalArgumentException.class);
  135. newRequest(user.getLogin(), template.getUuid(), null);
  136. }
  137. @Test
  138. public void fail_if_template_missing() {
  139. loginAsAdmin(db.getDefaultOrganization());
  140. expectedException.expect(BadRequestException.class);
  141. newRequest(user.getLogin(), null, DEFAULT_PERMISSION);
  142. }
  143. @Test
  144. public void fail_if_user_does_not_exist() {
  145. loginAsAdmin(db.getDefaultOrganization());
  146. expectedException.expect(NotFoundException.class);
  147. expectedException.expectMessage("User with login 'unknown-login' is not found");
  148. newRequest("unknown-login", template.getUuid(), DEFAULT_PERMISSION);
  149. }
  150. @Test
  151. public void fail_if_template_key_does_not_exist() {
  152. loginAsAdmin(db.getDefaultOrganization());
  153. expectedException.expect(NotFoundException.class);
  154. expectedException.expectMessage("Permission template with id 'unknown-key' is not found");
  155. newRequest(user.getLogin(), "unknown-key", DEFAULT_PERMISSION);
  156. }
  157. private void newRequest(@Nullable String userLogin, @Nullable String templateKey, @Nullable String permission) {
  158. TestRequest request = newRequest();
  159. if (userLogin != null) {
  160. request.setParam(PARAM_USER_LOGIN, userLogin);
  161. }
  162. if (templateKey != null) {
  163. request.setParam(org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_ID, templateKey);
  164. }
  165. if (permission != null) {
  166. request.setParam(PARAM_PERMISSION, permission);
  167. }
  168. request.execute();
  169. }
  170. private List<String> getLoginsInTemplateAndPermission(PermissionTemplateDto template, String permission) {
  171. PermissionQuery permissionQuery = PermissionQuery.builder().setOrganizationUuid(template.getOrganizationUuid()).setPermission(permission).build();
  172. return db.getDbClient().permissionTemplateDao()
  173. .selectUserLoginsByQueryAndTemplate(db.getSession(), permissionQuery, template.getId());
  174. }
  175. private void addUserToTemplate(UserDto user, PermissionTemplateDto template, String permission) {
  176. db.getDbClient().permissionTemplateDao().insertUserPermission(db.getSession(), template.getId(), user.getId(), permission);
  177. db.commit();
  178. }
  179. }