123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212 |
- /*
- * SonarQube
- * Copyright (C) 2009-2019 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.issue.ws;
-
- import java.util.List;
- import javax.annotation.Nullable;
- import org.junit.Rule;
- import org.junit.Test;
- import org.junit.rules.ExpectedException;
- import org.mockito.ArgumentCaptor;
- import org.sonar.api.server.ws.Request;
- import org.sonar.api.server.ws.Response;
- import org.sonar.api.server.ws.WebService;
- import org.sonar.api.utils.System2;
- import org.sonar.core.issue.FieldDiffs;
- import org.sonar.db.DbClient;
- import org.sonar.db.DbTester;
- import org.sonar.db.component.ComponentDto;
- import org.sonar.db.issue.IssueDbTester;
- import org.sonar.db.issue.IssueDto;
- import org.sonar.db.rule.RuleDefinitionDto;
- import org.sonar.db.rule.RuleDto;
- import org.sonar.server.es.EsTester;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.exceptions.UnauthorizedException;
- import org.sonar.server.issue.IssueFieldsSetter;
- import org.sonar.server.issue.IssueFinder;
- import org.sonar.server.issue.WebIssueStorage;
- import org.sonar.server.issue.IssueUpdater;
- import org.sonar.server.issue.TestIssueChangePostProcessor;
- import org.sonar.server.issue.index.IssueIndexer;
- import org.sonar.server.issue.index.IssueIteratorFactory;
- import org.sonar.server.notification.NotificationManager;
- import org.sonar.server.organization.DefaultOrganizationProvider;
- import org.sonar.server.organization.TestDefaultOrganizationProvider;
- import org.sonar.server.rule.DefaultRuleFinder;
- import org.sonar.server.tester.UserSessionRule;
- import org.sonar.server.ws.TestRequest;
- import org.sonar.server.ws.TestResponse;
- import org.sonar.server.ws.WsActionTester;
-
- import static java.util.Optional.ofNullable;
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.mockito.ArgumentMatchers.any;
- import static org.mockito.ArgumentMatchers.eq;
- import static org.mockito.Mockito.mock;
- import static org.mockito.Mockito.verify;
- import static org.sonar.api.rule.Severity.MAJOR;
- import static org.sonar.api.rule.Severity.MINOR;
- import static org.sonar.api.web.UserRole.ISSUE_ADMIN;
- import static org.sonar.api.web.UserRole.USER;
- import static org.sonar.db.component.ComponentTesting.newFileDto;
- import static org.sonar.db.issue.IssueTesting.newDto;
- import static org.sonar.db.rule.RuleTesting.newRuleDto;
-
- public class SetSeverityActionTest {
-
- @Rule
- public ExpectedException expectedException = ExpectedException.none();
- @Rule
- public DbTester dbTester = DbTester.create();
- @Rule
- public EsTester es = EsTester.create();
- @Rule
- public UserSessionRule userSession = UserSessionRule.standalone();
-
- private System2 system2 = mock(System2.class);
-
- private DbClient dbClient = dbTester.getDbClient();
- private DefaultOrganizationProvider defaultOrganizationProvider = TestDefaultOrganizationProvider.from(dbTester);
- private IssueDbTester issueDbTester = new IssueDbTester(dbTester);
- private OperationResponseWriter responseWriter = mock(OperationResponseWriter.class);
- private ArgumentCaptor<SearchResponseData> preloadedSearchResponseDataCaptor = ArgumentCaptor.forClass(SearchResponseData.class);
-
- private IssueIndexer issueIndexer = new IssueIndexer(es.client(), dbClient, new IssueIteratorFactory(dbClient));
- private TestIssueChangePostProcessor issueChangePostProcessor = new TestIssueChangePostProcessor();
- private WsActionTester tester = new WsActionTester(new SetSeverityAction(userSession, dbClient, new IssueFinder(dbClient, userSession), new IssueFieldsSetter(),
- new IssueUpdater(dbClient,
- new WebIssueStorage(system2, dbClient, new DefaultRuleFinder(dbClient, defaultOrganizationProvider), issueIndexer), mock(NotificationManager.class), issueChangePostProcessor),
- responseWriter));
-
- @Test
- public void set_severity() {
- IssueDto issueDto = issueDbTester.insertIssue(newIssue().setSeverity(MAJOR));
- setUserWithBrowseAndAdministerIssuePermission(issueDto);
-
- call(issueDto.getKey(), MINOR);
-
- verify(responseWriter).write(eq(issueDto.getKey()), preloadedSearchResponseDataCaptor.capture(), any(Request.class), any(Response.class));
- verifyContentOfPreloadedSearchResponseData(issueDto);
-
- IssueDto issueReloaded = dbClient.issueDao().selectByKey(dbTester.getSession(), issueDto.getKey()).get();
- assertThat(issueReloaded.getSeverity()).isEqualTo(MINOR);
- assertThat(issueReloaded.isManualSeverity()).isTrue();
- assertThat(issueChangePostProcessor.calledComponents())
- .extracting(ComponentDto::uuid)
- .containsExactlyInAnyOrder(issueDto.getComponentUuid());
- }
-
- @Test
- public void insert_entry_in_changelog_when_setting_severity() {
- IssueDto issueDto = issueDbTester.insertIssue(newIssue().setSeverity(MAJOR));
- setUserWithBrowseAndAdministerIssuePermission(issueDto);
-
- call(issueDto.getKey(), MINOR);
-
- List<FieldDiffs> fieldDiffs = dbClient.issueChangeDao().selectChangelogByIssue(dbTester.getSession(), issueDto.getKey());
- assertThat(fieldDiffs).hasSize(1);
- assertThat(fieldDiffs.get(0).diffs()).hasSize(1);
- assertThat(fieldDiffs.get(0).diffs().get("severity").newValue()).isEqualTo(MINOR);
- assertThat(fieldDiffs.get(0).diffs().get("severity").oldValue()).isEqualTo(MAJOR);
- }
-
- @Test
- public void fail_if_bad_severity() {
- IssueDto issueDto = issueDbTester.insertIssue(newIssue().setSeverity("unknown"));
- setUserWithBrowseAndAdministerIssuePermission(issueDto);
-
- expectedException.expect(IllegalArgumentException.class);
- expectedException.expectMessage("Value of parameter 'severity' (unknown) must be one of: [INFO, MINOR, MAJOR, CRITICAL, BLOCKER]");
- call(issueDto.getKey(), "unknown");
- }
-
- @Test
- public void fail_when_not_authenticated() {
- expectedException.expect(UnauthorizedException.class);
- call("ABCD", MAJOR);
- }
-
- @Test
- public void fail_when_missing_browse_permission() {
- IssueDto issueDto = issueDbTester.insertIssue();
- logInAndAddProjectPermission(issueDto, ISSUE_ADMIN);
-
- expectedException.expect(ForbiddenException.class);
- call(issueDto.getKey(), MAJOR);
- }
-
- @Test
- public void fail_when_missing_administer_issue_permission() {
- IssueDto issueDto = issueDbTester.insertIssue();
- logInAndAddProjectPermission(issueDto, USER);
-
- expectedException.expect(ForbiddenException.class);
- call(issueDto.getKey(), MAJOR);
- }
-
- @Test
- public void test_definition() {
- WebService.Action action = tester.getDef();
- assertThat(action.key()).isEqualTo("set_severity");
- assertThat(action.isPost()).isTrue();
- assertThat(action.isInternal()).isFalse();
- assertThat(action.params()).hasSize(2);
- assertThat(action.responseExample()).isNotNull();
- }
-
- private TestResponse call(@Nullable String issueKey, @Nullable String severity) {
- TestRequest request = tester.newRequest();
- ofNullable(issueKey).ifPresent(issue -> request.setParam("issue", issue));
- ofNullable(severity).ifPresent(value -> request.setParam("severity", value));
- return request.execute();
- }
-
- private IssueDto newIssue() {
- RuleDto rule = dbTester.rules().insertRule(newRuleDto());
- ComponentDto project = dbTester.components().insertPrivateProject();
- ComponentDto file = dbTester.components().insertComponent(newFileDto(project));
- return newDto(rule, file, project);
- }
-
- private void logInAndAddProjectPermission(IssueDto issueDto, String permission) {
- userSession.logIn("john").addProjectPermission(permission, dbClient.componentDao().selectByUuid(dbTester.getSession(), issueDto.getProjectUuid()).get());
- }
-
- private void setUserWithBrowseAndAdministerIssuePermission(IssueDto issueDto) {
- ComponentDto project = dbClient.componentDao().selectByUuid(dbTester.getSession(), issueDto.getProjectUuid()).get();
- userSession.logIn("john")
- .addProjectPermission(ISSUE_ADMIN, project)
- .addProjectPermission(USER, project);
- }
-
- private void verifyContentOfPreloadedSearchResponseData(IssueDto issue) {
- SearchResponseData preloadedSearchResponseData = preloadedSearchResponseDataCaptor.getValue();
- assertThat(preloadedSearchResponseData.getIssues())
- .extracting(IssueDto::getKey)
- .containsOnly(issue.getKey());
- assertThat(preloadedSearchResponseData.getRules())
- .extracting(RuleDefinitionDto::getKey)
- .containsOnly(issue.getRuleKey());
- assertThat(preloadedSearchResponseData.getComponents())
- .extracting(ComponentDto::uuid)
- .containsOnly(issue.getComponentUuid(), issue.getProjectUuid());
- }
- }
|