123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298 |
- /*
- * SonarQube
- * Copyright (C) 2009-2019 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
- package org.sonar.server.user.ws;
-
- import java.util.Arrays;
- import org.junit.Before;
- import org.junit.Rule;
- import org.junit.Test;
- import org.junit.rules.ExpectedException;
- import org.sonar.api.config.internal.MapSettings;
- import org.sonar.api.server.ws.WebService;
- import org.sonar.api.utils.System2;
- import org.sonar.db.DbClient;
- import org.sonar.db.DbSession;
- import org.sonar.db.DbTester;
- import org.sonar.db.user.UserDto;
- import org.sonar.server.authentication.CredentialsLocalAuthentication;
- import org.sonar.server.es.EsTester;
- import org.sonar.server.exceptions.ForbiddenException;
- import org.sonar.server.exceptions.NotFoundException;
- import org.sonar.server.organization.DefaultOrganizationProvider;
- import org.sonar.server.organization.OrganizationUpdater;
- import org.sonar.server.organization.TestDefaultOrganizationProvider;
- import org.sonar.server.organization.TestOrganizationFlags;
- import org.sonar.server.tester.UserSessionRule;
- import org.sonar.server.user.NewUserNotifier;
- import org.sonar.server.user.UserUpdater;
- import org.sonar.server.user.index.UserIndexer;
- import org.sonar.server.usergroups.DefaultGroupFinder;
- import org.sonar.server.ws.WsActionTester;
-
- import static com.google.common.collect.Lists.newArrayList;
- import static java.util.Collections.singletonList;
- import static org.assertj.core.api.Assertions.assertThat;
- import static org.mockito.Mockito.mock;
- import static org.sonar.db.user.UserTesting.newUserDto;
-
- public class UpdateActionTest {
-
- private static final OrganizationUpdater ORGANIZATION_CREATION_NOT_USED_FOR_UPDATE = null;
- private MapSettings settings = new MapSettings();
- private System2 system2 = new System2();
-
- @Rule
- public DbTester db = DbTester.create(system2);
- @Rule
- public EsTester es = EsTester.create();
- @Rule
- public UserSessionRule userSession = UserSessionRule.standalone().logIn().setSystemAdministrator();
- @Rule
- public ExpectedException expectedException = ExpectedException.none();
-
- private DbClient dbClient = db.getDbClient();
- private DbSession dbSession = db.getSession();
- private UserIndexer userIndexer = new UserIndexer(dbClient, es.client());
- private DefaultOrganizationProvider defaultOrganizationProvider = TestDefaultOrganizationProvider.from(db);
- private TestOrganizationFlags organizationFlags = TestOrganizationFlags.standalone();
- private CredentialsLocalAuthentication localAuthentication = new CredentialsLocalAuthentication(db.getDbClient());
-
- private WsActionTester ws = new WsActionTester(new UpdateAction(
- new UserUpdater(system2, mock(NewUserNotifier.class), dbClient, userIndexer, organizationFlags, defaultOrganizationProvider, ORGANIZATION_CREATION_NOT_USED_FOR_UPDATE,
- new DefaultGroupFinder(db.getDbClient()), settings.asConfig(), localAuthentication),
- userSession, new UserJsonWriter(userSession), dbClient));
-
- @Before
- public void setUp() {
- db.users().insertDefaultGroup(db.getDefaultOrganization(), "sonar-users");
- }
-
- @Test
- public void update_user() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("name", "Jon Snow")
- .setParam("email", "jon.snow@thegreatw.all")
- .setParam("scmAccounts", "jon.snow")
- .execute()
- .assertJson(getClass(), "update_user.json");
- }
-
- @Test
- public void update_only_name() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("name", "Jon Snow")
- .execute()
- .assertJson(getClass(), "update_name.json");
- }
-
- @Test
- public void update_only_email() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("email", "jon.snow@thegreatw.all")
- .execute()
- .assertJson(getClass(), "update_email.json");
- }
-
- @Test
- public void blank_email_is_updated_to_null() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("email", "")
- .execute()
- .assertJson(getClass(), "blank_email_is_updated_to_null.json");
-
- UserDto userDto = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(userDto.getEmail()).isNull();
- }
-
- @Test
- public void remove_scm_accounts() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setMultiParam("scmAccount", singletonList(""))
- .execute();
-
- UserDto userDto = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(userDto.getScmAccounts()).isNull();
- }
-
- @Test
- public void update_only_scm_accounts() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setMultiParam("scmAccount", singletonList("jon.snow"))
- .execute()
- .assertJson(getClass(), "update_scm_accounts.json");
-
- UserDto user = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(user.getScmAccountsAsList()).containsOnly("jon.snow");
- }
-
- @Test
- public void update_scm_account_having_coma() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setMultiParam("scmAccount", singletonList("jon,snow"))
- .execute();
-
- UserDto user = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(user.getScmAccountsAsList()).containsOnly("jon,snow");
- }
-
- @Test
- public void update_scm_account_ignores_duplicates() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setMultiParam("scmAccount", Arrays.asList("jon.snow", "jon.snow", "jon.jon", "jon.snow"))
- .execute();
-
- UserDto user = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(user.getScmAccountsAsList()).containsExactlyInAnyOrder("jon.jon", "jon.snow");
- }
-
- @Test
- public void update_scm_account_ordered_case_insensitive() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setMultiParam("scmAccount", Arrays.asList("jon.3", "Jon.1", "JON.2"))
- .execute();
-
- UserDto user = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(user.getScmAccountsAsList()).containsExactly("Jon.1", "JON.2", "jon.3");
- }
-
- @Test
- public void update_only_scm_accounts_with_deprecated_scmAccounts_parameter() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("scmAccounts", "jon.snow")
- .execute()
- .assertJson(getClass(), "update_scm_accounts.json");
-
- UserDto user = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(user.getScmAccountsAsList()).containsOnly("jon.snow");
- }
-
- @Test
- public void update_only_scm_accounts_with_deprecated_scm_accounts_parameter() {
- createUser();
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("scm_accounts", "jon.snow")
- .execute()
- .assertJson(getClass(), "update_scm_accounts.json");
-
- UserDto user = dbClient.userDao().selectByLogin(dbSession, "john");
- assertThat(user.getScmAccountsAsList()).containsOnly("jon.snow");
- }
-
- @Test
- public void fail_on_missing_permission() {
- createUser();
- userSession.logIn("polop");
-
- expectedException.expect(ForbiddenException.class);
-
- ws.newRequest()
- .setParam("login", "john")
- .execute();
- }
-
- @Test
- public void fail_on_unknown_user() {
- expectedException.expect(NotFoundException.class);
- expectedException.expectMessage("User 'john' doesn't exist");
-
- ws.newRequest()
- .setParam("login", "john")
- .execute();
- }
-
- @Test
- public void fail_on_disabled_user() {
- db.users().insertUser(u -> u.setLogin("john").setActive(false));
-
- expectedException.expect(NotFoundException.class);
- expectedException.expectMessage("User 'john' doesn't exist");
-
- ws.newRequest()
- .setParam("login", "john")
- .execute();
- }
-
- @Test
- public void fail_on_invalid_email() {
- createUser();
-
- expectedException.expect(IllegalArgumentException.class);
- expectedException.expectMessage("Email 'invalid-email' is not valid");
-
- ws.newRequest()
- .setParam("login", "john")
- .setParam("email", "invalid-email")
- .execute();
- }
-
- @Test
- public void test_definition() {
- WebService.Action action = ws.getDef();
- assertThat(action).isNotNull();
- assertThat(action.isPost()).isTrue();
- assertThat(action.params()).hasSize(5);
- }
-
- private void createUser() {
- UserDto userDto = newUserDto()
- .setEmail("john@email.com")
- .setLogin("john")
- .setName("John")
- .setScmAccounts(newArrayList("jn"))
- .setActive(true)
- .setLocal(true)
- .setExternalLogin("jo")
- .setExternalIdentityProvider("sonarqube");
- dbClient.userDao().insert(dbSession, userDto);
- userIndexer.commitAndIndex(dbSession, userDto);
- }
- }
|