瀏覽代碼

Remove bogus strncpy() calls

We don't know the size of the output buffer here and giving the input
string size is just confusing and upsets the compiler in some cases.
tags/v1.11.90
Pierre Ossman 3 年之前
父節點
當前提交
b2b265a183
共有 1 個檔案被更改,包括 2 行新增4 行删除
  1. 2
    4
      vncviewer/vncviewer.cxx

+ 2
- 4
vncviewer/vncviewer.cxx 查看文件

@@ -454,11 +454,9 @@ interpretViaParam(char *remoteHost, int *remotePort, int localPort)
}

if (*vncServerName != '\0')
strncpy(remoteHost, vncServerName, VNCSERVERNAMELEN);
strcpy(remoteHost, vncServerName);
else
strncpy(remoteHost, "localhost", VNCSERVERNAMELEN);

remoteHost[VNCSERVERNAMELEN - 1] = '\0';
strcpy(remoteHost, "localhost");

snprintf(vncServerName, VNCSERVERNAMELEN, "localhost::%d", localPort);
vncServerName[VNCSERVERNAMELEN - 1] = '\0';

Loading…
取消
儲存