Browse Source

Don't clear complex objects using memset()

This is fine for simple structs but not class based objects.
tags/v1.10.90
Pierre Ossman 3 years ago
parent
commit
b97c84b1d9
2 changed files with 2 additions and 4 deletions
  1. 0
    2
      win/rfb_win32/DIBSectionBuffer.cxx
  2. 2
    2
      win/rfb_win32/MonitorInfo.cxx

+ 0
- 2
win/rfb_win32/DIBSectionBuffer.cxx View File



DIBSectionBuffer::DIBSectionBuffer(HWND window_) DIBSectionBuffer::DIBSectionBuffer(HWND window_)
: bitmap(0), window(window_), device(0) { : bitmap(0), window(window_), device(0) {
memset(&format, 0, sizeof(format));
} }


DIBSectionBuffer::DIBSectionBuffer(HDC device_) DIBSectionBuffer::DIBSectionBuffer(HDC device_)
: bitmap(0), window(0), device(device_) { : bitmap(0), window(0), device(device_) {
memset(&format, 0, sizeof(format));
} }


DIBSectionBuffer::~DIBSectionBuffer() { DIBSectionBuffer::~DIBSectionBuffer() {

+ 2
- 2
win/rfb_win32/MonitorInfo.cxx View File

static LogWriter vlog("MonitorInfo"); static LogWriter vlog("MonitorInfo");




static void fillMonitorInfo(HMONITOR monitor, MonitorInfo* mi) {
static void fillMonitorInfo(HMONITOR monitor, MONITORINFOEXA* mi) {
vlog.debug("monitor=%p", monitor); vlog.debug("monitor=%p", monitor);
memset(mi, 0, sizeof(MONITORINFOEXA)); memset(mi, 0, sizeof(MONITORINFOEXA));
mi->cbSize = sizeof(MONITORINFOEXA); mi->cbSize = sizeof(MONITORINFOEXA);




struct monitorByNameData { struct monitorByNameData {
MonitorInfo* info;
MONITORINFOEXA* info;
const char* monitorName; const char* monitorName;
}; };



Loading…
Cancel
Save