Commit Graph

437 Commits

Author SHA1 Message Date
Pierre Ossman
ccd09baedd Fix about text encoding (partial revert of dc96cb4d)
It was actually a feature to translate the about string multiple
times as we may need different character encodings for it. We
still want a better approach that allows the compiler to analyse
the format string though so it isn't just a simple revert.
2015-04-07 14:58:45 +02:00
Peter Åstrand (astrand)
4ab2f8ab85 Removed extra newline in Listening on port printout. 2015-03-18 10:31:01 +01:00
Pierre Ossman
ead143f763 Merge branch 'multisocket-rebased' of https://github.com/twaugh/tigervnc 2015-03-17 12:51:31 +01:00
Tim Waugh
892d10a705 Fixed IPv6 support.
The TcpListener constructor now takes a 'struct sockaddr*' instead of
a string, and the createTcpListeners function creates TcpListener
instances for an address based on the results from getaddrinfo().

The XserverDesktop class now takes a list of TcpListener instances for
each of the RFB and HTTP sockets.

The TcpListener::closeFd member variable is not used and has been
removed.
2015-03-13 16:19:50 +00:00
Pierre Ossman
d1cb31f436 Merge branch 'upreqs' of https://github.com/CendioOssman/tigervnc
Conflicts:
	contrib/packages/rpm/el5/SPECS/tigervnc.spec
	vncviewer/Viewport.cxx
2015-03-12 11:15:32 +01:00
Pierre Ossman
a71a276637 Add a OS X system menu so that new viewer windows can be started 2015-03-04 09:58:18 +01:00
Pierre Ossman
8d713a92af Hide OS X specific callback when not needed 2015-03-04 09:54:27 +01:00
Pierre Ossman
3b865f1373 Fix bad long line detection logic in config file parser 2015-03-04 09:53:16 +01:00
Pierre Ossman
d7f8450c37 Change type to fix bad signed/unsigned comparison 2015-03-04 09:52:48 +01:00
Pierre Ossman
3620e19621 Make sure defaultServerName is initialised even on errors 2015-03-03 16:50:15 +01:00
Pierre Ossman
63471c9de0 Move about text constant so the compiler can analyse it 2015-03-03 16:49:50 +01:00
Pierre Ossman
6e538b4020 Fix bad initialiser lists 2015-03-03 16:48:01 +01:00
Pierre Ossman
b1cd6ca8f0 Reorder class initialiser list to match what actually happens 2015-03-03 16:37:43 +01:00
Pierre Ossman
fb450fba5d Fix mismatches between format string and arguments 2015-03-03 16:34:56 +01:00
Pierre Ossman
28c1d54937 Switch to unsigned parameters for ExtendedDesktopSize handler
The constants used here are unsigned so it makes more sense that
the parameters are as well.
2015-03-03 16:27:44 +01:00
Pierre Ossman
5c23b9ed7d Fix bad signed/unsigned comparisons
Either by casting, or switching to a more appropriate type
for the variable.
2015-03-03 16:26:03 +01:00
Pierre Ossman
a7bbe9c4a3 Make sure Exceptions do not use unsafe format strings 2015-03-03 16:17:51 +01:00
Pierre Ossman
eb95532f5c Remove unused variables 2015-03-03 16:10:53 +01:00
Pierre Ossman
d0565ec994 Merge branches 'format-security' and 'module-ldnow-master' of https://github.com/twaugh/tigervnc 2015-02-27 09:26:26 +01:00
Pierre Ossman
7665b793f0 The legacy OS X keyboard API is only 32-bit 2015-02-25 14:43:42 +01:00
Tim Waugh
0d247ad0d3 Don't need to log local port when handling -via (#126). 2015-02-25 13:40:45 +00:00
Pierre Ossman
245c802226 Escape FLTK menu entries
We don't want it automatically creating submenus when least
expected.
2015-02-25 11:27:49 +01:00
Pierre Ossman
b5b0ea5771 Revert "Switch to FLTK's copy() method for menus"
This reverts commit e95412569b
and commit 52a18150a7.

The copy() method unfortunately has its own problems so it was not
a good replacement.
2015-02-25 11:27:12 +01:00
Tim Waugh
14206b3c56 Avoid warning when compiling with gcc's -Wformat-security option. 2015-02-24 12:34:14 +00:00
Pierre Ossman
52a18150a7 Disable entries instead of shuffling memory around
Less risk for bugs this way.
2015-02-20 17:35:56 +01:00
Pierre Ossman
c134168be9 Update copyright years 2015-02-20 17:12:57 +01:00
Pierre Ossman
e95412569b Switch to FLTK's copy() method for menus
It has less surprises in terms of magical characters.
2015-02-20 17:08:30 +01:00
Pierre Ossman
5bf17addcb Create a console window for help output on Windows 2015-02-17 13:23:00 +01:00
Pierre Ossman
3c76a6d1eb Add shortcuts to context menu for quick access 2015-02-16 16:31:51 +01:00
Pierre Ossman
83e019f599 Stop mapping Meta to Super
A lot of X11 keyboard layouts send Meta for Shift-Alt so it's not
really a good idea to assume this is the Windows key.
2015-02-16 16:24:26 +01:00
Pierre Ossman
4cf2d3a621 Remove no longer functional workaround
This workaround is no longer effective with the new system handler
method of handling keyboard events. The bug has also been fixed
in upstream FLTK, further making it pointless.
2015-02-16 15:59:22 +01:00
Peter Åstrand (astrand)
11167e1f08 Use a common header file for Windows errno names.
In earlier Visual Studio and MinGW editions, BSD socket errno:s were
left undefined. This is no longer the case. This may cause build or
runtime errors. To avoid this, we are using a common header file which
corrects all definitions. This header will also be used with other
projects such as sercd, unfs3, PulseAudio etc.
2015-02-05 11:10:32 +01:00
Pierre Ossman
56610fb847 Raise FLTK requirement to 1.3.3
This means that we can remove a lot of conditionals and fallback code.
2015-01-27 16:28:15 +01:00
Pierre Ossman
9018af44da More debug logging for screen layout changes 2015-01-26 15:15:47 +01:00
Pierre Ossman
c0ea642910 Reduce symbol scope of parameter helpers
There is no need for these to be global symbols as they are only
used in that file.
2014-12-03 14:04:11 +01:00
Pierre Ossman
1bfbcb57d8 Rework the error message in parameters.cxx
They were not very end user friendly so redo more or less all of them.
2014-12-03 14:03:29 +01:00
Pierre Ossman
2aef35cfa2 Simplify log message as we always use TrueColour 2014-12-03 14:01:56 +01:00
Pierre Ossman
c76bd2b482 Improve some error messages 2014-12-03 14:01:31 +01:00
Pierre Ossman
744e55cbdf Add comments for translators where requested 2014-12-03 14:00:54 +01:00
Pierre Ossman
90347ae8b9 Remove "Error:" prefix from error message
We had already fixed the others, but this one was overlooked.
2014-11-19 13:47:39 +01:00
Pierre Ossman
bad31c2fb8 Make sure we do an initial resize
The local window manager might give us a window of a different size
than the one we request. Make sure that the remote resize setting
gets respected even in this case.
2014-11-11 13:59:01 +01:00
Pierre Ossman
7f8f3ea2c4 Merge branch 'build' of https://github.com/CendioOssman/tigervnc 2014-10-21 16:29:05 +02:00
Pierre Ossman
b27c1b240e Add Carbon and Cocoa dependencies to vncviewer
We use both frameworks directly from vncviewer so we should
make sure they get pulled in.
2014-10-17 13:55:05 +02:00
Pierre Ossman
428de11794 Move ws2_32 dependency to the correct place
It is rdr and network that needs it, not vncviewer.
2014-10-17 13:54:32 +02:00
Tim Waugh
7c56b4c332 Check the return value from XShmAttach. 2014-10-17 10:28:55 +01:00
Tim Waugh
b17c9c4ded Don't use MIT-SHM on remote displays.
When run from within 'ssh -X' or 'ssh -Y', MIT-SHM will appear to be
available even though it won't work: the shared memory will be on the
machine running vncviewer, not on the machine running the X server it
displays to. Depending on what shm segments are available on the
machine running the X server, the failure may not be apparent when
checking that MIT-SHM works.

Avoid this by not using MIT-SHM when XDisplayName() indicates we may
not be running locally.

Original bug report:
  https://bugzilla.redhat.com/show_bug.cgi?id=1072733
2014-10-16 14:53:17 +01:00
Pierre Ossman
d1a853bca7 Use exceptions rather than asserts for for "normal" errors
Although these are rare, they are still not indicative of bugs so
an exception (which ends up in the log and might also be shown to
the user) is more appropriate than an assert. Asserts should only
be used to catch blatant API misuse and similar.
2014-10-10 13:37:35 +02:00
Pierre Ossman
86750633ff Use the same style for exception messages 2014-10-10 13:33:19 +02:00
Pierre Ossman
3b07fc1263 Remove unused assert.h include 2014-10-10 13:29:53 +02:00
Pierre Ossman
a7d3dc7765 Handle PrintScreen and SysReq on Windows
This key requires a bit extra care on Windows. We get wildly
different messages depending on if Alt is pressed or not. The symbol
chosen now follows the standard behaviour on X11.
2014-09-30 17:03:28 +02:00