We mostly use classical C strings, but the memory management around them
can get confusing and error prone. Let's use std::string for the cases
where we need to return a newly allocated string.

The compiler doesn't enforce this, but it at least documents the
expected array size.

We know the needed space here, so let's keep it simple with a constant
size string buffer.

It should return a path to the directory itself, just like its sister
function getuserhomedir().

All library functions should be in a proper namespace.

A blank string might be very confusing, depending on where this will be
used. Let's give something more visible back in the cases where we
cannot get the proper name for the peer.

This mimics how some system functions (like inet_ntop()) work, and
avoids complexity around ownership of the returned string buffer.

The downside is that the string must be consumed directly as it will be
overwritten on the next call, but that is not an issue with the current
usage.

Use the same indentation we use in all other files.

It's unclear why this was initially added. The function takes string
constants, so it is not going to modify these.

Avoid complicating things by moving things in to a second buffer here as
there is no need for it.

We don't need to make extra copies of the string in most cases, so let's
simplify the code and access the string directly when we can.

We never use Windows' "UNICODE" mode anyway, so let's get rid of this
complexity.

This makes memory management more clear and robust when using these
helper functions.

Let the string helpers call the more fancy setParam(). This makes sure
we can avoid duplicating things.

Otherwise the old length is preserved, which will result in NULL pointer
dereferencing if the parameter is ever accessed.

This is explicitly a byte sequence, so let's try to keep a consistent
typing.

These are used here and there so let's make them more general rather
than hiding them in the stream classes.

Avoid our own custom types in favour of what's already included with
C++.

Avoid having our own custom stuff and instead use the modern, standard
types, for familiarity.

Avoid preprocessor magic and instead rely on templating to generate
optimized functions for performance critical code.

Everything else uses LF line endings, so fix up the few stray ones.

These are supported by gcc and clang, and I don't think MSVC works well
with our code anyway, so let's keep things simple and use these
directly.

This isn't needed with modern build environments, and can even conflict
with them.

If we don't mark these as volatile then they might get reset on
longjmp() and the code will misbehave.

These are just values, so setting const on them has no effect as the
caller will get a copy.

This allows us to separate accidental fall through from explicit ones,
which allows us to turn on such checks in the compiler.

If there isn't enough data, then the client reading the hash will fall
down and try to read the subtype instead, which isn't correct.

Invert the logic so we get a more consistent way through where we only
break out when there is insufficient data.

Do the same for the server code, for consistency.

This allows us to separate accidentally unused, from explicitly unused
parameters, which allows us to turn on such checks in the compiler.

They have no need for it, so let's simplify things.

Everything in flags is already handled at a higher level.

The flags should always be empty anyway.

This makes sure the compiler doesn't complain about problems in those
files.

We don't want any stray exceptions as we are cleaning up, so handle any
still pending decoder errors by just logging them. We are already
shutting down so there is no need to abort the connection here.

These require a key to have been set up on the server beforehand, so
they do not give a good default experience as clients will be unable to
connect.

This is to make the code more tolerant of typos when entering a hostname

This call should have been preceeded by hasData() or avail(), just like
all other accessor functions.

We should scope these as narrowely as possible to avoid side effects.

Avoid duplicating all the memory mangement, and instead use the
BufferedOutStream as a base clase for all out streams that need an
intermediate buffer.

Allow subclasses to call it, instead of it being strictly internal. This
is useful when a subclass can only provide data in minimum sized chunks.

Avoid having to buffer everything we want to discard, and instead do it
piece by piece. This is more efficient, and avoids hitting any limits on
the buffering.

Note that this is safe here because we already know we have all the
compressed data. It would not be safe for a general input stream.

These streams both need to change the corking state temporarily, but it
is important it is restored to the previous state or things might get
messed up.

For the zlib stream it would just leave things uncorked, which still
works but is less efficient.

But for the TLS stream it might make things very unresponsive as the
corking might be left on permanently, delaying packets indefinitely.

There is no point flushing when corking was enabled, as we might then
push out a small buffer that the corking otherwise would have preserved.

It seems MFT h264 decoder does not support frame cropping. Which
means that if frame width or height is not multiple of 16 then
decoded output can potentially be used with wrong offset. This
code adds explicit parsing of SPS to extract cropping information
to use, and will apply cropping if reported size differs from
expected.

This is the standard method of finding it on Unix systems, so make sure
we use it. Still keep a fallback, though, for other systems, e.g.
Windows.

FFMPEG is needed by the RFB library, so all the details about it should
only be applied there and not for other components.