The previous FIXME was incorrect. The old code did in fact continue
looking over the entire area. This commit restores that old behaviour.

It knows more details so it can track things better.

It had regressed in performance compared to 1.3. This brings it back
up to the same speed.

The only class that cares if connections are reversed or not is
VNCSConnectionST so let it keep track of this fact.

Needed for some tests.

In earlier Visual Studio and MinGW editions, BSD socket errno:s were
left undefined. This is no longer the case. This may cause build or
runtime errors. To avoid this, we are using a common header file which
corrects all definitions. This header will also be used with other
projects such as sercd, unfs3, PulseAudio etc.

We're not doing a sufficient job of keeping this updated so list
it as an external requirement instead.

On some platforms va_list might be defined as something that causes
ambiguity and results in the wrong function being called.

This allows us to simplify things by getting rid of some old
compatibility code. People should really be using current versions
of GnuTLS anyway to stay secure.

It just adds noise and you can't really tell which timer it is
anyway without more logging in other places.

The internal Xorg headers are very incompatible with C++ and we've had
to resort to all kinds of hacks in order to include them in our C++
code. This approach isn't really viable long term so restructure things
so that we have a glue layer written in C that bridges the Xorg core
with the RFB classes.

Both SSecurityVeNCrypt and SSecurityStack are wrappers around other
security objects, so they need to delegate the properties of those
sub-objects properly.

A read-only client should not be allowed to kick out other clients.
It will be forced into shared mode, or refused the connection, depending
on the neverShared parameter.

So clients with limited access rights can not affect it.

They use char* rather than void*, requiring a cast here.

This is the format we support when converting a string to an
address, so it makes sense to use them the other way around.

There might be more protocols in the future, and we might also
misdetect things depending on varying IPv6 functions being missing.

This reverts commit 39d7dc043a.

We should be secure by default, even if it might cause a performance
hit. Those who wish to make that trade off are more likely to notice
the lack of performance than others noticing the lack of security.

It's often useful to see if encryption was used, and how the user
authenticated (if at all).

Try to read second password (for read only access) from rfbauth file. If client
sent second password instead of first one, allow him read only access.

SConnection has AccessRights property that specifies what connected client can
do. Set this property to value given by SSecurity after successful
authentication. This way individual SSecurity subclasses can accept clients but
restrict their access.

We don't even log this much for RFB protocol stuff, and it makes
it very annoying to run with full debugging on.

It is rdr and network that needs it, not vncviewer.

This was just plain wrong, so redo it properly.

Having it in ConnParams made the linker pull all the encoder objects
into vncviewer, making it larger than necessary and giving it extra
parameters in its help output that weren't relevant.

The input string might contain formatting marks, so make sure those
are ignored.