The size of size_t depends on the architecture, so we need to have
different conversion to and from strings. But we don't really need that
range, so avoid the issue by using a standard integer size.

Let's log a bit more details when we need to deal with certificate
exceptions to make it easier to debug things.

The browsers let you add an exception for this case, so we should as
well.

GnuTLS can help use translate certificate issues in to user presentable
strings, so let's clean up that reporting.

The browsers let you add an exception for this case, so we should as
well.

This should have been done in 5f46d55.

The browsers let you add an exception for this case, so we should as
well.

We don't want to proceed unless we've made sure the user has approved
the issues with the certificate. So add an extra check that all status
flags have been dealt with.

GnuTLS should hopefully never set just this flag, but let's be fully
prepared for all scenarios.

We've required GnuTLS 3.x for a long time, so this code has been dead
for a while.

The WM_CLASS we set on all windows is just "vncviewer", so that it
matches the name of the .desktop file, which is what GNOME expects.

These are not valid outside of UTF-16 so seeing them in a UTF-8 sequence
means that something is wrong with that sequence. Best to filter them
out rather than letting them propagate and have unknown effects.

We should handle this in the low-level protocol code as much as possible
to avoid mistakes. This way the rest of the code can assume that strings
are always UTF-8 with \n line endings.

If we can't rely on the OS to handle corking for us, then we need to
enable our own handling of it.

The previous method isn't compatible with CMake's try_compile() as it
will respect CMAKE_EXE_LINKER_FLAGS, but not CMAKE_C_LINK_EXECUTABLE and
friends. This results in the default libraries being completely missing,
and the compile test failing.

They've patched their Xorg sources to no longer require this package.

Make sure we can actually build without XRandR libraries.

Make sure we can actually build without XFixes libraries.

Make sure we can actually build without XTest libraries.

The need for these must have got lost somewhere in the type cleanup.

They are not fully supported and break with some backends, like Ninja.

These are expected to abort if they fail to find the relevant software
and "REQUIRED" is specified.

It is more specific, and it properly sets up propagation when include
directories also need to be used further down a dependency chain.

This is important in case there are build flags that need to propagate
between libraries for things to build correctly.

Get in sync with what's recommended these days.

This is fully automated, so we can't let anything wait for user input or
the job will just hang.

The newlines aren't stripped, so they are quite sufficient separators
for the commands.

We don't want a broken job to consume our entire quota, so make sure
things are killed if the stray too far from a normal runtime.

These will always be byte streams at heart, so let's try to keep them
with a proper type. Should make it clearer how they will be used.

The coordinates we get are relative the root window of each screen, so
we can only trust them if we are on the same screen. So let's explicitly
check that we are still getting events from the expected screen by
checking the root window field of the event.

An assert will kill the entire server, which is overly harsh when there
is a problem with a single connection. Instead, throw an exception which
will just disconnect that specific client.

Addresses the following AVC denial:

type=PROCTITLE msg=audit(01/12/2023 02:58:12.648:696) : proctitle=/usr/sbin/vncsession fedora :1
type=PATH msg=audit(01/12/2023 02:58:12.648:696) : item=1 name=/home/fedora/.vnc nametype=CREATE cap_fp=none cap_fi=none cap_fe=0 cap_fver=0 cap_frootid=0
type=PATH msg=audit(01/12/2023 02:58:12.648:696) : item=0 name=/home/fedora/ inode=262145 dev=fc:02 mode=dir,700 ouid=fedora ogid=fedora rdev=00:00 obj=unconfined_u:object_r:user_home_dir_t:s0 nametype=PARENT cap_fp=none cap_fi=none cap_fe=0 cap_fver=0 cap_frootid=0
type=CWD msg=audit(01/12/2023 02:58:12.648:696) : cwd=/home/fedora
type=SYSCALL msg=audit(01/12/2023 02:58:12.648:696) : arch=x86_64 syscall=mkdir success=no exit=EACCES(Permission denied) a0=0x7fff47d52540 a1=0755 a2=0x0 a3=0x0 items=2 ppid=2869 pid=2880 auid=fedora uid=fedora gid=fedora euid=fedora suid=fedora fsuid=fedora egid=fedora sgid=fedora fsgid=fedora tty=(none) ses=8 comm=vncsession exe=/usr/sbin/vncsession subj=system_u:system_r:vnc_session_t:s0 key=(null)
type=AVC msg=audit(01/12/2023 02:58:12.648:696) : avc:  denied  { create } for  pid=2880 comm=vncsession name=.vnc scontext=system_u:system_r:vnc_session_t:s0 tcontext=system_u:object_r:vnc_home_t:s0 tclass=dir permissive=0

Resolves: rhbz#2143704

Clipboard functions may run on connections that are not yet at
RFBSTATE_NORMAL. Due to recent hardening of the accessCheck() function,
it is important to validate that the state is RFBSTATE_NORMAL before
calling accessCheck().

Fixes #1599.

It's a type specific to that class, so let's keep them close for
clarity.

Make sure we don't send a bogus request to the X server in the (common)
case that we don't actually have anything to restore.

It is much more natural than custom methods for this very common
operation.

It is easy to get confused if these methods modify the existing object,
or return a new one. So let's mark the return value as critical so the
compiler can help out if someone gets it wrong.

This can have unexpected consequences as some code may rely on it being
a simple variable. Instead to what we do in Socket, which is to define a
unique name for getting socket error numbers.

It doesn't use any exceptions, so stop including the header for it.

These files don't use anything from this header, so remove the include.

This exposes some missing includes in other places, though. So add an
explicit include in the files that were relying on an indirect
inclusion.

This matches the naming in STL, which is what we are mostly mimicing now
that we are using std::string for these functions.