- Use BrowserStack workaround for proper sendKeys functionality on IE11. - TreeGridBigDetailsManagerTest: allow two pixel discrepancy in expected scroll position to accommodate IE. - TreeWideContent: switched from raw type to type inference. - ValoColorPickerInputFormatsTest: switched equals comparison to correct way around. - ResponsiveLayoutUpdateTest: updated screenshots for IE - ColumnCollapsingAndColumnExpansionTest: updated screenshots for IE - ClosingWindowWithBrowserFrameShouldntGenerate404Test: test is incompatible with IE driver, excluded from tested browsers. In manual testing IE doesn't get 404 in the logs with or without the fix associated with this test but there are other client-side exceptions related to focus handling in either case. However, those are out of scope for this particular fix and should be investigated separately.tags/8.10.0.alpha1
@@ -17,7 +17,7 @@ public class TreeWideContent extends AbstractTestUI { | |||
tree.setWidth("150px"); | |||
tree.setHeight("100px"); | |||
TreeData<String> data = new TreeData(); | |||
TreeData<String> data = new TreeData<>(); | |||
data.addItem(null, "Foo"); | |||
data.addItem("Foo", "Extra long text content that should be wider" | |||
+ " than the allocated width of the Tree."); |
@@ -148,7 +148,7 @@ public class ValoColorPickerInputFormatsTest extends MultiBrowserTest { | |||
// verify there are errors | |||
assertTrue(previewElement.getColorFieldContainsErrors()); | |||
// verify value has not been changed | |||
assertEquals(previewElement.getColorFieldValue(), "#xyz"); | |||
assertEquals("#xyz", previewElement.getColorFieldValue()); | |||
} | |||
private void setColorpickerValue(String value) { |
@@ -762,7 +762,7 @@ public class TreeGridBigDetailsManagerTest extends MultiBrowserTest { | |||
assertThat("Scroll to 55 didn't scroll as expected", | |||
(double) detailsY + detailsHeight, | |||
closeTo(wrapperY + wrapperHeight, 1d)); | |||
closeTo(wrapperY + wrapperHeight, 2d)); | |||
$(ButtonElement.class).id(SCROLL_TO_3055).click(); | |||
waitUntil(expectedConditionDetails(74, 5, null)); | |||
@@ -775,7 +775,7 @@ public class TreeGridBigDetailsManagerTest extends MultiBrowserTest { | |||
assertThat("Scroll to 3055 didn't scroll as expected", | |||
(double) detailsY + detailsHeight, | |||
closeTo(wrapperY + wrapperHeight, 1d)); | |||
closeTo(wrapperY + wrapperHeight, 2d)); | |||
$(ButtonElement.class).id(SCROLL_TO_END).click(); | |||
waitUntil(expectedConditionDetails(99, 9, 2)); | |||
@@ -792,7 +792,7 @@ public class TreeGridBigDetailsManagerTest extends MultiBrowserTest { | |||
assertThat("Scroll to end didn't scroll as expected", | |||
(double) detailsY + detailsHeight, | |||
closeTo(wrapperY + wrapperHeight, 1d)); | |||
closeTo(wrapperY + wrapperHeight, 2d)); | |||
$(ButtonElement.class).id(SCROLL_TO_START).click(); | |||
waitUntil(expectedConditionDetails(0, 0, 0)); |
@@ -1,14 +1,18 @@ | |||
package com.vaadin.tests.components.window; | |||
import com.vaadin.testbench.elements.ButtonElement; | |||
import com.vaadin.testbench.elements.LabelElement; | |||
import com.vaadin.testbench.elements.WindowElement; | |||
import com.vaadin.tests.tb3.MultiBrowserTest; | |||
import java.util.Arrays; | |||
import java.util.List; | |||
import org.junit.Assert; | |||
import org.junit.Test; | |||
import org.openqa.selenium.logging.LogEntry; | |||
import org.openqa.selenium.remote.DesiredCapabilities; | |||
import java.util.List; | |||
import com.vaadin.testbench.elements.ButtonElement; | |||
import com.vaadin.testbench.elements.LabelElement; | |||
import com.vaadin.testbench.elements.WindowElement; | |||
import com.vaadin.testbench.parallel.Browser; | |||
import com.vaadin.tests.tb3.MultiBrowserTest; | |||
public class ClosingWindowWithBrowserFrameShouldntGenerate404Test | |||
extends MultiBrowserTest { | |||
@@ -36,4 +40,12 @@ public class ClosingWindowWithBrowserFrameShouldntGenerate404Test | |||
return !logs.stream().anyMatch( | |||
ClosingWindowWithBrowserFrameShouldntGenerate404Test::contains404); | |||
} | |||
@Override | |||
public List<DesiredCapabilities> getBrowsersToTest() { | |||
// IE driver does not support logging API, see | |||
// https://github.com/SeleniumHQ/selenium/issues/6414 | |||
return Arrays.asList(Browser.CHROME.getDesiredCapabilities(), | |||
Browser.FIREFOX.getDesiredCapabilities()); | |||
} | |||
} |
@@ -45,6 +45,9 @@ public class BrowserStackBrowserFactory extends DefaultBrowserFactory { | |||
caps.setCapability("ie.ensureCleanSession", true); | |||
caps.setCapability(InternetExplorerDriver.IE_ENSURE_CLEAN_SESSION, | |||
true); | |||
// Workaround for an IE11 bug in BrowserStack sendKeys handling, see | |||
// https://www.browserstack.com/automate/using-sendkeys-on-remote-IE11 | |||
caps.setCapability("browserstack.sendKeys", true); | |||
break; | |||
default: | |||
caps = DesiredCapabilities.firefox(); |