Browse Source

Remove redundant locking (#8894)

Change-Id: I2a5176fe0c329e66d9e7a87825fc99a03fb5d708
tags/7.1.0.beta1
Leif Åstrand 11 years ago
parent
commit
1c4adacdc2
1 changed files with 4 additions and 9 deletions
  1. 4
    9
      server/src/com/vaadin/server/VaadinService.java

+ 4
- 9
server/src/com/vaadin/server/VaadinService.java View File

@@ -880,6 +880,7 @@ public abstract class VaadinService implements Serializable {
*
*/
public UI findUI(VaadinRequest request) {
// getForSession asserts that the lock is held
VaadinSession session = VaadinSession.getForSession(this,
request.getWrappedSession());

@@ -887,16 +888,10 @@ public abstract class VaadinService implements Serializable {
String uiIdString = request.getParameter(UIConstants.UI_ID_PARAMETER);
int uiId = Integer.parseInt(uiIdString);

// Get lock before accessing data in session
session.lock();
try {
UI ui = session.getUIById(uiId);
UI ui = session.getUIById(uiId);

UI.setCurrent(ui);
return ui;
} finally {
session.unlock();
}
UI.setCurrent(ui);
return ui;
}

/**

Loading…
Cancel
Save