Browse Source

Clarify comments in Table.typeIsCompatible (#8168)

Change-Id: Idc9b2e2052afe2b5586904c535674ec686bb4685
tags/7.4.0.alpha1
Juuso Valli 10 years ago
parent
commit
716046af83
1 changed files with 2 additions and 16 deletions
  1. 2
    16
      server/src/com/vaadin/ui/Table.java

+ 2
- 16
server/src/com/vaadin/ui/Table.java View File

@@ -2775,22 +2775,8 @@ public class Table extends AbstractSelect implements Action.Container,
*/
private boolean typeIsCompatible(Class<?> a, Class<?> b) {
// TODO Implement this check properly
// Map<Class<?>, Class<?>> typemap = new HashMap<Class<?>, Class<?>>();
// typemap.put(byte.class, Byte.class);
// typemap.put(short.class, Short.class);
// typemap.put(int.class, Integer.class);
// typemap.put(long.class, Long.class);
// typemap.put(float.class, Float.class);
// typemap.put(double.class, Double.class);
// typemap.put(char.class, Character.class);
// typemap.put(boolean.class, Boolean.class);
// if (typemap.containsKey(a)) {
// a = typemap.get(a);
// }
// if (typemap.containsKey(b)) {
// b = typemap.get(b);
// }
// return a.isAssignableFrom(b);
// Basically we need to do a a.isAssignableFrom(b)
// with special considerations for primitive types.
return true;
}


Loading…
Cancel
Save