Disable automatic removal of trailing whitespace and reformatted using Luna

Automatic removal of trailing whitespaces in Eclipse does not work even
in a nearly consistent way across platforms, versions or even on the same
maching within the same workspaces. Saving the same file multiple times
even alternates between adding and removing a whitespace on empty block
comment lines when saving.

Change-Id: I0efd307fd48869ea688eb79aa77c9ba38de5a4a6

.settings/org.eclipse.jdt.ui.prefs

 sp_cleanup.always_use_parentheses_in_expressions=false
 sp_cleanup.always_use_this_for_non_static_field_access=false
 sp_cleanup.always_use_this_for_non_static_method_access=false
+sp_cleanup.convert_functional_interfaces=false
 sp_cleanup.convert_to_enhanced_for_loop=false
 sp_cleanup.correct_indentation=false
 sp_cleanup.format_source_code=true
 sp_cleanup.format_source_code_changes_only=false
+sp_cleanup.insert_inferred_type_arguments=false
 sp_cleanup.make_local_variable_final=false
 sp_cleanup.make_parameters_final=false
 sp_cleanup.make_private_fields_final=true
 sp_cleanup.qualify_static_member_accesses_with_declaring_class=false
 sp_cleanup.qualify_static_method_accesses_with_declaring_class=false
 sp_cleanup.remove_private_constructors=true
-sp_cleanup.remove_trailing_whitespaces=true
+sp_cleanup.remove_redundant_type_arguments=false
+sp_cleanup.remove_trailing_whitespaces=false
 sp_cleanup.remove_trailing_whitespaces_all=true
 sp_cleanup.remove_trailing_whitespaces_ignore_empty=false
 sp_cleanup.remove_unnecessary_casts=true
 sp_cleanup.remove_unused_private_types=true
 sp_cleanup.sort_members=false
 sp_cleanup.sort_members_all=false
+sp_cleanup.use_anonymous_class_creation=false
 sp_cleanup.use_blocks=true
 sp_cleanup.use_blocks_only_for_return_and_throw=false
+sp_cleanup.use_lambda=false
 sp_cleanup.use_parentheses_in_expressions=false
 sp_cleanup.use_this_for_non_static_field_access=true
 sp_cleanup.use_this_for_non_static_field_access_only_if_necessary=true
 sp_cleanup.use_this_for_non_static_method_access=true
 sp_cleanup.use_this_for_non_static_method_access_only_if_necessary=true
+sp_cleanup.use_type_arguments=false

client/src/com/vaadin/client/ApplicationConnection.java

         startRequest();
 
         JSONObject payload = new JSONObject();
-        if (!getCsrfToken().equals(ApplicationConstants.CSRF_TOKEN_DEFAULT_VALUE)) {
+        if (!getCsrfToken().equals(
+                ApplicationConstants.CSRF_TOKEN_DEFAULT_VALUE)) {
             payload.put(ApplicationConstants.CSRF_TOKEN, new JSONString(
                     getCsrfToken()));
         }

client/src/com/vaadin/client/communication/Heartbeat.java

 
             @Override
             public void onError(Request request, Throwable exception) {
-                getLogger().severe("Exception sending heartbeat: " + exception.getMessage());
+                getLogger().severe(
+                        "Exception sending heartbeat: "
+                                + exception.getMessage());
                 // Notify network observers about response status
                 connection.fireEvent(new ConnectionStatusEvent(0));
                 // Don't break the loop

client/src/com/vaadin/client/componentlocator/LocatorStrategy.java

      * @return The DOM element identified by {@code path} or null if the element
      *         could not be located.
      */
-    Element getElementByPathStartingAt(String path,
-            Element root);
+    Element getElementByPathStartingAt(String path, Element root);
 
     /**
      * Locates all elements that match a String locator (path) which identifies
      *         found.
      */
 
-    List<Element> getElementsByPathStartingAt(
-            String path, Element root);
+    List<Element> getElementsByPathStartingAt(String path, Element root);
 }

client/src/com/vaadin/client/debug/internal/HierarchySection.java

 
         hierarchyPanel.addListener(new SelectConnectorListener() {
             @Override
-            public void select(ServerConnector connector,
-                    Element element) {
+            public void select(ServerConnector connector, Element element) {
                 printState(connector, true);
             }
         });
 
         analyzeLayoutsPanel.addListener(new SelectConnectorListener() {
             @Override
-            public void select(ServerConnector connector,
-                    Element element) {
+            public void select(ServerConnector connector, Element element) {
                 printState(connector, true);
             }
         });

client/src/com/vaadin/client/debug/internal/SelectConnectorListener.java

      * @param element
      *            selected element of the connector or null if unknown
      */
-    public void select(ServerConnector connector,
-            Element element);
+    public void select(ServerConnector connector, Element element);
 }

client/src/com/vaadin/client/ui/VOverlay.java

      * A "thread local" of sorts, set temporarily so that VOverlayImpl knows
      * which VOverlay is using it, so that it can be attached to the correct
      * overlay container.
-     *
+     * 
      * TODO this is a strange pattern that we should get rid of when possible.
      */
     protected static VOverlay current;
 
     /*
      * (non-Javadoc)
-     *
+     * 
      * @see com.google.gwt.user.client.ui.PopupPanel#hide()
      */
     @Override
 
     /*
      * (non-Javadoc)
-     *
+     * 
      * @see com.google.gwt.user.client.ui.PopupPanel#hide(boolean)
      */
     @Override

client/src/com/vaadin/client/ui/dd/DDUtil.java

     }
 
     public static HorizontalDropLocation getHorizontalDropLocation(
-            Element element, NativeEvent event,
-            double leftRightRatio) {
+            Element element, NativeEvent event, double leftRightRatio) {
         int clientX = Util.getTouchOrMouseClientX(event);
 
         // Event coordinates are relative to the viewport, element absolute

client/src/com/vaadin/client/ui/dd/DragImageModifier.java

 /**
  * Interface implemented by widgets if the drag image used for drag'n'drop
  * requires additional initialization/configuration. The method
- * {@link #modifyDragImage(Element)} is called for each element in the automatically generated drag image.
+ * {@link #modifyDragImage(Element)} is called for each element in the
+ * automatically generated drag image.
  * 
  * @since 7.2
  * @author Vaadin Ltd

server/src/com/vaadin/server/Page.java

     }
 
     public void init(VaadinRequest request) {
-        // NOTE: UI.refresh makes assumptions about the semantics of this method.
+        // NOTE: UI.refresh makes assumptions about the semantics of this
+        // method.
         // It should be kept in sync if this method is changed.
 
         // Extract special parameter sent by vaadinBootstrap.js

server/src/com/vaadin/server/VaadinSession.java

              * deadlocks unless implemented very carefully. get(long, TimeUnit)
              * does not have the same detection since a sensible timeout should
              * avoid completely locking up the application.
-             *
+             * 
              * Even though no deadlock could occur after the runnable has been
              * run, the check is always done as the deterministic behavior makes
              * it easier to detect potential problems.

server/src/com/vaadin/server/communication/ClientRpcWriter.java

                     // + parameterType.getName());
                     // }
                     // }
-                    EncodeResult encodeResult = JsonCodec.encode(invocation.getParameters()[i],
-                            referenceParameter, parameterType,
-                            ui.getConnectorTracker());
+                    EncodeResult encodeResult = JsonCodec.encode(
+                            invocation.getParameters()[i], referenceParameter,
+                            parameterType, ui.getConnectorTracker());
                     paramJson.put(encodeResult.getEncodedValue());
                 }
                 invocationJson.put(paramJson);

server/src/com/vaadin/ui/NotificationConfiguration.java

         NotificationTypeConfiguration styleSetup = getTypeConf(type);
         if (styleSetup == null) {
             styleSetup = new NotificationTypeConfiguration();
-            ui.getState().notificationConfigurations.put(type.getStyle(), styleSetup);
+            ui.getState().notificationConfigurations.put(type.getStyle(),
+                    styleSetup);
         }
 
         return styleSetup;

server/src/com/vaadin/ui/TabSheet.java

      *            the position at where the the tab should be added.
      * @return the created {@link Tab}
      */
-    public Tab addTab(Component tabComponent, String caption, Resource icon, int position) {
+    public Tab addTab(Component tabComponent, String caption, Resource icon,
+            int position) {
         if (tabComponent == null) {
             return null;
         } else if (tabs.containsKey(tabComponent)) {
 
         @Override
         public Resource getIcon() {
-            return getResource(ComponentConstants.ICON_RESOURCE
-                    + tabState.key);
+            return getResource(ComponentConstants.ICON_RESOURCE + tabState.key);
         }
 
         @Override
 
         @Override
         public void setIcon(Resource icon, String iconAltText) {
-            setResource(ComponentConstants.ICON_RESOURCE + tabState.key,
-                    icon);
+            setResource(ComponentConstants.ICON_RESOURCE + tabState.key, icon);
             tabState.iconAltText = iconAltText;
         }
     }

server/src/com/vaadin/util/CurrentInstance.java

                  * ThreadLocal should only outlive the referenced object on
                  * threads that are not doing anything related to Vaadin, which
                  * should thus never invoke CurrentInstance.get().
-                 *
+                 * 
                  * At this point, there might also be other values that have
                  * been collected, so we'll scan the entire map and remove stale
                  * CurrentInstance objects. Using a ReferenceQueue could make
                  * CurrentInstance. Without this a reference to an already
                  * collected instance may be left in the CurrentInstance when it
                  * really should be restored to null.
-                 *
+                 * 
                  * One example case that this fixes:
                  * VaadinService.runPendingAccessTasks() clears all current
                  * instances and then sets everything but the UI. This makes

server/tests/src/com/vaadin/server/VaadinPortletRequestTests.java

 
     @Test
     public void defaultValueForPortletPreferenceIsNull() {
-        when(preferences.getValue(anyString(), isNull(String.class))).thenReturn(null);
+        when(preferences.getValue(anyString(), isNull(String.class)))
+                .thenReturn(null);
 
         String value = sut.getPortletPreference("foo");
 

uitest/src/com/vaadin/tests/components/abstractcomponent/PrimaryStyleTest.java

         $(ButtonElement.class).id("update-button").click();
 
         // Verify that the class names where updated as expected.
-        List<WebElement> updatedElements = driver.findElements(By.className("updated-correctly"));
+        List<WebElement> updatedElements = driver.findElements(By
+                .className("updated-correctly"));
         assertThat(updatedElements, hasSize(initialElements.size()));
 
     }

uitest/src/com/vaadin/tests/components/button/ButtonToggleIcons.java

         layout.addComponent(new Button("Toggle icon", iconToggleListener));
         layout.addComponent(new NativeButton("Toggle icon", iconToggleListener));
     }
-}
+}

uitest/src/com/vaadin/tests/components/checkbox/CheckBoxRpcCountTest.java

 
         // Click on the actual checkbox.
         inputElem.click();
-        //Have to use waitUntil to make this test more stable.
+        // Have to use waitUntil to make this test more stable.
         waitUntilLabelIsUpdated(countElem, "1 RPC call(s) made.");
 
         // Click on the checkbox label.
         waitUntilLabelIsUpdated(countElem, "3 RPC call(s) made.");
     }
 
-    private void waitUntilLabelIsUpdated(final WebElement countElem, final String expectedText) {
+    private void waitUntilLabelIsUpdated(final WebElement countElem,
+            final String expectedText) {
         waitUntil(new ExpectedCondition<Boolean>() {
             @Override
             public Boolean apply(WebDriver input) {

uitest/src/com/vaadin/tests/components/combobox/ComboBoxInputPromptTest.java

         ComboBoxElement disabledComboBox = getComboBoxWithCaption("Disabled");
         ComboBoxElement readOnlyComboBox = getComboBoxWithCaption("Read-only");
 
-        assertThat(getInputPromptValue(normalComboBox), is("Normal input prompt"));
+        assertThat(getInputPromptValue(normalComboBox),
+                is("Normal input prompt"));
         assertThat(getInputPromptValue(disabledComboBox), isEmptyString());
         assertThat(getInputPromptValue(readOnlyComboBox), isEmptyString());
 
         toggleDisabledAndReadonly();
-        assertThat(getInputPromptValue(disabledComboBox), is("Disabled input prompt"));
-        assertThat(getInputPromptValue(readOnlyComboBox), is("Read-only input prompt"));
+        assertThat(getInputPromptValue(disabledComboBox),
+                is("Disabled input prompt"));
+        assertThat(getInputPromptValue(readOnlyComboBox),
+                is("Read-only input prompt"));
 
         toggleDisabledAndReadonly();
         assertThat(getInputPromptValue(disabledComboBox), isEmptyString());

uitest/src/com/vaadin/tests/components/combobox/ComboBoxScrollingWithArrowsTest.java

         // provide any way to access the popup and send keys to it.
         // Ticket #13756
 
-        return driver.findElement(By
-                .className("v-filterselect-input"));
+        return driver.findElement(By.className("v-filterselect-input"));
     }
 
     private void openPopup() {
             dropDownComboBox.sendKeys(Keys.DOWN);
         }
 
-        assertThat(getSelectedItemText(), is("item " + PAGESIZE)); //item 10
+        assertThat(getSelectedItemText(), is("item " + PAGESIZE)); // item 10
     }
 
     private String getSelectedItemText() {
         waitUntilNextPageIsVisible();
         dropDownComboBox.sendKeys(Keys.UP);
 
-        assertThat(getSelectedItemText(), is("item " + (PAGESIZE - 1))); //item 9
+        assertThat(getSelectedItemText(), is("item " + (PAGESIZE - 1))); // item
+                                                                         // 9
     }
 
     private void waitUntilNextPageIsVisible() {

uitest/src/com/vaadin/tests/components/datefield/DateFieldReadOnlyTest.java

 package com.vaadin.tests.components.datefield;
 
-
 import com.vaadin.testbench.By;
 import com.vaadin.testbench.elements.ButtonElement;
 import com.vaadin.testbench.elements.DateFieldElement;
 public class DateFieldReadOnlyTest extends MultiBrowserTest {
 
     @Test
-    public void readOnlyDateFieldPopupShouldNotOpen() throws IOException, InterruptedException {
+    public void readOnlyDateFieldPopupShouldNotOpen() throws IOException,
+            InterruptedException {
         openTestURL();
 
         compareScreen("initial");
     }
 
     private void closePopup() {
-        findElement(By.className("v-datefield-calendarpanel")).sendKeys(Keys.RETURN);
+        findElement(By.className("v-datefield-calendarpanel")).sendKeys(
+                Keys.RETURN);
     }
 
     private void openPopup() {
-        //waiting for openPopup() in TB4 beta1: http://dev.vaadin.com/ticket/13766
-        $(DateFieldElement.class).first().findElement(By.tagName("button")).click();
+        // waiting for openPopup() in TB4 beta1:
+        // http://dev.vaadin.com/ticket/13766
+        $(DateFieldElement.class).first().findElement(By.tagName("button"))
+                .click();
     }
 
     private void toggleReadOnly() {

uitest/src/com/vaadin/tests/components/gridlayout/MoveComponentsFromGridLayoutToInnerLayoutTest.java

 
 import static org.junit.Assert.*;
 
-public class MoveComponentsFromGridLayoutToInnerLayoutTest extends MultiBrowserTest {
+public class MoveComponentsFromGridLayoutToInnerLayoutTest extends
+        MultiBrowserTest {
 
     @Test
     public void buttonIsMovedInsideInnerLayout() throws IOException {

uitest/src/com/vaadin/tests/components/menubar/MenuTooltipTest.java

     public void testToolTipDelay() throws InterruptedException {
         openTestURL();
 
-        Coordinates elementCoordinates = getCoordinates($(MenuBarElement.class).first());
+        Coordinates elementCoordinates = getCoordinates($(MenuBarElement.class)
+                .first());
 
         Mouse mouse = ((HasInputDevices) getDriver()).getMouse();
 

uitest/src/com/vaadin/tests/components/notification/NotificationsWaiAria.java

                     .getNotificationConfiguration();
             notificationConf.setAssistivePrefix(typeValue, prefix.getValue());
             notificationConf.setAssistivePostfix(typeValue, postfix.getValue());
-            notificationConf
-                    .setAssistiveRole(typeValue, (NotificationRole) role.getValue());
+            notificationConf.setAssistiveRole(typeValue,
+                    (NotificationRole) role.getValue());
 
             n.show(Page.getCurrent());
         }

uitest/src/com/vaadin/tests/components/window/WindowMoveListenerTest.java

         waitUntilWindowHasReseted(window, winPos);
     }
 
-    private void waitUntilWindowHasReseted(final WebElement window, final Point winPos) {
+    private void waitUntilWindowHasReseted(final WebElement window,
+            final Point winPos) {
         waitUntil(new ExpectedCondition<Boolean>() {
             @Override
             public Boolean apply(WebDriver input) {
-                return winPos.x == window.getLocation().x &&
-                       winPos.y == window.getLocation().y;
+                return winPos.x == window.getLocation().x
+                        && winPos.y == window.getLocation().y;
             }
         }, 5);
     }

uitest/src/com/vaadin/tests/layouts/gridlayout/GridLayoutWidthChangeTest.java

 
         compareScreen("initial");
 
-        $(ButtonElement.class).caption("Reduce GridLayout parent width").first().click();
+        $(ButtonElement.class).caption("Reduce GridLayout parent width")
+                .first().click();
 
         compareScreen("buttonMoved");
     }

uitest/src/com/vaadin/tests/layouts/layouttester/GridLayout/GridAddReplaceMove.java

 
     /*
      * (non-Javadoc)
-     *
+     * 
      * @see com.vaadin.tests.components.AbstractTestUI#setup(com.vaadin.server.
      * VaadinRequest)
      */

uitest/src/com/vaadin/tests/layouts/layouttester/HLayout/HAddReplaceMove.java

 import com.vaadin.tests.layouts.layouttester.BaseAddReplaceMove;
 import com.vaadin.ui.HorizontalLayout;
 
-
 public class HAddReplaceMove extends BaseAddReplaceMove {
 
     /**

uitest/src/com/vaadin/tests/layouts/layouttester/HLayout/HCaption.java

 import com.vaadin.tests.layouts.layouttester.BaseCaption;
 import com.vaadin.ui.HorizontalLayout;
 
-
 public class HCaption extends BaseCaption {
 
     /**

uitest/src/com/vaadin/tests/layouts/layouttester/VLayout/VLayoutExpandTest.java

 
 import com.vaadin.tests.layouts.layouttester.BaseLayoutExpandTest;
 
-
 /**
  *
  * @since

uitest/src/com/vaadin/tests/layouts/layouttester/VLayout/VLayoutRegErrorTest.java

 
 import com.vaadin.tests.layouts.layouttester.BaseLayoutRegErrorTest;
 
-
 /**
  *
  * @since

uitest/src/com/vaadin/tests/layouts/layouttester/VLayout/VLayoutSizingTest.java

 
 import com.vaadin.tests.layouts.layouttester.BaseLayoutSizingTest;
 
-
 /**
  *
  * @since

uitest/src/com/vaadin/tests/push/PushConfigurationLongPollingTest.java

 
         clearDebugMessages();
         new Select(getPushModeSelect()).selectByVisibleText("AUTOMATIC");
-        waitForDebugMessage("Push connection established using long-polling", 10);
+        waitForDebugMessage("Push connection established using long-polling",
+                10);
         waitForServerCounterToUpdate();
     }
 

uitest/src/com/vaadin/tests/push/ReconnectLongPollingTest.java

  */
 package com.vaadin.tests.push;
 
-
 public class ReconnectLongPollingTest extends ReconnectTest {
 
     @Override

uitest/src/com/vaadin/tests/push/ReconnectStreamingTest.java

  */
 package com.vaadin.tests.push;
 
-
 public class ReconnectStreamingTest extends ReconnectTest {
 
     @Override

uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java

     }
 
     protected WebElement getTooltipElement() {
-        return getDriver().findElement(com.vaadin.testbench.By.className("v-tooltip-text"));
+        return getDriver().findElement(
+                com.vaadin.testbench.By.className("v-tooltip-text"));
     }
 
     protected Coordinates getCoordinates(TestBenchElement element) {

uitest/src/com/vaadin/tests/tooltip/AdjacentElementsWithTooltipsTest.java

     }
 
     private ButtonElement getButton(String caption) {
-        return $(ButtonElement.class)
-                    .caption(caption).first();
+        return $(ButtonElement.class).caption(caption).first();
     }
 }