Browse Source

Fix TreeGrid.getHierarchyColumn to use correct id (#9690)

Fixes #9661
tags/8.1.0.rc2
Teemu Suo-Anttila 6 years ago
parent
commit
c81f853fd9

+ 1
- 1
server/src/main/java/com/vaadin/ui/TreeGrid.java View File

@@ -248,7 +248,7 @@ public class TreeGrid<T> extends Grid<T>
* has been explicitly set
*/
public Column<T, ?> getHierarchyColumn() {
return getColumn(getState(false).hierarchyColumnId);
return getColumnByInternalId(getState(false).hierarchyColumnId);
}

/**

+ 12
- 0
server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java View File

@@ -5,6 +5,7 @@ import org.junit.Test;

import com.vaadin.data.TreeData;
import com.vaadin.data.provider.TreeDataProvider;
import com.vaadin.ui.Grid.Column;
import com.vaadin.ui.TreeGrid;
import com.vaadin.ui.renderers.TextRenderer;

@@ -14,6 +15,7 @@ public class TreeGridTest {
private boolean expandEventFired = false;
private boolean collapseEventFired = false;

@Test
public void testChangeRendererOfHierarchyColumn() {
treeGrid.addColumn(Object::toString).setId("foo");
treeGrid.setHierarchyColumn("foo");
@@ -44,4 +46,14 @@ public class TreeGridTest {
Assert.assertFalse("Item not collapsed", treeGrid.isExpanded("Foo"));
Assert.assertTrue("Collapse event not fired", collapseEventFired);
}

@Test
public void testSetAndGetHierarchyColumn() {
Column<String, String> column = treeGrid.addColumn(Object::toString)
.setId("foo");
treeGrid.setHierarchyColumn("foo");
Assert.assertEquals("Hierarchy column was not correctly returned",
column, treeGrid.getHierarchyColumn());
}

}

Loading…
Cancel
Save