Browse Source
Remove whitespace-maven-plugin and formatter-maven-plugin. (#12213)
- These plugins cause significant problems for many Windows developers, and since most active maintainers are currently included in that group, the plugins have been deemed more trouble than they are worth.tags/8.13.0.alpha1
Anna Koskinen
3 years ago
8 changed files with 0 additions and 112 deletions
+ 0
- 2
.github/CONTRIBUTING.md
View File
| @@ -14,8 +14,6 @@ Unless the issue is specific to a single version of the Framework, you should al | |||
| In your repo, make a new branch from `master`. Make your code changes in that branch, and once you're done make a pull request to the `vaadin/framework` branch `master`. | |||
| The `vaadin/framework` project uses `formatter-maven-plugin` to format the code. It will be executed as part of the Maven build. Make sure to run `mvn compile` before making the commit. | |||
| We recommend making sure that the "Allow edits from maintainers" checkbox on the pull request page is checked. This allows us to commit minor fixes, like correcting typos, without bothering you. | |||
| ### Getting feedback and responding to it | |||
+ 0
- 1
README-DEV.md
View File
| @@ -119,7 +119,6 @@ After that is done, you should have 9 of 28 save actions activated and listed as | |||
| Run <code>install</code> maven goal for the project root to get started. | |||
| In Eclipse this is done by right-clicking on the project root in Project Explorer and choosing *Run As* -> *Maven Build...*. If you choose to skip tests you may need to run the <code>install</code> maven goal for `vaadin-uitest` project separately. | |||
| * Note that the first compilation takes a while to finish as Maven downloads dependencies used in the projects. | |||
| * In some Windows environments the compilation doesn't respect the `core.autocrlf=false` and the workspace preferences listed in the previous section, and running <code>install</code> converts all line endings from six core projects (root, `vaadin-client`, `vaadin-server`, `vaadin-shared`, `vaadin-testbench-api`, `vaadin-uitest`) to Windows-style. As a quick-and-dirty workaround you can change the line endings back through *File* -> *Convert Line Delimiters To* -> *Unix* and comment out references to plugins `net.revelc.code.formatter` and `com.github.dantwining.whitespace-maven-plugin` from each affected module's pom.xml (root project references them twice) to prevent it from happening again. *Do not* include those changes or any files with Windows-style line endings in any pull request. Because you consequently lose the formatting benefits of those plugins, you also need to be more careful about not including irrelevant formatting changes in your commits. | |||
| Now the project should compile without further configuration. | |||
+ 0
- 9
client/pom.xml
View File
| @@ -46,15 +46,6 @@ | |||
| <build> | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.github.dantwining.whitespace-maven-plugin</groupId> | |||
| <artifactId>whitespace-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <artifactId>maven-resources-plugin</artifactId> | |||
| <executions> | |||
+ 0
- 70
pom.xml
View File
| @@ -458,38 +458,6 @@ | |||
| <artifactId>vaadin-maven-plugin</artifactId> | |||
| <version>${vaadin.plugin.version}</version> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| <version>2.7.2</version> | |||
| <configuration> | |||
| <configFile>${project.basedir}/../eclipse/VaadinJavaConventions.xml</configFile> | |||
| <skipJsFormatting>true</skipJsFormatting> | |||
| </configuration> | |||
| <executions> | |||
| <execution> | |||
| <id>format-source</id> | |||
| <goals> | |||
| <goal>format</goal> | |||
| </goals> | |||
| <phase>process-sources</phase> | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.github.dantwining.whitespace-maven-plugin</groupId> | |||
| <artifactId>whitespace-maven-plugin</artifactId> | |||
| <version>1.0.4</version> | |||
| <executions> | |||
| <execution> | |||
| <id>trim-trailing-spaces-source</id> | |||
| <goals> | |||
| <goal>trim</goal> | |||
| </goals> | |||
| <phase>process-sources</phase> | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-checkstyle-plugin</artifactId> | |||
| @@ -543,44 +511,6 @@ | |||
| <ignore></ignore> | |||
| </action> | |||
| </pluginExecution> | |||
| <pluginExecution> | |||
| <pluginExecutionFilter> | |||
| <groupId> | |||
| net.revelc.code.formatter | |||
| </groupId> | |||
| <artifactId> | |||
| formatter-maven-plugin | |||
| </artifactId> | |||
| <versionRange> | |||
| [2.7.2,) | |||
| </versionRange> | |||
| <goals> | |||
| <goal>format</goal> | |||
| </goals> | |||
| </pluginExecutionFilter> | |||
| <action> | |||
| <ignore></ignore> | |||
| </action> | |||
| </pluginExecution> | |||
| <pluginExecution> | |||
| <pluginExecutionFilter> | |||
| <groupId> | |||
| com.github.dantwining.whitespace-maven-plugin | |||
| </groupId> | |||
| <artifactId> | |||
| whitespace-maven-plugin | |||
| </artifactId> | |||
| <versionRange> | |||
| [1.0.4,) | |||
| </versionRange> | |||
| <goals> | |||
| <goal>trim</goal> | |||
| </goals> | |||
| </pluginExecutionFilter> | |||
| <action> | |||
| <ignore></ignore> | |||
| </action> | |||
| </pluginExecution> | |||
| </pluginExecutions> | |||
| </lifecycleMappingMetadata> | |||
| </configuration> | |||
+ 0
- 8
server/pom.xml
View File
| @@ -139,14 +139,6 @@ | |||
| <build> | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.github.dantwining.whitespace-maven-plugin</groupId> | |||
| <artifactId>whitespace-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-dependency-plugin</artifactId> | |||
+ 0
- 9
shared/pom.xml
View File
| @@ -37,15 +37,6 @@ | |||
| <build> | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.github.dantwining.whitespace-maven-plugin</groupId> | |||
| <artifactId>whitespace-maven-plugin</artifactId> | |||
| </plugin> | |||
| <!-- Generated Version.java --> | |||
| <plugin> | |||
| <groupId>org.codehaus.mojo</groupId> | |||
+ 0
- 4
testbench-api/pom.xml
View File
| @@ -35,10 +35,6 @@ | |||
| <build> | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-checkstyle-plugin</artifactId> | |||
+ 0
- 9
uitest/pom.xml
View File
| @@ -237,15 +237,6 @@ | |||
| <plugins> | |||
| <plugin> | |||
| <groupId>net.revelc.code.formatter</groupId> | |||
| <artifactId>formatter-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.github.dantwining.whitespace-maven-plugin</groupId> | |||
| <artifactId>whitespace-maven-plugin</artifactId> | |||
| </plugin> | |||
| <plugin> | |||
| <groupId>com.vaadin</groupId> | |||
| <artifactId>vaadin-maven-plugin</artifactId> | |||
Loading…