Browse Source

Improved Binder#hasChanges JavaDoc (#8912)

JavaDoc now more explicitly states that hasChanges is not designed to work with setBean.
tags/8.1.0.alpha2
Matti Tahvonen 7 years ago
parent
commit
da7b805f10
1 changed files with 12 additions and 8 deletions
  1. 12
    8
      server/src/main/java/com/vaadin/data/Binder.java

+ 12
- 8
server/src/main/java/com/vaadin/data/Binder.java View File

@@ -1602,7 +1602,7 @@ public class Binder<BEAN> implements Serializable {
* level validators if a bean is currently set with
* {@link #setBean(Object)}, and returns whether any of the validators
* failed.
*
*
* @return whether this binder is in a valid state
* @throws IllegalStateException
* if bean level validators have been configured and no bean is
@@ -1789,7 +1789,7 @@ public class Binder<BEAN> implements Serializable {
* <p>
* The listener is added to all fields regardless of whether the method is
* invoked before or after field is bound.
*
*
* @see ValueChangeEvent
* @see ValueChangeListener
*
@@ -1933,12 +1933,16 @@ public class Binder<BEAN> implements Serializable {
}

/**
* Check whether any of the bound fields' values have changed since last
* explicit call to {@link #setBean(Object)}, {@link #readBean(Object)},
* {@link #removeBean()}, {@link #writeBean(Object)} or
* {@link #writeBeanIfValid(Object)}. Unsuccessful write operations will not
* affect this value. Return values for each case are compiled into the
* following table:
* Check whether any of the bound fields' have uncommitted changes since
* last explicit call to {@link #readBean(Object)}, {@link #removeBean()},
* {@link #writeBean(Object)} or {@link #writeBeanIfValid(Object)}.
* Unsuccessful write operations will not affect this value.
* <p>
* Note that if you use {@link #setBean(Object)} method, Binder tries to
* commit changes as soon as all validators have passed. Thus, when using
* this method with it seldom makes sense and almost always returns false.
*
* Return values for each case are compiled into the following table:
*
* <p>
*

Loading…
Cancel
Save