Browse Source

Use textContent instead of innerText in TextRenderer (#8936)

* Use textContent instead of innerText in TextRenderer

This improves standards compliance and reduces unnecessary layouting.

Optimization suggested by Oskar Hýbl, Cleverbee solutions
tags/8.1.0.alpha3
Henri Sara 7 years ago
parent
commit
e091687db4

+ 8
- 1
client/src/main/java/com/vaadin/client/renderers/TextRenderer.java View File

@@ -15,6 +15,7 @@
*/
package com.vaadin.client.renderers;

import com.google.gwt.dom.client.Element;
import com.vaadin.client.widget.grid.RendererCellReference;

/**
@@ -27,6 +28,12 @@ public class TextRenderer implements Renderer<String> {

@Override
public void render(RendererCellReference cell, String text) {
cell.getElement().setInnerText(text);
// optimization suggested by Oskar Hýbl, Cleverbee solutions
setTextContent(cell.getElement(), text);
}

private native void setTextContent(Element elem, String text)
/*-{
elem.textContent = text;
}-*/;
}

Loading…
Cancel
Save