Browse Source

Change VSlider to use Event.ONKEYDOWN with Firefox 65+ (#11506)

Fixes #11502
tags/7.7.18^0
Tatu Lund 5 years ago
parent
commit
f24723c1db
1 changed files with 9 additions and 5 deletions
  1. 9
    5
      client/src/main/java/com/vaadin/client/ui/VSlider.java

+ 9
- 5
client/src/main/java/com/vaadin/client/ui/VSlider.java View File

@@ -283,11 +283,7 @@ public class VSlider extends SimpleFocusablePanel
increaseValue(true);
} else if (DOM.eventGetType(event) == Event.MOUSEEVENTS) {
processBaseEvent(event);
} else if (BrowserInfo.get().isGecko()
&& DOM.eventGetType(event) == Event.ONKEYPRESS
|| !BrowserInfo.get().isGecko()
&& DOM.eventGetType(event) == Event.ONKEYDOWN) {

} else if (isNavigationEvent(event)) {
if (handleNavigation(event.getKeyCode(), event.getCtrlKey(),
event.getShiftKey())) {

@@ -313,6 +309,14 @@ public class VSlider extends SimpleFocusablePanel
}
}

private boolean isNavigationEvent(Event event) {
if (BrowserInfo.get().isGecko() && BrowserInfo.get().getGeckoVersion() < 65) {
return DOM.eventGetType(event) == Event.ONKEYPRESS;
} else {
return DOM.eventGetType(event) == Event.ONKEYDOWN;
}
}

private void processMouseWheelEvent(final Event event) {
final int dir = DOM.eventGetMouseWheelVelocityY(event);


Loading…
Cancel
Save