Even though the call to Profiler.enter would be eliminated by the
compiler, it would still include the string concatenation since it can't
prove it wouldn't have any side effects.
Change-Id: Iae3f6d18c409f019d2207d212d00ecb78078bc3e
Fix Grid jerky resize in vertical split panel (#18370)
This patch makes SplitPanels overflow hidden when there is a full
height/width widget in the container.
Change-Id: I9cb80019806cd5237b7e07fdda05d44e50d3b929
Fix Grid details on sort to display them on correct rows (#18224)
Due to the nature of Container this is only achieved by removing any
existing details and reopening those after the sort is done.
Change-Id: Ic42186ed85981d5dad4ff0948aa22f7a0404480d
Don't recalculate columns if only height has changed (#18274)
This patch increases the reported fps in GridResizeTerror from 12 to 35
in my Chrome if only changing the height. No automatic test since
performance testing on our shared testing infrastructure would be quite
error-prone.
Change-Id: I327391dc04dde72a6e770df3b564ae8d4e3c15bb
Change focused Grid cell when scrolling with the keyboard (#18356).
- The focused cell is now updated when scrolling with pageup/down, home
or end key.
- The scroll amount is slightly reduced to ensure that no cells are
skipped over with pgup/down scroll.
Change-Id: Id1ddd4f0f3f3b1315df3f8d9813080fbd5009bcd
Revert "Prevent field from updating when removing text change listener. (#16270)"
This reverts commit 4af793d06a.
Test ConverterThatEnforcesAFormatTest.checkElaborating is broken by this change.
Change-Id: I8243f6a7bff6d7011d402bce4b614f7d2e4206fd
This patch also fixes issues with vertical scrollbar on page and
autoscrolling along with calculating drag element and marker positions
wrong.
Change-Id: I3d39c7bc6ddea630e04a9967ff8e1055c0736b79
Now calls directly to correct spacer container to update visibility
instead of doing extra work with recalculating everything.
Change-Id: I8625033012773a10983cd5d4f6ef3ce1be50ee26
Selection is now shown although scrollToSelectedItem is false (#16673)
If scrollToSelectedItem is set to false (which is needed to work
properly with
large datasets) the selected item caption is sent to client with a
special
attribute to avoid the field looking like unselected.
Change-Id: Ib80355c3b52faaaeaa9ab7195644701cc3bf0d15
Required indicator for Table now works as expected (#17294)
Table is a field (and one of the most powerful ones), but it cannot be
used as required, especially if one wants to use the built in "required
indicators" in Vaadin. Those only work if client side connector extends
AbstractFieldConnector so Table is now extending it as well and
(I expect that it ) needs to do the AbstractHasComponentsConnector
stuff internally.
Change-Id: I4ceb719366621053c7fe4c9691d624d61ed57567