Add support for custom Grid sidebar items (#17569)
The current implementation does not in all cases enforce that visibility
toggles are always before any custom items. The JavaDoc warns about this
and the order is also restored whenever a visibility toggle is added or
removed.
Change-Id: I7160a04d6c96b2d6d821b13e420172e6115bc072
- if columns hidable when grid rendered, sidebar button had invalid height
- removed border radius from grid sidebar
- inherit font color for grid sidebar button
Change-Id: Ib35d917b35e701bd736a28f19b34dbece7fcbe71
Fix DataSource NPE under when dataChangeHandler is not set (#16590)
AbstractRemoteDataSource no longer asserts that data change handler
exists. Changing the DataSource in Grid is now safe even during data
source backend requests.
Change-Id: I57fb1cb6c7fd2aa7b8365a9b283a80a162349af1
- Fixed regression caused by #17423 in IE8
- Fixed fragile tests for focusing spacer content in Grid
- Changed TestCategory for EscalatorBasicClientFeaturesTest from 'escalator' to 'grid'.
Change-Id: I644f85a68fee643e468342093ad537dcd7bf8626
Revert "Reduce reflows when sizing columns (#17315)"
This reverts commit 103b329d32. It causes problems
with screenshot tests (GridColumnAutoWidthServerTest).
Change-Id: I1de4a44573b22e0bea8ffa2626724e2a182cb876
API for column hiding toggle caption in Grid (#17272)
Fixes column toggle not getting a caption when a hidable column is added.
Fixes column toggle not getting a caption on columns with widget in header.
Change-Id: Ie10ada793a3635302603f684f232cadaef74a982
This patch increases the reported fps from 10 to 17 in Chrome and from 5
to 10 in Firefox. No automatic test since performance testing on our
shared testing infrastructure would be quite error-prone.
Change-Id: I0bb6af250743058a8f32bb2df89da97660e94b52
Grid column hiding info from client to server #(17023)
Fixes mismatched client-server API regarding ColumnVisibilityChangeEvent
Adds and removes the column hiding toggle as needed when columns added / removed.
Known bug when a hidable column added, column toggle won't get the caption of column.
Change-Id: I708e19432dc822f713bf11f5b8e6eadb528a3961
Fixes several issues with hidden columns in Grid (#17023)
Makes sure that hidden columns are taken into account when calculating indices.
This is because escalator doesn't know about hidden columns, thus need to
convert cell indices to actual column indices in quite many places.
Change-Id: I4c0f3097938ee9340a1922464e12ad7261084ecb
Fix invalid assumptions about empty Grid (#16734, #16684)
* Don't reset to default column sizes when adding row to emtpy escalator
* Don't wait for data after size is explicilty reset to 0
* Don't assume there were previous rows when adjusting focus on add
Change-Id: I59e8c0ef0c5633cf3678db63a660e3f1d1ca7d2a