Tatu Lund
0fa5bc69b2
Catch and handle IllegalStateException (#11733)
* Catch and handle IllegalStateException
Fixes https://github.com/vaadin/framework/issues/11730
* Renaming variables
4 years ago
Anna Koskinen
ba158beabb
Updated row and spacer handling for Escalator (#11438)
Updated row and spacer handling for Escalator.
Main changes:
- Spacers are only maintained and checked for rows that have DOM
representation, and not at all if there is no details generator. This
gives notable performance improvements to some particularly large Grids
- Escalator no longer tries to trim away any rows that don't fit within
the viewport just because a details row gets opened in Grid. This leads
to some increase in simultaneous DOM elements, but simplifies the logic
considerably. For example opening or closing details rows doesn't
require checking the overall content validity beyond the details row
itself anymore, but some repositioning at most. There are also no longer
any orphaned spacers without corresponding DOM rows.
- Spacers are better integrated into the overall position calculations.
- Some public methods that are no longer used by Escalator or have
changed functionality or order of operations. Any extending classes that
tap into row, spacer, or scroll position handling are likely to need
reworking after this update.
- Auto-detecting row height is delayed until Escalator is both attached
and displayed.
4 years ago
Zhe Sun
6cb298b39d
Additional updates and fixes for 8.9 branch (#11679)
* Release note update for 8.9
* Fix unstable tests in the branch
* Code formatting
4 years ago
ZheSun88
8e3add71da
Update since tag
4 years ago
Tatu Lund
344d8660f3
Apply offset to column index depending on presense of selection column (#11667)
* Apply offset to column index depending on presense of selection column
After testing this manually I noticed that offset correction needs to be negative
* Add the testing UI
4 years ago
Anna Koskinen
6daad0a61c
Improvements to detail row index handling. (#11345)
- Escalator should notify when an existing details row is moved to a new
index.
- Grid and DetailsManagerConnector should update their internal indexing
when details manager index changes in Escalator.
4 years ago
Tatu Lund
487e450c61
Adding css class to Editor when on selected row (#11636)
* Adding "v-grid-editor-selected" stylename in editor cell wrapper element when Grid is opened on selected row.
4 years ago
Zhe Sun
e80358a391
Recalculate the column widths before the first row is added (#11609)
* Recalculate the column widths before the first row is added
Fixes #11607
5 years ago
cuong-phan
543a842e67
Fix Grid reordering when there are hidden columns
* Fix grid column reordering
Fix grid column reordering when there are hidden columns and footerRow.join
* Add test
5 years ago
Anna Koskinen
994f39b9ed
Don't attempt to scroll to the beginning or end if Grid has no rows. (#11570)
Fixes #11558
5 years ago
Sun Zhe
b20a9a8318
Code formatting (#11278)
5 years ago
Anna Koskinen
a174deeac8
Fixes to displaying Grid in a detail row. (#11147)
- Multiple headers shouldn't stack behind each other.
- Body rows shouldn't get stuck to default row height.
- Compatibility version's hidable row selector shouldn't try to
calculate row heights based on rows that haven't been added to DOM yet.
Fixes #7674
5 years ago
Anna Koskinen
2aa7a0696a
Replaced Grid's internal size calculation fix with an indexing fix. (#11154)
- More lightweight, and fixes things for any custom implementations of
Escalator as well.
Fixes #11044
5 years ago
Anastasia Smirnova
77a921791a
Ensure that HeaderRow is not null in Grid (#11165)
Ensure that HeaderRow is not null in Grid
Fixes #10485
5 years ago
Teemu Suo-Anttila
7979160203
Fix Grid resetting row height on resize (#11056)
5 years ago
Teemu Suo-Anttila
17761dc259
Fix Grid internal size calculations on vertical resize (#11046)
5 years ago
Anastasia Smirnova
d9303ad743
Add bottomBorder size to check in Grid (#10946)
Fixes #10931
6 years ago
Ilia Motornyi
d543e47bec
Enable Maven plugin for Eclipse formatting (#10829)
6 years ago
Anna Koskinen
206a4d3146
Add null check to Grid's DnD focus handling (#10822)
Fixes #10699
6 years ago
Teemu Suo-Anttila
78daf54cbf
Update release notes and since tags for 8.4 (#10760)
6 years ago
Ilia Motornyi
6541b7bad2
Update copyright year (#10761)
6 years ago
Anna Koskinen
1187cf22f0
Grid editor open (#10674)
6 years ago
Teemu Suo-Anttila
9cf87e1423
Fix selecting rows from header and footer (#10720)
6 years ago
Artur
e813c97e0b
Setting of tooltips for grid header/footer cells (#10489)
Fixes #7527
6 years ago
Ilia Motornyi
f44f4f1b51
8.3.2 since (#10678)
* @since 8.3.2
6 years ago
Adam Wagner
d9dd40d0e4
Fix Grid details height calculation issue (#10343)
6 years ago
Teemu Suo-Anttila
d1749cbaf9
Fix Grid initial render performance (#10579)
Fixes #10232
6 years ago
Adam Wagner
eb398be6f7
Fix column width in resize event when mode is SIMPLE (#10442)
6 years ago
Leif Åstrand
c905ac6adf
Rename widgetEventsAllowed to handleWidgetEvents (#10529)
6 years ago
Teemu Suo-Anttila
580d607444
Add missing since tags and JavaDocs (#10487)
6 years ago
Teemu Suo-Anttila
46da9629b1
Implement widget event handling for Columns in Grid (#10412)
Fixes #7833
6 years ago
Artur
d9a0e1c22f
Do not create DOM elements for initially hidden columns (#10465)
6 years ago
Teemu Suo-Anttila
7bf6967182
Fix selection column size calculation without data (#10384)
6 years ago
Teemu Suo-Anttila
ed57efc07e
Update since tags in JavaDoc (#10325)
6 years ago
Ahmed Ashour
d44a5e217d
Fix end of line comments, which were made by automatic formatter (#10234)
6 years ago
Knoobie
e65efdfb50
add Grid.Column#get/setAssistiveCaption (#10219)
* add Grid#Column#get/setAssistiveCaption
* fix test and update doc
* move testGridAssistiveCaption to GridTest
* delete test file
* delete test file
* Delete GridAssistiveCaptionTest.java
* Create GridAssistiveCaptionTest
* Create GridAssistiveCaption
* Rename GridAssistiveCaption to GridAssistiveCaption.java
* Rename GridAssistiveCaptionTest to GridAssistiveCaptionTest.java
* Reformat using eclipse
6 years ago
Ahmed Ashour
fb6e81221b
Use lambda with Handlers (#10229)
Also improve naming by replacing one-letter variable names.
6 years ago
Ahmed Ashour
10bd7544fd
Improve naming of fields and variables (#10242)
* Variable names to conform to naming convention.
* Use static constants where it makes sense
6 years ago
Knoobie
d0dde67c18
adds simple fix for missing label text in grid select checkboxes (#10223)
* adds simple fix for missing label text in grid select checkboxes
* updated comment and wording
6 years ago
Adam Wagner
df2157ab9f
Check class name type on Grid cell mouse over (#10194)
* Check whether className is of type string
* Move string type checker method to widget util
* Fix formatting of WidgetUtil
* Break svg into lines
6 years ago
Ahmed Ashour
c265cd1d6e
Fix HTML tags inside code in javadoc (#10160)
* Fix HTML tags inside code in javadoc
* only modify <table> and <tr>
* Fix javadoc
6 years ago
Ahmed Ashour
03570cb874
Scheduler.ScheduledCommand and RepeatingCommand to be lambda (#10203)
* Scheduler.ScheduledCommand and RepeatingCommand to be lambda
* Restore <table> in javadoc
* Fix docs
6 years ago
Piotr Wilkin
69c6675572
Fix for Grid client-side exception. (#10166)
Do not try to update the select all checkbox if it is not visible.
Fixes #10164
6 years ago
Ahmed Ashour
fa62729e24
Fix typos (#10158)
6 years ago
Ahmed Ashour
ab18b6c58e
Remove unneeded .toString() (#10141)
6 years ago
Ahmed Ashour
9494818412
Use StringBuilder instead of StringBuffer (#10154)
6 years ago
Knoobie
80336d30ed
Add role="grid" and aria-multiselectable to grid (#10009)
Also adds aria-selected for grid rows.
6 years ago
Ahmed Ashour
763a5cbe8c
First sentence of javadoc should end with a period (#10114)
Also includes minor other javadoc and formatting fixes.
6 years ago
Henri Sara
131601de36
Update empty since tags for 8.2 (#10107)
6 years ago
Ahmed Ashour
7065740d6d
Use interface instead of implementation (#10073)
6 years ago